aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Blacklist AndroidOne + WritePixelsTestGravatar joshualitt2015-12-15
| | | | | | BUG=skia:4711 Review URL: https://codereview.chromium.org/1528033002
* Add helper for determining whether to use sized internal format in GLGravatar bsalomon2015-12-15
| | | | | | | | | | Fix case where texture format and data format are different. Use helper when createing a testing "backend" texture. BUG=skia: Review URL: https://codereview.chromium.org/1527753002
* Tests: reduce verbosityGravatar halcanary2015-12-15
| | | | Review URL: https://codereview.chromium.org/1526943003
* SkPreConfig.h: Allow defined(__unix__) to imply SK_BUILD_FOR_UNIXGravatar mseaborn2015-12-15
| | | | | | | | | | | | | | This is more general than checking for __linux, __FreeBSD__, etc. (In principle we could remove some of the existing checks such as __FreeBSD__, but I have not tried that so far.) In particular, it allows Skia to build with the NaCl or PNaCl toolchains, which is something we would like for Mojo. BUG=https://github.com/domokit/mojo/issues/431 TEST=none Review URL: https://codereview.chromium.org/1523733003
* Specialize Sk2d for SSE2Gravatar mtklein2015-12-15
| | | | | | | | | | Given the autovectorization we've seen, I wouldn't expect big speedups from this, but it does give us a point of control over what's going on. BUG=skia: CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review URL: https://codereview.chromium.org/1526923003
* Revert of In BUILD.public, enable SK_SUPPORT_LEGACY_HAIR_IGNORES_CAPS. ↵Gravatar benjaminwagner2015-12-15
| | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/1516863007/ ) Reason for revert: The failing test has been blacklisted. The issue was not caused by this CL. Original issue's description: > In BUILD.public, enable SK_SUPPORT_LEGACY_HAIR_IGNORES_CAPS. > > Somehow https://codereview.chromium.org/1491843006 causes fills to change in one test. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/b6c77f6d62a62db3aec483e0a995ca30b9c97f0b TBR=mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1530533003
* SkBitmapProcState rounding biasGravatar fmalita2015-12-15
| | | | | | | | | | | | | Epsilon bias to keep bitmap sample rounding consistent with geometry rounding. Also update the GM to draw an outer border + drop uninteresting scales in favor of negative scale variants. BUG=skia:4680,skia:4649 R=reed@google.com,caryclark@google.com,mtklein@google.com Review URL: https://codereview.chromium.org/1527633002
* Add link to Gold trybot runs in every uploaded Skia CLGravatar rmistry2015-12-15
| | | | | | | BUG=skia:4433 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1521913005 Review URL: https://codereview.chromium.org/1521913005
* adb_wait_for_device: More fixesGravatar borenet2015-12-15
| | | | | | BUG=skia:4690 Review URL: https://codereview.chromium.org/1527713002
* Fix valgrind suppressions for libjpeg-turbo warningGravatar msarett2015-12-14
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1518393003
* Update sync_google3.sh to match autoroller.py.Gravatar benjaminwagner2015-12-14
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1526593003
* Add option to control maximum GrBatch lookbackGravatar bsalomon2015-12-14
| | | | Review URL: https://codereview.chromium.org/1498653002
* Switch fragment coordinate to 'highp' to fix various broken GMs.Gravatar ethannicholas2015-12-14
| | | | | | BUG=skia:4693 Review URL: https://codereview.chromium.org/1523793002
* Unify some SkNx codeGravatar mtklein2015-12-14
| | | | | | | | | | | | | | | - one base case and one N=1 case instead of two each (or three with doubles) - use SkNx_cast instead of FromBytes/toBytes - 4-at-a-time Sk4f::ToBytes becomes a special standalone Sk4f_ToBytes If I did everything right, this'll be perf- and pixel- neutral. https://gold.skia.org/search2?issue=1526523003&unt=true&query=source_type%3Dgm&master=false BUG=skia: CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review URL: https://codereview.chromium.org/1526523003
* Revert of SkTime updates (patchset #2 id:20001 of ↵Gravatar mtklein2015-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1521293002/ ) Reason for revert: linux Canary builder has no std::steady_clock. Weird... Original issue's description: > SkTime updates > > 1) Use steady_clock instead of high_resolution_clock. If we don't have a > guarantee of monotonicity, it's pretty much useless for timing things. > > 2) Implement Mac/iOS with <chrono> too. This was waiting on C++11 library support. > > Both high_resolution_clock and steady_clock are (still) busted on MSVC 2013, > so no change there. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/6a20871e5aeaa7e61f3348694bf436af16f824b9 TBR=herb@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1529603002
* SkBitmap moveGravatar halcanary2015-12-14
| | | | | | | | Running `Release/dm --gpu 0`, the number of times we call SkBitmap::operator=(const SkBitmap&) (which refs the pixelref) is reduced from ~214929 to ~214626. Review URL: https://codereview.chromium.org/1514503004
* adb_wait_for_device: Add battery fallback, support no batteryGravatar borenet2015-12-14
| | | | | | | BUG=skia:4690 TBR=rmistry Review URL: https://codereview.chromium.org/1528563002
* Documentation: HarfBuzz linkGravatar halcanary2015-12-14
| | | | | | | NOTRY=true TBR=caryclark@google.com Review URL: https://codereview.chromium.org/1526683002
* Documentation: text shapingGravatar halcanary2015-12-14
| | | | | | | NOTRY=true DOCS_PREVIEW= https://skia.org/user/tips?cl=1523023002#kerning Review URL: https://codereview.chromium.org/1523023002
* path ops: check for deleted endsGravatar caryclark2015-12-14
| | | | | | | TBR=fmalita@chromium.org BUG=569540 Review URL: https://codereview.chromium.org/1524803002
* SkTime updatesGravatar mtklein2015-12-14
| | | | | | | | | | | | | | 1) Use steady_clock instead of high_resolution_clock. If we don't have a guarantee of monotonicity, it's pretty much useless for timing things. 2) Implement Mac/iOS with <chrono> too. This was waiting on C++11 library support. Both high_resolution_clock and steady_clock are (still) busted on MSVC 2013, so no change there. BUG=skia: Review URL: https://codereview.chromium.org/1521293002
* If a point is on a path edge, it's in the path, at least for all cases where ↵Gravatar caryclark2015-12-14
| | | | | | | | | | | the path edge is not canceled with another edge through coincidence. Add test cases for edges and conics, and make sure it all works. R=reed@google.com BUG=skia:4669,4265 Review URL: https://codereview.chromium.org/1517883002
* adb_wait_for_device: If we can't get the battery level, just exitGravatar borenet2015-12-14
| | | | | | | | BUG=skia:4606 TBR=rmistry NOTREECHECKS=true Review URL: https://codereview.chromium.org/1529453002
* Revert of Add config options to run different GPU APIs to dm and nanobench ↵Gravatar reed2015-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #12 id:220001 of https://codereview.chromium.org/1490113005/ ) Reason for revert: speculative revert to see if it unblocks the DEPS roll https://codereview.chromium.org/1529443002 Original issue's description: > Add config options to run different GPU APIs to dm and nanobench > > Add extended config specification form that can be used to run different > gpu backend with different APIs. > > The configs can be specified with the form: > gpu(api=string,dit=bool,nvpr=bool,samples=int) > > This replaces and removes the --gpuAPI flag. > > All existing configs should still work. > > Adds following documentation: > > out/Debug/dm --help config > > Flags: > --config: type: string default: 565 8888 gpu nonrendering > Options: 565 8888 debug gpu gpudebug gpudft gpunull msaa16 msaa4 > nonrendering null nullgpu nvprmsaa16 nvprmsaa4 pdf pdf_poppler skp svg > xps or use extended form 'backend(option=value,...)'. > > Extended form: 'backend(option=value,...)' > > Possible backends and options: > > gpu(api=string,dit=bool,nvpr=bool,samples=int) GPU backend > api type: string default: native. > Select graphics API to use with gpu backend. > Options: > native Use platform default OpenGL or OpenGL ES backend. > gl Use OpenGL. > gles Use OpenGL ES. > debug Use debug OpenGL. > null Use null OpenGL. > dit type: bool default: false. > Use device independent text. > nvpr type: bool default: false. > Use NV_path_rendering OpenGL and OpenGL ES extension. > samples type: int default: 0. > Use multisampling with N samples. > > Predefined configs: > > gpu = gpu() > msaa4 = gpu(samples=4) > msaa16 = gpu(samples=16) > nvprmsaa4 = gpu(nvpr=true,samples=4) > nvprmsaa16 = gpu(nvpr=true,samples=16) > gpudft = gpu(dit=true) > gpudebug = gpu(api=debug) > gpunull = gpu(api=null) > debug = gpu(api=debug) > nullgpu = gpu(api=null) > > BUG=skia:2992 > > Committed: https://skia.googlesource.com/skia/+/e13ca329fca4c28cf4e078561f591ab27b743d23 TBR=bsalomon@google.com,scroggo@google.com,joshualitt@google.com,kkinnunen@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:2992 Review URL: https://codereview.chromium.org/1528473002
* Add minimum battery level to adb_wait_for_deviceGravatar borenet2015-12-14
| | | | | | | | | This should prevent the Android bots running out of battery at the expense of extra time spent waiting at the end of the build. BUG=skia:4606 Review URL: https://codereview.chromium.org/1522013002
* Add config options to run different GPU APIs to dm and nanobenchGravatar kkinnunen2015-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add extended config specification form that can be used to run different gpu backend with different APIs. The configs can be specified with the form: gpu(api=string,dit=bool,nvpr=bool,samples=int) This replaces and removes the --gpuAPI flag. All existing configs should still work. Adds following documentation: out/Debug/dm --help config Flags: --config: type: string default: 565 8888 gpu nonrendering Options: 565 8888 debug gpu gpudebug gpudft gpunull msaa16 msaa4 nonrendering null nullgpu nvprmsaa16 nvprmsaa4 pdf pdf_poppler skp svg xps or use extended form 'backend(option=value,...)'. Extended form: 'backend(option=value,...)' Possible backends and options: gpu(api=string,dit=bool,nvpr=bool,samples=int) GPU backend api type: string default: native. Select graphics API to use with gpu backend. Options: native Use platform default OpenGL or OpenGL ES backend. gl Use OpenGL. gles Use OpenGL ES. debug Use debug OpenGL. null Use null OpenGL. dit type: bool default: false. Use device independent text. nvpr type: bool default: false. Use NV_path_rendering OpenGL and OpenGL ES extension. samples type: int default: 0. Use multisampling with N samples. Predefined configs: gpu = gpu() msaa4 = gpu(samples=4) msaa16 = gpu(samples=16) nvprmsaa4 = gpu(nvpr=true,samples=4) nvprmsaa16 = gpu(nvpr=true,samples=16) gpudft = gpu(dit=true) gpudebug = gpu(api=debug) gpunull = gpu(api=null) debug = gpu(api=debug) nullgpu = gpu(api=null) BUG=skia:2992 Review URL: https://codereview.chromium.org/1490113005
* Try to fix intermittent GrAutoLocaleSetter crashes on WindowsGravatar kkinnunen2015-12-13
| | | | | | | | | | | | Try to fix intermittent GrAutoLocaleSetter crashes on Windows. The string returned by setlocale() is only valid up to next setlocale(), so it can not be fed to setlocale(). Also, libraries such as ANGLE might call setlocale when inside a callstack containing GrAutoLocaleSetter. This would render the old locale pointer invalid. Review URL: https://codereview.chromium.org/1514083002
* Update SKP versionGravatar update-skps2015-12-13
| | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS Review URL: https://codereview.chromium.org/1522753002
* In SkPixmap.cpp, change SkAlphaMul to SkMulDiv255.Gravatar benjaminwagner2015-12-11
| | | | | | | | | | Add a test that we get the same color back after calling SkBitmap::eraseColor, modulo rounding. Also update some incorrect docs. BUG=skia:4297 Review URL: https://codereview.chromium.org/1521673002
* archive skpx... currently dead codeGravatar mtklein2015-12-11
| | | | | | | BUG=skia: CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review URL: https://codereview.chromium.org/1521623003
* Change google3 sync scripts to sync latest rather than LKGR.Gravatar benjaminwagner2015-12-11
| | | | | | | | This matches the behavior of the autoroller and is generally more useful. BUG=skia: Review URL: https://codereview.chromium.org/1508313004
* A change to cleanup some organization around df textGravatar joshualitt2015-12-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1519083002
* New GM: image_scale_alignedGravatar fmalita2015-12-11
| | | | | | | | | To verify alignment for various image scaling modes. BUG=skia:4649 R=reed@google.com Review URL: https://codereview.chromium.org/1514923002
* Change computeOutputColorType() to mimic old behaviorGravatar msarett2015-12-11
| | | | | | | | | | | | | | | This will prevent behavior changes in BitmapFactory when switching from SkImageDecoder to SkAndroidCodec. We will only choose kGray8 if it is explicitly requested (and also supported). Additionally, we will always decode GIFS and WBMPS to kIndex8. BUG=skia: Review URL: https://codereview.chromium.org/1519843002
* Add test for previously unflattenablesGravatar scroggo2015-12-11
| | | | | | BUG=skia:4613 Review URL: https://codereview.chromium.org/1514373003
* Fix a crash in SkParsePath::FromSVGStringGravatar scroggo2015-12-11
| | | | | | BUG=skia:3491 Review URL: https://codereview.chromium.org/1515193002
* remove explicit 'f' in glbench shaderGravatar joshualitt2015-12-11
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1503383006
* In BUILD.public, enable SK_SUPPORT_LEGACY_HAIR_IGNORES_CAPS.Gravatar benjaminwagner2015-12-11
| | | | | | | | Somehow https://codereview.chromium.org/1491843006 causes fills to change in one test. BUG=skia: Review URL: https://codereview.chromium.org/1516863007
* Make BitmapRegionDecoder succeed on invalid requestsGravatar msarett2015-12-11
| | | | | | | | | | If the client requests a color type or alpha type that is not supported, we should decode to the default/appropriate color and alpha types to match existing behavior in Android. BUG=skia: Review URL: https://codereview.chromium.org/1513023002
* Move all text stuff to its own folderGravatar joshualitt2015-12-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1521453002
* make internaldrawBmpText part of GrTextUtilsGravatar joshualitt2015-12-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1518883002
* Add check for highp support in Conic effectGravatar robertphillips2015-12-11
| | | | | | | | | | | | | | | | | | | | | This CL may not really be necessary since it seems that the Android Ones we have fall back to mediump when highp isn't supported. FYI, for bits-of-precision/precision we have: Low Med High Precision-Used A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad N5 (Adreno 330) 10 10 23 High - conic looks bad!!! N6 (Adreno 420) 10 10 23 High - conic looks good N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!! N9 (K1) 23 23 23 High - looks good N10 (Mail-604) 10 10 23 High - looks good I suspect derivative computation is broken on the Adreno 300s. BUG=555779,skia:4668 TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/1513573009
* Initialize glGen* call id args to zeroGravatar kkinnunen2015-12-11
| | | | | | | | | | | | Initialize glGenTexture, glGenBuffer call id buffer items to zero before calls. Otherwise it's not easy to check if the call succeeded or not. Assert the rule in debug gl context. Make TesselatingPathRendererTests use debug gl context. It exercises some of the GenBuffers call sites. Review URL: https://codereview.chromium.org/1514033002
* Run debug gl context for DEF_GPU_TEST_FOR_ALL_CONTEXTSGravatar kkinnunen2015-12-10
| | | | | | | Run debug gl context for tests defined with DEF_GPU_TEST_FOR_ALL_CONTEXTS. Review URL: https://codereview.chromium.org/1514023002
* Revert of DM: fix `--config $VIA-pdf` to not crash (patchset #3 id:40001 of ↵Gravatar msarett2015-12-10
| | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1513323002/ ) Reason for revert: I believe that this is breaking master-skia in Android. Original issue's description: > DM: fix `--config $VIA-pdf` to not crash > > Committed: https://skia.googlesource.com/skia/+/6bce4177cb72faac9c10d01d57e17168ae7ecadf TBR=mtklein@google.com,halcanary@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1513053004
* Remove flag needed by outdated libpngGravatar msarett2015-12-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1514873003
* yet another memcpy -> sk_careful_memcpyGravatar mtklein2015-12-10
| | | | | | | | | | | | will fix https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3834 No API changes. TBR=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/1514923003
* Add a warmup flag to visualbenchGravatar cdalton2015-12-10
| | | | | | | | Adds a flag to control whether we use a warmup bench. BUG=skia: Review URL: https://codereview.chromium.org/1468233003
* Fix UB function problems for AA merger.Gravatar herb2015-12-10
| | | | | | BUG=skia:4634 Review URL: https://codereview.chromium.org/1518863002
* Fix 'debugging on Android' android_gdb_app script.Gravatar aam2015-12-10
| | | | | | | | | | | | 1) com.skia -> com.skia.sample_app 2) pass arguments to android_gdb_app to android_setup.sh so you can build gdbserver binaries for your actual device(rather than default arm64). This allows you to run it like this for example: ./platform_tools/android/bin/android_gdb_app -d nexus_6 BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=1509853006 Review URL: https://codereview.chromium.org/1509853006