| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
| |
Remove AST from GrClipMaskCache
Remove AST from GrClipMaskManager
BUG=skia:2889
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/663583002
|
|
|
|
|
|
|
|
|
|
| |
Enabling JPEG YUV Decoding in Skia
BUG=skia:3005, skia:1674, skia:3029
Committed: https://skia.googlesource.com/skia/+/8e6c3b93a39e19111662a760ede97df55e51d39f
Review URL: https://codereview.chromium.org/399683007
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/659443007
|
|
|
|
|
|
| |
BUG=skia:2947
Review URL: https://codereview.chromium.org/610003002
|
|
|
|
|
|
| |
BUG=skia:2947
Review URL: https://codereview.chromium.org/613673005
|
|
|
|
|
|
|
|
|
| |
Compute blob bounds when the client doesn't pass explicit run rects to
the builder. This allows us to remove a couple of internal workarounds.
R=reed@google.com,mtklein@google.com,bungeman@google.com
Review URL: https://codereview.chromium.org/654873003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/644253003
|
|
|
|
| |
Review URL: https://codereview.chromium.org/657353004
|
|
|
|
|
|
|
|
|
|
| |
If SkPDFDevice::drawText is called with glyph encoding and a font with
cubic outlines (CFF or Type1) and a glyph code > 255 then it was
mutating the in(const) glyph codes in place. Instead, a copy is made.
BUG=skia:3019
Review URL: https://codereview.chromium.org/656143002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/658913002
|
|
|
|
|
|
|
|
| |
https://skia.googlesource.com/third_party/nanomsg/
BUG=skia:3027
Review URL: https://codereview.chromium.org/657113004
|
|
|
|
|
|
|
|
|
| |
You can also click on the errors in the parsed output to jump directly to the offending location in the editor.
BUG=skia:
NOTRY=true
Review URL: https://codereview.chromium.org/660573003
|
|
|
|
|
|
| |
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/654313002
|
|
|
|
|
|
|
|
|
| |
TBR=
BUG=skia:3031
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/664533002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #4 id:60001 of https://codereview.chromium.org/653133004/)
Reason for revert:
A large number of GMs on Ubuntu12 are failing. The text layout on GPU is visibly different than that for 8888.
Original issue's description:
> Change drawText() to generate positions and send to drawPosText()
>
> The idea here is to have a central place that does layout for drawText(), and
> then always feed text through drawPosText(). This both makes all of the
> GrTextContexts consistent in drawText() output, and does a better job of
> stressing drawPosText().
>
> Because of the effect of matrices on hinting and approximation error, the
> generated text is not 100% identical to that produced by the raster pipeline.
>
> BUG=skia:2778
>
> Committed: https://skia.googlesource.com/skia/+/7851a56895c9c076f73a835a7dd51d3c6180c16f
TBR=cdalton.nvidia@gmail.com,bungeman@google.com,reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2778
Review URL: https://codereview.chromium.org/659993003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The idea here is to have a central place that does layout for drawText(), and
then always feed text through drawPosText(). This both makes all of the
GrTextContexts consistent in drawText() output, and does a better job of
stressing drawPosText().
Because of the effect of matrices on hinting and approximation error, the
generated text is not 100% identical to that produced by the raster pipeline.
BUG=skia:2778
Review URL: https://codereview.chromium.org/653133004
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should prevent further enumeration according to the docs.
http://golang.org/pkg/database/sql/#Rows.Close
BUG=None
TEST=None
R=humper@google.com
Review URL: https://codereview.chromium.org/638373003
|
|
|
|
|
|
|
|
| |
Image subsets were always showing the same tile and were causing an image to be fully YUV decoded once per tile, which was both slow and wrong.
BUG=413001, 419718
Review URL: https://codereview.chromium.org/661483002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor SkGLContext to be actually extendable. Before, non-trivial subclass
would need to destroy the GL connection upon running the destructor. However,
the base class would run GL commands in its own destructor (with destroyed GL
connection)
Refactor so that SkGLContext subclass object creation is completely done by
the factory function. If the factory function returns a non-NULL ptr, it means the context
is usable.
The destruction is done with the destructor instead of virtual function called
upon destruction. Make the destructors not to call virtual functions, for
clarity.
Remove custom 1x1 FBO setup code from the base class. It appears not to be used
anymore.
BUG=skia:2992
Review URL: https://codereview.chromium.org/640283004
|
|
|
|
| |
Review URL: https://codereview.chromium.org/657923002
|
|
|
|
|
|
| |
BUG=skia:2889
Review URL: https://codereview.chromium.org/650283002
|
|
|
|
|
|
| |
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/659803005
|
|
|
|
|
|
|
|
|
|
| |
Update it to use glog variant.
BUG=skia:2980
TEST=go build webtry.go
TBR=jcgregorio@google.com
Review URL: https://codereview.chromium.org/659813003
|
|
|
|
|
|
|
|
| |
BUG=skia:2980
TEST=go get -d && go build webtry.go
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/655323002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The net effect is that two "+1" instructions are removed from insert().
search() nets no change: two +1 removed, two +1 added.
When vectorized, this removes the need to add in userToGrid() at all and
so the need to read an awkward {0, 0, 1, 1} constant from memory. Mostly
the benefit is less vector code to look at and think about.
BUG=skia:
Review URL: https://codereview.chromium.org/659823004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A careful reading of the preprocessor specification indicates that
any use of the 'defined' operator outside the form of 'defined X' or
'defined ( X )' directly in the constant expression of a '#if' or
'#elif' may cause undefined behavior.
In particular, msvc is very unpredictable. The 'defined X' and
'defined ( X )' forms behave differently when created from marco
expansion, with 'defined ( X )' generally evaluating to '0L'. The
'defined X' form generally behaves more the way one would expect,
but still has a number of quirks which should simply be considered
undefined behavior.
BUG=chromium:419245
Review URL: https://codereview.chromium.org/657183002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/656503002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As mentioned in http://golang.org/doc/effective_go.html#blank_assign,
errors are provided for a reason, so always check them.
The documentation for this function is available at
http://golang.org/pkg/os/#Chdir.
BUG=None
TEST=None
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/651343002
|
|
|
|
|
|
|
|
|
|
| |
all its commands interleaved in contiguous memory. GrTRecorder also
supports extra data associated with objects, so we can store arrays
inline without having to call malloc().
Committed: https://skia.googlesource.com/skia/+/360b6801cfd90485891d709e44cf395d527ba69e
Review URL: https://codereview.chromium.org/628453002
|
|
|
|
|
|
|
|
|
|
| |
It was used to check to see if an SkPaint had mutable fields on it.
Now that all the fields are immutable, this function is no longer
used. Remove it.
BUG=skia:2097
Review URL: https://codereview.chromium.org/661543002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/399683007/)
Reason for revert:
Caused many test bots to go red:
http://build.chromium.org/p/client.skia/builders/Test-ChromeOS-Alex-GMA3150-x86-Release/builds/22/steps/dm/logs/stdio
http://build.chromium.org/p/client.skia/builders/Test-ChromeOS-Link-HD4000-x86_64-Debug/builds/168/steps/dm/logs/stdio
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/38/steps/dm/logs/stdio
Original issue's description:
> JPEG YUV Decoding
>
> Enabling JPEG YUV Decoding in Skia
>
> BUG=skia:3005, skia:1674
>
> Committed: https://skia.googlesource.com/skia/+/8e6c3b93a39e19111662a760ede97df55e51d39f
TBR=reed@google.com,scroggo@google.com,sugoi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:3005, skia:1674
Review URL: https://codereview.chromium.org/656163002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/657083004
|
|
|
|
|
|
| |
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/660563003
|
|
|
|
|
|
| |
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/659803004
|
|
|
|
|
|
|
|
| |
Enabling JPEG YUV Decoding in Skia
BUG=skia:3005, skia:1674
Review URL: https://codereview.chromium.org/399683007
|
|
|
|
| |
Review URL: https://codereview.chromium.org/660573002
|
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=caryclark@google.com
NOTRY=True
Review URL: https://codereview.chromium.org/657793003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/656473004
|
|
|
|
|
|
| |
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/654273002
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/658753002
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=./run_server.sh --help and ./run_server.sh -public
R=borenet@google.com
Review URL: https://codereview.chromium.org/649303003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#17 id:1240001 of https://codereview.chromium.org/628453002/)
Reason for revert:
Leaking memory:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/builds/9/steps/gm/logs/stdio
Original issue's description:
> Adds a GrTRecorder class that GrInOrderDrawBuffer uses to allocate
> all its commands interleaved in contiguous memory. GrTRecorder also
> supports extra data associated with objects, so we can store arrays
> inline without having to call malloc().
>
> Committed: https://skia.googlesource.com/skia/+/360b6801cfd90485891d709e44cf395d527ba69e
TBR=bsalomon@google.com,reed@google.com,cdalton@nvidia.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/654863003
|
|
|
|
|
|
|
|
| |
A few references to "profile" still existed in SkColorCubeFilter, so I removed them.
BUG=skia:
Review URL: https://codereview.chromium.org/651303002
|
|
|
|
|
|
| |
BUG=skia:2443
Review URL: https://codereview.chromium.org/653153003
|
|
|
|
|
|
| |
TBR=
Review URL: https://codereview.chromium.org/657603005
|
|
|
|
|
|
| |
BUG=skia:2922
Review URL: https://codereview.chromium.org/638293004
|
|
|
|
|
|
|
|
| |
all its commands interleaved in contiguous memory. GrTRecorder also
supports extra data associated with objects, so we can store arrays
inline without having to call malloc().
Review URL: https://codereview.chromium.org/628453002
|
|
|
|
|
|
|
|
|
|
| |
Rename GrContext::lockAndRefScratchTexture to refScratchTexture.
GrSurface::writePixels returns bool instead of void.
BUG=skia:2889
Review URL: https://codereview.chromium.org/638403003
|
|
|
|
|
|
| |
BUG=416289
Review URL: https://codereview.chromium.org/636233008
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
text/template and html/template both have a helper function called
"Must" that according to the docs in http://golang.org/pkg/text/template/#Must
and http://golang.org/pkg/html/template/#Must, wraps a call to a function
returning (*Template, error) and panics if the error is non-nil.
So we don't need to that ourselves. Which is a good thing and makes code
cleaner.
BUG=None
TEST=None
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/642243004
|