aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Reenable testing webp to PDF on ValgrindGravatar scroggo2016-01-06
| | | | | | | | | | | The errors were probably due to skbug.com/4038, which has been fixed. Reenable the test. BUG=skia:3505 BUG=skia:4038 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1535133002 Review URL: https://codereview.chromium.org/1535133002
* Add Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release to the CQGravatar borenet2016-01-06
| | | | | | | BUG=skia:4758 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1564743003 Review URL: https://codereview.chromium.org/1564743003
* Fix some SkCodecPrintfsGravatar scroggo2016-01-06
| | | | | | | | | | Silence the warning about peeking. Until we implement peeking for the stream often used, it will always print, cluttering the logs. Add some more information to the warning about failing to rewind. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1564843002 Review URL: https://codereview.chromium.org/1564843002
* Optimize SkTileImageFilter destination bitmap size.Gravatar senorblanco2016-01-06
| | | | | | | | | | | | | | | The destination bitmap size was not being clipped by the clip bounds, so tiled rendering (ie., clipping to a small region and rendering a SkTileImageFilter with a large dstRect) was much slower than non-tiled rendering. Correctness is covered by unit test ImageFilterDrawTiled, and performance by TileImageFilterBench. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1563873002 Review URL: https://codereview.chromium.org/1563873002
* Add additional assert to GrSingleOwnerGravatar joshualitt2016-01-06
| | | | | | | | | TBR=bsalomon@google.com TBR=mtklein@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1566703003 Review URL: https://codereview.chromium.org/1566703003
* SkPDF: Change handling of large-numbers in matricies.Gravatar halcanary2016-01-06
| | | | | | | | | | | re-do http://crrev.com/1438503002 right. Also, add a unit test that asserts without this change. BUG=skia:734 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1552263003 Review URL: https://codereview.chromium.org/1552263003
* Add skstd::remove_pointer_t and use it.Gravatar bungeman2016-01-06
| | | | | | | | This replaces an existing incomplete implementation. This also makes it easier to update the current use in the future when switching to <type_traits>. Review URL: https://codereview.chromium.org/1555153002
* add commentGravatar caryclark2016-01-06
| | | | | | | | | TBR=reed@google.com NOTRY=true BUG=skia:4757 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1566733002 Review URL: https://codereview.chromium.org/1566733002
* Create debug only SkSingleOwnerGravatar joshualitt2016-01-06
| | | | | | | | | | | This is so Gpu code can guard against improper multithreaded usage in debug builds TBR=bsalomon@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1555953004 Review URL: https://codereview.chromium.org/1555953004
* fix valgrindGravatar caryclark2016-01-06
| | | | | | | | | | | | | | (A recently added fuzzer test broke the valgrind bot, intentionally, to isolate an uninitialized memory bug.) If the conic has ordered points, but cannot be broken into parts, treat it as if it were monotonic. R=reed@google.com BUG=skia:4757 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1568513002 Review URL: https://codereview.chromium.org/1568513002
* Add debug sentinel to GrMemoryPool to check for memory stompingGravatar robertphillips2016-01-06
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1553233006 Review URL: https://codereview.chromium.org/1553233006
* In Google3 build, use SK_SFNTLY_SUBSETTER define to enable/disable sfntly.Gravatar benjaminwagner2016-01-05
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1561753002 Review URL: https://codereview.chromium.org/1561753002
* Start using <type_traits> and <utility> (C++11).Gravatar bungeman2016-01-05
| | | | | | | | | | | | | | SkUtility.h and SkTLogic.h implement a number of type traits now available through <type_traits> and <utility>. This removes SkUtility.h, replacing it with <utility>, and moves a number of traits in SkTLogic.h to use the std:: equivelents. This change only uses C++11 parts of the standard library; SkTLogic.h will continue to provide C++14 and beyond for now in the skstd namespace. The changes to SkTLogic.h are being done gradually so that safe changes may be landed confidently, with more risky changes in the future. Review URL: https://codereview.chromium.org/1561683002
* Add a bench to test SkTileImageFilter.Gravatar senorblanco2016-01-05
| | | | | | | | | | Tests in three modes: no tiling, 32x32 tiled rendering, and 64x64 tiled rendering. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1559403003 Review URL: https://codereview.chromium.org/1559403003
* fix nexus playerGravatar caryclark2016-01-05
| | | | | | | | | | | The path contains test has such large numbers that it is indeterminate whether it will return true or false. Allow either result, ensuring that the test itself doesn't crash. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1565463002 Review URL: https://codereview.chromium.org/1565463002
* Also ignore sfntly for Google3/iOS.Gravatar mtklein2016-01-05
| | | | | | | | | | | It's just complicating their build process for now. Will follow up by removing sfntly dependency after this rolls. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1559393002 Review URL: https://codereview.chromium.org/1559393002
* More framework support for TransferBuffersGravatar jvanverth2016-01-05
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1534123003 Review URL: https://codereview.chromium.org/1534123003
* Move read pixels format info into ConifgInfo in GrGLCapsGravatar bsalomon2016-01-05
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1542813004 Review URL: https://codereview.chromium.org/1542813004
* fix linear gradient assert, by explicitly clampingGravatar reed2016-01-05
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1556993003 Review URL: https://codereview.chromium.org/1556993003
* take gr-context parameter to refEncoded, indicating a desire for only ↵Gravatar reed2016-01-05
| | | | | | | | | | | | | | | gpu-specific formats Prime motivator: - we always call refEncoded on the generator when trying to upload - we call it *before* we ask for raster or YUV - for blink, this call can be very slow, as they have to cons-up their SkData the first time (and grab a mutex to do it) - this parameter will indicate to them that we're only interested in gpu formats, which they will know if they have. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1556333004 Review URL: https://codereview.chromium.org/1556333004
* Add assert that memory pool is empty when GrTextBlobCache freesGravatar joshualitt2016-01-05
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1555993005 Review URL: https://codereview.chromium.org/1555993005
* Add null check for bmp->tex result in SkImageFilter::filterInputGpuGravatar bsalomon2016-01-05
| | | | | | | BUG=chromium:570479 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1555333002 Review URL: https://codereview.chromium.org/1555333002
* CMake: generate SkUserConfig.h with configure_fileGravatar mtklein2016-01-05
| | | | | | | | | | | 1) It's simpler. 2) It should cache correctly (and not trigger total rebuilds everytime we re-run CMake.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1544493002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot Review URL: https://codereview.chromium.org/1544493002
* Add comment for using infinite check in quad rootGravatar caryclark2016-01-05
| | | | | | | | TBR=reed@google.com NOTRY=true GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1556073004 Review URL: https://codereview.chromium.org/1556073004
* Return 'correct' size from GrMemoryPoolGravatar joshualitt2016-01-05
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1552283002 Review URL: https://codereview.chromium.org/1552283002
* clean up dead x86 filter opts codeGravatar mtklein2016-01-05
| | | | | | | | | | This is dead after removing shadeSpan16(). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1553233004 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review URL: https://codereview.chromium.org/1553233004
* Spin off more thread-safe work in DM.Gravatar mtklein2016-01-05
| | | | | | | | | | | | | | | | | | | | | | | | | Even in GPU configs, encoding a .png and writing to disk is thread safe. This CL moves that work to an SkTaskGroup, offloading it from the GPU thread to a threadpool. In my brief local testing, this makes DM run in about half the time for GPU-bound work, e.g. $ out/Release/dm --src gm --config gpudft -w output Before: 43.79 real 37.01 user 4.28 sys After : 23.64 real 39.31 user 4.46 sys This won't affect the bots much, as they already skip .png generation when gold.skia.org already has a .png of an image with a given hash. (Most of the time saved here is under WriteToDisk() after the gUninterestingHashes check.) CQ_EXTRA_TRYBOTS=client.skia:Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Release-Trybot BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1561553002 Review URL: https://codereview.chromium.org/1561553002
* give up on quad root if infiniteGravatar caryclark2016-01-05
| | | | | | | | | | | | SkPath::contains() uses SkFindUnitQuadRoots to see which side of a curve a point is on. If the intermediate exceeds a float, return no found root. R=reed@google.com BUG=572406 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1556353002 Review URL: https://codereview.chromium.org/1556353002
* remove shadeSpan16 from shaderGravatar reed2016-01-05
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1556003003 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review URL: https://codereview.chromium.org/1556003003
* df generation: single allocation with callocGravatar mtklein2016-01-05
| | | | | | | | | | | | | | | | | | | The dfStorage DFData allocation can never fit in its stack space: 5px padding on each side always implies at least a 10x10 DFData allocation, but the stack space only fits 64 DFData. So we've always been spilling to the heap. If we're going to spill to the heap, we might as well allocate/free all our temporary memory in one block, and since we want it zeroed, might as well calloc. So in practice this replaces 1-2 malloc, 1-2 free, and 2 bzeros with 1 calloc and 1 free. BUG=skia:4729 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1544983004 Committed: https://skia.googlesource.com/skia/+/12204d90337656542a42fa0fcccb7bec13af0cce CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Release-Trybot Review URL: https://codereview.chromium.org/1544983004
* update nanobench Valgrind suppressionGravatar mtklein2016-01-05
| | | | | | | | | | | | | | start_keepalive is static, so it's likely inlined. We'll put a ... where it goes to allow that. C.f. https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind/builds/529/steps/nanobench%20--abandonGpuContext/logs/stdio BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1562433002 TBR=egdaniel@google.com Review URL: https://codereview.chromium.org/1562433002
* Revert of Make SkGLContext lifetime more well-defined (patchset #7 id:120001 ↵Gravatar jcgregorio2016-01-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/1511773005/ ) Reason for revert: Broke tests on Android, iOS, Mac and Windows. Original issue's description: > Make SkGLContext lifetime more well-defined > > Remove refcounting from SkGLContext. > > SkGLContext is expected to behave like GrContextFactory would own > it, as implied by the GrContextFactory function. > > If it is refcounted, this does not hold. > > Also other use sites, such as in SkOSWindow_win (command buffer gl > object), confirm the behavior. The object is explicitly owned and > destroyed, not shared. > > Also fixes potential crashes from using GL context of an abandoned > context. > > Also fixes potential crashes in DM/nanobench, if the GrContext lives > longer than GLContext through internal refing of GrContext. > > Moves the non-trivial implementations from GrContextFactory.h to > .cpp, just for consistency sake. > > Changes pathops_unittest.gyp. The pathops_unittest uses > GrContextFactory, but did not link to its implementation. The reason > they worked was that the implementation used (constructors, destructors) > happened to be in the .h file. > > This works towards being able to use command buffer and NVPR from > the SampleApp. > > BUG=skia:2992 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1511773005 > > Committed: https://skia.googlesource.com/skia/+/830e012187f951d49d7e46e196ac8d1e653a25da TBR=bsalomon@google.com,kkinnunen@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:2992 Review URL: https://codereview.chromium.org/1555053003
* Take care fall-through case of switch in skiaGravatar tzik2016-01-05
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1549273002 Review URL: https://codereview.chromium.org/1549273002
* Make SkGLContext lifetime more well-definedGravatar kkinnunen2016-01-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove refcounting from SkGLContext. SkGLContext is expected to behave like GrContextFactory would own it, as implied by the GrContextFactory function. If it is refcounted, this does not hold. Also other use sites, such as in SkOSWindow_win (command buffer gl object), confirm the behavior. The object is explicitly owned and destroyed, not shared. Also fixes potential crashes from using GL context of an abandoned context. Also fixes potential crashes in DM/nanobench, if the GrContext lives longer than GLContext through internal refing of GrContext. Moves the non-trivial implementations from GrContextFactory.h to .cpp, just for consistency sake. Changes pathops_unittest.gyp. The pathops_unittest uses GrContextFactory, but did not link to its implementation. The reason they worked was that the implementation used (constructors, destructors) happened to be in the .h file. This works towards being able to use command buffer and NVPR from the SampleApp. BUG=skia:2992 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1511773005 Review URL: https://codereview.chromium.org/1511773005
* SampleApp: remove Picture_DeviceTypeGravatar kkinnunen2016-01-05
| | | | | | | | | | | | | | | | | | | | | | | Remove Picture_DeviceType from SampleApp SampleWindow DeviceType enumeration. Use a bool variable to control whether the drawing happens via MultiPictureDraw. The MultiPictureDraw mode can be activated by 'M', and title is updated to contain "<MPD>". Previously the MPD mode was inaccessible. This works towards removing backend specific code from SampleApp and VisualBench with the aim to move the code to the common SkView framework (SkWindow in particular). The grand goal is to be able to use command buffer GPU API and NVPR in these apps. BUG=skia:4733 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1538343002 Review URL: https://codereview.chromium.org/1538343002
* If we swap its arguments, SkTaskGroup::batch() _is_ sk_parallel_for.Gravatar mtklein2016-01-04
| | | | | | | | | | | Why have two names if we can get away with one? This kills off sk_parallel_for_thread_count(), which was only used to avoid forcing a deadlock in OncePtrTest on multicore machines in singlethreaded mode... a really niche use case. Instead just don't explicitly force a race. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1552093002 Review URL: https://codereview.chromium.org/1552093002
* Revert of df generation: single allocation with calloc (patchset #2 id:20001 ↵Gravatar mtklein2016-01-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/1544983004/ ) Reason for revert: Crashing multiple bots, e.g. https://uberchromegw.corp.google.com/i/client.skia.android/builders/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release/builds/3525 Original issue's description: > df generation: single allocation with calloc > > The dfStorage DFData allocation can never fit in its stack space: 5px padding on each side always implies at least a 10x10 DFData allocation, but the stack space only fits 64 DFData. > > So we've always been spilling to the heap. > > If we're going to spill to the heap, we might as well allocate/free all our temporary memory in one block, and since we want it zeroed, might as well calloc. > > So in practice this replaces 1-2 malloc, 1-2 free, and 2 bzeros with 1 calloc and 1 free. > > > BUG=skia:4729 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1544983004 > > Committed: https://skia.googlesource.com/skia/+/12204d90337656542a42fa0fcccb7bec13af0cce TBR=jvanverth@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4729 Review URL: https://codereview.chromium.org/1556263002
* Two malloc+bzero -> calloc.Gravatar mtklein2016-01-04
| | | | | | | | | | | | | | I was profiling DM and noticed a couple spots where we malloc then bzero. These might as well call calloc instead: - any time DM itself allocates bitmaps for raster drawing; - any time Skia allocates memory for a raster SkSurface. We could use malloc for opaque surfaces, but it seems simpler to always calloc. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1557713003 Review URL: https://codereview.chromium.org/1557713003
* remove use of malloc.hGravatar mtklein2016-01-04
| | | | | | | | | | It's non-portable, commented out, and those asserts are not important. Let's just blow it away. BUG=skia:4736 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1551673002 Review URL: https://codereview.chromium.org/1551673002
* df generation: single allocation with callocGravatar mtklein2016-01-04
| | | | | | | | | | | | | | | The dfStorage DFData allocation can never fit in its stack space: 5px padding on each side always implies at least a 10x10 DFData allocation, but the stack space only fits 64 DFData. So we've always been spilling to the heap. If we're going to spill to the heap, we might as well allocate/free all our temporary memory in one block, and since we want it zeroed, might as well calloc. So in practice this replaces 1-2 malloc, 1-2 free, and 2 bzeros with 1 calloc and 1 free. BUG=skia:4729 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1544983004 Review URL: https://codereview.chromium.org/1544983004
* Revert of Try using std::call_once (patchset #1 id:1 of ↵Gravatar mtklein2016-01-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1550893002/ ) Reason for revert: Can't use on XP. :( Original issue's description: > Try using std::call_once > > Now that we've got std library support, perhaps we should start using it. > This CL acts as a little canary, and may help fix the linked bug. > > I'm not really sure what's going on in the linked bug, but using > std::call_once over homegrown atomics has to be the right answer... > > BUG=chromium:418041 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1550893002 > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Going to land this ahead of review while the tree is quiet to see how it rolls. > TBR=herb@google.com > > Committed: https://skia.googlesource.com/skia/+/8895b72f789e5dc8bb99cb9727875439005fc919 TBR=herb@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:418041 Review URL: https://codereview.chromium.org/1552333003
* handle halfway case in scan converterGravatar caryclark2016-01-04
| | | | | | | | | | | | | | | | | Scan edges that start at exactly -0.5 aren't trimmed by clipping or by rounding, triggering a debug assert. One way to fix this is to round the top and left down instead of up. Also, move the path initialization of gm/composeshader.cpp to make debugging other path problems easier. R=reed@google.com BUG=skia:2715 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1544873002 Review URL: https://codereview.chromium.org/1544873002
* remove now defunct get_paint_offsetGravatar reed2016-01-04
| | | | | | | | | | | This used to be used when we wanted to know where the paint was, so we could perform peep-hole optimizations. We no longer do that on this (older) picture format, so now this function only serves to clog up the file with asserts. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1557123002 Review URL: https://codereview.chromium.org/1557123002
* Android bots: set battery threshold to 80%Gravatar borenet2016-01-04
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1559913003 Review URL: https://codereview.chromium.org/1559913003
* On Valgrind bots, print a message every 20 minutesGravatar msarett2016-01-04
| | | | | | | | | | | | | I believe that the timeout failure on the Valgrind bot occurs because we skip many tests consecutively without printing any output. Skipping these tests requires non-trivial work. Printing a message every 20 minutes will avoid timeouts. BUG=skia:4740 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1554193002 Review URL: https://codereview.chromium.org/1554193002
* Add unit test for crbug.com/570232Gravatar robertphillips2016-01-04
| | | | | | | | | This is the promised followup to https://codereview.chromium.org/1539553002/ (Add default ctor to SkMask) and would've caught the bug before it got out into the wild. BUG=570232 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1552303002 Review URL: https://codereview.chromium.org/1552303002
* Android devices: wait for 100% chargeGravatar borenet2016-01-04
| | | | | | | | | Some devices are getting pretty low by the end of the build (3%). No reason to cut it close, bump to 100% charge. This will cause some devices to sit for a while as they charge up. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1556023002 Review URL: https://codereview.chromium.org/1556023002
* [Reland] Repeating SkBitmapProcState rounding biasGravatar fmalita2016-01-04
| | | | | | | | | | | | | | | | 1) observe the bias in repeat matrix procs also. 2) add utility for device space -> bitmap space mapping. 3) remove unneeded filter bias This is a reland of https://codereview.chromium.org/1529833003/. The main difference (and the fix) vs. the prev version is increased precision: the mapper now operates with SkFractionalInts. R=reed@google.com BUG=skia:4680, skia:4649 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1539083002 Review URL: https://codereview.chromium.org/1539083002
* remove 565 effects shadersGravatar caryclark2016-01-04
| | | | | | | | | | | | | | | This removes the 565 optimization for radial, linear, sweep, and picture shaders. The optimization gets little real-world use and has a reasonable fallback. This also permits removing the square root table for the radial gradient case. R=reed@google.com BUG=skia:1947 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1553103003 Review URL: https://codereview.chromium.org/1553103003
* Move path fallback for AA rect out of SkGpuDeviceGravatar cdalton2016-01-04
| | | | | | | | | | | | The AA rect batches currently in Skia have view matrix restrictions. If a view matrix is not supported, we have to draw the rect as a path instead. This changes moves the decision to draw as a path out of SkGpuDevice and into GrDrawContext. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1551883003 Review URL: https://codereview.chromium.org/1551883003
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 18:29:29 +0000