aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Revert "Remove ambient clamp hack for analytic shadows."Gravatar Jim Van Verth2018-04-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d75b34394b5c53b0a5e8144dd28f956fbc8b90b2. Reason for revert: Breaking GMs Original change's description: > Remove ambient clamp hack for analytic shadows. > > The hack was added to make analytic ambient shadows match the geometric > ones exactly. Removing it does produce a slight difference, but it's > only visible at full black values (and then, only slightly) and this > makes room to pass a blend parameter for falloff. > > Also fixes an issue with filling out arcs in the shadow tesselator. > > Bug: skia:7486 > Change-Id: If78d0104df7e18f4320c1658af75576f6a4a8c73 > Reviewed-on: https://skia-review.googlesource.com/122580 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Jim Van Verth <jvanverth@google.com> TBR=jvanverth@google.com,bsalomon@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia:7486 Change-Id: If0a20a358759c08a3a475d60be54a3d62ff7b6ad Reviewed-on: https://skia-review.googlesource.com/123120 Reviewed-by: Jim Van Verth <jvanverth@google.com>
* ccpr: Don't call calcCubicInverseTransposePowerBasisMatrixGravatar Chris Dalton2018-04-23
| | | | | | | | | | | We only need a few values from this Matrix, so it doesn't make sense to spend time solving the entire thing. Bug: skia: Change-Id: Id56d6f593a9a5afe1455bf2c93f6a51b1b9f1642 Reviewed-on: https://skia-review.googlesource.com/122130 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Roll skia/third_party/skcms f1a2ba9..fe14a6a (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-23
| | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/f1a2ba9..fe14a6a 2018-04-23 mtklein@chromium.org factor eval_13()/grad_13() for fewer multiplies The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=stani@google.com Change-Id: Iea841211295323429db5941df6fc1e2a5df35bec Reviewed-on: https://skia-review.googlesource.com/123065 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Enable skcms by defaultGravatar Brian Osman2018-04-23
| | | | | | | | | | This effectively switches Flutter and Android Framework to use skcms for color space transformation. Change-Id: I254f6a8614d6976ff13979ae0e745c49c334e5c6 Reviewed-on: https://skia-review.googlesource.com/123080 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* SkPDF: Don't forget to upcast before shift.Gravatar Hal Canary2018-04-23
| | | | | | | | Change-Id: I3643749a7634e0b37f6e366e22190f09ac37f863 Reviewed-on: https://skia-review.googlesource.com/123044 Auto-Submit: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Clip the SkAntiRect because of possible tilingsGravatar Yuqian Li2018-04-23
| | | | | | | | | | | | Otherwise, the AndroidShadow will crash or draw incorrectly for the threaded backend with # tiles >= 3. Bug: skia: Change-Id: If3c3b41f3576b1c44178d6343626e99be64e766b Reviewed-on: https://skia-review.googlesource.com/122953 Commit-Queue: Yuqian Li <liyuqian@google.com> Auto-Submit: Yuqian Li <liyuqian@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
* Generalize to SkDescriptorMapGravatar Herb Derby2018-04-23
| | | | | | | Change-Id: I4e7ff8093dbbe24cd5de4d4ea478716514d519f2 Reviewed-on: https://skia-review.googlesource.com/123041 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Use relative path to skcms GN fileGravatar Brian Osman2018-04-23
| | | | | | | | | | | | | This allows clients to find this dependency when skia isn't the root of the build. Bug: skia: Change-Id: Ic1b075f962ea754fd02acc17f44363193a2bf9d1 Reviewed-on: https://skia-review.googlesource.com/123043 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Fix deprecated constructor usageGravatar Brian Osman2018-04-23
| | | | | | | | | Bug: skia: Change-Id: I76ea81b863892f03caa315923f913ae73be71839 Reviewed-on: https://skia-review.googlesource.com/123042 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
* Add Transform section to viewer tools window.Gravatar Ben Wagner2018-04-23
| | | | | | | | | This adds sliders for Zoom and Rotate. Change-Id: Ie568e5381d76bd5a457760e2d6224e42e64c7f16 Reviewed-on: https://skia-review.googlesource.com/123027 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* use SkRect::outset, as it clamps on overflowGravatar Mike Reed2018-04-23
| | | | | | | | | Bug: oss-fuzz:7929 Change-Id: Ic9a2582eb7ab638fda71b10bf987a6c584770e43 Reviewed-on: https://skia-review.googlesource.com/122959 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Roll skia/third_party/skcms 17d4b82..f1a2ba9 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-23
| | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/17d4b82..f1a2ba9 2018-04-23 mtklein@chromium.org add SKCMS_PROFILE support for ARMv8 The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=stani@google.com Change-Id: Ie331159bbfaf98c86467a8877120ed2c8f8bf8d8 Reviewed-on: https://skia-review.googlesource.com/122991 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Rewrite CHECK_INTERSECT to perform the !(opposite) predicate, so that weGravatar Mike Reed2018-04-23
| | | | | | | | | | return false if either argument is NaN. Bug: oss-fuzz:7914 Change-Id: If4f5eae736bb93451d2ff1c802e7c84a62a38cbc Reviewed-on: https://skia-review.googlesource.com/122957 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Roll skia/third_party/skcms 71966da..17d4b82 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-23
| | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/71966da..17d4b82 2018-04-23 mtklein@chromium.org SKCMS_PROFILE support on ARMv7 The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=stani@google.com Change-Id: I342ffdfcbd1c4588f031f574d7fef939b51abd3b Reviewed-on: https://skia-review.googlesource.com/122989 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Fixes in ReadPixels2 and yuv_texture gm to fix Vulkan validation issues.Gravatar Greg Daniel2018-04-23
| | | | | | | | Bug: skia: Change-Id: Idfccdec9106bdc79a690da0e173a232a0cbe51a9 Reviewed-on: https://skia-review.googlesource.com/122955 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Reland "Prevent masked solid-color draws from being turned into clears"Gravatar Robert Phillips2018-04-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f92bb3785fa8015cde9f379be52dedfce5abc290. Reason for revert: The new unit test has been suppressed on ANGLE Original change's description: > Revert "Prevent masked solid-color draws from being turned into clears" > > This reverts commit e9f2bbe082e9e1eb9d76e3043adedc9443427d8d. > > Reason for revert: ANGLE > > Original change's description: > > Prevent masked solid-color draws from being turned into clears > > > > GrRenderTargetContext::drawRect was eliding a BlurMask filtered circle. > > > > Bug: skia:7765 > > Change-Id: Id98c059f7d786ee5c9bca839c8e099997ff2aedb > > Reviewed-on: https://skia-review.googlesource.com/122793 > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > TBR=bsalomon@google.com,robertphillips@google.com > > Change-Id: I1b7752eab0fcf55ab6248eed587fd85d438efd78 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:7765 > Reviewed-on: https://skia-review.googlesource.com/122960 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> TBR=bsalomon@google.com,robertphillips@google.com Change-Id: If432c24548ef0f6df4fd6a06aa3b1fb38ba793b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7765 Reviewed-on: https://skia-review.googlesource.com/123000 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Disable BlurMaskBiggerThanDest unit test on ANGLEGravatar Robert Phillips2018-04-23
| | | | | | | | Bug: skia:7835 Change-Id: Iec9469799121f435670c5a3841707fe6199066c5 Reviewed-on: https://skia-review.googlesource.com/122954 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/skcms c4941e8..71966da (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-23
| | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/c4941e8..71966da 2018-04-23 mtklein@chromium.org fail skcms_Parse() for useless profiles The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=stani@google.com Change-Id: I8c36fb89675b9b1639a1d494641d8993d3723c93 Reviewed-on: https://skia-review.googlesource.com/122980 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Add SwiftShader Test jobs.Gravatar Ben Wagner2018-04-23
| | | | | | | | | Bug: skia:7671 Change-Id: I29134929071ba6c59de948e5f579d33e973f9baa Reviewed-on: https://skia-review.googlesource.com/122541 Auto-Submit: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Backspace opens slide picker (not paint) in viewer.Gravatar Ben Wagner2018-04-23
| | | | | | | | | | | | | A recent change added the "Paint" section to the viewer tools window. The code around forcing the slide picker open when the backspace key was pressed was inadvertantly separated from the slide picker section, so now the paint section is confusingly held open instead. This changes the logic so that the slide picker is once again the target of backspace. Change-Id: Ibfcb78bb0a1e2bdbb2ccce54b38e8206e0303753 Reviewed-on: https://skia-review.googlesource.com/122949 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Reject XYZ profiles missing some (or all) TRC tagsGravatar Brian Osman2018-04-23
| | | | | | | | | | | | | | The previous behavior isn't justified by the spec, and doesn't match skcms' behavior. To ease migration and avoid discrepancy when dealing with fuzzer-generated profiles, enforce the stricter rules here. Bug: chromium:835666 Change-Id: Ice6452b521a737d6dc339571dcbb313567235ed6 Reviewed-on: https://skia-review.googlesource.com/122952 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-04-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/161623779eaf8cd3dd571dfa4aa5b44b9611396f presubmit: don't attempt to verify nonexistent vpython specs. (jbudorick@chromium.org) https://crrev.com/98824231fc49c39ec47005c1e580684fc34d3026 [git-cl] make more informative error message. (tandrii@chromium.org) https://crrev.com/5c62ed59d2a3901931d01b27388d7c0037178a8e owners: Add support for comments at the end of the line. (ehmaldonado@chromium.org) https://crrev.com/733d4ec8e3364f9491291963475aee2a137bb2f1 [gerrit_util] learn about and use LUCI_CONTEXT when available. (tandrii@chromium.org) https://crrev.com/b3c4441c8176780f5f58e22c1ffb9406f9934799 [auth] cache LUCI_CONTEXT local_auth parameters. (tandrii@chromium.org) https://crrev.com/741afe8c930f988eb8d2b715540cfc598b12c38a [auth] cleanup old code.google.com oauth scope usage. (tandrii@chromium.org) https://crrev.com/067ef5d8941a59ca176f5ee63bb02d0e3df947c4 Add support for checking that OWNERS files are correctly formatted. (ehmaldonado@chromium.org) https://crrev.com/94580ab035eb3d05e352dc9c16b4908e9f744579 [auth] Fix typo introduced in https://crrev.com/c/1018488/13/auth.py#514 (tandrii@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I98cd3d3913f1289be562add4d7170ff2b8ac7263 Reviewed-on: https://skia-review.googlesource.com/122950 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* (Mostly) respect FilterQuality in draw[stretchy]Gravatar Leon Scroggins III2018-04-23
| | | | | | | | | | | | | | | | | | | | | | | Bug: b/77917978 For drawImageLattice drawBitmapLattice drawImageNine drawBitmapNine , respect the SkFilterQuality on the SkPaint. Previously the GPU used the lowest quality to avoid a bleeding effect, leading to ugly nine- patches on Android. For all backends, cap the filter quality at kLow_SkFilterQuality. Update SkCanvas' documentation to specify this. Change-Id: Id28c7753834975f039170f14bc51be4f2bd44d41 Reviewed-on: https://skia-review.googlesource.com/121891 Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com> Auto-Submit: Leon Scroggins <scroggo@google.com>
* [infra] Fast-forward recipes, re-enable rollerGravatar Eric Boren2018-04-23
| | | | | | | | | Bug: skia: Change-Id: I3dfda2b49917079350b89d739ba6e00fd12c20f1 Reviewed-on: https://skia-review.googlesource.com/122300 Auto-Submit: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Revert "Prevent masked solid-color draws from being turned into clears"Gravatar Robert Phillips2018-04-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e9f2bbe082e9e1eb9d76e3043adedc9443427d8d. Reason for revert: ANGLE Original change's description: > Prevent masked solid-color draws from being turned into clears > > GrRenderTargetContext::drawRect was eliding a BlurMask filtered circle. > > Bug: skia:7765 > Change-Id: Id98c059f7d786ee5c9bca839c8e099997ff2aedb > Reviewed-on: https://skia-review.googlesource.com/122793 > Reviewed-by: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,robertphillips@google.com Change-Id: I1b7752eab0fcf55ab6248eed587fd85d438efd78 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7765 Reviewed-on: https://skia-review.googlesource.com/122960 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/skcms e658346..c4941e8 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-23
| | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/e658346..c4941e8 2018-04-19 mtklein@chromium.org copy BUILD.gn into skcms repo The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=stani@google.com Change-Id: Ia87cbb4641b91d1b8d24eeef4f720273936313c4 Reviewed-on: https://skia-review.googlesource.com/122929 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/angle2/ 505ea1bb5..40786bdfc (3 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/505ea1bb56cc..40786bdfc8e0 $ git log 505ea1bb5..40786bdfc --date=short --no-merges --format='%ad %ae %s' 2018-04-18 jiawei.shao ES31: Add validation on geometry shader interface blocks matching 2018-04-19 lucferron Vulkan: Implement Texture wrap modes and non-mipmapped filtering modes 2018-04-13 oetuaho Fix Vulkan renderer string for NVIDIA Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=stani@google.com Change-Id: Ifc39e911c45deab9756f3e7cc1866cd499ec0cde Reviewed-on: https://skia-review.googlesource.com/122927 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Remove Android compile bot from the CQGravatar Ravi Mistry2018-04-23
| | | | | | | | | | NoTry: True Bug: skia:7834 Change-Id: Ia38a800da098101effb6804118ccf4b0a0a93c72 Reviewed-on: https://skia-review.googlesource.com/122945 Commit-Queue: Ravi Mistry <rmistry@google.com> Auto-Submit: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Switch RecreateSKPs and Bookmaker bots to use service accountsGravatar Eric Boren2018-04-23
| | | | | | | Bug: skia: Change-Id: I59aefe7c7e7a6861b00f0e22310e7ceaff3d6d0e Reviewed-on: https://skia-review.googlesource.com/122944 Reviewed-by: Ravi Mistry <rmistry@google.com>
* Remove UpdateMetaConfig botGravatar Eric Boren2018-04-23
| | | | | | | | | | | | | It's perma-failing, and it doesn't work with Kitchen due to the new service account not being authorized. Rather than spend the energy to fix the service account (and move to an internal repo) I'll just delete it since it's blocked on a low priority bug with an unknown ETA. Bug: skia: Change-Id: I04636fda334f8a878bde2612b3edad65d81986dc Reviewed-on: https://skia-review.googlesource.com/122943 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Disable threaded SW mask generation on DDL botsGravatar Robert Phillips2018-04-23
| | | | | | | | | | Although we will support threaded generation of SW masks in DDL mode, this more closely matches Chrome's behavior Change-Id: I28596f66693e3daa941c3dbd974a8d33f4561c16 Reviewed-on: https://skia-review.googlesource.com/122789 Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Prevent masked solid-color draws from being turned into clearsGravatar Robert Phillips2018-04-23
| | | | | | | | | GrRenderTargetContext::drawRect was eliding a BlurMask filtered circle. Bug: skia:7765 Change-Id: Id98c059f7d786ee5c9bca839c8e099997ff2aedb Reviewed-on: https://skia-review.googlesource.com/122793 Reviewed-by: Brian Salomon <bsalomon@google.com>
* roll skcms to just before where we added BUILD.gnGravatar Mike Klein2018-04-23
| | | | | | | | | The next roll should find it wants to copy in BUILD.gn, right? Change-Id: Idf9ab7891906a0a7df9b6ba99f95b556771b5797 Reviewed-on: https://skia-review.googlesource.com/122661 Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com>
* Roll third_party/externals/angle2/ aecfa71b4..505ea1bb5 (3 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/aecfa71b4a2c..505ea1bb56cc $ git log aecfa71b4..505ea1bb5 --date=short --no-merges --format='%ad %ae %s' 2018-04-18 tobine Roll (2/2) to latest LVL as of 4/18/18 2018-04-18 tobine Roll (1/2) LVL version forward and disable VANGLE 2018-04-19 ynovikov Use EGL_KHR_no_config_context in Android GLES backend, when available Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=stani@google.com Change-Id: I69ded436bf137cd900ef06907055b140294e5ba6 Reviewed-on: https://skia-review.googlesource.com/122924 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Fixed SkVertices crashing on Windows DLL buildsGravatar Yong-Hwan Baek2018-04-22
| | | | | | | | | SkVertices::Builder uses custom new operator but not exposed to dll. While delete operator in SkVertices.h could be inlined, it causes crash on Windows DLL builds. This patch fixes this issue. Change-Id: I8b635ad3aa4a3f496a392ce7840417947999e4b0 Reviewed-on: https://skia-review.googlesource.com/122480 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Roll third_party/externals/angle2/ 3ec304dba..aecfa71b4 (6 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/3ec304dba28d..aecfa71b4a2c $ git log 3ec304dba..aecfa71b4 --date=short --no-merges --format='%ad %ae %s' 2018-04-20 ynovikov Print more logs 2018-04-10 geofflang Refactor packed enum generation to support EGL enums. 2018-04-20 geofflang Use LIKELY and UNLIKELY macros to wrap error generation. 2018-04-20 jmadill Fix WebGL compat feedback loop null deref. 2018-04-19 tobine Make Mock ICD json file a data_dep of Mock ICD 2018-04-19 lucferron Refactor Texture::syncState to pass down the Context Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=scroggo@google.com Change-Id: I6f07498ffda7bf9b524acc723f0b1e70dea0eca8 Reviewed-on: https://skia-review.googlesource.com/122860 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Remove assert that color spaces have valid profile dataGravatar Brian Osman2018-04-22
| | | | | | | | | | | | | | Chrome fuzzing can trigger this code with malformed profile data (which suggests that the older SkColorSpace::MakeICC allowed some invalid profile data to slip through). In any case, simply returning false to reject the profile is fine. Bug: chromium:835540 Change-Id: Ib675b8e9e3be444ad5dbf8153d60d86284682c90 Reviewed-on: https://skia-review.googlesource.com/122940 Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@google.com>
* Fix starting location in GrRTC::drawOval when converting to GrShapeGravatar Brian Salomon2018-04-20
| | | | | | | | Change-Id: I3b86d15add9d463e64c97f53bdb5042f1e2a2f27 Reviewed-on: https://skia-review.googlesource.com/122880 Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Analytic dashing of circles with single on/off intervals and butt caps.Gravatar Brian Salomon2018-04-20
| | | | | | | | Change-Id: If19ac52cb78af57572a102cec0084f5b6c037680 Reviewed-on: https://skia-review.googlesource.com/121882 Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Fix argument names and documentation for SkMatrix44::set3x3()Gravatar Brian Osman2018-04-20
| | | | | | | | | | | | | | | Column-major is an implementation choice, not an interface. There is exactly one acceptable subscript notation for indexing matrix elements, and it's row first, then column. Having these named backwards was unnecessarily confusing. Note that this doesn't alter behavior in any way, it just brings this function in line with expectations from any reasonable mathematician. Change-Id: Ie4ceb40281ef507889d25403afbf24116514c45a Reviewed-on: https://skia-review.googlesource.com/122790 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Reland "Add stub gpu workaround generators"Gravatar Adrienne Walker2018-04-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a reland of 94d25b970b97c68ddd0b4ceb71f2233aac05e6b5 Original change's description: > Add stub gpu workaround generators > > Like https://chromium-review.googlesource.com/c/chromium/src/+/1005362, > this patch adds a way for Chrome and Skia to share a set of driver > workaround names so that they can be turned on by Chrome (or Skia) as > needed. > > To avoid weird cross-repository dependencies, the generator script is > duplicated in Skia. > > This patch just adds a few dummy workaround names to make sure the build > process is working. The followup to this is to add workaround init > to GrContext/GrContextOptions and to start implementing individual > workarounds. > > Implementing these workarounds is to support Chrome's "out of process > raster" which will use Ganesh without a command buffer, and so will not > have the workarounds that the command buffer provides. > > Bug: chromium:829614 > Change-Id: I40745a777a95805995991fedb81657ae418b52d9 > Reviewed-on: https://skia-review.googlesource.com/120608 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Adrienne Walker <enne@chromium.org> Bug: chromium:829614 Change-Id: Idb3309ffa894f7585ee493388b56565e9d4a3101 Reviewed-on: https://skia-review.googlesource.com/122800 Auto-Submit: Adrienne Walker <enne@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Add ability to dump opList info at flush-timeGravatar Robert Phillips2018-04-20
| | | | | | | | | When debugging DDL it is useful to just see which ops are being drawn instead of the entire reordering history. Change-Id: I89708fecbd53c097b00e65b0da426bfb8046b0ee Reviewed-on: https://skia-review.googlesource.com/122780 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Fix Housekeeper-PerCommit-InfraTestsGravatar Ben Wagner2018-04-20
| | | | | | | | | | | | | Failure was the result of a conflict between these two CLs: https://skia-review.googlesource.com/122640 https://skia-review.googlesource.com/121425 Bug: skia:7671 No-Try: true Change-Id: I143e8dc4e27b6f0720b0f9d72839a6f53bdd6c4a Reviewed-on: https://skia-review.googlesource.com/122792 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Reduce threads used for DNG decodes on AndroidGravatar Leon Scroggins III2018-04-20
| | | | | | | | | | | | | | | | Bug: b/78120086 DNG files require lots of memory to decode. We recently removed the limit on how much SkRawCodec can allocate, allowing it to decode large warped DNG files, so long as the device has enough memory. But in practice, running too many threads at once with each thread allocating a lot of memory results in crashing on Android. Reduce the number of threads so we save memory and do not crash. Change-Id: I464b5a21c019463d2ec31e333f25ebb0b81605bd Reviewed-on: https://skia-review.googlesource.com/122786 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Add SwiftShader Build jobs.Gravatar Ben Wagner2018-04-20
| | | | | | | | | Bug: skia:7671 No-Try: true Change-Id: I34015cceca538c84d87a77b6688fa1490c620d04 Reviewed-on: https://skia-review.googlesource.com/121425 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add cmake_linux asset.Gravatar Ben Wagner2018-04-20
| | | | | | | | | | Bug: skia:7671 No-Try: true Change-Id: I4a2c5abb8480dfb7ca75a4d523f8b337a3eb9fba Reviewed-on: https://skia-review.googlesource.com/122520 Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add discard check when deciding if we should execute op list or not.Gravatar Greg Daniel2018-04-20
| | | | | | | | Bug: skia:7828 Change-Id: I339ba64b6312cd9444cd4faffd426d91852774e9 Reviewed-on: https://skia-review.googlesource.com/122784 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Remove another writePixels instanceGravatar Robert Phillips2018-04-20
| | | | | | | | | This converts the GrSWMaskHelper to being DDL compatible Change-Id: Ic0c7f95a7ed6d2936118b4127c2cfce94a2ec0da Reviewed-on: https://skia-review.googlesource.com/122788 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* ccpr: Don't solve for cubic roots that are out of rangeGravatar Chris Dalton2018-04-20
| | | | | | | | | | | | | Most real-world cubics don't have both KLM roots inside T=0..1, and a large amount don't have any. This CL gives a nice speedup by not wasting time finding padding around KLM roots that we aren't going to chop at anyway. Bug: skia: Change-Id: Icb7217142e29fc3f8e8ff657e9dc739caf6d6714 Reviewed-on: https://skia-review.googlesource.com/122129 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Add SwiftShader to DEPS.Gravatar Ben Wagner2018-04-20
| | | | | | | | | | Bug: skia:7671 No-Try: true Change-Id: Ib41428b5c3ed8d6655fac38e525014663ce85817 Reviewed-on: https://skia-review.googlesource.com/121357 Commit-Queue: Hal Canary <halcanary@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-28 15:34:59 +0000