aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Fix a warning in PictureBenchmark.Gravatar scroggo@google.com2012-09-25
| | | | | | | | | Forgot to change from false to NULL. False does the right thing, but gives a warning. Fix the warning. Review URL: https://codereview.appspot.com/6570049 git-svn-id: http://skia.googlecode.com/svn/trunk@5666 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reimplement drawBitmapRectToRect to correctly handle fraction srcRect.Gravatar reed@google.com2012-09-25
| | | | | | | | | | | | | | | | | | | | | | | | The prev impl relied on drawBitmap "deducing" the destination rect by applying the computed matrix to the bitmap's bounds. This cannot be done if the srcRect is fractional, and therefore not representable w/ a bitmap. The new impl computes the same matrix, but calls down to the device via drawRect + a bitmap_shader. This allows us to specfiy the dstRect explicitly. The possible down-side is that we now rely on the device subclass to efficiently handle draRect+shader, instead of calling its drawBitmap entry-point. To give the device the chance to handle this differently, I now call through to a new device virtual: drawBitmapRect. The default impl is to create the shader and call drawRect, but a subclass can intercept that. For now, the GPU override of drawBitmapRect is mimicing the old behavior (by rounding the srcRect to an iRect). This preserves its ability to call drawBitmap which handles very-large textures, but shows some gittering/imprecision, due to the rounding. ... this is the same GPU behavior we have before this CL. Review URL: https://codereview.appspot.com/6542065 git-svn-id: http://skia.googlecode.com/svn/trunk@5663 2bbb7eff-a529-9590-31e7-b0007b416f81
* This patch adds support for optional processing of the alpha channel inGravatar senorblanco@chromium.org2012-09-25
| | | | | | | | | | | | | | the matrix convolution filter. Test cases are added to the GM and the bench. NOTE: This will require rebaselining the matrixconvolution GM, so it will likely turn the bots red until that is done. https://codereview.appspot.com/6547049/ git-svn-id: http://skia.googlecode.com/svn/trunk@5661 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Skia_Periodic_House_KeepingGravatar skia.committer@gmail.com2012-09-25
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@5656 2bbb7eff-a529-9590-31e7-b0007b416f81
* "fix" chrome buildGravatar robertphillips@google.com2012-09-25
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@5655 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix mac buildsGravatar caryclark@google.com2012-09-24
| | | | | | comment out 64 bit / mac error check git-svn-id: http://skia.googlecode.com/svn/trunk@5654 2bbb7eff-a529-9590-31e7-b0007b416f81
* Build fix. Unreviewed.Gravatar senorblanco@chromium.org2012-09-24
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@5653 2bbb7eff-a529-9590-31e7-b0007b416f81
* unbreak the build part iiGravatar caryclark@google.com2012-09-24
| | | | | | allow android in debugger.gyp git-svn-id: http://skia.googlecode.com/svn/trunk@5651 2bbb7eff-a529-9590-31e7-b0007b416f81
* unbreak the buildGravatar caryclark@google.com2012-09-24
| | | | | | move define of skia_arch_type to front git-svn-id: http://skia.googlecode.com/svn/trunk@5650 2bbb7eff-a529-9590-31e7-b0007b416f81
* iOS support work in progressGravatar caryclark@google.com2012-09-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | include/core/SkTypes.h - address unsigned warning include/core/SkInstCnt.h src/core/SkInstCnt.cpp gyp/common.gypi - always define SK_ENABLE_INST_COUNT for debug builds src/views/mac/SkNSView.mm - only call glClear if there is a GL context src/ports/SkImageDecoder_CG.cpp - fix iOS hack by using proper include gyp/opts.gyp - exclude more ARM files from iOS for now (see issue 900) gyp/common_conditions.gypi - add release, more ios specific common settings gyp/bench.gyp - add iOS condition gyp/SampleApp.gyp - remove precompiled header, hardcoded SDK path - add more frameworks gyp/debugger.gyp - fix syntax error - add iOS/Android condition gyp/core.gyp - remove hardcoded SDK path, add more frameworks gyp/common_variables.gypi - add ios SDK path - add ios SDK version gyp/iOSSampleApp.gyp - remove obsolete project gyp/zlib.gyp - add ios library path Review URL: https://codereview.appspot.com/6551070 git-svn-id: http://skia.googlecode.com/svn/trunk@5649 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix for GrTextureStripAtlas memory leakGravatar robertphillips@google.com2012-09-24
| | | | | | | | https://codereview.appspot.com/6549050/ git-svn-id: http://skia.googlecode.com/svn/trunk@5648 2bbb7eff-a529-9590-31e7-b0007b416f81
* Addressed xcode analysis complaintsGravatar robertphillips@google.com2012-09-24
| | | | | | | | http://codereview.appspot.com/6558048/ git-svn-id: http://skia.googlecode.com/svn/trunk@5646 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to trigger rebuild after tweaking Windows build slavesGravatar borenet@google.com2012-09-24
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@5645 2bbb7eff-a529-9590-31e7-b0007b416f81
* When recording a GM to a picture, pass the GM's size to beginRecording.Gravatar scroggo@google.com2012-09-21
| | | | | | Review URL: https://codereview.appspot.com/6552047 git-svn-id: http://skia.googlecode.com/svn/trunk@5644 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make flattenables no longer depend on global static initializers.Gravatar scroggo@google.com2012-09-21
| | | | | | | | | | | | | | | | | Instead, force all builds to call InitializeFlattenables. Remove the make_debugger script, which was created to force rebuilding without global static initializers so that all flattenables would be linked. It is no longer necessary since all flattenables will be linked thanks to InitializeFlattenables, which now can (and must) be called when global static initializers are turned on. BUG=https://code.google.com/p/skia/issues/detail?id=903 BUG=https://code.google.com/p/skia/issues/detail?id=902 Review URL: https://codereview.appspot.com/6548044 git-svn-id: http://skia.googlecode.com/svn/trunk@5642 2bbb7eff-a529-9590-31e7-b0007b416f81
* [PDF] Fix name generation - / needs to be escaped.Gravatar vandebo@chromium.org2012-09-21
| | | | | | | | BUG=chromium 148422 Review URL: https://codereview.appspot.com/6542044 git-svn-id: http://skia.googlecode.com/svn/trunk@5641 2bbb7eff-a529-9590-31e7-b0007b416f81
* check for very large blurs, and don't try to cache the result in fontcacheGravatar reed@google.com2012-09-21
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=138208 git-svn-id: http://skia.googlecode.com/svn/trunk@5640 2bbb7eff-a529-9590-31e7-b0007b416f81
* disable experiemental hack to try to speedup floorGravatar reed@google.com2012-09-21
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@5636 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Skia_Periodic_House_KeepingGravatar skia.committer@gmail.com2012-09-21
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@5635 2bbb7eff-a529-9590-31e7-b0007b416f81
* Adding hasPendingCommands API method to SkDeferredCanvasGravatar junov@chromium.org2012-09-20
| | | | | | | BUG=http://code.google.com/p/chromium/issues/detail?id=146178 Review URL: https://codereview.appspot.com/6550050 git-svn-id: http://skia.googlecode.com/svn/trunk@5632 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to trigger a bot cycle after r5630Gravatar borenet@google.com2012-09-20
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@5631 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fixing how deferred canvas purges itself when a clear is recoreded.Gravatar junov@chromium.org2012-09-20
| | | | | | | | | | | | | | | | | | | | | | This fixes performance because the old code was not reconstructing the clip state correctly. This was causing a major performance degradation in the Galactic IE testdrive demo. This fix also enbles the purge on clear optimization when there is saved state on the matrix/clip stack. The approach taken to solve the problem consists in purging by running the playback silently. The previous approach was tearing down and restarting the gpipe, which required reconstructing state, which is fragile and hard to do correctly, and has the side effect of clearing the bitmap heap and the flattened dictionary. Note: This CL is expected to slightly degrade performance of the deferred_canvas_record bench, which uses the skip on clear optimization. This is because a silent playback takes more time that just destroying the SkGPipe. Correctness trumps performance. BUG=http://code.google.com/p/chromium/issues/detail?id=146178 Review URL: https://codereview.appspot.com/6531048 git-svn-id: http://skia.googlecode.com/svn/trunk@5627 2bbb7eff-a529-9590-31e7-b0007b416f81
* Adding a silent playback option to SkGPipeReadGravatar junov@chromium.org2012-09-20
| | | | | | | | | | | Testing state consistency after silent playback in CanvasTest indirectly through SkDeferredCanvas. BUG=http://code.google.com/p/chromium/issues/detail?id=146178 TEST=CanvasTest unit test, and bench with --mode deferredSilent Review URL: https://codereview.appspot.com/6542047 git-svn-id: http://skia.googlecode.com/svn/trunk@5619 2bbb7eff-a529-9590-31e7-b0007b416f81
* Got debugger compiling again after SkCanvas API changeGravatar robertphillips@google.com2012-09-20
| | | | | | | | http://codereview.appspot.com/6543047/ git-svn-id: http://skia.googlecode.com/svn/trunk@5616 2bbb7eff-a529-9590-31e7-b0007b416f81
* Prevent LinearRegression from dividing by zero so the GenerateBenchGraphs ↵Gravatar senorblanco@chromium.org2012-09-20
| | | | | | | | | | step doesn't blow up if the data is all zeroes. http://codereview.appspot.com/6546049/ git-svn-id: http://skia.googlecode.com/svn/trunk@5615 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove automatic resizing in *_picturesGravatar borenet@google.com2012-09-20
| | | | | | Review URL: https://codereview.appspot.com/6554045 git-svn-id: http://skia.googlecode.com/svn/trunk@5614 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update bench_expectationsGravatar borenet@google.com2012-09-20
| | | | | | | | | | We only have three runs since the regression was fixed in r5605: 153.68, 154.09, 153.71 These bounds seem reasonable to me. Review URL: https://codereview.appspot.com/6541049 git-svn-id: http://skia.googlecode.com/svn/trunk@5613 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove use of SkRefPtr in public header (SkPDFDocument.h)Gravatar reed@google.com2012-09-20
| | | | | | Review URL: https://codereview.appspot.com/6546048 git-svn-id: http://skia.googlecode.com/svn/trunk@5612 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove unused parameter (that also slowed us down) to SkAutoTDeleteGravatar reed@google.com2012-09-20
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@5611 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix premul alpha problems w/matrix convolution filter, and re-enable the bench.Gravatar senorblanco@chromium.org2012-09-20
| | | | | | | | http://codereview.appspot.com/6541043/ git-svn-id: http://skia.googlecode.com/svn/trunk@5610 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove all SkRefPtr from SkPDFDevice.hGravatar reed@google.com2012-09-20
| | | | | | Review URL: https://codereview.appspot.com/6542049 git-svn-id: http://skia.googlecode.com/svn/trunk@5609 2bbb7eff-a529-9590-31e7-b0007b416f81
* Pull SDKROOT into a gyp variable, so it can be locally overridden. ThisGravatar senorblanco@chromium.org2012-09-20
| | | | | | | | | | allows building on Lion or Mountain Lion using XCode 4.4. http://codereview.appspot.com/6553044/ git-svn-id: http://skia.googlecode.com/svn/trunk@5607 2bbb7eff-a529-9590-31e7-b0007b416f81
* first cut at making iOS workGravatar caryclark@google.com2012-09-20
| | | | | | | | | | | | | Replace __arm__ with SK_CPU_ARM add support for iOS simulator and device fix const warning in iOSSampleApp update gyp files https://code.google.com/p/skia/issues/detail?id=900 tracks fixing missing arm assembly Review URL: https://codereview.appspot.com/6552045 git-svn-id: http://skia.googlecode.com/svn/trunk@5606 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix GrTextureAccess::operator ==Gravatar bsalomon@google.com2012-09-20
| | | | | | | | | compare the textures, correctly intepret memcmp result, don't compare last byte of swizzle array which must be 0. BUG=895 Review URL: https://codereview.appspot.com/6542048 git-svn-id: http://skia.googlecode.com/svn/trunk@5605 2bbb7eff-a529-9590-31e7-b0007b416f81
* In render_pictures tiled rendering, draw a separate PNG for each tile.Gravatar scroggo@google.com2012-09-20
| | | | | | | | | | Since the passed in picture may represent an image which is too large to be represented on the GPU, never create such a large canvas. Instead, after drawing to each tile, create a file showing just that tile. Review URL: https://codereview.appspot.com/6532056 git-svn-id: http://skia.googlecode.com/svn/trunk@5603 2bbb7eff-a529-9590-31e7-b0007b416f81
* In bench_pictures, use a pool of tiles for multicore drawing.Gravatar scroggo@google.com2012-09-20
| | | | | | | | | | | | | | | | | | | Also includes some code cleanup and code sharing. Allow setting the number of threads on the command line. Rename ThreadSafePipeController::playback to ::draw, to be the same as SkPicture so DrawTileToCanvas can take a template parameter. Disallow multithreading with GPU turned on. Display help information with improper tiled arguments. BUG=https://code.google.com/p/skia/issues/detail?id=871 Review URL: https://codereview.appspot.com/6536050 git-svn-id: http://skia.googlecode.com/svn/trunk@5602 2bbb7eff-a529-9590-31e7-b0007b416f81
* Yet another speculative Android fix. Unreviewed.Gravatar senorblanco@chromium.org2012-09-19
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@5600 2bbb7eff-a529-9590-31e7-b0007b416f81
* Renaming a couple methods in SkDeferredCanvas.cpp to improve readabilityGravatar junov@chromium.org2012-09-19
| | | | | | Review URL: https://codereview.appspot.com/6536060 git-svn-id: http://skia.googlecode.com/svn/trunk@5599 2bbb7eff-a529-9590-31e7-b0007b416f81
* Speculative fix for Android GMs. Unreviewed.Gravatar senorblanco@chromium.org2012-09-19
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@5598 2bbb7eff-a529-9590-31e7-b0007b416f81
* Skip empty directories and input files not ending in .skp in *_picturesGravatar borenet@google.com2012-09-19
| | | | | | | Addressing https://code.google.com/p/skia/issues/detail?id=886 Review URL: https://codereview.appspot.com/6531047 git-svn-id: http://skia.googlecode.com/svn/trunk@5597 2bbb7eff-a529-9590-31e7-b0007b416f81
* begin to skiafy PDF headers : removing use of SkRefPtrGravatar reed@google.com2012-09-19
| | | | | | Review URL: https://codereview.appspot.com/6526050 git-svn-id: http://skia.googlecode.com/svn/trunk@5596 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to trigger a rebuild after removing bad bench data from r5592Gravatar borenet@google.com2012-09-19
| | | | | | This should stop the failures from GenerateBenchGraphs git-svn-id: http://skia.googlecode.com/svn/trunk@5595 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Skia_Periodic_House_KeepingGravatar skia.committer@gmail.com2012-09-19
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@5594 2bbb7eff-a529-9590-31e7-b0007b416f81
* Unreviewed; build fix.Gravatar senorblanco@chromium.org2012-09-18
| | | | | | | | | Disable matrixconvolution bench until I can figure out the premul issues. git-svn-id: http://skia.googlecode.com/svn/trunk@5593 2bbb7eff-a529-9590-31e7-b0007b416f81
* Implements a matrix convolution filter (raster path only). The filtering loopGravatar senorblanco@chromium.org2012-09-18
| | | | | | | | | | | | is templated on the tiling mode for speed: interior pixels are unconditionally fetched; border pixels apply the appropriate tiling mode before fetching. It handles target, bias, divisor (as gain), and edge modes (named to be more skia-like). It does not handle the "preserveAlpha" semantics of feConvolveMatrix, nor "kernelUnitLength". git-svn-id: http://skia.googlecode.com/svn/trunk@5592 2bbb7eff-a529-9590-31e7-b0007b416f81
* shape ops work in progressGravatar caryclark@google.com2012-09-18
| | | | | | at least 12M of the quad/quad intersection tests pass git-svn-id: http://skia.googlecode.com/svn/trunk@5591 2bbb7eff-a529-9590-31e7-b0007b416f81
* Explicitly convert from int to SkScalar to avoid a compiler error on gcc 4.5Gravatar george@mozilla.com2012-09-18
| | | | | | Review URL: https://codereview.appspot.com/6526047 git-svn-id: http://skia.googlecode.com/svn/trunk@5589 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix for r5587 compiler error (removed ../src/gpu in HashCacheTest.cpp)Gravatar robertphillips@google.com2012-09-18
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@5588 2bbb7eff-a529-9590-31e7-b0007b416f81
* Added functor to GrTHashCache to allow discovery of un-reffed resourcesGravatar robertphillips@google.com2012-09-18
| | | | | | | | http://codereview.appspot.com/6503126/ git-svn-id: http://skia.googlecode.com/svn/trunk@5587 2bbb7eff-a529-9590-31e7-b0007b416f81
* update gyp files to build on iOSGravatar caryclark@google.com2012-09-18
| | | | | | | | | | Note that there's a hack in SkImageDecoder_CG.cpp -- the necessary defines are included directly. This is temporary until I can figure out how to include them properly. Review URL: https://codereview.appspot.com/6523044 git-svn-id: http://skia.googlecode.com/svn/trunk@5586 2bbb7eff-a529-9590-31e7-b0007b416f81