aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* optimize fast/simple case in raster tilingGravatar Mike Reed2018-04-16
| | | | | | | | | | | | | | | 1. We want to avoid as much overhead as possible in the tiler setup, so do a quick check before handling bounds 2. Compare against current clipbounds instead of devicesize, which may eliminate looping sometimes Follow-on to https://skia-review.googlesource.com/c/skia/+/119570 Bug: 818693 Bug: 820245 Bug: 820470 Change-Id: If34721c7e467d1ab9e879f25e7b86af6732ca384 Reviewed-on: https://skia-review.googlesource.com/121329 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com>
* Simplify the operation on atomic fIsFinishingGravatar Yuqian Li2018-04-16
| | | | | | | | Bug: skia: Change-Id: I7ffe9bc11d211b0c1a4873b28ad4d0f574a6148b Reviewed-on: https://skia-review.googlesource.com/121326 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Let SkCoverageDeltaList store width and use it during blittingGravatar Yuqian Li2018-04-16
| | | | | | | | | | | | Otherwise, out/Debug/viewer -m complexclip_bw_invert may crash using the threaded backend because the clip in the initFn may be wider than the clip in the drawFn. Bug: skia: Change-Id: I3b3ddc9a912fcc155bd30a6bc1f87e24739d1ca6 Reviewed-on: https://skia-review.googlesource.com/121327 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* SkBlitter is not thread safe; make one for each thread.Gravatar Yuqian Li2018-04-16
| | | | | | | | | | | | | | | Otherwise, GM fancy_gradients would be drawn incorrectly and TSAN will issue alerts as SkARGB32_Shader_Blitter has its own memory that may be written during blitting. As we make one blitter for each thread, we also don't need to send in a thread-alloc for blitCoverageDeltas Bug: skia: Change-Id: Ie4ee0886b88c797ab57c65674b0b7527501b164f Reviewed-on: https://skia-review.googlesource.com/120641 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Snap the bitmap as it may be changed laterGravatar Yuqian Li2018-04-16
| | | | | | | | Bug: skia: Change-Id: If06510f6fd3b64cce3440a543973c9c83913da10 Reviewed-on: https://skia-review.googlesource.com/120141 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* SkPDF: use std::aligned_storage for typed unionGravatar Hal Canary2018-04-16
| | | | | | | Change-Id: I38e063cf7557aab1cffbaa126aea4dc7142d914c Reviewed-on: https://skia-review.googlesource.com/121583 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Some Chromium bots have been LUCIfiedGravatar Ravi Mistry2018-04-16
| | | | | | | | | NoTry: true Bug: skia: Change-Id: I8a289178ca2d23200efbaf93181fa0b6d2af2058 Reviewed-on: https://skia-review.googlesource.com/121587 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Roll third_party/externals/angle2/ 76b2c3852..a4fa9c278 (3 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/76b2c3852995..a4fa9c2782da $ git log 76b2c3852..a4fa9c278 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 lucferron Vulkan: drawElements with GL_LINE_LOOP and an offset 2018-04-15 jmadill Vulkan: Implement cube map texture sampling. 2018-04-12 jiawei.shao Store shader information in ShaderMap in class Program and Compiler Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=scroggo@google.com Change-Id: Ia5e4d939683cb0ed4f9a421aa9d5c832441afffb Reviewed-on: https://skia-review.googlesource.com/121555 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Don't allow ganesh to allocate mip maps for wrapped textures.Gravatar Greg Daniel2018-04-16
| | | | | | | | | | | | | | We will not allocate new mips on a wrapped texture but we will use mips if the wrapped texture already has one. If we need mips for a draw this will trigger a copy to occur. Also some cleanup up of our InternalSurfaceFlags in general. Bug: skia:7806 Change-Id: I7aa666478cc91bba6e0644b323825fcc9b49793a Reviewed-on: https://skia-review.googlesource.com/121348 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Draw stroked circles with round caps analytically.Gravatar Brian Salomon2018-04-16
| | | | | | | | | | These draw as the butt cap version where the stroked circle is clipped by half planes. But then we add in coverage from circles at the caps. Bug: skia:7793 Change-Id: I7c27a2a5f1f9c1645cc9042e68e787dd81ea28b8 Reviewed-on: https://skia-review.googlesource.com/120140 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* Reland "Cumulate deltas even if they're out of the clip"Gravatar Yuqian Li2018-04-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ffbe93296838c3a93a87261cae7f7229b56f1f8a. Reason for revert: guard flag is now in Original change's description: > Revert "Cumulate deltas even if they're out of the clip" > > This reverts commit 520e578b9987ea99b8ee62b485e941b3d5d96e0f. > > Reason for revert: guard flag isn't in yet > > Original change's description: > > Cumulate deltas even if they're out of the clip > > > > Otherwise, GM complexclip_aa_inverse will be drawn incorrectly > > in t8888 mode. > > > > Bug: skia: > > Change-Id: I2fe9dd94f3219e3883f713ca95ea3c3d8a49c7ba > > Reviewed-on: https://skia-review.googlesource.com/121261 > > Reviewed-by: Cary Clark <caryclark@google.com> > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > TBR=caryclark@google.com,liyuqian@google.com,reed@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: skia: > Change-Id: If7fa2a8bd1ff3e9b55c3900cbba82a3e2562f502 > Reviewed-on: https://skia-review.googlesource.com/121424 > Reviewed-by: Yuqian Li <liyuqian@google.com> > Commit-Queue: Yuqian Li <liyuqian@google.com> TBR=caryclark@google.com,liyuqian@google.com,reed@google.com Change-Id: I4ec1fec53782a106407d1398c43cab748fd5f259 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/121600 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* document SkColor.hGravatar Cary Clark2018-04-16
| | | | | | | | | | | | | | | | | | | | | | SkColor.h uses #define liberally, and has many global symbols, two things bookmaker hasn't seen in other includes. Revised .h -> .bmh converter to work with SkColor.h as well as updating how .bmh indices are built. Generated SkColor_Reference.bmh for globals, and SkColor4f_Reference.bmh for class. Other than the existing comments, this doesn't update the documentation or add new examples. Docs-Preview: https://skia.org/?cl=118985 TBR=caryclark@google.com Bug: skia:6898 Change-Id: I5978257ee0e51319823efbe8dfc467a08c99ffe0 Reviewed-on: https://skia-review.googlesource.com/118985 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Revert "Cumulate deltas even if they're out of the clip"Gravatar Yuqian Li2018-04-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 520e578b9987ea99b8ee62b485e941b3d5d96e0f. Reason for revert: guard flag isn't in yet Original change's description: > Cumulate deltas even if they're out of the clip > > Otherwise, GM complexclip_aa_inverse will be drawn incorrectly > in t8888 mode. > > Bug: skia: > Change-Id: I2fe9dd94f3219e3883f713ca95ea3c3d8a49c7ba > Reviewed-on: https://skia-review.googlesource.com/121261 > Reviewed-by: Cary Clark <caryclark@google.com> > Commit-Queue: Yuqian Li <liyuqian@google.com> TBR=caryclark@google.com,liyuqian@google.com,reed@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia: Change-Id: If7fa2a8bd1ff3e9b55c3900cbba82a3e2562f502 Reviewed-on: https://skia-review.googlesource.com/121424 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* ccpr: Normalize the cubic inflection function instead of its rootsGravatar Chris Dalton2018-04-16
| | | | | | | | | | | | When solving for KLM, switches back to normalizing the cubic's inflection function rather than both individual roots. Also performs some general code clean up for SkClassifyCubic. Bug: skia: Change-Id: Id513e7e02c50a8709f3eccf92fad9e5134d73d83 Reviewed-on: https://skia-review.googlesource.com/121201 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Remove all notion of transport from the API - V2.Gravatar Herb Derby2018-04-16
| | | | | | | | | | | | There is only a need to pass buffers in and out of the system. All transport is external to the system. BUG=skia:7515 Change-Id: Ie50cbc3fa1b9776e56dab8e49e91ce640e0b3954 Reviewed-on: https://skia-review.googlesource.com/119893 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Unblacklist fixed tests on DDL3 botsGravatar Robert Phillips2018-04-16
| | | | | | | | | Bug: skia:7787 Bug: skia:7751 Change-Id: I87b34431eb46c3429a036eb4f8950e5b2b29a2c8 Reviewed-on: https://skia-review.googlesource.com/121483 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* skcms→019d877 add a basic profiling mode to src/Transform.cGravatar Mike Klein2018-04-16
| | | | | | | Change-Id: I136064f8b772f1aa5ecfedac4b0f9ebb92da9d73 Reviewed-on: https://skia-review.googlesource.com/121486 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Make TestCase class in GrShapeTest heap allocate its GrShapesGravatar Brian Salomon2018-04-16
| | | | | | | | | Uses less stack space in test functions. Change-Id: I50a66cc27d95c2b4e2292184b928f7bbd71789f0 Reviewed-on: https://skia-review.googlesource.com/121482 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Revert "[infra] Run recipes through Kitchen"Gravatar Eric Boren2018-04-16
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7bbb26fee0dcd7c53c1f5b80f62966654dd823ba. Reason for revert: uploads broke task scheduler Original change's description: > [infra] Run recipes through Kitchen > > Bug: skia:7050 > Change-Id: I50632444eb4ca7f9ae2b1b30b766e531092ccad4 > Reviewed-on: https://skia-review.googlesource.com/82500 > Commit-Queue: Eric Boren <borenet@google.com> > Reviewed-by: Ravi Mistry <rmistry@google.com> TBR=borenet@google.com,rmistry@google.com Change-Id: Ic3a5404fde844f01eca551d50039a84a20e84e11 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7050 Reviewed-on: https://skia-review.googlesource.com/121423 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* [infra] Run recipes through KitchenGravatar Eric Boren2018-04-16
| | | | | | | | Bug: skia:7050 Change-Id: I50632444eb4ca7f9ae2b1b30b766e531092ccad4 Reviewed-on: https://skia-review.googlesource.com/82500 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Roll third_party/externals/angle2/ 152152618..76b2c3852 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/152152618edf..76b2c3852995 $ git log 152152618..76b2c3852 --date=short --no-merges --format='%ad %ae %s' 2018-03-19 oetuaho Store invariant declarations in variable metadata Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=scroggo@google.com Change-Id: I178da34faf71bd10d398c6b89d0e93564d1d772e Reviewed-on: https://skia-review.googlesource.com/121542 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Increase android compile timeoutGravatar Ravi Mistry2018-04-16
| | | | | | | | Bug: skia: Change-Id: I6798da94442945304a9f60aac6e8f0d68c6267b5 Reviewed-on: https://skia-review.googlesource.com/121462 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* show flatness vectors in sampleGravatar Mike Reed2018-04-16
| | | | | | | | Bug: skia: Change-Id: I5a3882c993138dc5e1da92a7a4b1a9f96c740d1c Reviewed-on: https://skia-review.googlesource.com/121461 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Update SKP versionGravatar UpdateSKPs2018-04-15
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I2ad59409c8f37197e8ca42026b9082ed75e1caed Reviewed-on: https://skia-review.googlesource.com/121520 Commit-Queue: update-skps <update-skps@skia.org> Reviewed-by: update-skps <update-skps@skia.org>
* Revert "Delete getRenderTargetHandle call on SkSurface."Gravatar Greg Daniel2018-04-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c828109ebd1519134b1c3fa168519ac07a31fe05. Reason for revert: Need to fix flutter Original change's description: > Delete getRenderTargetHandle call on SkSurface. > > All clients and internal code should be switched (once changes land soon) > to the new getBackendRenderTarget call instead. > > Bug: skia: > Change-Id: I6f490b6d26a72f37f97216be04e541483206510d > Reviewed-on: https://skia-review.googlesource.com/121103 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia: Change-Id: I571298f839757fcdedcd8117519e740ac7ef1344 Reviewed-on: https://skia-review.googlesource.com/121480 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Cumulate deltas even if they're out of the clipGravatar Yuqian Li2018-04-14
| | | | | | | | | | | Otherwise, GM complexclip_aa_inverse will be drawn incorrectly in t8888 mode. Bug: skia: Change-Id: I2fe9dd94f3219e3883f713ca95ea3c3d8a49c7ba Reviewed-on: https://skia-review.googlesource.com/121261 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Reland "Whitespace change"Gravatar Ravi Mistry2018-04-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0806b7ce3b594aef2b28bed8230a7923ed93415a. Reason for revert: Testing yet again Original change's description: > Revert "Whitespace change" > > This reverts commit 470d82973182d0c4e30568c20af9d96dcfd63485. > > Reason for revert: Testing again > > Original change's description: > > Whitespace change > > > > NoTry: true > > Bug: skia: > > Change-Id: I6dc0ba66aca94f7f99cb851dda6503c0cb9c302b > > Reviewed-on: https://skia-review.googlesource.com/114407 > > Reviewed-by: Ben Wagner <benjaminwagner@google.com> > > Commit-Queue: Ravi Mistry <rmistry@google.com> > > TBR=benjaminwagner@google.com,rmistry@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: skia: > Change-Id: I98498e483808694a74c60cc921727108cf1429c5 > NoTry: true > Reviewed-on: https://skia-review.googlesource.com/117660 > Reviewed-by: Ravi Mistry <rmistry@google.com> > Commit-Queue: Ravi Mistry <rmistry@google.com> TBR=benjaminwagner@google.com,rmistry@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia: Change-Id: Ib2de5475abe988901377730991b34921f0aab164 Reviewed-on: https://skia-review.googlesource.com/121422 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Roll third_party/externals/angle2/ 983c429fa..152152618 (7 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/983c429fa3bf..152152618edf $ git log 983c429fa..152152618 --date=short --no-merges --format='%ad %ae %s' 2018-04-11 courtneygo Enable unneeded-internal-declaration compiler warning 2018-04-13 thakis Add standalone angle bots to default cq set, remove upstream win-msvc-rel bot. 2018-04-13 jmadill Add "root" variable to DEPS. 2018-04-13 jmadill Move client attribs mask to front-end. 2018-04-13 cwallez Fix infra.cq to point to new Windows configs. 2018-04-13 ynovikov Suppress self-assign warning in angle_deqp_decpp and angle_deqp_libtester 2018-04-12 lucferron Vulkan: DrawElements with line loops client side memory support Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=borenet@google.com Change-Id: I46497417f384488da41cfd7e3eb6b96356856f59 Reviewed-on: https://skia-review.googlesource.com/121375 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* fix sksl standalone build errorGravatar Ethan Nicholas2018-04-13
| | | | | | | | Bug: skia: Change-Id: I7de6d46a5774b5820bb6468a418be7c56da8510b Reviewed-on: https://skia-review.googlesource.com/121421 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Blacklist check_small_sigma_offset on ChromecastGravatar Eric Boren2018-04-13
| | | | | | | | Bug: skia:6687 Change-Id: I4244b6345da5edd1ac6fe2225ed8c109a6e66a66 Reviewed-on: https://skia-review.googlesource.com/121347 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* remove unused virtual onNotifyPixelsChangedGravatar Mike Reed2018-04-13
| | | | | | | | Bug: skia: Change-Id: I993701a1059d7d309991b06147bd0cc4a1a4fe93 Reviewed-on: https://skia-review.googlesource.com/121350 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* rewrite iterator to make msvc happyGravatar Mike Reed2018-04-13
| | | | | | | | | | | | Revert "Revert "add test for degenerate canvas dimension"" This reverts commit 1749af20a11d0f364dbb7cad8dc89101f956c923. Bug: skia: Change-Id: I382cbef397dfba600a6779b159764239399b177f Reviewed-on: https://skia-review.googlesource.com/121344 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Support downscaling to max texture size when making cross-context imagesGravatar Brian Osman2018-04-13
| | | | | | | | | This is one solution to https://github.com/flutter/flutter/issues/16454 Change-Id: Iacd59f07e1bf87b6caccb64df16ab8827dfc78b1 Reviewed-on: https://skia-review.googlesource.com/121342 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Add a MSVS bot to the CQGravatar Eric Boren2018-04-13
| | | | | | | | Bug: skia: Change-Id: I625b46e197ce1bef47aa73f7e7e419cec2450735 Reviewed-on: https://skia-review.googlesource.com/121364 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Clone the xpos array in drawPosTextGravatar Yuqian Li2018-04-13
| | | | | | | | | | | | | It was a mistake to miss it... This fixes GM bigtext and almost every GM that uses drawPosText in the t8888 mode. Bug: skia: Change-Id: I32d6cc1fd1cde5c8b7caaad9eb3ba6a1706c22a6 Reviewed-on: https://skia-review.googlesource.com/121328 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* added sk_LastFragColorGravatar Ethan Nicholas2018-04-13
| | | | | | | | Bug: skia: Change-Id: If64d8281beb8b7687db629eef2e956974ee9a979 Reviewed-on: https://skia-review.googlesource.com/121343 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Revert "add test for degenerate canvas dimension"Gravatar Mike Reed2018-04-13
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 715b919e37aa662131ca70b0056bc8192d4bcee9. Reason for revert: compile break on win Original change's description: > add test for degenerate canvas dimension > > Bug: skia: > Change-Id: Ib0532e706fbcdb126619301591ddc64910babdef > Reviewed-on: https://skia-review.googlesource.com/121341 > Reviewed-by: Yuqian Li <liyuqian@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=liyuqian@google.com,reed@google.com Change-Id: I09dcba20d923d04ca1dc3fd0e62e8f42e4d4cdfd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/121380 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* add test for degenerate canvas dimensionGravatar Mike Reed2018-04-13
| | | | | | | | Bug: skia: Change-Id: Ib0532e706fbcdb126619301591ddc64910babdef Reviewed-on: https://skia-review.googlesource.com/121341 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Don't try to readback from the GPU for small blur sigmasGravatar Robert Phillips2018-04-13
| | | | | | | | | | | | | This should revert Ganesh's small sigma handling behavior to back before: https://skia-review.googlesource.com/c/skia/+/52400 (Reorganize blur filter to insert new implementation) BUG=skia:7787 BUG=skia:7751 BUG=832838 Change-Id: I0ce6b888be534afb60336abf561e97741fa34684 Reviewed-on: https://skia-review.googlesource.com/121331 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Make a GM for checking blur bounds.Gravatar Herb Derby2018-04-13
| | | | | | | | Change-Id: I30e7ac2ad37f666e3fafe94a3f52a764e1e2e652 Reviewed-on: https://skia-review.googlesource.com/88040 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Roll third_party/externals/angle2/ cc1293775..983c429fa (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/cc129377530b..983c429fa3bf $ git log cc1293775..983c429fa --date=short --no-merges --format='%ad %ae %s' 2018-04-10 lucferron Vulkan: Lineloops edge base bugfix and new tests Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=borenet@google.com Change-Id: I913a16f80bad1c6b9f68b6461d06c690e848a0d0 Reviewed-on: https://skia-review.googlesource.com/121307 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* [skottie] Harden json string parsingGravatar Florin Malita2018-04-13
| | | | | | | | TBR= Change-Id: I538d1a86c1adc4a00deffc254c8bfde8d5d6794b Reviewed-on: https://skia-review.googlesource.com/121324 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* path is rect bug number nineGravatar Cary Clark2018-04-13
| | | | | | | | | | | | | | | This variation exploits a sequence which uses a zero length line to note that lines have been recorded, but no rectangle edge has been encountered. R=robertphillips@google.com Docs-Preview: https://skia.org/?cl=121282 Bug: 824145,skia:7792 Change-Id: I652e9482b2867c3d7da30d5f5df2aecbfd0d716d Reviewed-on: https://skia-review.googlesource.com/121282 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>
* Update Skia milestone to 68Gravatar Heather Miller2018-04-13
| | | | | | | | | | TBR=reed Bug: skia: Change-Id: I17ff9424c674efbc782bf1b40477467c678cddd9 Reviewed-on: https://skia-review.googlesource.com/121321 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
* Roll third_party/externals/angle2/ ed8d5ec73..cc1293775 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/ed8d5ec73330..cc129377530b $ git log ed8d5ec73..cc1293775 --date=short --no-merges --format='%ad %ae %s' 2018-04-12 jmadill ImageIndex: Consolidate layer/cube face. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=borenet@google.com Change-Id: I69ced425b724725e6821a25eab7e57afe5dc3237 Reviewed-on: https://skia-review.googlesource.com/121302 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Limit our IsBadForDAA for stroke width > 0 and <= 2Gravatar Yuqian Li2018-04-13
| | | | | | | | | | | Now, according to our gold, we probably are overkilling the DAA. That could be bad for performance. Bug: skia:6886 chromium:821353 Change-Id: I92bb4cbedb106f7fbd7e01e8107773d413e2da52 Reviewed-on: https://skia-review.googlesource.com/121260 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* ccpr: Actually blacklist ANGLEGravatar Chris Dalton2018-04-12
| | | | | | | | | | | | It helps to assign it true instead of false... TBR=bsalomon@google.com Bug: skia: Change-Id: I535333d12a79a3fbc82d68e05cf4c2541fa39fa0 Reviewed-on: https://skia-review.googlesource.com/121247 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Roll third_party/externals/angle2/ 14f4817c4..ed8d5ec73 (8 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/14f4817c4dad..ed8d5ec73330 $ git log 14f4817c4..ed8d5ec73 --date=short --no-merges --format='%ad %ae %s' 2018-03-20 courtneygo Add json build file generation 2018-04-09 lfy GLES1: Built-in matrix operations 2018-04-06 cwallez TextureD3D_2D::CopyImage clear using initializeContents 2018-04-12 lucferron Vulkan: Suppress flaky test in GLSLTest on Windows 2018-04-10 brandon1.jones Autogenerate ANGLE extension entry points 2018-04-11 lucferron Vulkan: drawArrays followed by drawElements bugfix 2018-04-11 jmadill VertexArray: Use switch macro for faster iteration. 2018-04-09 lucferron Vulkan: Enable GLSLTest tests for Vulkan Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=borenet@google.com Change-Id: I50385beb88d338652586cc35da03911d5bf4f5d2 Reviewed-on: https://skia-review.googlesource.com/121245 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* can't abort looper loop, as saveCount won't be balancedGravatar Mike Reed2018-04-12
| | | | | | | | | | | | | | This is triggered by a recent change to clear the looper from the paint we return. That change made the call to nothingToDraw() return true, which in turn meant we didn't get the balancing call to restore in the looper's next() call. Follow-up to https://skia-review.googlesource.com/c/skia/+/121062 Bug: skia: Change-Id: I3ba7d487e4193103fb1d223d34c9c6eb486eca09 Reviewed-on: https://skia-review.googlesource.com/121220 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Don't create lazy proxys if their width/height is greater than max tex sizeGravatar Greg Daniel2018-04-12
| | | | | | | | | Bug: skia: Change-Id: I53508c4e3bbd4c315be4b29a66716e0c5e7f25bf Reviewed-on: https://skia-review.googlesource.com/121161 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-19 02:38:16 +0000