aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Add DDL SkpOnly botGravatar Robert Phillips2018-03-15
| | | | | | | Change-Id: If9402ad5a3ae7d17221cf1bca621b8aad4d9e9d0 Reviewed-on: https://skia-review.googlesource.com/114466 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* update_meta_config: Use new LUCI optional GPU trybotGravatar Eric Boren2018-03-15
| | | | | | | | Bug: skia: Change-Id: I1eca549d38b64869a763951b8469712d620e24bf Reviewed-on: https://skia-review.googlesource.com/114516 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* drawTextRSXform should not apply matrix to shaderGravatar Mike Reed2018-03-15
| | | | | | | | | | | drawTextRSXform should draw the same as drawTextOnPath (as regards shaders) Bug: b/69904791 Change-Id: I393dd8fd7a5bdc6a018b1ca33592b208c7141868 Reviewed-on: https://skia-review.googlesource.com/114468 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Delete unused VkClearTestGravatar Greg Daniel2018-03-15
| | | | | | | | Bug: skia: Change-Id: I4aa1886e7f4048fc13a741ddbc37b9ca3f48a41d Reviewed-on: https://skia-review.googlesource.com/114510 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* GrGLES: unify MakeNativeInterface_{android,egl}Gravatar Hal Canary2018-03-15
| | | | | | | | BUG=skia:3508 Change-Id: Ibc98ea3e579cb545635c28d345cae24f57d0c2a3 Reviewed-on: https://skia-review.googlesource.com/114471 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* fix pathops fuzzers and debuggingGravatar Cary Clark2018-03-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | En route to fixing fuzzer bugs, I discovered that most debugging in pathops was broken. Pathops has extensive runtime functions that trace links and connections between data structures that are invaluable to debugging. The only practical way to use these functions is to call them from the debugger in immediate mode. Some time, some where, the MSVS Immediate Window ceased to be able to call functions that are members of structs or classes, and functions that take templated parameters. I can find no mention of this on the web, so I assume that something about our setup is triggering this, but I've had no luck finding the culprit. In the meantime, I've added global functions wrapped in a namespace to sneak calls to these functions without MSVS being any the wiser. While this works, it is likely to bitrot by tomorrow or next Tuesday so I will continue to try to find and fix the root cause. This also fixes the fuzzer bugs; generally one-line edits that change asserts to fails. All pathops tests succeed with this. To run all tests, do: ./out/debug/pathops_unittest -V -x ./out/release/pathops_unittest -V -x TBR=caryclark@google.com Bug: skia: Change-Id: I956ae3d8df6d25e155e62bd6dede64519c7fbdb1 Reviewed-on: https://skia-review.googlesource.com/114321 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* SkAutoGlyphCache change some sites to Find*.Gravatar Herb Derby2018-03-15
| | | | | | | Change-Id: Iec3a0c60106017394fcdd981052713b6e42fa595 Reviewed-on: https://skia-review.googlesource.com/114506 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Make CreateBackendFormatFromTexture shared codeGravatar Robert Phillips2018-03-15
| | | | | | | | | TBR=bsalomon@google.com Change-Id: I19e6e6c8dc32ba584738545d443de092e4987a5a Reviewed-on: https://skia-review.googlesource.com/114374 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Fix initialLayout update in Vk createTestingOnlyImageGravatar Greg Daniel2018-03-15
| | | | | | | | Bug: skia: Change-Id: I5d4321e68c065e3775266994c65a4abf18360731 Reviewed-on: https://skia-review.googlesource.com/114497 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Check GL_EXT_texture_format_BGRA8888 before GL_APPLE_texture_format_BGRA8888Gravatar Alexis Hetu2018-03-15
| | | | | | | | | | | | | | | | When both GL_EXT_texture_format_BGRA8888 and GL_APPLE_texture_format_BGRA8888 extensions are present, the presence of GL_APPLE_texture_format_BGRA8888 was preventing GL_EXT_texture_format_BGRA8888 from allowing BGRA8888 to be used as a render target. By checking for GL_EXT_texture_format_BGRA8888 first, this solves the issue. The issue was encountered trying to run vr_pixeltests on top of SwiftShader on the bots with a version of SwiftShader exposing both extension strings. Change-Id: I446ec502a4703d24c24339708dcbbe9c334a7533 Reviewed-on: https://skia-review.googlesource.com/114495 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Alexis Hetu <sugoi@google.com>
* protect PathMeasure against input paths with NaNsGravatar Cary Clark2018-03-15
| | | | | | | | | | | found by fuzzer R=kjlubick@google.com Bug: skia: Change-Id: Ifde8706a7ca6fad785a1b0b50f3df3fb099c0e36 Reviewed-on: https://skia-review.googlesource.com/114477 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>
* Remove SK_RASTER_RECORDER_IMPLEMENTATIONGravatar Robert Phillips2018-03-15
| | | | | | | | | TBR=bsalomon@google.com Change-Id: I9608ce5ce2b9d38c5e356d8428a8ff05df6ccda7 Reviewed-on: https://skia-review.googlesource.com/114490 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Revert "ccpr: Unblacklist vulkan"Gravatar Greg Daniel2018-03-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 30ce2a3620ffe428762de08be50f3a62462524a2. Reason for revert: Crashing drivers on intel and powerVR. Possible SPIR-V error Original change's description: > ccpr: Unblacklist vulkan > > All issues have been resolved. > > Bug: skia: > Change-Id: Id63d63ad081725885cb0225b410b0d3972abd8f7 > Reviewed-on: https://skia-review.googlesource.com/113060 > Commit-Queue: Chris Dalton <csmartdalton@google.com> > Reviewed-by: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,csmartdalton@google.com Change-Id: Ibb9ea75cc0fbe2db0ff11a8b22bac8f47242f775 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/114540 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Make sure we set correct GrPixelConfig in promise imagesGravatar Greg Daniel2018-03-15
| | | | | | | | | | Land just the Promise image fixes from, https://skia-review.googlesource.com/c/skia/+/114261 Bug: skia: Change-Id: I917cf2c1f5c6e51f9d7f1d3ec4526db551e89d84 Reviewed-on: https://skia-review.googlesource.com/114472 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Prepare ddl skp rendering for prime timeGravatar Robert Phillips2018-03-15
| | | | | | | Change-Id: I87742b8ef043588c4e835ab6ec49b217dd49f829 Reviewed-on: https://skia-review.googlesource.com/114289 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/externals/angle2/ 5eaddbd01..0b0dcbc1c (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/5eaddbd018ea..0b0dcbc1cffa $ git log 5eaddbd01..0b0dcbc1c --date=short --no-merges --format='%ad %ae %s' 2018-03-14 oetuaho Prune empty cases and switch statements Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=stephana@google.com Change-Id: I4577adae4389eb5f8e248c5cbb46d226434e84f2 Reviewed-on: https://skia-review.googlesource.com/114487 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* ccpr: Unblacklist vulkanGravatar Chris Dalton2018-03-15
| | | | | | | | | | All issues have been resolved. Bug: skia: Change-Id: Id63d63ad081725885cb0225b410b0d3972abd8f7 Reviewed-on: https://skia-review.googlesource.com/113060 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Roll skia/third_party/externals/angle2/ 87db7c524..5eaddbd01 (9 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/87db7c524e70..5eaddbd018ea $ git log 87db7c524..5eaddbd01 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 jmadill Vulkan: Flag uniforms as dirty when they are updated. 2018-03-14 lucferron Vulkan: Support of float uniform matrixes (2,3,4). 2018-03-14 geofflang Add an EGL extension to disable GL extensions by default. 2018-03-14 jmadill VertexArray: Add perf tests for VAO dirty bits. 2018-03-14 jiawei.shao ES31: Support program parameter queries on geometry shader 2018-03-13 lucferron Vulkan: Get/SetUniform for float / int and vec* 2018-03-14 cwallez cq.cfg: equivalent_to to 100% for Linux tryservers. 2018-03-13 cwallez Fix cubemap robust resource init for GenerateMipmap 2018-03-14 jmadill Move DrawCallParams to the gl front-end. Created with: roll-dep skia/third_party/externals/angle2 BUG=815092 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=stephana@google.com Change-Id: Iaa1f591c7efbc29332e1ef5075e52c8f06aed6a1 Reviewed-on: https://skia-review.googlesource.com/114520 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Add a png.imp for include-what-you-use.Gravatar Ben Wagner2018-03-14
| | | | | | | | | | | | | The png.h header provides some macros and declarations from subincludes. By default include-what-you-use will suggest using these subincludes directly, but this was not the intent of png.h. This adds a mapping file so that include-what-you-use knows that these subincludes are actually private and png.h should be used instead. Change-Id: Ibf9df6dbdbde0e657f6e548ed0e8f2310f44cfea Reviewed-on: https://skia-review.googlesource.com/114481 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* remove SK_SUPPORT_LEGACY_BLURMASKFILTER from androidGravatar Mike Reed2018-03-14
| | | | | | | | Bug: skia: Change-Id: I8c29fe8ae7907a8309d90ef4474de8c4c75fc760 Reviewed-on: https://skia-review.googlesource.com/114478 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* GrGLES: clean up android_get_gl_procGravatar Hal Canary2018-03-14
| | | | | | | Change-Id: Ia65b582d17c80e27574042c02363ec75bafcb0db Reviewed-on: https://skia-review.googlesource.com/114440 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Some iwyu for tests which will otherwise break.Gravatar Ben Wagner2018-03-14
| | | | | | | | | | | A change currently in progress would break these test files since they aren't including what they use. Make them include what they use so they don't break in the future. Change-Id: I25d8d57631706dec0d0197b3759c6c18a0fe3aa0 Reviewed-on: https://skia-review.googlesource.com/114465 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Only include png.h for png.Gravatar Ben Wagner2018-03-14
| | | | | | | | | | | The png.h include provides macros and declarations though several subincludes. We will need a mapping for include what you use to mark this. Change-Id: Ie5e1c9ac7325d2fa12cf61986da8a4bb18557d42 Reviewed-on: https://skia-review.googlesource.com/114474 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Disable vulkan tests to fix botsGravatar Stephan Altmueller2018-03-14
| | | | | | | | Bug: skia:7322 Change-Id: I8a26353134aee2c0972a3cb579040eb1c5c6dacd Reviewed-on: https://skia-review.googlesource.com/114281 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* Add SkColorType getter on SkImage.Gravatar Greg Daniel2018-03-14
| | | | | | | | | | Bug: skia: Change-Id: I131fb5f7faf3f54e0eb6d31b800d224e6d4963ce Reviewed-on: https://skia-review.googlesource.com/114464 Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Reland "Add back missing unique key checks when creating CachedBitmap/Image ↵Gravatar Greg Daniel2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Proxies" This reverts commit 4f57eb8002a0488cfbf08717b25af93fae37a39a. Reason for revert: Doesn't look to be cause of chrome roll failures Original change's description: > Revert "Add back missing unique key checks when creating CachedBitmap/Image Proxies" > > This reverts commit b78dd5d01eb16ae3cb9104ce8c0fa7e861431259. > > Reason for revert: possibly breaking chrome roll > > Original change's description: > > Add back missing unique key checks when creating CachedBitmap/Image Proxies > > > > Its possible that this could fix perf regression in Chrome. > > > > Bug: 811452 > > Change-Id: I2d4f7827092b361469586580f0c7c843ab2d5cec > > Reviewed-on: https://skia-review.googlesource.com/114280 > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com > > Change-Id: I71646befd07bf28442ac3b9225c021cd141bf398 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 811452 > Reviewed-on: https://skia-review.googlesource.com/114422 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: I957d66123bce150387a1ce6a80bcfc06c82d5fa1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811452 Reviewed-on: https://skia-review.googlesource.com/114426 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Add glyph cache warming - prototypeGravatar Herb Derby2018-03-14
| | | | | | | | | | | | | | | | | A system for prewarming the cache using a single "RPC" This improve performance by ~5X. This is a checkin of rough code so I can use small changes clean it up. BUG=skia:7515 Change-Id: Id0192b4f533c257b0a7eea0170b1e25c336d6432 Reviewed-on: https://skia-review.googlesource.com/105440 Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Scale the GPU when running perf on Pixel(2)"Gravatar Ravi Mistry2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit aa504cddb9196a3f5e798a280061ba6eb3c22901. Reason for revert: Kevin asked me to revert since this broke things Original change's description: > Scale the GPU when running perf on Pixel(2) > > This is a similar followup to: > https://skia-review.googlesource.com/c/skia/+/93561 > > Bug: skia: > Change-Id: I9b11dbf3d063fd64b1dd712cf1c596618f2c9ffc > Reviewed-on: https://skia-review.googlesource.com/114340 > Reviewed-by: Eric Boren <borenet@google.com> > Commit-Queue: Kevin Lubick <kjlubick@google.com> TBR=borenet@google.com,kjlubick@google.com Change-Id: Idbc7234f2b7ff8c5e632680903836e1f4eaa50d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/114425 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* fixed SkSL SPIR-V vector comparisonsGravatar Ethan Nicholas2018-03-14
| | | | | | | | Bug: skia: Change-Id: I57788fe427f62e20c6e073fd96279910febef22e Reviewed-on: https://skia-review.googlesource.com/114367 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Add accessor and less for raw glyph ID and WSGravatar Herb Derby2018-03-14
| | | | | | | | | | Accessor is for debugging and Android. Less is for ordered containers. Change-Id: Ic4b7e0e9e32506f8594db961c274f93c5b5d1cee Reviewed-on: https://skia-review.googlesource.com/114369 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Add incompleteShortIntPrecision to SkSL StandaloneShaderCapsGravatar Chris Dalton2018-03-14
| | | | | | | | | | TBR=ethannicholas@google.com Bug: skia: Change-Id: If3b86e414d74072dd3e38a5507bbcbcecc3946f6 Reviewed-on: https://skia-review.googlesource.com/114378 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Scale the GPU when running perf on Pixel(2)Gravatar Kevin Lubick2018-03-14
| | | | | | | | | | | This is a similar followup to: https://skia-review.googlesource.com/c/skia/+/93561 Bug: skia: Change-Id: I9b11dbf3d063fd64b1dd712cf1c596618f2c9ffc Reviewed-on: https://skia-review.googlesource.com/114340 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Revert "Update clang_win to yesterday's build (from Chromium)."Gravatar Ben Wagner2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit cefa808f3f237434139ce5fbbbbaf34cbc90e368. Reason for revert: Flaky failure: LINK : fatal error LNK1104: cannot open file 'c:\b\s\w\ir\clang_win\lib\clang\6.0.0\lib\windows\clang_rt.ubsan_standalone-x86_64.lib' Original change's description: > Update clang_win to yesterday's build (from Chromium). > > Change-Id: Iea0f841f7c9a3449213c549ba310ab2a3d928ca2 > Reviewed-on: https://skia-review.googlesource.com/114093 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Mike Klein <mtklein@chromium.org> TBR=mtklein@chromium.org,mtklein@google.com,benjaminwagner@google.com Change-Id: I1e738d48f75fbd5878658bc79f3d340dd5acfe0a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/114424 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Revert "Improve handling of GrPixelConfig in GrBackendTex/RT ctors"Gravatar Greg Daniel2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7d2b16ad13fd3262c776ae75ae35da4ad69df690. Reason for revert: Maybe breaking chrome? Original change's description: > Improve handling of GrPixelConfig in GrBackendTex/RT ctors > > Make sure that no client facing code was relying on what we set as the > default value for fConfig by making in kUnkown. > > Bug: skia: > Change-Id: Ie52ff08ba8deeacc16fe06eb0dd0c7292b2edf91 > Reviewed-on: https://skia-review.googlesource.com/114261 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: I91e190d72407f9c4bee93a031a557f740bb49b66 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/114423 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Revert "Add Win x86 Clang Perf/Test jobs."Gravatar Ben Wagner2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 40091fd4fc453eb514bf7ca903326fa3538ab6c9. Reason for revert: Need to revert dependency https://skia-review.googlesource.com/c/skia/+/114093 Original change's description: > Add Win x86 Clang Perf/Test jobs. > > Also switch CQ Win 32-bit Build from MSVC to Clang. > > No-Try: true > Change-Id: Ic312ee611b1e99143480840c08a9266a4d8b448b > Reviewed-on: https://skia-review.googlesource.com/113672 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,benjaminwagner@google.com Change-Id: I6a13e97df461bd61eac92bbc3c498146b5322a4a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/114421 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* hide SkBlurMaskFilter and SkBlurQualityGravatar Mike Reed2018-03-14
| | | | | | | | | | SK_SUPPORT_LEGACY_BLURMASKFILTER Bug: skia: Change-Id: Ic3e27e08e6e3cd2ffc1cd13b044e197bebc96236 Reviewed-on: https://skia-review.googlesource.com/113940 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Experiment: relax 4 byte alignment for glyph imagesGravatar Herb Derby2018-03-14
| | | | | | | | | | | | | This experiment remove the need for rowbytes to be 4 byte aligned in width. This causes waste in data transfer between the Renderer and GPU process. BUG=skia:7515 Change-Id: Iad0383ee0adbacaa791bf4251325867e82fdbea1 Reviewed-on: https://skia-review.googlesource.com/114371 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Revert "Add back missing unique key checks when creating CachedBitmap/Image ↵Gravatar Greg Daniel2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Proxies" This reverts commit b78dd5d01eb16ae3cb9104ce8c0fa7e861431259. Reason for revert: possibly breaking chrome roll Original change's description: > Add back missing unique key checks when creating CachedBitmap/Image Proxies > > Its possible that this could fix perf regression in Chrome. > > Bug: 811452 > Change-Id: I2d4f7827092b361469586580f0c7c843ab2d5cec > Reviewed-on: https://skia-review.googlesource.com/114280 > Commit-Queue: Greg Daniel <egdaniel@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: I71646befd07bf28442ac3b9225c021cd141bf398 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811452 Reviewed-on: https://skia-review.googlesource.com/114422 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Revert "Switch Win Exceptions Build to Clang."Gravatar Ben Wagner2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e1cb4778c70a6bef543a8936c5521a71a037f551. Reason for revert: Need to revert dependency https://skia-review.googlesource.com/c/skia/+/114093 Original change's description: > Switch Win Exceptions Build to Clang. > > No-Try: true > Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431 > Reviewed-on: https://skia-review.googlesource.com/113673 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,benjaminwagner@google.com Change-Id: I36f4c6cdf890043d4b77b8d5347b4752f58ebd33 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/114420 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Remove Goma builds and support in gn_flavor.Gravatar Ben Wagner2018-03-14
| | | | | | | | | | | | The experiment with using Goma to speed up Windows compiles was very close to being successful, but at this point the ongoing maintenance does not seem to be worth the 50-70 seconds saved. Change-Id: Ie3900b9a681e448a3e47634efbab7695ebccad33 Reviewed-on: https://skia-review.googlesource.com/114363 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Roll skia/third_party/externals/angle2/ fccebffe6..87db7c524 (4 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/fccebffe63cf..87db7c524e70 $ git log fccebffe6..87db7c524 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 jmadill D3D11: Minor cleanup to DrawCallVertexParams. 2018-03-14 jmadill Vulkan: Implement basic depth/stencil buffers. 2018-03-14 lucferron Sort the Format_table_autogen.cpp switch case by gl format 2018-03-02 oetuaho Use function id to group functions in ParseContext Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=stephana@google.com Change-Id: I953db675111741594d0813b4bfda9490a338eb14 Reviewed-on: https://skia-review.googlesource.com/114372 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* ccpr: Add an attenuation parameter to triangle cornersGravatar Chris Dalton2018-03-14
| | | | | | | | | | | | | Adds an attenuation parameter to corners that corrects the over-coverage from linear interpolation. Adds a GM for shared corners that ensures we're doing this right. Bug: skia: Change-Id: Iff8bd40554f9fda2e7e03faa3c9fbefe65f27568 Reviewed-on: https://skia-review.googlesource.com/114272 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Add a shader cap for incomplete short int precisionGravatar Chris Dalton2018-03-14
| | | | | | | | | Bug: skia: Change-Id: Iac36eb763e687f6ecc3acbd4afced66f95596be2 Reviewed-on: https://skia-review.googlesource.com/109003 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Roll skia/third_party/externals/skcms/ 6cecdee60..2b5c77024 (1 commit)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms/+log/6cecdee60988..2b5c7702441a $ git log 6cecdee60..2b5c77024 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 brianosman ApproximateTransferFunction -> ApproximateCurves Created with: roll-dep skia/third_party/externals/skcms The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=stephana@google.com Change-Id: I9a723e3aed3662c9b6727dd11ff542fa35592a91 Reviewed-on: https://skia-review.googlesource.com/114366 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Cleanup TODO in gen_tasksGravatar Kevin Lubick2018-03-14
| | | | | | | | | | It is well after December 2017 Bug: skia: Change-Id: I3e48735dac9885606bdecab301379a1312966ff1 Reviewed-on: https://skia-review.googlesource.com/114361 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Switch Win Exceptions Build to Clang.Gravatar Ben Wagner2018-03-14
| | | | | | | | No-Try: true Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431 Reviewed-on: https://skia-review.googlesource.com/113673 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Add Win x86 Clang Perf/Test jobs.Gravatar Ben Wagner2018-03-14
| | | | | | | | | | Also switch CQ Win 32-bit Build from MSVC to Clang. No-Try: true Change-Id: Ic312ee611b1e99143480840c08a9266a4d8b448b Reviewed-on: https://skia-review.googlesource.com/113672 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Provide promise images when rendering SKPs w/ DDLGravatar Robert Phillips2018-03-14
| | | | | | | Change-Id: I8014693eefb3c7811a1fc0354ee8441c90c97328 Reviewed-on: https://skia-review.googlesource.com/113213 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Ensure that GrGpu state tracking is initialized before making a backend ↵Gravatar Brian Salomon2018-03-14
| | | | | | | | | RT/Tex in tests Change-Id: Ie5692d97678705306f514d5911bf331f784e7a40 Reviewed-on: https://skia-review.googlesource.com/114288 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* add explicit API to know if the writebuffer is using its external storageGravatar Mike Reed2018-03-14
| | | | | | | | | | To help with https://skia-review.googlesource.com/c/skia/+/114262 Bug: skia: Change-Id: I83fcccdec0dbaef28d0e557ea6fb9bd0ed59ed44 Reviewed-on: https://skia-review.googlesource.com/114284 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-26 14:59:30 +0000