aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* limit discrete path effect iterationsGravatar Cary Clark2018-03-21
| | | | | | | | | R=fmalita@google.com, reed@google.com Bug: skia:7737 Change-Id: I339548f7a39618d7559182487e8969d591953b89 Reviewed-on: https://skia-review.googlesource.com/115659 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* Add Node as a bot asset.Gravatar Joe Gregorio2018-03-21
| | | | | | | | | | | Should be used for running karma tests on skia-elements and also for running lottiecap on bots. Bug: skia: Change-Id: I5c48cb741017be4eda014faea77ab88dec2e9637 Reviewed-on: https://skia-review.googlesource.com/115622 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Joe Gregorio <jcgregorio@google.com>
* small ABI + narrow/wide code updatesGravatar Mike Klein2018-03-21
| | | | | | | | | | | | | | | | | | | | The only tangible effect this CL should have is to use __vectorcall on all Windows builds, including scalar ones. The code generation is a little better there with __vectorcall than not, so might as well. This is a baby step towards vector stages with MSVC, but a very baby step indeed. Mostly this refactors and regroups a bunch of logic to reflect my current thoughts. The BUILD.gn changes are essentially no-ops, but they simplify things and make our flags more similar to how those targets are built in Chromium. (And I cleaned up other /arch: uses so this works.) Change-Id: I73dd39d15cdc7b3d268231a707952bbbfd91496e Reviewed-on: https://skia-review.googlesource.com/115644 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Remove deprecated version of SkImage::MakeFromAdoptedTexture that does not ↵Gravatar Brian Salomon2018-03-21
| | | | | | | | | | take SkColorType Bug: skia:6718 Change-Id: Ia2762855078bcbad8faf2f538f0afc64913e5e9b Reviewed-on: https://skia-review.googlesource.com/115364 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove legacy precision boundaryGravatar Yuqian Li2018-03-21
| | | | | | | | Bug: skia:7731 Change-Id: I86a87b960541c2bc7b099ca9f609342cb0bbf563 Reviewed-on: https://skia-review.googlesource.com/115652 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* ccpr: Use a more stable formula to find quadratic coordinatesGravatar Chris Dalton2018-03-21
| | | | | | | | | | | | | | | The 3x3 inverse grew unstable on small curves with large coordinates, not to mention being inefficient. This fixes many bad pixels on the chalkboard. Also begins scaling curve gradients by the AA bloat, in order to match triangle edges more closely and visualize curve AA in the ccpr sample. Bug: skia: Change-Id: I0f7da2e7599d4d5c458b3dd307185679dc78bb50 Reviewed-on: https://skia-review.googlesource.com/115527 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* change canvas-state to just record clip boundsGravatar Mike Reed2018-03-21
| | | | | | | | | | | | This reflects the long-standing restrictions in our clients (webview) and the reality of the gpu target which just uses scissors. It also removes one of the few callers of canvas::clipRegion, which we'd like to remove. Bug: skia: Change-Id: Ie3b3c6e8752f82cddef256f753000f9da4bdbdee Reviewed-on: https://skia-review.googlesource.com/113260 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Mike Reed <reed@google.com>
* GrGLExtensions: remove unneded unique_ptrGravatar Hal Canary2018-03-21
| | | | | | | Change-Id: Ic949b186fbb4f503d2edbea7033ad242c12ad101 Reviewed-on: https://skia-review.googlesource.com/115640 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Update Android build file for SkQP to point to ndk compliant libjsoncppGravatar Derek Sollenberger2018-03-21
| | | | | | | | Bug: b/74442448 Change-Id: If5e0e349cdb13352d580e55b0af26c908cc80003 Reviewed-on: https://skia-review.googlesource.com/115605 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
* Fix version check for vulkan layersGravatar Greg Daniel2018-03-21
| | | | | | | | Bug: skia: Change-Id: I9520899c4b86d6436e3697d0cc6358c2b8641169 Reviewed-on: https://skia-review.googlesource.com/114686 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Add texture-specific flags for External & Rectangle texturesGravatar Robert Phillips2018-03-21
| | | | | | | | | | | | | | | | For DDLs, Ganesh needs to know about External & Rectangle textures prior to instantiation (or PromiseImage fulfillment). These new flags allow the client to provide this information when the lazyProxy is created. The new texture flags work analogously to the render target flags: GrSurface and GrSurfaceProxy get a new set of accessors for the new flags The new flags are set appropriately on a GrGLTexture when it is created For wrapped texture proxies the flags are just copied off of the GrSurface For lazy-proxies/promise-images the flags are computed up front and passed to the proxy The GrSurfaceProxy/GrSurface flags equivalence is verified in GrSurfaceProxy::assign Change-Id: Ia8e1998aa0a36ce4481bfd9e56be21f990e83148 Reviewed-on: https://skia-review.googlesource.com/114985 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/externals/angle2/ b2c60b1a1..8574357f1 (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/b2c60b1a1950..8574357f1798 $ git log b2c60b1a1..8574357f1 --date=short --no-merges --format='%ad %ae %s' 2018-03-19 oetuaho Share parameter arrays more between built-in functions 2018-03-15 oetuaho Remove desktop GLSL builtins from symbol lookups Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: Ib426b7e7e770c049ad679ca749b83ba5236b91d3 Reviewed-on: https://skia-review.googlesource.com/115623 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Simplify format_rowbyts calculation.Gravatar Herb Derby2018-03-21
| | | | | | | | | As per comment in change 114371. Change-Id: I9724d5df205bb1430ebd3371677cce344372decc Reviewed-on: https://skia-review.googlesource.com/115610 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Try to have glyph count go through to allow easier glyphid setsGravatar Herb Derby2018-03-21
| | | | | | | Change-Id: I402e7240629db58c4212049583d6a06bcf7dcc40 Reviewed-on: https://skia-review.googlesource.com/115606 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Remove more uses of SkAutoGlyphCache.Gravatar Herb Derby2018-03-21
| | | | | | | Change-Id: I438bfb1a43857aa9e7e29b19e53dd921ec6eab1a Reviewed-on: https://skia-review.googlesource.com/115604 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Herb Derby <herb@google.com>
* handle extreme dashesGravatar Cary Clark2018-03-21
| | | | | | | | | | | | | Make searching indices unsigned so intermediate middle doesn't overflow. Verified fix runs test in skia:7675 successfully. R=reed@google.com Bug: skia:7675 Change-Id: I76be1d3fee8875ae9eb2b18eb070ef66c8006c03 Reviewed-on: https://skia-review.googlesource.com/114798 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* Port 2 Canvas fuzzers to oss-fuzzGravatar Kevin Lubick2018-03-21
| | | | | | | | Bug: skia: Change-Id: I0d34bfff4a53f831986614844bdc955935f28501 Reviewed-on: https://skia-review.googlesource.com/115582 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* fixed attributes of sk_InvocationIDGravatar Ethan Nicholas2018-03-21
| | | | | | | | Bug: skia: Change-Id: I549fdfa75f536e00f14bca445753f4c1354fa5d0 Reviewed-on: https://skia-review.googlesource.com/115361 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* fix MakeFromImage examplesGravatar Cary Clark2018-03-21
| | | | | | | | | | | deprecated flavor, erroneously used, have been removed Docs-Preview: https://skia.org/?cl=115581 Bug: skia:6898 Change-Id: Idc47411831985d4504ce1b230cb02731ec8a2edb Reviewed-on: https://skia-review.googlesource.com/115581 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Move DDL TSAN bot to Release & add Release DDL ASAN botGravatar Robert Phillips2018-03-21
| | | | | | | Change-Id: Icbbbe7275cf9bc62cbc175d4453affa12ded495a Reviewed-on: https://skia-review.googlesource.com/115526 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/externals/angle2/ 427071ea3..b2c60b1a1 (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/427071ea307a..b2c60b1a1950 $ git log 427071ea3..b2c60b1a1 --date=short --no-merges --format='%ad %ae %s' 2018-03-20 ynovikov cq.cfg: equivalent_to to 100% for Android tryservers. 2018-03-01 ynovikov Rename vulkan_loader to libvulkan Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: I3b10736bbf6a790a3c49bb9872b2a86a03ec5b0f Reviewed-on: https://skia-review.googlesource.com/115541 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll skia/third_party/externals/angle2/ b391ec408..427071ea3 (3 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/b391ec40837c..427071ea307a $ git log b391ec408..427071ea3 --date=short --no-merges --format='%ad %ae %s' 2018-03-19 jiawei.shao ES31: Add link validation on geometry shader interface block limits 2018-03-12 lfy GLES1: Revise entry points 2018-03-20 cwallez cq.cfg: equivalent_to to 100% for Mac tryservers. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: I7ed8950262abb9695fc888fda0a44dd5076f6d24 Reviewed-on: https://skia-review.googlesource.com/115530 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Switch to new NVIDIA drivers on Win2k8 Golo bots.Gravatar Ben Wagner2018-03-20
| | | | | | | | | Bug: chromium:823867 Change-Id: Ic6a738907beb573c8f66b38b6a7e56e330c08f5b No-Try: true Reviewed-on: https://skia-review.googlesource.com/115522 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Don't add change listeners to pixelRefs in DDL modeGravatar Robert Phillips2018-03-20
| | | | | | | | Change-Id: I1ddfec1e0d697dd4ed183c304514b14c89aca11d Reviewed-on: https://skia-review.googlesource.com/115400 Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* [lottiecap] Fix timestamp calculation to exactly match skottie in DM.Gravatar Joe Gregorio2018-03-20
| | | | | | | | | | Also use the much faster goToAndStop() call. Bug: skia: Change-Id: I22b8ac2b3d2fd70da4b396cb6b4ad50485a6f408 Reviewed-on: https://skia-review.googlesource.com/115324 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Joe Gregorio <jcgregorio@google.com>
* Reland "Switch Win Exceptions Build to Clang."Gravatar Ben Wagner2018-03-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2f2419b936150e24ca1aea891ba405c8ea8ebdc7. Reason for revert: Creating CL to reland Original change's description: > Revert "Switch Win Exceptions Build to Clang." > > This reverts commit e1cb4778c70a6bef543a8936c5521a71a037f551. > > Reason for revert: Need to revert dependency https://skia-review.googlesource.com/c/skia/+/114093 > > Original change's description: > > Switch Win Exceptions Build to Clang. > > > > No-Try: true > > Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431 > > Reviewed-on: https://skia-review.googlesource.com/113673 > > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > > Reviewed-by: Mike Klein <mtklein@google.com> > > TBR=mtklein@google.com,benjaminwagner@google.com > > Change-Id: I36f4c6cdf890043d4b77b8d5347b4752f58ebd33 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/114420 > Reviewed-by: Ben Wagner <benjaminwagner@google.com> > Commit-Queue: Ben Wagner <benjaminwagner@google.com> TBR=mtklein@google.com,benjaminwagner@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ie4ba6c264b3ab2b3c63ac0e225638b0a4e70cda1 Reviewed-on: https://skia-review.googlesource.com/114822 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* ccpr: Update the sample to use proper coverage count buffersGravatar Chris Dalton2018-03-20
| | | | | | | | Bug: skia: Change-Id: I6ce3ec567e671fa2ab3f05403015b48251518227 Reviewed-on: https://skia-review.googlesource.com/115072 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* fix pathop fuzzerGravatar Cary Clark2018-03-20
| | | | | | | | | | | turn assert into fail R=kjlubick@google.com Bug: skia: Change-Id: I1124573959c90c7dae1a8cd54199dae429b8ca73 Reviewed-on: https://skia-review.googlesource.com/115481 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>
* more SkImageInfo docsGravatar Cary Clark2018-03-20
| | | | | | | | | | | | | | | fix a couple of fiddles with changed output rewrite some SkSurface image makers move towards replacing SkImageInfo.h R=caryclark@google.com Docs-Preview: https://skia.org/?cl=115163 Bug: skia:6898 Change-Id: Id9895b051cd457336c30250a69cf95359d1d34d7 Reviewed-on: https://skia-review.googlesource.com/115163 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Reland "Add Win x86 Clang Perf/Test jobs."Gravatar Ben Wagner2018-03-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9aef424b71a3b200b4c8cf12a7541991622ccabf. Reason for revert: Creating CL to reland Original change's description: > Revert "Add Win x86 Clang Perf/Test jobs." > > This reverts commit 40091fd4fc453eb514bf7ca903326fa3538ab6c9. > > Reason for revert: Need to revert dependency https://skia-review.googlesource.com/c/skia/+/114093 > > Original change's description: > > Add Win x86 Clang Perf/Test jobs. > > > > Also switch CQ Win 32-bit Build from MSVC to Clang. > > > > No-Try: true > > Change-Id: Ic312ee611b1e99143480840c08a9266a4d8b448b > > Reviewed-on: https://skia-review.googlesource.com/113672 > > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > > Reviewed-by: Mike Klein <mtklein@google.com> > > TBR=mtklein@google.com,benjaminwagner@google.com > > Change-Id: I6a13e97df461bd61eac92bbc3c498146b5322a4a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/114421 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Ben Wagner <benjaminwagner@google.com> TBR=mtklein@google.com,benjaminwagner@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I15f1d9fbc8cc91d62690c59ec8d4264a6959f7a0 Reviewed-on: https://skia-review.googlesource.com/114821 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Remove deprecated SkImage::MakeFromTexture variants that don't take SkColorTypeGravatar Brian Salomon2018-03-20
| | | | | | | | | Bug: skia:6718 Change-Id: I3b23ddb903fab5c41b7e6b1811a78cc38ba64590 Reviewed-on: https://skia-review.googlesource.com/115086 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* tests: pass if !skia_enable_pdfGravatar Hal Canary2018-03-20
| | | | | | | Change-Id: Iff42b9a166d59b21a97fd2910d54beff1ec82969 Reviewed-on: https://skia-review.googlesource.com/115366 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Move MakeCrossContextFromPixmap to use lazy version of createTextureProxyGravatar Greg Daniel2018-03-20
| | | | | | | | | | After this change it is only tests that are using the old API. Bug: skia: Change-Id: I421ab5efbc604769d2356609d61670c289574f3d Reviewed-on: https://skia-review.googlesource.com/115300 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Allow only Android to use SkAutoGlyphCacheNoGammaGravatar Herb Derby2018-03-20
| | | | | | | Change-Id: Id7b67bc1e4e994f96037266adf7dc159980e4169 Reviewed-on: https://skia-review.googlesource.com/115244 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Herb Derby <herb@google.com>
* update_meta_config: Use new LUCI mac optional GPU trybotGravatar Corentin Wallez2018-03-20
| | | | | | | | | BUG=chromium:815092 Change-Id: I7ec1d448c94bbdb6931fb315d6daf3d882430497 Reviewed-on: https://skia-review.googlesource.com/115362 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Regularize SkGlyphCache creation.Gravatar Herb Derby2018-03-20
| | | | | | | | | | | | | This allows no need for downcasting for specialized use of SkScalerContext for the remote case. This allows cache priming to be used in a single process. BUG=skia:7515 Change-Id: I963a50e36af9deef5a3414fc8a4c94ccfc38deaf Reviewed-on: https://skia-review.googlesource.com/115121 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* SkQP/Docs: fix missing step in READMEGravatar Hal Canary2018-03-20
| | | | | | | | NoTry: true Change-Id: Id97b0677ea203fdf542e42957a38feb84db08b4c Reviewed-on: https://skia-review.googlesource.com/115365 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Update clang_win to latest used by Chromium.Gravatar Ben Wagner2018-03-20
| | | | | | | | | | | | | | | | Revision number comes from https://cs.chromium.org/chromium/src/tools/clang/scripts/update.py?l=30&rcl=d8897aff36aefd9ac967d76810057482c5afc0f3 (via mtklein). This CL is effectively a reland of https://skia-review.googlesource.com/c/skia/+/114093, using the version of Clang from the link above as of 2018-03-16. The original CL was reverted due to skia:7720, which was tangential. Change-Id: I2a0074a4de26ae8f657d0bce29189b161e20eb66 Reviewed-on: https://skia-review.googlesource.com/115164 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* detect nonfinite cubic pointsGravatar Mike Reed2018-03-20
| | | | | | | | | Bug: oss-fuzz:7031 Cq-Include-Trybots: skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Release-All-SKNX_NO_SIMD Change-Id: I657c0652dc863256f445a84c084ccc37d287f534 Reviewed-on: https://skia-review.googlesource.com/115222 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Reland "fix nextContour bug"Gravatar Mike Reed2018-03-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0a86820f2fe3b62f2a5ac2917a1ef342dbe53722. Reason for revert: fix has landed in CTS Original change's description: > Revert "fix nextContour bug" > > This reverts commit 473f69276f1854db80e094cc4af091f7f8a5b00b. > > Reason for revert: a CTS test PathMeasureTest.android.graphics.cts.PathMeasureTest.testNextContour is failing > > Original change's description: > > fix nextContour bug > > > > Calling nextContour() needs to ensure that we've already measured the "current" one. > > > > Bug: skia: > > Change-Id: I501c26d0b068028d67103888f06ec89125a5407a > > Reviewed-on: https://skia-review.googlesource.com/114692 > > Reviewed-by: Cary Clark <caryclark@google.com> > > Commit-Queue: Mike Reed <reed@google.com> > > TBR=caryclark@google.com,reed@google.com > > Change-Id: I7f1e08651dfe73c02158b209dc28af2b174e246f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/114823 > Reviewed-by: Stan Iliev <stani@google.com> > Commit-Queue: Stan Iliev <stani@google.com> TBR=caryclark@google.com,reed@google.com,stani@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia: Change-Id: I0fd61473ef0df62722cf6c6b86f1277f580e4ab1 Reviewed-on: https://skia-review.googlesource.com/115340 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* More removal of auto glyph cache.Gravatar Herb Derby2018-03-20
| | | | | | | | | Working on the last constructor. Change-Id: Iad80c3fd13be47ac46d9037af522b3b3337426fd Reviewed-on: https://skia-review.googlesource.com/115243 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Reland "Check the boundary while cumulating deltas in a mask"Gravatar Yuqian Li2018-03-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2ac541e66ce1afe174b31c24705ca47891816078. Reason for revert: try a new fix; the old one doesn't work because the deltas are not sorted. We use masks specifically because we don't want to sort deltas. Original change's description: > Revert "Check the boundary while cumulating deltas in a mask" > > This reverts commit d9779bcf93c2e11699230a54214309732b9161a7. > > Reason for revert: breaks gold > > Original change's description: > > Check the boundary while cumulating deltas in a mask > > > > Without the fix, > > > > ./out/Debug/dm --config t8888 -m complexclip_bw > > > > will trigger the assert. > > > > Note that this boundary check is already in place when deltas are > > cumulated without using a mask. > > > > Bug: skia: > > Change-Id: I68bfe2b7196d440743d3a7535d097bb8ec7689c3 > > Reviewed-on: https://skia-review.googlesource.com/113210 > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > Reviewed-by: Cary Clark <caryclark@skia.org> > > TBR=liyuqian@google.com,reed@google.com,caryclark@skia.org > > Change-Id: Ice0e3618b02ef48b0f2a9f0662a12f76078e984a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/113170 > Reviewed-by: Yuqian Li <liyuqian@google.com> > Commit-Queue: Yuqian Li <liyuqian@google.com> TBR=liyuqian@google.com,reed@google.com,caryclark@skia.org Change-Id: Ia7a3608a54bed23827ed014213dcd6248adb271d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7731 Reviewed-on: https://skia-review.googlesource.com/113520 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com>
* Add DDL TSAN and ASAN botsGravatar Robert Phillips2018-03-20
| | | | | | | Change-Id: I0d1aa9a137809349e34ab773b5ee41b69e813f9e Reviewed-on: https://skia-review.googlesource.com/115220 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* [skottie] Simplify DM outputGravatar Florin Malita2018-03-20
| | | | | | | | | | | | | | Tweak the Skottie DM strip to facilitate diffing against Lottie results: * remove timestamps * remove grid * always use 200x200 tiles (and a 1000x1000 bitmap size) TBR= Change-Id: I870aaa5e19c44f74ee05a8ce72f32d70a26058ef Reviewed-on: https://skia-review.googlesource.com/114680 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Roll skia/third_party/externals/angle2/ daedf4d23..b391ec408 (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/daedf4d234eb..b391ec40837c $ git log daedf4d23..b391ec408 --date=short --no-merges --format='%ad %ae %s' 2018-03-12 oetuaho Generate code for looking up built-ins 2018-03-16 courtneygo Update KHR header to avoid compiler issue. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: Idf85cf562c8a81600a963462b9b009a1d601d283 Reviewed-on: https://skia-review.googlesource.com/115181 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Add in float-divide-by-zero as an FYI sanitizerGravatar Kevin Lubick2018-03-20
| | | | | | | Bug: skia: Change-Id: Iacf9bcf10c69d3d6e2a1a2bdcce62bdd364582a1 Reviewed-on: https://skia-review.googlesource.com/115078 Reviewed-by: Mike Klein <mtklein@chromium.org>
* [recipes] Add toolchain version to extra_cflags.Gravatar Ben Wagner2018-03-20
| | | | | | | | | | | | | In compile recipes, add a dummy define (e.g. -DDUMMY_clang_linux_version=42) to the compiler flags so that ninja will recompile from scratch when the toolchain changes. Bug: skia:7720 Change-Id: I9a330b21af364b3aa6a1eebbe6ac2022cfa82fdc Reviewed-on: https://skia-review.googlesource.com/115160 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* [recipes] Add asset_version utility function.Gravatar Ben Wagner2018-03-20
| | | | | | | | Bug: skia:7720 Change-Id: I044ca5281354b21c9deffa408ad7ec20c51d2e2e Reviewed-on: https://skia-review.googlesource.com/115122 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* [lottiecap] Moved over from buildbot repo.Gravatar Joe Gregorio2018-03-20
| | | | | | | | | | | | Command line application to build a 5x5 filmstrip from a Lottie file in Chrome headless and then export that filmstrip in a 1000x1000 PNG. Bug: skia: Change-Id: I38decac363f2d592fddc28b3f4ca9450c5851ac6 Reviewed-on: https://skia-review.googlesource.com/115100 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Roll skia/third_party/externals/angle2/ 3761dc7bf..daedf4d23 (3 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/3761dc7bf683..daedf4d234eb $ git log 3761dc7bf..daedf4d23 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 lucferron Vulkan: Add a DynamicDescriptorPool class. 2018-03-15 oetuaho Clean up switch/case pruning code 2018-03-16 lucferron Vulkan: Add 2 features to StreamingBuffer Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: I39af6ac4fae88ae8a88b5777f825e8b217103cf1 Reviewed-on: https://skia-review.googlesource.com/115170 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>