aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Use GrOvalOpFactory ops to draw non-AA rrects, ovals, and arcs.Gravatar Brian Salomon2018-01-12
| | | | | | | | | | This improves performance. Bug: skia: Change-Id: Ie01170ec084be66ea166b2baffcdb415583aa523 Reviewed-on: https://skia-review.googlesource.com/93321 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Added SkSL workaround for devices which cannot safely access gl_FragCoordGravatar Brian Osman2018-01-12
| | | | | | | | | | | This is the root cause of https://github.com/flutter/flutter/issues/13216 I've got a GM that demonstrates the bug, but only in Viewer. Bug: skia:7410 Change-Id: Iaa1f27b10166aa09e4dc5949e5a6ca1bd14c99ac Reviewed-on: https://skia-review.googlesource.com/93920 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Begin support for large color emoji glyphsGravatar Jim Van Verth2018-01-12
| | | | | | | | Bug: skia: Change-Id: I10184a0c2ffae9baf3adb3c670d5e61ceeaf90ff Reviewed-on: https://skia-review.googlesource.com/93360 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* [skotty,sksg] Initial gradient supportGravatar Florin Malita2018-01-12
| | | | | | | | TBR= Change-Id: I61e4d46ac14660f4c9ea757be2278e4098131a6b Reviewed-on: https://skia-review.googlesource.com/94121 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* GrTessellator: eliminate some redundant computation.Gravatar Stephen White2018-01-12
| | | | | | | | | No need to recompute the bisector when mitering. Change-Id: If7b99244d530d4b2241b7b45611f9401b2f02d69 Reviewed-on: https://skia-review.googlesource.com/93673 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Bitmap: clearing pixelref keeps rowbytesGravatar Hal Canary2018-01-12
| | | | | | | Change-Id: Ibf8b69adcb4e9df597079a8d9ada75b4a31194e6 Reviewed-on: https://skia-review.googlesource.com/94040 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* [recipes] Define variables in __init__Gravatar Eric Boren2018-01-12
| | | | | | | | | | This may fix weird races in tests. Bug: skia: Change-Id: I41c36424c7b559301e915a0892590c74931ae463 Reviewed-on: https://skia-review.googlesource.com/93942 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Roll skia/third_party/externals/angle2/ e1aa92193..1ea85a131 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/e1aa92193142..1ea85a1316cf $ git log e1aa92193..1ea85a131 --date=short --no-merges --format='%ad %ae %s' 2018-01-11 fjhenigman Add #! line to scripts/bootstrap.py. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=ethannicholas@google.com Change-Id: I01c930dac176088759a32de780e70645673732e6 Reviewed-on: https://skia-review.googlesource.com/93786 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Blacklist SkImage_makeNonTextureImage on Skylake vkGravatar Chris Dalton2018-01-12
| | | | | | | | Bug: skia: Change-Id: I7394d2f392d7179777b65e77194436271efea80d Reviewed-on: https://skia-review.googlesource.com/93760 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Simplify call when finished with bitmaps.Gravatar Mike Reed2018-01-12
| | | | | | | Bug: skia: Change-Id: I841052bdaf68f6ec4c98a045712941f313a7b27b Reviewed-on: https://skia-review.googlesource.com/94000 Reviewed-by: Hal Canary <halcanary@google.com>
* Revert "Revert "fix legacy makeRasterImage()""Gravatar Mike Klein2018-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ef29e42ef3d81a0e704cf0efcfc9937b531f0327. Reason for revert: probably not either roll. Original change's description: > Revert "fix legacy makeRasterImage()" > > This reverts commit 7c4ca043361f6adb3d17a9d3db2397d86bac5a2d. > > Reason for revert: layout, cereal tests? > > Original change's description: > > fix legacy makeRasterImage() > > > > Passing the color space down into SkImage_Lazy ends up triggering a > > SkTransferFunctionBehavior::kRespect decode (tf(r*a)), where we want > > ignore (tf(r)*a) to have any hope of working with the legacy backend. > > > > This fix in turn needs another little extension of another old hack in > > SkImage_Gpu for makeNonTextureImage() to keep working there. > > > > Bug: skia:7479 > > > > Change-Id: If48ca68e95d9eee597f6b10434498049981314ba > > Reviewed-on: https://skia-review.googlesource.com/93380 > > Commit-Queue: Mike Klein <mtklein@chromium.org> > > Reviewed-by: Brian Osman <brianosman@google.com> > > TBR=mtklein@chromium.org,brianosman@google.com > > Change-Id: I65092e01d767ef1fd35563f0b79ceded3c12b267 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:7479 > Reviewed-on: https://skia-review.googlesource.com/93820 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> TBR=mtklein@chromium.org,mtklein@google.com,brianosman@google.com Change-Id: Ic9b48d311cca152ab2e620363dd4528ed382eb88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7479 Reviewed-on: https://skia-review.googlesource.com/93960 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Revert "Revert "Revert "Snap alpha for small rects"""Gravatar Ethan Nicholas2018-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 15150a60ebea7b268493d0595cec7db9a5465fac. Reason for revert: we suspect this is behind the roll failures Original change's description: > Revert "Revert "Snap alpha for small rects"" > > This reverts commit 131c8ea4b7ffad7ebf6c49cf9337602f1249806d. > > Reason for revert: the CL does not seem to have caused any failures > > Original change's description: > > Revert "Snap alpha for small rects" > > > > This reverts commit 52f8e71a45ead72f257317f82775eb3459b71eae. > > > > Reason for revert: possibly causing Google3 roll failure? > > > > Original change's description: > > > Snap alpha for small rects > > > > > > This is more similar to our alpha snapping in AAA. More critically, we > > > may have a tiny alpha difference after some 90 degree rotations and that > > > breaks the Chromium svg layout tests (where the expected reference is a > > > rotated svg...) > > > > > > TBR: fmalita@google.com > > > Bug: skia: > > > Change-Id: I59b750153488083f65b731643e0baca823cb78e4 > > > Reviewed-on: https://skia-review.googlesource.com/92940 > > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > > TBR=mtklein@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > > > Change-Id: I2ca0b9375caa473dc2f407655b17603b68337c1f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: skia: > > Reviewed-on: https://skia-review.googlesource.com/93323 > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > TBR=mtklein@google.com,ethannicholas@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > Change-Id: I0cb343fa5448ecf0e6a2073bb4e3603275d6984c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/93680 > Reviewed-by: Yuqian Li <liyuqian@google.com> > Commit-Queue: Yuqian Li <liyuqian@google.com> TBR=mtklein@google.com,ethannicholas@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com Change-Id: If00c7c8cb6b44c489615444b9aca5a2f25b2d5fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/93860 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Revert "fix legacy makeRasterImage()"Gravatar Mike Klein2018-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7c4ca043361f6adb3d17a9d3db2397d86bac5a2d. Reason for revert: layout, cereal tests? Original change's description: > fix legacy makeRasterImage() > > Passing the color space down into SkImage_Lazy ends up triggering a > SkTransferFunctionBehavior::kRespect decode (tf(r*a)), where we want > ignore (tf(r)*a) to have any hope of working with the legacy backend. > > This fix in turn needs another little extension of another old hack in > SkImage_Gpu for makeNonTextureImage() to keep working there. > > Bug: skia:7479 > > Change-Id: If48ca68e95d9eee597f6b10434498049981314ba > Reviewed-on: https://skia-review.googlesource.com/93380 > Commit-Queue: Mike Klein <mtklein@chromium.org> > Reviewed-by: Brian Osman <brianosman@google.com> TBR=mtklein@chromium.org,brianosman@google.com Change-Id: I65092e01d767ef1fd35563f0b79ceded3c12b267 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7479 Reviewed-on: https://skia-review.googlesource.com/93820 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Roll skia/third_party/externals/angle2/ ea22b7a58..e1aa92193 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/ea22b7a58bfd..e1aa92193142 $ git log ea22b7a58..e1aa92193 --date=short --no-merges --format='%ad %ae %s' 2018-01-08 geofflang Create a new DeviceImpl each time one is requested from a DisplayImpl. Created with: roll-dep skia/third_party/externals/angle2BUG=742034 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=ethannicholas@google.com Change-Id: Ibb70a692449ebc04580b2dc0cffd4340cebb804f Reviewed-on: https://skia-review.googlesource.com/93784 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll skia/third_party/externals/angle2/ ed1390f80..ea22b7a58 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/ed1390f808b0..ea22b7a58bfd $ git log ed1390f80..ea22b7a58 --date=short --no-merges --format='%ad %ae %s' 2018-01-04 oetuaho Constant fold array indexing and comparison Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=ethannicholas@google.com Change-Id: I40707309b62099c563c42a817d53b2cfe0901944 Reviewed-on: https://skia-review.googlesource.com/93781 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll skia/third_party/externals/angle2/ 540a1dfe1..ed1390f80 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/540a1dfe131e..ed1390f808b0 $ git log 540a1dfe1..ed1390f80 --date=short --no-merges --format='%ad %ae %s' 2018-01-05 fjhenigman Doc fix and improvement. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=ethannicholas@google.com Change-Id: Ic25dba51a36787cf7ffdb0ff679deb00837e85dd Reviewed-on: https://skia-review.googlesource.com/93677 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Revert cert dim now that all Mac builders have new cert.Gravatar Ben Wagner2018-01-11
| | | | | | | | Bug: chromium:799625, skia:7408 Change-Id: Ibacb40c8383559d29bfe31dcc68d40b28844853e Reviewed-on: https://skia-review.googlesource.com/92687 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Stephan Altmueller <stephana@google.com>
* Fix invalid switch in FuzzCanvasGravatar Kevin Lubick2018-01-11
| | | | | | | | | | | Also tweak when we report OOM - AFL-fuzz is fine, but libfuzzer should abort, not exit. Bug: skia: Change-Id: Ic19277bbceec5e7c0ac966d6d9ac677bcfebcfae Reviewed-on: https://skia-review.googlesource.com/93201 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
* Roll skia/third_party/externals/angle2/ 0e1224c82..540a1dfe1 (8 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/0e1224c82c67..540a1dfe131e $ git log 0e1224c82..540a1dfe1 --date=short --no-merges --format='%ad %ae %s' 2018-01-08 geofflang Refactor DeviceImpl creation. 2018-01-08 geofflang Remove the externallyForced method of DeviceImpl. 2017-12-05 jiajia.qin ES31: Update block members static use 2018-01-10 jmadill Vulkan: Add PipelineDesc. 2018-01-10 ynovikov Flatten "#pragma STDGL invariant(all)" also for ESSL to ESSL translation 2018-01-09 jmadill common: Add aligned memory allocator. 2017-12-25 jiajia.qin Use dirty bit for draw indirect buffer 2018-01-09 oetuaho Prune unreferenced variables with a constructor initializer Created with: roll-dep skia/third_party/externals/angle2BUG=742034,742034 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=ethannicholas@google.com Change-Id: If7f378c29be6101960b37e3fa7b64171ba60b283 Reviewed-on: https://skia-review.googlesource.com/93663 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Avoid nullptr deference when deserializing SkPictureGravatar Kevin Lubick2018-01-11
| | | | | | | | | | | | Avoid resetting SkAutoSTArray values to negatives. Additionally, clean up some misc logs that aren't helpful. Bug: skia:7405 Change-Id: Ied353a4e415e2efd5ab8180e7f6c681248dd9134 Reviewed-on: https://skia-review.googlesource.com/93240 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Revert "Revert "Snap alpha for small rects""Gravatar Yuqian Li2018-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 131c8ea4b7ffad7ebf6c49cf9337602f1249806d. Reason for revert: the CL does not seem to have caused any failures Original change's description: > Revert "Snap alpha for small rects" > > This reverts commit 52f8e71a45ead72f257317f82775eb3459b71eae. > > Reason for revert: possibly causing Google3 roll failure? > > Original change's description: > > Snap alpha for small rects > > > > This is more similar to our alpha snapping in AAA. More critically, we > > may have a tiny alpha difference after some 90 degree rotations and that > > breaks the Chromium svg layout tests (where the expected reference is a > > rotated svg...) > > > > TBR: fmalita@google.com > > Bug: skia: > > Change-Id: I59b750153488083f65b731643e0baca823cb78e4 > > Reviewed-on: https://skia-review.googlesource.com/92940 > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > TBR=mtklein@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > Change-Id: I2ca0b9375caa473dc2f407655b17603b68337c1f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/93323 > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> TBR=mtklein@google.com,ethannicholas@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com Change-Id: I0cb343fa5448ecf0e6a2073bb4e3603275d6984c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/93680 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Changes to site documentationGravatar Andrew Monshizadeh2018-01-11
| | | | | | | | | | | | | | | | | Mostly just formatting fixes with a few grammatical changes. Two real notable changes: - Removed references to SkGLCanvas from Tips & FAQ and replaced with references to `SkDevice` and `SkSurface`. - Deleted deprecated "Quick Start Guides" folder Docs-Preview: https://skia.org/?cl=92361 Bug: skia: Change-Id: Ief790b1c2bae8fe0e39aa8d66c79f80560d18c9e Reviewed-on: https://skia-review.googlesource.com/92361 Reviewed-by: Heather Miller <hcm@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Joe Gregorio <jcgregorio@google.com>
* Add bisect_roll toolGravatar Eric Boren2018-01-11
| | | | | | | | | | | | | 1. Loads the list of commits which have not yet rolled. 2. Loads the recent roll attempts. 3. Suggests a commit to try. 4. Uploads a roll CL at the commit specified by the user. Bug: skia: Change-Id: I68a7f6dbbca638cc9f17bad4eed71e889fe43b6e Reviewed-on: https://skia-review.googlesource.com/93580 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Add in Region SetPath FuzzerGravatar Kevin Lubick2018-01-11
| | | | | | | | | | Also refactor a few things to make it easier to use oss-fuzz. Bug: skia: Change-Id: Ie518a6cfc7d57a347b5d09089379f986d33f8b7f Reviewed-on: https://skia-review.googlesource.com/41740 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Make GrTextureOp capable of edge antialiasing.Gravatar Brian Salomon2018-01-11
| | | | | | | | Bug: skia: Change-Id: I0088bdbb6a76811611fa4628656bf9513c5bf04a Reviewed-on: https://skia-review.googlesource.com/91105 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* update bookmaker to ToTGravatar Cary Clark2018-01-11
| | | | | | | | | | | | | | | more image docs, still not done add ability to comment out non-working examples easily start work on additional self-checks clean up use of this-> in docs TBR=reed@google.com Docs-Preview: https://skia.org/?cl=91720 Bug: skia:6898 Change-Id: I706ab8145290e53ab67d3f509ccf4e1225adb3c3 Reviewed-on: https://skia-review.googlesource.com/91720 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* [skotty,sksg] Initial matte layer supportGravatar Florin Malita2018-01-11
| | | | | | | | TBR= Change-Id: I5b689f5d7b0d147fa200cf5bffe476077085cb19 Reviewed-on: https://skia-review.googlesource.com/93300 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Specify "resources" in skia_nanobench's dataGravatar Pirama Arumuga Nainar2018-01-11
| | | | | | | | | | | | | | | Doing so installs packages the resource directory during a 'tests' build. This lets us run skia_nanobench in the internal test infra, which doesn't have access to the source tree. Test: Check that all files in "resources" is packaged during 'make tests dist' in an Android tree. Change-Id: Ia547cf09087e5795bdd825d0d48f179086a9ca4a Reviewed-on: https://skia-review.googlesource.com/93060 Reviewed-by: Derek Sollenberger <djsollen@google.com> Reviewed-by: Stephen Hines <srhines@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
* Roll skia/third_party/externals/angle2/ c74ec1a5b..0e1224c82 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/c74ec1a5bbbd..0e1224c82c67 $ git log c74ec1a5b..0e1224c82 --date=short --no-merges --format='%ad %ae %s' 2017-12-26 yizhou.jiang fix bug for querying sample positions on D3D Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=ethannicholas@google.com Change-Id: I3239885833b5018b26d92701f6cfafa25a9114e5 Reviewed-on: https://skia-review.googlesource.com/93340 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Enable the GL_EXT_geometry_shader extension where necessaryGravatar Chris Dalton2018-01-11
| | | | | | | | | Bug: skia: Change-Id: I37bfb90efed28748d6c3e53be5c9703c291b036c Reviewed-on: https://skia-review.googlesource.com/93460 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Trying gpu scaling on Nexus 5 and 5xGravatar Kevin Lubick2018-01-11
| | | | | | | | | | We do some of this already in skpbench. Bug: skia: Change-Id: Ia698466e83f9b476644c126747a2f89346361d13 Reviewed-on: https://skia-review.googlesource.com/93561 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* [skotty] Adjust Draw node bounds for paintGravatar Florin Malita2018-01-11
| | | | | | | | | TBR= Change-Id: I88b3fe9c0ed4be2244b82d78995d6e27fa022296 Reviewed-on: https://skia-review.googlesource.com/93301 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* fix legacy makeRasterImage()Gravatar Mike Klein2018-01-11
| | | | | | | | | | | | | | | | Passing the color space down into SkImage_Lazy ends up triggering a SkTransferFunctionBehavior::kRespect decode (tf(r*a)), where we want ignore (tf(r)*a) to have any hope of working with the legacy backend. This fix in turn needs another little extension of another old hack in SkImage_Gpu for makeNonTextureImage() to keep working there. Bug: skia:7479 Change-Id: If48ca68e95d9eee597f6b10434498049981314ba Reviewed-on: https://skia-review.googlesource.com/93380 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* Fix buffer size assertion in VulkanGravatar Chris Dalton2018-01-11
| | | | | | | | Bug: skia: Change-Id: I2b878ec288b6dac891fc3724678a528d2db08b09 Reviewed-on: https://skia-review.googlesource.com/93362 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* remove SK_SUPPORT_LEGACY_RECTMAKELARGEST flagGravatar Mike Reed2018-01-11
| | | | | | | Bug: skia: Change-Id: Ic36f1282d23f3f92b250e44685149505cad74bf2 Reviewed-on: https://skia-review.googlesource.com/93423 Reviewed-by: Mike Reed <reed@google.com>
* Revert "Snap alpha for small rects"Gravatar Ethan Nicholas2018-01-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 52f8e71a45ead72f257317f82775eb3459b71eae. Reason for revert: possibly causing Google3 roll failure? Original change's description: > Snap alpha for small rects > > This is more similar to our alpha snapping in AAA. More critically, we > may have a tiny alpha difference after some 90 degree rotations and that > breaks the Chromium svg layout tests (where the expected reference is a > rotated svg...) > > TBR: fmalita@google.com > Bug: skia: > Change-Id: I59b750153488083f65b731643e0baca823cb78e4 > Reviewed-on: https://skia-review.googlesource.com/92940 > Reviewed-by: Yuqian Li <liyuqian@google.com> > Commit-Queue: Yuqian Li <liyuqian@google.com> TBR=mtklein@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com Change-Id: I2ca0b9375caa473dc2f407655b17603b68337c1f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/93323 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* restore intersect methods to use old-style empty-checks on their inputsGravatar Mike Reed2018-01-10
| | | | | | | | | | Bug introduced when we made isEmpty check for int32_t width/height Bug:800804 Change-Id: I59799c88fb02f176c1545dd0edae050b510df079 Reviewed-on: https://skia-review.googlesource.com/93302 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Add valid checks in places we query isTestingOnlyBackendTextureGravatar Greg Daniel2018-01-10
| | | | | | | | Bug: skia:7477 Change-Id: I410427f12c7bb85d11a5e4ed1f09bbd80bbbb54c Reviewed-on: https://skia-review.googlesource.com/93000 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* make lua a rollable dep, roll itGravatar Mike Klein2018-01-10
| | | | | | | | | | | | | | This rolls from 5.2.1 (2013) to 5.3.4 (2017). I was looking at why the GomaNoFallback bot was failing, and noticed that we had a static copy of Lua here instead of a DEPS entry. This doesn't do anything to change the GomaNoFallback situation. Change-Id: Ia3cdca85551fe680b60b38cb8c5a8fb5349e177f Reviewed-on: https://skia-review.googlesource.com/93120 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Snap alpha for small rectsGravatar Yuqian Li2018-01-10
| | | | | | | | | | | | | | This is more similar to our alpha snapping in AAA. More critically, we may have a tiny alpha difference after some 90 degree rotations and that breaks the Chromium svg layout tests (where the expected reference is a rotated svg...) TBR: fmalita@google.com Bug: skia: Change-Id: I59b750153488083f65b731643e0baca823cb78e4 Reviewed-on: https://skia-review.googlesource.com/92940 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Remove internal files from externally visible markdown documentationGravatar Robert Phillips2018-01-10
| | | | | | | Change-Id: I8d2d8d64891b7952bee9f7f39ff15ad30e3fabdd Reviewed-on: https://skia-review.googlesource.com/93100 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Roll skia/third_party/externals/angle2/ 0690e1aa3..c74ec1a5b (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-01-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/0690e1aa31d4..c74ec1a5bbbd $ git log 0690e1aa3..c74ec1a5b --date=short --no-merges --format='%ad %ae %s' 2018-01-09 oetuaho Record gl_in array size in a symbol in ParseContext Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=ethannicholas@google.com Change-Id: Ie1976aa0f00b4b21dbdac7c41f25c89fe86f9d15 Reviewed-on: https://skia-review.googlesource.com/93080 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* [skotty] Initial solid layer supportGravatar Florin Malita2018-01-09
| | | | | | | | TBR= Change-Id: Ib78ff693a1c79873248563502635aed93a90f963 Reviewed-on: https://skia-review.googlesource.com/92624 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Compare drawBounds with MakeLargest instead of isFiniteGravatar Yuqian Li2018-01-09
| | | | | | | | | | | | In some cases, transformedBounds is finite but its rounded out IRect is empty so we can't do that. TBR: reed@google.com Bug: skia: Change-Id: Ife78e91a494964042fa09b8cbe86cabbd2572fb9 Reviewed-on: https://skia-review.googlesource.com/92625 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* support gray8 destinations on CPUGravatar Mike Klein2018-01-09
| | | | | | | | | | | | | | | | | - fill in a couple switches to allow software to rasterize gray8 - add a gray8 config to DM so we can test it - enable this config on some bots Today we draw gray8 using SkRasterPipeline, loading it as {g,g,g,1} and storing using the same fixed luma math as SkLumaColorFilter. One day it'd be nice to use the color space's luma vector if present. Can we support this on GPU? Change-Id: I4ee661c8bd5f33f5db2433ffb6e1bc2483af8397 Reviewed-on: https://skia-review.googlesource.com/92681 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* [skotty] Minor tools tweaksGravatar Florin Malita2018-01-09
| | | | | | | | | | | * fix "show inval" persistency in SkottySlide * add frame-stamp to DM film strip TBR= Change-Id: I965b28fa25b4d6ddfa1ddf80f5f9187dff3f943c Reviewed-on: https://skia-review.googlesource.com/92941 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* fix external link in commentGravatar Cary Clark2018-01-09
| | | | | | | | | | | | update link to one that is accessible by all TBR=iclelland@google.com NOTRY=true Change-Id: Ib8fb6d05779d863641d323311435dbbb5807eeee Reviewed-on: https://skia-review.googlesource.com/92685 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* shrink our 'largest' so that its non-emptyGravatar Mike Reed2018-01-09
| | | | | | | | Bug: skia: Change-Id: Ib12fd9491069440c85d5aa9c9d6d26787f03ef0d Reviewed-on: https://skia-review.googlesource.com/92643 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* add flag for flutterGravatar Mike Reed2018-01-09
| | | | | | | Bug: skia: Change-Id: I73b6045aa17c7a38fcbd3245be926a5097d165ee Reviewed-on: https://skia-review.googlesource.com/92684 Reviewed-by: Mike Reed <reed@google.com>
* detect bad conic weightsGravatar Mike Reed2018-01-09
| | | | | | | | Bug: skia:7478 Change-Id: I5fb254e10f3f38184fe41eb01e543f04b1a03081 Reviewed-on: https://skia-review.googlesource.com/92641 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Reed <reed@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-30 12:45:09 +0000