aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Disable LCD text explicitly in SkPictureImageFilter::onFilterImage()Gravatar fmalita2014-11-20
| | | | | | | | | | | As an intermediate fix for https://code.google.com/p/skia/issues/detail?id=3142, we can use a non-public SkCanvas constructor and force-disable LCD text. BUG=skia:3142 R=reed@google.com,senorblanco@google.com Review URL: https://codereview.chromium.org/725243004
* Add SkNVRefCnt::deref().Gravatar mtklein2014-11-20
| | | | | | | | TBR=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/744853002
* Don't use NULL GrOptDrawState to indicate that draw should be skipped.Gravatar bsalomon2014-11-20
| | | | Review URL: https://codereview.chromium.org/742853002
* Add SkNVRefCnt, prune down SkPicture's sizeGravatar mtklein2014-11-20
| | | | | | | | | | | | | | SkNVRefCnt is a variant of SkRefCnt that's Not Virtual, so weighs 4 bytes instead of 8 or 16. There's only benefit to doing this if the deriving class does not otherwise need a vtable, e.g. SkPicture. I've stripped out some cruft from SkPicture, rearranged fields to pack tightly, and added compile asserts for the sizes of SkPicture, SkRecord, and SkVarAlloc. BUG=skia:3144 Review URL: https://codereview.chromium.org/741793002
* SkRecord: Pack SkRegion::Op and AA bit together.Gravatar mtklein2014-11-20
| | | | | | | | Saves 4 bytes per clip op. BUG=skia: Review URL: https://codereview.chromium.org/741093002
* SkCanvas::clear() should call down to devices even when the clip is empty.Gravatar mtklein2014-11-20
| | | | | | | | SkDrawIter had a lovely, completely unused, option for this. Oversight? BUG=skia: Review URL: https://codereview.chromium.org/735233003
* Stop overloading internal_dispose in SkTextBlob and SkDataGravatar bsalomon2014-11-20
| | | | Review URL: https://codereview.chromium.org/737093002
* Make sure pictures draw Clears even when the clip is empty.Gravatar mtklein2014-11-20
| | | | | | | | | | | | We fix this by rewriting empty queries to very tiny queries, which will certainly hit ops that span the entire picture (like Clear) and hopefully not much more. (This doesn't quite work in the full cull rect world if [0,0,ε,ε] doesn't overlap the picture. Let's cross that bridge when we get there.) BUG=432991 Review URL: https://codereview.chromium.org/732723004
* dstCopy on optdrawstateGravatar joshualitt2014-11-20
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/735363003
* Preventing division by 0 in non-separable blend mode shaders.Gravatar rosca2014-11-20
| | | | | | | | | In the software path, the same issue has been fixed some time ago: https://codereview.chromium.org/114173002 BUG=skia: Review URL: https://codereview.chromium.org/666043003
* Implement conics for NVPRGravatar kkinnunen2014-11-19
| | | | | | | | | Implement conics for NVPR. Verified with currently disabled conicpaths gm, produces mostly same shapes with nvprmsaa4 and msaa4. BUG=skia:2033 Review URL: https://codereview.chromium.org/694503003
* even more stragglers -- hopefully this makes the gtx machine go green?Gravatar Greg Humphreys2014-11-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/716243005
* more rebaseline stragglersGravatar Greg Humphreys2014-11-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/726373004
* Store DM failures in an array, not a single string.Gravatar mtklein2014-11-19
| | | | | | | | | | | | | | | | | | | | | | This should fix the problem where a repeatedly failing test causes this assertion: ../../src/core/SkString.cpp:572: failed assertion "length >= 0 && length < SkToInt(kBufferSize)" Example output: 0 GMs x 7 configs, 2 tests, 0 pictures 0 tasks left, 100 failed Failures: test RTree: ../../tests/RTreeTest.cpp:77 0 != rtree.getCount() test RTree: ../../tests/RTreeTest.cpp:77 0 != rtree.getCount() test RTree: ../../tests/RTreeTest.cpp:77 0 != rtree.getCount() test RTree: ../../tests/RTreeTest.cpp:77 0 != rtree.getCount() < 95 lines elided > test RTree: ../../tests/RTreeTest.cpp:77 0 != rtree.getCount() 100 failures. BUG=skia: Review URL: https://codereview.chromium.org/741833002
* a few straggling rebaselinesGravatar Greg Humphreys2014-11-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/742893002
* Small cleanups after GrDrawState/GrOptDrawState base class elimination.Gravatar bsalomon2014-11-19
| | | | Review URL: https://codereview.chromium.org/739133004
* Implement SkPicture::bytesUsed() for SkRecord backendGravatar tomhudson2014-11-19
| | | | | | | BUG=chromium:230419 R=mtklein@google.com,reed@google.com Review URL: https://codereview.chromium.org/490253003
* No need to short circuit the query rect here anymore.Gravatar mtklein2014-11-19
| | | | | | | | Whatever assertion was triggering in SkRTree.cpp seems to be gone now. BUG=432991 Review URL: https://codereview.chromium.org/725373003
* Remove debug-only fData from SKTDArray.Gravatar mtklein2014-11-19
| | | | | | | | | | | | | It makes the code harder to read, and makes Debug and Release SkTDArrays different sizes. Looks like fData is left over from when debuggers weren't very good at inspecting data structures. No API changes. TBR=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/739263002
* scissor state on optstateGravatar joshualitt2014-11-19
| | | | | | | | waiting BUG=skia: Review URL: https://codereview.chromium.org/742763002
* Add an image filter row to GM:lcdtextpropsGravatar fmalita2014-11-19
| | | | | | | | | We should be disabling LCD text when rendering image filters, but currently don't. Add a GM to capture this behavior. R=reed@google.com Review URL: https://codereview.chromium.org/741433003
* Remove /arch:SSE2 from Win 64 Release buildsGravatar bsalomon2014-11-19
| | | | Review URL: https://codereview.chromium.org/740733002
* add runtime config option to retain stream for custom typefacesGravatar humper2014-11-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/729973004
* move GrGeometryProcessor to srcGravatar joshualitt2014-11-19
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/739943003
* Create GrOptDrawState before recording draw in GrInOrderDrawBufferGravatar bsalomon2014-11-19
| | | | Review URL: https://codereview.chromium.org/739673002
* Allow pictures to have a full boundsGravatar reed2014-11-19
| | | | | | | | This reverts commit 7c4cdd2c5b7b6c71fa0e7612594f7885f2dbf264. BUG=skia: Review URL: https://codereview.chromium.org/738083002
* Revert of allow pictures to have a full bounds (patchset #3 id:40001 of ↵Gravatar reed2014-11-19
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/736583004/) Reason for revert: needed to update legacy width() helpers Original issue's description: > allow pictures to have a full bounds > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7e76bff26e7c74902841ca4f607eb0b24a833a4a TBR=fmalita@google.com,mtklein@google.com,robertphillips@google.com,fmalita@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/722043005
* allow pictures to have a full boundsGravatar reed2014-11-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/736583004
* Add processor name to comment when printing out shaders.Gravatar egdaniel2014-11-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/735153002
* add roundOut that returns its resultGravatar reed2014-11-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/742663002
* Update SKP versionGravatar skia.buildbots2014-11-18
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/738003002
* change roundOut() to take a dst, so we can use that signature to return IRectGravatar reed2014-11-18
| | | | | | | BUG=skia: TBR=robertphilips Review URL: https://codereview.chromium.org/731373003
* setting patch_primitive_nvprmsaa4 on K1 to ignoreGravatar joshualitt2014-11-18
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/743563003
* drawinfo carries bufferinfoGravatar joshualitt2014-11-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/737723003
* ignore dashcubics test pending skia bug 2049Gravatar Greg Humphreys2014-11-18
| | | | | | BUG=skia:2049 Review URL: https://codereview.chromium.org/741533002
* a few straggling rebaselinesGravatar Greg Humphreys2014-11-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/738943003
* more rebaselines for the perspective test serverGravatar Greg Humphreys2014-11-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/727063004
* rebaseline new GTX images from drive update on linuxGravatar Greg Humphreys2014-11-18
| | | | | | | | BUG=skia: TBR=borenet NOTRY=true Review URL: https://codereview.chromium.org/735833002
* Add computation of saveLayer information to RecordingBenchGravatar robertphillips2014-11-18
| | | | | | In (Add flag to beginRecording to request saveLayer information - https://codereview.chromium.org/721883002/) I claimed the extra recording cost would be negligible. This CL attempts to put some numbers behind that. Review URL: https://codereview.chromium.org/741523002
* http://skbug.com/3130 step 4 (include/utils/SkWGL.h gone for good)Gravatar halcanary2014-11-18
| | | | | | BUG=skia:3130 Review URL: https://codereview.chromium.org/729363003
* wip for drawablesGravatar reed2014-11-18
| | | | | | | | | | | | Idea: 1. in its mutable recording state, keep a table of drawables on the side, and store an index in the record list. 2. In "immediate-mode" draw, just call the clients drawable directly (need access to our private list to turn the stored index into a proc) 3. when we "snap", we replace the list of drawables with a list of (sub) pictures, and then during playback of the snapped picture, we invoke a private drawable which just calls "drawPicture" on the index'd subpicture. Review URL: https://codereview.chromium.org/727363003
* rebaseline after dont-normalize-matrix clGravatar reed2014-11-18
| | | | | | | | BUG=skia: TBR= NOTRY=True Review URL: https://codereview.chromium.org/738743003
* fix for use of uninit variableGravatar joshualitt2014-11-18
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/740463002
* SkVarAlloc::approxBytesAllocated()Gravatar mtklein2014-11-18
| | | | | | | | | | | | This is what I was getting at on the other CL. BUG=skia: Committed: https://skia.googlesource.com/skia/+/f27f1bcce50c8f95aea8469684a70b70c9baee09 CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-Nexus5-Adreno330-Arm7-Release-Trybot Review URL: https://codereview.chromium.org/730193003
* Prune SkRTreeGravatar mtklein2014-11-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Propagate a bunch of constant parameters through. - Delete code that's not used when bulk loading. - Allocate all Nodes together. - Stay in SkRect. Doing a single malloc for the nodes can't not have improved memory usage. Looks like this might improve record performance ~5%, probably mostly from staying in SkRects. This finally dethrones building the BBH as the hot spot. (Now it's mapping user bounds back to device bounds and adjusting for paints.) Recording time changes from my MBP: desk_rectangletransition.skp 11.5us -> 11.7us 1x desk_forecastio.skp 115us -> 114us 0.98x desk_booking.skp 550us -> 541us 0.98x tabl_mercurynews.skp 176us -> 173us 0.98x tabl_hsfi.skp 294us -> 287us 0.98x desk_wordpress.skp 351us -> 343us 0.98x tabl_worldjournal.skp 439us -> 426us 0.97x tabl_gmail.skp 20.3us -> 19.7us 0.97x desk_youtubetvvideo.skp 10.8us -> 10.4us 0.97x desk_googleplus.skp 1.1ms -> 1.07ms 0.97x tabl_slashdot.skp 106us -> 103us 0.97x desk_jsfiddlebigcar.skp 26.7us -> 25.7us 0.96x tabl_techmeme.skp 95.4us -> 91.7us 0.96x tabl_deviantart.skp 133us -> 127us 0.96x desk_pinterest.skp 40.6us -> 38.9us 0.96x desk_carsvg.skp 195us -> 187us 0.96x tabl_engadget.skp 376us -> 359us 0.96x tabl_sahadan.skp 60.5us -> 57.5us 0.95x tabl_culturalsolutions.skp 255us -> 242us 0.95x tabl_gspro.skp 58.3us -> 55.5us 0.95x desk_linkedin.skp 146us -> 138us 0.94x desk_ebay.skp 192us -> 181us 0.94x tabl_cnn.skp 467us -> 440us 0.94x desk_jsfiddlehumperclip.skp 29.9us -> 28.1us 0.94x desk_tigersvg.skp 43.2us -> 40.5us 0.94x desk_yahooanswers.skp 131us -> 123us 0.94x desk_googlespreadsheetdashed.skp 1.18ms -> 1.11ms 0.94x desk_blogger.skp 193us -> 181us 0.94x tabl_mozilla.skp 1.82ms -> 1.7ms 0.94x tabl_mlb.skp 145us -> 136us 0.93x mobi_wikipedia.skp 577us -> 539us 0.93x tabl_frantzen.skp 54.1us -> 50.4us 0.93x desk_baidu.skp 87.9us -> 81.9us 0.93x desk_techcrunch.skp 224us -> 209us 0.93x desk_sfgate.skp 206us -> 192us 0.93x tabl_ukwsj.skp 269us -> 250us 0.93x desk_facebook.skp 316us -> 293us 0.93x desk_gmailthread.skp 205us -> 190us 0.93x tabl_googlecalendar.skp 158us -> 147us 0.93x tabl_digg.skp 382us -> 354us 0.93x desk_amazon.skp 106us -> 98.5us 0.93x tabl_androidpolice.skp 693us -> 642us 0.93x tabl_nytimes.skp 206us -> 191us 0.92x desk_gws.skp 124us -> 114us 0.92x desk_youtube.skp 255us -> 235us 0.92x tabl_cuteoverload.skp 583us -> 537us 0.92x desk_oldinboxapp.skp 18us -> 16.6us 0.92x desk_mobilenews.skp 297us -> 273us 0.92x tabl_pravda.skp 168us -> 154us 0.92x tabl_vnexpress.skp 236us -> 217us 0.92x desk_css3gradients.skp 202us -> 185us 0.92x tabl_gamedeksiam.skp 508us -> 464us 0.91x desk_wowwiki.skp 1.02ms -> 929us 0.91x desk_espn.skp 209us -> 191us 0.91x desk_chalkboard.skp 315us -> 284us 0.9x desk_mapsvg.skp 607us -> 543us 0.89x desk_pokemonwiki.skp 5.18ms -> 4.62ms 0.89x desk_samoasvg.skp 335us -> 298us 0.89x desk_youtubetvbrowse.skp 10.1us -> 8.59us 0.85x BUG=skia:3085, skia:2834 Review URL: https://codereview.chromium.org/734723002
* Revert of SkVarAlloc::approxBytesAllocated (patchset #5 id:80001 of ↵Gravatar mtklein2014-11-18
| | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/730193003/) Reason for revert: Android needs dlmalloc_usable_size(). Original issue's description: > SkVarAlloc::approxBytesAllocated() > > This is what I was getting at on the other CL. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/f27f1bcce50c8f95aea8469684a70b70c9baee09 > > CQ_EXTRA_TRYBOTS=Test-Android-Nexus5-Adreno330-Arm7-Release-Trybot TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/741443002
* minor cleanup in GrGpu.hGravatar bsalomon2014-11-18
| | | | Review URL: https://codereview.chromium.org/731073003
* rebaseline perspective gm after matrix dont-renormalize-clGravatar reed2014-11-18
| | | | | | | | BUG=skia: TBR= NOTRY=True Review URL: https://codereview.chromium.org/741433002
* SkVarAlloc::approxBytesAllocated()Gravatar mtklein2014-11-18
| | | | | | | | This is what I was getting at on the other CL. BUG=skia: Review URL: https://codereview.chromium.org/730193003
* don't normalize after perspective concatGravatar reed2014-11-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/734513004