aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* [skotty] Initial shape transform supportGravatar Florin Malita2017-12-31
| | | | | | | | | TBR= Change-Id: I29ce2e6a29492fb0ec51f28f095392594ea6781c Reviewed-on: https://skia-review.googlesource.com/90024 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Update SKP versionGravatar UpdateSKPs2017-12-31
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I1aa9189cde5d4fc5df289afc434f8c3060f353f8 Reviewed-on: https://skia-review.googlesource.com/90140 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* [skotty] Fix path close handlingGravatar Florin Malita2017-12-31
| | | | | | | | | | ... and add a transform animation sample TBR= Change-Id: I27a67d7861dffb9ca22a5e7155ee0eba3b4575f6 Reviewed-on: https://skia-review.googlesource.com/90023 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Initial Lottie loader impl (Skotty)Gravatar Florin Malita2017-12-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Coarse workflow: * Construction 1) build a Json tree 2) collect asset IDs (for preComp/image layer resolution) 3) "attach" pass - traverse the Json tree - build an SkSG dom, one fragment at a time - attach "animator" objects to the dom, for each animated prop 4) done, we can throw away the Json tree * For each animation tick 1) iterate over active animators and poke their respective dom nodes/attributes 2) revalidate the SkSG dom 3) draw the SkSG dom Note: post construction, things are super-simple - we just poke SkSG DOM attributes with interpolated values, and everything else is handled by SkSG (invalidation, revalidation, render). Change-Id: I96a02be7eb4fb4cb3831f59bf2b3908ea190c0dd Reviewed-on: https://skia-review.googlesource.com/89420 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* fix pipe reader for drawLatticeGravatar Mike Reed2017-12-30
| | | | | | | | Bug: skia: Change-Id: Ic2c4dc4a0441987528268ec13e44a873b33e6bdc Reviewed-on: https://skia-review.googlesource.com/90022 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* [sksg] Fix inval rect mappingGravatar Florin Malita2017-12-30
| | | | | | | | | | Return false from mapRect() doesn't mean the op failed. TBR= Change-Id: I0582fde3efaa792010f27e3684cfe9c4332e29dc Reviewed-on: https://skia-review.googlesource.com/90021 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Roll skia/third_party/externals/angle2/ bed35d766..8c3988c59 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/bed35d766712..8c3988c59ebe $ git log bed35d766..8c3988c59 --date=short --no-merges --format='%ad %ae %s' 2017-12-21 jmadill Vulkan: Use one pipeline layout for all Programs. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=kjlubick@google.com Change-Id: I888e0317aeec43f8cbc1ed73d3b2331751632532 Reviewed-on: https://skia-review.googlesource.com/90101 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Roll skia/third_party/externals/angle2/ 49ac74bd4..bed35d766 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/49ac74bd4c96..bed35d766712 $ git log 49ac74bd4..bed35d766 --date=short --no-merges --format='%ad %ae %s' 2017-12-20 oetuaho Don't query names of empty symbols Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=kjlubick@google.com Change-Id: I28679cc1a7edf26eff5180961efa52430c5e9455 Reviewed-on: https://skia-review.googlesource.com/90081 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Roll skia/third_party/externals/angle2/ b8cb939f5..49ac74bd4 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/b8cb939f5817..49ac74bd4c96 $ git log b8cb939f5..49ac74bd4 --date=short --no-merges --format='%ad %ae %s' 2017-12-21 jmadill Vulkan: Implement command re-ordering. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=kjlubick@google.com Change-Id: I2943bf5eea9542f3ea21021c026a7b7a0aa96b47 Reviewed-on: https://skia-review.googlesource.com/90061 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
* [sksg] Refactor stroke logicGravatar Florin Malita2017-12-29
| | | | | | | | | | Instead of a specialized node, hoist attributes to base class. TBR= Change-Id: I4fa5a24dfc899307a8603577738972ebd32f57f5 Reviewed-on: https://skia-review.googlesource.com/89903 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Roll skia/third_party/externals/angle2/ 8a57b468e..b8cb939f5 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/8a57b468e254..b8cb939f5817 $ git log 8a57b468e..b8cb939f5 --date=short --no-merges --format='%ad %ae %s' 2017-12-20 oetuaho Fix tracking variables in folded ternary operators Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=kjlubick@google.com Change-Id: I3a9e5295292ee1d2624fcef5ba320495ad5a7536 Reviewed-on: https://skia-review.googlesource.com/89981 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
* Revert "remove legacy support for old old picture versions"Gravatar Mike Reed2017-12-29
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f3504d430cec35330017aa2af3a51083801c7dd9. Reason for revert: breaks unittest in Printing unittest in chrome Original change's description: > remove legacy support for old old picture versions > > Bug: skia: > Change-Id: Ieb97eabdb18e8c7bfa86e6a1fc6e0389cd096daa > Reviewed-on: https://skia-review.googlesource.com/89860 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Mike Reed <reed@google.com> TBR=mtklein@google.com,fmalita@chromium.org,reed@google.com Change-Id: I9f90da5dcfb9543f2f575fa7dc3b9c82996b041d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/90020 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* remove legacy support for old old picture versionsGravatar Mike Reed2017-12-29
| | | | | | | | Bug: skia: Change-Id: Ieb97eabdb18e8c7bfa86e6a1fc6e0389cd096daa Reviewed-on: https://skia-review.googlesource.com/89860 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* [sksg] Fix paint invalGravatar Florin Malita2017-12-29
| | | | | | | | | | | Paint nodes contribute to invalidation. Hoist the inval logic from geometry nodes to draw nodes. TBR= Change-Id: Iab33086c377ef4940a84dae3cdccb2c9bdbee99c Reviewed-on: https://skia-review.googlesource.com/89901 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Roll skia/third_party/externals/angle2/ 007530ea5..8a57b468e (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/007530ea55ce..8a57b468e254 $ git log 007530ea5..8a57b468e --date=short --no-merges --format='%ad %ae %s' 2017-12-28 jmadill Re-land "Vulkan: Roll loader/validation layers SDK. (2/2)" Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=kjlubick@google.com Change-Id: I001f37219a9c4e725ba3c95217f1d12ad85a4708 Reviewed-on: https://skia-review.googlesource.com/89940 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
* Roll skia/third_party/externals/angle2/ f095799b5..007530ea5 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/f095799b54ea..007530ea55ce $ git log f095799b5..007530ea5 --date=short --no-merges --format='%ad %ae %s' 2017-12-28 jmadill Entry Points: Refactor Extensions Part 2. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=kjlubick@google.com Change-Id: Ia23b7d0edea4a32866a4f7d18694403f550590c6 Reviewed-on: https://skia-review.googlesource.com/89880 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Roll skia/third_party/externals/angle2/ aaa55bfa3..f095799b5 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/aaa55bfa376d..f095799b54ea $ git log aaa55bfa3..f095799b5 --date=short --no-merges --format='%ad %ae %s' 2017-12-22 oetuaho Fix accessing the name of a nested struct definition Created with: roll-dep skia/third_party/externals/angle2 BUG=797156 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=kjlubick@google.com Change-Id: Ia1cc3afadffaa2fd56ab4b316d053e629508317e Reviewed-on: https://skia-review.googlesource.com/89760 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
* Fix bug of a + (b - a) == 0 for small positive b and huge a (e.g., 1e18)Gravatar Yuqian Li2017-12-28
| | | | | | | | | | | | | | I am unable to make a MSAN build to work locally. But I think that this should fix the problem by looking at the gradient of the fuzzer: Z.createRadialGradient(1.94159387872, 138.616510533, 2.22085316544e+18, 10.3399911492, 176.149195942, 153.078363987); Bug: chromium:797184 Change-Id: I16c571a378742c4ef50afe9c5baba791da7fc208 Reviewed-on: https://skia-review.googlesource.com/89541 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Roll skia/third_party/externals/angle2/ 06f863774..aaa55bfa3 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/06f863774011..aaa55bfa376d $ git log 06f863774..aaa55bfa3 --date=short --no-merges --format='%ad %ae %s' 2017-12-28 oetuaho Index symbols by id in ValidateOutputs Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=kjlubick@google.com Change-Id: I438604078950945d2430abefd6a13aa8f5bbd415 Reviewed-on: https://skia-review.googlesource.com/89700 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
* [sksg] Initial stroke wrapper supportGravatar Florin Malita2017-12-27
| | | | | | | | | TBR= Change-Id: I33e2fe076334de34c4427e7bfe6b6aaa724130b2 Reviewed-on: https://skia-review.googlesource.com/89641 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Fix conical test where r1 = r2 = 0Gravatar Yuqian Li2017-12-27
| | | | | | | | Bug: skia:7436 Change-Id: I0fdbd458d4e2da53e587be27ac90fbb2d32584e5 Reviewed-on: https://skia-review.googlesource.com/89520 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* [sksg] Initial Path supportGravatar Florin Malita2017-12-27
| | | | | | | | | TBR= Change-Id: I594634d339b5e1ad9181dc5303af1a1c754d0fe3 Reviewed-on: https://skia-review.googlesource.com/89540 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Remove usage of SkGammas in SkColorSpace serializationGravatar Brian Osman2017-12-27
| | | | | | | | Bug: skia:7419 Change-Id: I613d9d19eaa05402aadff12d022a4471605d7ec0 Reviewed-on: https://skia-review.googlesource.com/89183 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
* Revert "remove approxbytes api from SkPicture"Gravatar Mike Reed2017-12-25
| | | | | | | | | | This reverts commit bfc11853a88cda6951ae97399577fadadf2adcd5. Bug: skia: Change-Id: Ied4baad0496a06a52bec6965f9c97e13ebe2ab0a Reviewed-on: https://skia-review.googlesource.com/89442 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "re-add dummy printf to fix bots"Gravatar Mike Reed2017-12-25
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 1395994aa02795d6c887124cb15813484ba65061. Reason for revert: broke flutter Original change's description: > re-add dummy printf to fix bots > > Bug: skia: > Change-Id: I3184736f37481c5ac20eae1a15c17aed4f3c3e52 > Reviewed-on: https://skia-review.googlesource.com/89441 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=borenet@google.com,rmistry@google.com,jcgregorio@google.com,reed@google.com Change-Id: I36b9efffe8a0c9df1970a31ffee5cb59171d967f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/89381 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Add a bench for comparing complex clip strategiesGravatar Florin Malita2017-12-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clip consisting of a union of |n| circles. Comparing mask (2x saveLayer + srcIn) vs. clipPath approaches. MBP numbers: ! -> high variance, ? -> moderate variance micros bench 233.05 ! clip_strategy_mask_100 gl 207.61 ! clip_strategy_mask_10 gl 210.41 ? clip_strategy_mask_5 gl 219.10 ? clip_strategy_mask_1 gl 115.56 ? clip_strategy_path_100 gl 113.29 ! clip_strategy_path_10 gl 102.36 ? clip_strategy_path_5 gl 6.37 ? clip_strategy_path_1 gl 361.06 ! clip_strategy_mask_100 8888 328.97 ! clip_strategy_mask_10 8888 316.72 ! clip_strategy_mask_5 8888 325.84 ! clip_strategy_mask_1 8888 368.54 ! clip_strategy_path_100 8888 306.99 ! clip_strategy_path_10 8888 298.71 ! clip_strategy_path_5 8888 191.00 ! clip_strategy_path_1 8888 TBR= Change-Id: I945c12e2e35b9847af06342473e56272e2041e21 Reviewed-on: https://skia-review.googlesource.com/72521 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Fix leak in GM:RectanizerGravatar Florin Malita2017-12-24
| | | | | | | | | TBR= Change-Id: I0e6135ac7fac433a0539f00a45f569ce4f48aa7c Reviewed-on: https://skia-review.googlesource.com/89421 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* re-add dummy printf to fix botsGravatar Mike Reed2017-12-24
| | | | | | | | Bug: skia: Change-Id: I3184736f37481c5ac20eae1a15c17aed4f3c3e52 Reviewed-on: https://skia-review.googlesource.com/89441 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* remove approxbytes api from SkPictureGravatar Mike Reed2017-12-24
| | | | | | | | Bug: skia: Change-Id: I292bc9ab52fe8df3ce97a2ad4b06085b0332b19d Reviewed-on: https://skia-review.googlesource.com/89440 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Update SKP versionGravatar UpdateSKPs2017-12-24
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I5daecb02cb3bd24b2d6921eee78ad6ce58b50101 Reviewed-on: https://skia-review.googlesource.com/89460 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* remove unused headerGravatar Mike Reed2017-12-23
| | | | | | | | Bug: skia: Change-Id: I944962971e72f9dfa05473bf40f6328a92b7816a Reviewed-on: https://skia-review.googlesource.com/89360 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Roll skia/third_party/externals/angle2/ 2b7bbc282..06f863774 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/2b7bbc282280..06f863774011 $ git log 2b7bbc282..06f863774 --date=short --no-merges --format='%ad %ae %s' 2017-12-22 zmo Revert "Re-land "Vulkan: Roll loader/validation layers SDK. (2/2)"" Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=csmartdalton@google.com Change-Id: Ib80b06eed4a2221f9d08a2fb0222b7b9da605249 Reviewed-on: https://skia-review.googlesource.com/89263 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
* Rearrange GRTC::drawPath()Gravatar Brian Salomon2017-12-22
| | | | | | | | | | Check for rrects first. Don't recreate path if shape simplified it to check for nested rects. Change-Id: I3c82c4269abf8b579ba7e92be76a33c956a01602 Reviewed-on: https://skia-review.googlesource.com/89182 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "CCPR: Initial semi-optimized vertex shader Impl"Gravatar Chris Dalton2017-12-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e3877ce5ceb7842b61d54bebcc51864e5787a2bc. Reason for revert: Intel crashing again Original change's description: > CCPR: Initial semi-optimized vertex shader Impl > > TBR=bsalomon@google.com > > Bug: skia: > Change-Id: I24173e146d8c95cec5f29e8cb4fa5e2c28f9a33c > Reviewed-on: https://skia-review.googlesource.com/89120 > Reviewed-by: Chris Dalton <csmartdalton@google.com> > Commit-Queue: Chris Dalton <csmartdalton@google.com> TBR=bsalomon@google.com,brianosman@google.com,csmartdalton@google.com Change-Id: I2485db30397958722a07c5992c748ab69365ebb6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/89300 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Revert "Update isolate binaries and update isolate recipe"Gravatar Ravi Mistry2017-12-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8bc327bffb7ae7d10b93ee75c3d207caeb37f93b. Reason for revert: Isolate tests step in CT_ bots taking 5x longer. Original change's description: > Update isolate binaries and update isolate recipe > > Context: Email to skiabot@ from mcgreevy@ > > Bug: skia: > Change-Id: Ic3bc19600809bde5adcd9edd23ba4d8b126ec852 > Reviewed-on: https://skia-review.googlesource.com/88540 > Reviewed-by: Kevin Lubick <kjlubick@google.com> > Commit-Queue: Ravi Mistry <rmistry@google.com> TBR=benjaminwagner@google.com,rmistry@google.com,kjlubick@google.com Change-Id: Ifda029a65bf6414dc40502356870101ac3f88cb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/89280 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* CCPR: Initial semi-optimized vertex shader ImplGravatar Chris Dalton2017-12-22
| | | | | | | | | | TBR=bsalomon@google.com Bug: skia: Change-Id: I24173e146d8c95cec5f29e8cb4fa5e2c28f9a33c Reviewed-on: https://skia-review.googlesource.com/89120 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* fix usage of deprecated SkMatrix44 constructorGravatar Ethan Nicholas2017-12-22
| | | | | | | | | Bug: skia: Change-Id: I04acc1132df7c0357229af8583f9b2e8e2f02f3b Reviewed-on: https://skia-review.googlesource.com/89162 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Quarantine android bots instead of shutting off deviceGravatar Kevin Lubick2017-12-22
| | | | | | | | | | | | | | This should make it easier to diagnose and remotely fix the devices/hosts. Only works because of https://chrome-internal-review.googlesource.com/c/infradata/config/+/535542 Bug: skia: Change-Id: Idf11a09da6c7367212a0ac0b0b959cbf49fed85b Reviewed-on: https://skia-review.googlesource.com/89181 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* attempt 3: add experimental bilerp_clamp_8888 stageGravatar Mike Klein2017-12-22
| | | | | | | | | | | | | | | | | | | | | | It looks like we can specialize hot image shaders into their own single stages for a good speedup on both x86 and ARM. I've started here with bilerp_clamp_8888, and will follow up with bgra and 565, and lowp versions of those, and probably also the same for nearest neighbors. All pixels are identical in GMs. This time, rewrite the loop over sample points to be a little friendlier to 32-bit x86 code generation. The previous version created an object file indirection feature build_stages.py can't handle. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Android-Clang-NexusPlayer-CPU-Moorefield-x86-Release-All-Android,Test-Android-Clang-NexusPlayer-GPU-PowerVR-x86-Release-All-Android Change-Id: I150b6af4a5b89e009dc04ca69e1857892e173deb Reviewed-on: https://skia-review.googlesource.com/89180 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* handle closed dashed rectsGravatar Cary Clark2017-12-22
| | | | | | | | | | | | | | | If a closed rect is dashed, the dash continues around the initial join if the dash is 'on' when the rect starts and stops. For the cull path case, add a tiny right angle at the location of the initial join if needed. R=reed@google.com Bug: skia:7311 Change-Id: Id60b8e84b3a5fd6cde1b638dbaacdad57eba7f01 Reviewed-on: https://skia-review.googlesource.com/88201 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>
* Remove another stray pair of clamps.Gravatar Mike Klein2017-12-22
| | | | | | | | | | This clamping should not be necessary now that SkRasterPipeline is more robust to out of gamut values. Change-Id: I17f9af8ccd3d837617a3ed864af1e87e77605cf5 Reviewed-on: https://skia-review.googlesource.com/89160 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* converted YUVEffect to SkSLGravatar Ethan Nicholas2017-12-22
| | | | | | | | Bug: skia: Change-Id: I1875e44417a0a583c4f35ee4d46856a34ba55245 Reviewed-on: https://skia-review.googlesource.com/88580 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Update isolate binaries and update isolate recipeGravatar Ravi Mistry2017-12-22
| | | | | | | | | | Context: Email to skiabot@ from mcgreevy@ Bug: skia: Change-Id: Ic3bc19600809bde5adcd9edd23ba4d8b126ec852 Reviewed-on: https://skia-review.googlesource.com/88540 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* add safemath version of readbuffer->skipGravatar Mike Reed2017-12-22
| | | | | | | | | Bug: skia: Change-Id: I6a5d24569cc1bd93bd190d81e3375993da9c56f0 Reviewed-on: https://skia-review.googlesource.com/88581 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* remove dead code behind SK_SUPPORT_LEGACY_SERIALPROCS_REFGravatar Mike Reed2017-12-22
| | | | | | | | Bug: skia: Change-Id: Iba5ad1e8d5c74c79627cabbbbe4e835278553609 Reviewed-on: https://skia-review.googlesource.com/88820 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Roll skia/third_party/externals/angle2/ b6af22b52..2b7bbc282 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/b6af22b522be..2b7bbc282280 $ git log b6af22b52..2b7bbc282 --date=short --no-merges --format='%ad %ae %s' 2017-12-21 jmadill Entry Points: Refactor Extensions Part 1. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=csmartdalton@google.com Change-Id: I4efbac59561c799094623b4f042c945a74bc078a Reviewed-on: https://skia-review.googlesource.com/89060 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* CCPR: Fix Intel crash and un-blacklistGravatar Chris Dalton2017-12-22
| | | | | | | | Bug: skia: Change-Id: I6dca83426fb1199033a0871f965ec622b7f318a0 Reviewed-on: https://skia-review.googlesource.com/88903 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Roll skia/third_party/externals/angle2/ 755a9317f..b6af22b52 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/755a9317ff1e..b6af22b522be $ git log 755a9317f..b6af22b52 --date=short --no-merges --format='%ad %ae %s' 2017-12-15 oetuaho Store TVariable* in TIntermSymbol instead of storing id Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=csmartdalton@google.com Change-Id: I35219b2b3a82d445209729bdc5bfbefefe3458d9 Reviewed-on: https://skia-review.googlesource.com/88901 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Make GrShape recognize horizontal/vertical dashed lines with 0 off intervals ↵Gravatar Brian Salomon2017-12-21
| | | | | | | | | as rrects. Change-Id: Ic29b41911e0185d36093d5352f4494709e8124ba Reviewed-on: https://skia-review.googlesource.com/88428 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Roll skia/third_party/externals/angle2/ beb6dc74a..755a9317f (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/beb6dc74a2bc..755a9317ff1e $ git log beb6dc74a..755a9317f --date=short --no-merges --format='%ad %ae %s' 2017-12-21 jmadill Re-land "Vulkan: Roll loader/validation layers SDK. (2/2)" Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=csmartdalton@google.com Change-Id: I4529fa275fe88df35f375942baa4c8911df34582 Reviewed-on: https://skia-review.googlesource.com/88843 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>