aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Add a SkPixelSerializer SkImage encode variantGravatar fmalita2015-09-03
| | | | | | | R=reed@google.com BUG=skia:4285 Review URL: https://codereview.chromium.org/1310633006
* add interactive xfer sampleGravatar reed2015-09-02
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1323223004
* Testing CQ committer listGravatar rmistry2015-09-02
| | | | | | | | BUG=skia: NOTRY=true TBR= Review URL: https://codereview.chromium.org/1308163007
* Fix bug in ico decodesGravatar msarett2015-09-02
| | | | | | | | | | | Some icos have been looking a bit strange in Gold. Looks like the cause was that we were decoding to kUnpremul accidentally. BUG=skia: Review URL: https://codereview.chromium.org/1321913003
* Moved committer list to chrome-infra-auth and deleted it from the repoGravatar sergiyb2015-09-02
| | | | | | | R=rmistry@chromium.org BUG=chromium:511311 Review URL: https://codereview.chromium.org/1314153006
* Remove unwanted images in GoldGravatar msarett2015-09-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | These extra outputs were caused by recent changes to push_codec_srcs. https://codereview.chromium.org/1327433003/ *** First, I would argue that we do not want to test "native" modes (ex: codec, scanline, etc) to scales that require sampling (ex: 0.1, 0.2, etc). Right now, we are trying to scale jpegs to 0.1, settling for 0.125 as the closest option, and then trying to compare the 0.125 scaled image to the actual 0.1 scaled image in Gold. *** Second, I messed up and caused our test setup to try to decode to kIndex8 and kGray8 "always" instead of only when it is recommended. The bad effect of this happens because we can decode jpegs to kGray8 even if they are color images. Right now in Gold, we have a bunch of untriaged gray versions of color images. The second issue would have been caught if we signaled a fatal failure for invalid conversions. Maybe we should look into this now that 565 is supported everywhere? BUG=skia: Review URL: https://codereview.chromium.org/1314163007
* Give reason while file open failed.Gravatar bungeman2015-09-02
| | | | Review URL: https://codereview.chromium.org/1326743004
* Add new surface flagGravatar jvanverth2015-09-02
| | | | | | TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/1320533005
* Revert of Minor cleanup in GrTessellatingPathRenderer. (patchset #1 id:1 of ↵Gravatar senorblanco2015-09-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1322023002/ ) Reason for revert: Patch is incorrect -- floating point errors can cause zero-area monotone polys to be skipped, resulting in a smaller vertex count than estimated. Reproduce as follows: out/Debug/SampleApp --slide Fuzzer --msaa 4 switch to GPU mode. Result: ../../src/gpu/batches/GrTessellatingPathRenderer.cpp:1500: failed assertion "static_cast<int>(end - verts) == vertexCount" Original issue's description: > Minor cleanup in GrTessellatingPathRenderer. > > Vertex counts are always exact, so don't bother handling the case > where they're different. Just assert. > Rename variables to reflect. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/9389b871c3b0f06bb34626cf9bdbfe0c93779327 TBR=bsalomon@google.com,senorblanco@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1321723006
* Remove GrAddPathRenderers_defaultGravatar joshualitt2015-09-02
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1311673014
* Replace font name table access with standard Skia function.Gravatar caryclark2015-09-02
| | | | | | | | Remove partial name detection. Fix typo in custom deserializer to use the sk_ truncated font name. Review URL: https://codereview.chromium.org/1327683002
* forgot base implGravatar reed2015-09-02
| | | | | | | BUG=skia: TBR=fmalita Review URL: https://codereview.chromium.org/1323173002
* Fix for distancefield text uses override descriptorGravatar joshualitt2015-09-02
| | | | | | BUG=skia:4282 Review URL: https://codereview.chromium.org/1324953002
* VisualBenchTest: Read nanobench_flags.txtGravatar borenet2015-09-02
| | | | | | BUG=skia:4093 Review URL: https://codereview.chromium.org/1314873005
* Specify try_job_retry_config for Skia try jobsGravatar rmistry2015-09-02
| | | | | | | | | | | | | Retry config support was added to the CQ in https://chromereviews.googleplex.com/240527013/ This CL uses the retry config in Skia's cq.cfg file. CQ's default failure_retry_weight is 1. We set it to 2 which will immediately go beyond the try job quota and will not retry for failures. It will retry for transient errors. BUG=chromium:522460 TBR=mtklein NOTRY=true Review URL: https://codereview.chromium.org/1330473002
* Various improvements to CodecSrc testing in dmGravatar msarett2015-09-01
| | | | | | | | | | | | | | | | | | | | | *** Add CodecMode and ScaledCodecMode (in place of NormalMode), so now we test SkCodec's getPixels() and SkScaledCodec's getPixels() *** Don't attempt to test scanline and codec modes using the dimensions that were recommended for SkScaledCodec. *** Change tags so that each scale gets its own output folder. TODO: Make ScanlineMode and ScanlineSubsetMode support kOutOfOrder etc. I think this belongs with the gif CL - I don't want to add test modes that we don't run yet. BUG=skia:4202 BUG=skia:4238 Review URL: https://codereview.chromium.org/1327433003
* Fix bmp bug in ReadHeader()Gravatar msarett2015-09-01
| | | | | | | | | | | | | For BmpMaskCodecs, we need to skip any offset after the header to get to the start of pixel data. Before this fix, we only skipped this data when codecOut is non-NULL (instead of on every call to ReadHeader()). https://gold.skia.org/search?q=1&neg=true&unt=false&query=name%3Drgb16-565pal.bmp_0.200%26name%3Drgb16-565pal.bmp%26name%3Drgb16-565pal.bmp_0.250%26name%3Drgb16-565pal.bmp_0.333%26name%3Drgb16-565pal.bmp_0.375%26name%3Drgb16-565pal.bmp_0.400%26name%3Drgb16-565pal.bmp_0.500%26source_type%3Dimage BUG=skia: Review URL: https://codereview.chromium.org/1318393004
* Experimental: fix documentGravatar halcanary2015-09-01
| | | | | | | | NOTRY=true TBR= Review URL: https://codereview.chromium.org/1324043002
* Experimental: document that cmake + c api example now works in Ubuntu.Gravatar halcanary2015-09-01
| | | | | | | | NOTRY=true TBR= Review URL: https://codereview.chromium.org/1318823011
* Remove an extra newline in documentation.Gravatar halcanary2015-09-01
| | | | | | | TBR= NOTRY=true Review URL: https://codereview.chromium.org/1319363003
* Stop using SkScalerContext::getAdvance() in SkGlyphCache.Gravatar mtklein2015-09-01
| | | | | | | | | | | | | | | | We think it'll simplify things to just always get the full metrics. On most platforms, it's no different, and we think the platforms that do differ (FreeType) will be nearly just as cheap. Removing this distinction helps us make SkGlyphCaches concurrent by removing a state (we-have-only-advances) from its logical state machine. We see no significant changes running SKPs before and after this CL. That makes sense, of course, because the SKPs bake some of this into drawPosText. BUG=skia: Review URL: https://codereview.chromium.org/1321243004
* add preroll to image, for chrome's warmup passGravatar reed2015-09-01
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1301373007
* Restore old NEON blit_mask_d32_a8 methods.Gravatar mtklein2015-09-01
| | | | | | | | | | | | | | As you'll see from the BUG line, we have a strong indication that the new Sk4px methods regress some devices. This restores the old code back as literally as possible while still fitting in SkOpts framework. This is ideally temporary breathing room. We should get an early indication of if those bugs will improve by watching https://perf.skia.org/#4004 BUG=skia:4117,525844,519596,524149 Review URL: https://codereview.chromium.org/1312763009
* Documentation: C API commentsGravatar halcanary2015-09-01
| | | | Review URL: https://codereview.chromium.org/1271023002
* Cmake: fix to make linking work on UbuntuGravatar halcanary2015-09-01
| | | | Review URL: https://codereview.chromium.org/1320443009
* C API: Add SK_API, also documentation of an example.Gravatar halcanary2015-09-01
| | | | | | | | SK_API = __declspec(dllexport) / __attribute__((visibility("default"))) Also, add documentation in experimental/c-api-example/c.md Review URL: https://codereview.chromium.org/1307183006
* Added SkComposeShader GPU implementationGravatar wangyix2015-09-01
| | | | | | | | | | | | moved onCreateGLInstance() to private in GrComposeEffect Added SkComposeShader gpu implementation; composeshader gm is unchanged BUG=skia:4182 TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/1292353005
* CMake tweaksGravatar mtklein2015-09-01
| | | | | | | | | - I think CMake 3.1 is enough for now. - Ubuntu works too. BUG=skia:4269 Review URL: https://codereview.chromium.org/1323093002
* skia: Replace CommandBuffer_ with eglGravatar hendrikw2015-09-01
| | | | | | | I ended up exporting the egl functions directly, so this needs to change on the skia side as well Review URL: https://codereview.chromium.org/1324823002
* Limit lifetime of GrDrawContext objectsGravatar robertphillips2015-09-01
| | | | | | GrDrawContext's are about to become real allocated objects. This CL sets up the machinery so they won't leak. Review URL: https://codereview.chromium.org/1321353002
* Remove GrGpuTraceMarker hooks until we rethink the designGravatar joshualitt2015-09-01
| | | | | | | TBR=bsalomon@google.com BUG=526308 Review URL: https://codereview.chromium.org/1323823003
* GrGLBlend::AppendPorterDuffBlend now supports kClear_ModeGravatar wangyix2015-09-01
| | | | | | BUG=skia:4182 Review URL: https://codereview.chromium.org/1307393005
* Various minor cross-platform changesGravatar jvanverth2015-09-01
| | | | Review URL: https://codereview.chromium.org/1310843007
* SkColorCubeFilter_opts: rounding is actually free here.Gravatar mtklein2015-09-01
| | | | | | | | (Sk4f(float) is statically initializable, unlike the old SkPMFlor(SkPMColor).) BUG=skia:4117 Review URL: https://codereview.chromium.org/1317593007
* Move PathRenderers to batches folderGravatar joshualitt2015-09-01
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1306143005
* Call standard libjpeg/libjpeg-turbo APIsGravatar msarett2015-09-01
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1322623004
* Require Sk4f::toBytes() clampsGravatar mtklein2015-09-01
| | | | | | | | BUG=skia:4117 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;client.skia.android:Test-Android-GCC-Nexus9-CPU-Denver-Arm64-Release-Trybot Review URL: https://codereview.chromium.org/1312053004
* link test to bugGravatar caryclark2015-09-01
| | | | | | | | | | | | | | | | | | | | | | | | crbug.com/526025 includes a minimized SVG test case. Translating that test case into native code (fuzzTNG) did not reproduce the bug. That test case should have not been included with skia issue 1323813003, and is deleted here. Running the minimal test case in a modified version of chrome isolated the bug. The modified version generated the test fuzz763_3 with the edit #define DEBUGGING_PATHOPS_FROM_HOST 1 in src/pathops/SkPathopsOp.cpp line 188. Rename fuzz763_3 to issue_526025 to associate the test with the bug. Note that the bug contains the body of the CL in comment $5. R=reed@google.com Review URL: https://codereview.chromium.org/1315503005
* Make GrTextContext no longer store a GrDrawContextGravatar robertphillips2015-09-01
| | | | | | This, at least, makes GrTextContexts no longer bound to a single GrDrawContext. (Passing in a RenderTarget and praying it matched the DrawContext was always a bit fishy too). Review URL: https://codereview.chromium.org/1320323004
* Image generator-backed SkPictureShaderGravatar fmalita2015-08-31
| | | | | | | | A respin of http://crrev.com/866773002 R=reed@google.com Review URL: https://codereview.chromium.org/1323863002
* Clean up remaining users of SkPMFloatGravatar mtklein2015-08-31
| | | | | | | | | | | | This switches over SkXfermodes_opts.h and SkColorMatrixFilter to use Sk4f, and converts the SkPMFloat benches to Sk4f benches. No pixels should change here, and no code beyond the Sk4f_ benches should change speed. The benches are faster than the old versions. BUG=skia:4117 Review URL: https://codereview.chromium.org/1324743002
* simplify bitmap scaler and cacheGravatar reed2015-08-31
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1320513005
* Move float<->byte conversions into Sk4f.Gravatar mtklein2015-08-31
| | | | | | | | | | | | | | | | | | | This lets us avoid conversions to [0.0, 1.0] space and rounding that aren't necessary for SkColorCubeFilter_opts.h. Dropping rounding on the way back to bytes means we'll see a bunch of off-by-1 diffs. Rough perf effect: SSSE3: 110 -> 93 (~15%) NEON: 465 -> 375 (~20%) This is the beginning of the end for SkPMFloat as an entity distinct from Sk4f. I've kept it for now so I can convert sites one by one and think about how things that really want to keep PM color order will work. BUG=skia:4117 Review URL: https://codereview.chromium.org/1319413003
* Document SkString::resize(int) as destructive.Gravatar bungeman2015-08-31
| | | | | | | | | It is easy to think in some cases that SkString::resize(int) is not destructive, since optimizations mean that most of the time the data is still there after a resize. However, in the general case, the original string's data is lost and the new SkString contains garbage. Review URL: https://codereview.chromium.org/1304833004
* Add empty files to empty targets to appease XCode.Gravatar mtklein2015-08-31
| | | | | | BUG=skia:4117 Review URL: https://codereview.chromium.org/1312703004
* Minor cleanup in GrTessellatingPathRenderer.Gravatar senorblanco2015-08-31
| | | | | | | | | | Vertex counts are always exact, so don't bother handling the case where they're different. Just assert. Rename variables to reflect. BUG=skia: Review URL: https://codereview.chromium.org/1322023002
* Rename flag from "distance field" to "device independent."Gravatar bsalomon2015-08-31
| | | | Review URL: https://codereview.chromium.org/1322433006
* Revert of By default purge resources that haven't been used for 64 flushes ↵Gravatar bsalomon2015-08-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #4 id:60001 of https://codereview.chromium.org/1316233003/ ) Reason for revert: Breaking again Original issue's description: > By default purge resources that haven't been used for 64 flushes > > BUG=skia:4258 > > Committed: https://skia.googlesource.com/skia/+/85047175508a24f43eef49359bed215a2a3bb104 > > R=robertphillips@google.com > > Committed: https://skia.googlesource.com/skia/+/71d0c33068d41878cc3117f3761f49300f6b3d54 > > Committed: https://skia.googlesource.com/skia/+/bd783cd5b62118277b75933c3cd7b9097129259a TBR=robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4258 Review URL: https://codereview.chromium.org/1322753004
* Add a GM for image filters applied to stroked primitives.Gravatar senorblanco2015-08-31
| | | | | | BUG=skia:3194 Review URL: https://codereview.chromium.org/1323573004
* remove duplicate linked list adjustmentGravatar caryclark2015-08-31
| | | | | | | | | | | | | | | | | | | | | The list of intersection points on a curve segment may have entries that can be safely removed when nearby points have nearly the same t value and point value. When a path includes very large curves as well as small ones, as is the case with this fuzzer, additional points may lie between the similar points that do not meet the nearby criteria. After merging the nearby point with its doppelganger, SkOpSegment::moveNearby() unnecessarily set the doppelganger's next pointer to the one following the nearby point. While this usually has no effect, since the merge already updated the linked list, the explicit call removes the additional outlier points from the segment. TBR=reed@google.com BUG=526025 Review URL: https://codereview.chromium.org/1323813003
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-04 22:16:33 +0000