aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Add unit test for SkDashPathEffect::asPoints' cullingGravatar robertphillips2014-11-05
| | | | | | This is a follow on to (Crop the fast path dashed lines to the cull rect - https://codereview.chromium.org/699623003/) Review URL: https://codereview.chromium.org/701133002
* Whitelist intentionally racy TRACE_EVENT reads and writes.Gravatar mtklein2014-11-05
| | | | | | | | | | | | | | | | | | | | Chrome's tracing framework appears to be intentionally racy on its quick-reject checks, trading some data loss for better performance when disabled. People will never notice the data loss, but TSAN does. Let's assuage TSAN with some annotations. The 'volatile' val in SK_ANNOTATE_UNPROTECTED_WRITE was making this not compile, but that volatile doesn't really make sense there: the value we're writing is not what we care about, it's the destination. CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot No API changes. TBR=reed BUG=skia: Review URL: https://codereview.chromium.org/702883002
* Revert of Bisect Mac performance regression. (patchset #6 id:100001 of ↵Gravatar egdaniel2014-11-05
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/693213002/) Reason for revert: Block deps roll by breaking webkit test hit-test-counts on mac. Original issue's description: > With https://chromium.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 blink_perf.layout regressed. It appears that the typeface cache is being missed. This is a partial revert of the Skia change which reverts the smallest amount of code to restore performance. > > BUG=chromium:425566 > > Committed: https://skia.googlesource.com/skia/+/47eda52e8fb88f0725b401762a3e0bddc98e9fb3 TBR=reed@google.com,bungeman@google.com NOTREECHECKS=true NOTRY=true BUG=chromium:425566 Review URL: https://codereview.chromium.org/683753003
* Cleanup: Remove unused InstallNewHandler() function from SkGraphics.Gravatar tfarina2014-11-05
| | | | | | | | BUG=None TEST=None R=bsalomon@google.com Review URL: https://codereview.chromium.org/701813006
* Workaround for PowerVR clear issue.Gravatar bsalomon2014-11-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/701573002
* Add suppression to valgrind.supp for fun:FcConfigEvaluate.Gravatar bungeman2014-11-05
| | | | | | | Any allocation under FcConfigValues will be 'lost'. Update the valgrind suppression to reflect this. Review URL: https://codereview.chromium.org/703893003
* Bug fix for cull_line in SkDashPathEffect.Gravatar egdaniel2014-11-05
| | | | | | | | | | | In cull_line we must also check if both points are the same. Otherwise we fail the assert in the else "SkASSERT(dy && !dx)". This is currently blocking the roll as it fails a webkit test. BUG=skia: Review URL: https://codereview.chromium.org/703783002
* Crop the fast path dashed lines to the cull rectGravatar robertphillips2014-11-04
| | | | | | | | | | | | | | | | | | | | | | | Without: maxrss loops min median mean max stddev samples config bench 56M 1 13.3ms 13.6ms 13.6ms 14.2ms 2% Ooooo..... 8888 GM_dashing5_bw 56M 13 390us 417us 416us 459us 5% ooooO..o.o gpu GM_dashing5_bw 56M 1 13.4ms 13.9ms 14.1ms 15ms 3% Oooo..ooOo 8888 GM_dashing5_aa 56M 13 402us 421us 416us 425us 2% Ooo.ooOOOO gpu GM_dashing5_aa With: 40M 1 1.53ms 1.54ms 1.54ms 1.55ms 0% oo.O...o.. 8888 GM_dashing5_bw 40M 12 407us 412us 415us 445us 3% ...Oo..... gpu GM_dashing5_bw 40M 1 1.7ms 1.7ms 1.7ms 1.72ms 0% o.O....... 8888 GM_dashing5_aa 43M 13 405us 409us 409us 415us 1% ooo.Ooo..o gpu GM_dashing5_aa The GM images (including the new one) are the same with and without this CL. BUG=428296 Review URL: https://codereview.chromium.org/699623003
* DFText: fix placement of glyphs when we fall back to pathsGravatar jvanverth2014-11-04
| | | | | | | | Rendering a glyph with a path wants to place it at the (sx, sy) we get as input to the method, but we add (dx, dy) for the clipRect check. Hence, we need to subtract that out before we render the path. Review URL: https://codereview.chromium.org/699283003
* update slidesGravatar reed2014-11-04
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/686853005
* Revert of Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe ↵Gravatar piotaixr2014-11-04
| | | | | | | | | | | | | | | | | | | | | | (patchset #8 id:140001 of https://codereview.chromium.org/613673005/) Reason for revert: The patch is breaking the telemetry blink build on some windows configurations Original issue's description: > Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe > > Depend on https://codereview.chromium.org/663233002 > > BUG=skia:2947 > > Committed: https://skia.googlesource.com/skia/+/687732fe046c9cfec940f2d7f661cd97651d10a8 > > Committed: https://skia.googlesource.com/skia/+/9bb7539a59ab15749fe26fecfec05330cffae684 BUG=skia:2947, 426708 Review URL: https://codereview.chromium.org/705633002
* Additional baselines for 4b86bacb0428.Gravatar bungeman2014-11-04
| | | | The Nexus9 lacked a trybot at the time.
* Add tracing to the SkCanvas drawFoo() methods to find long draw ops.Gravatar danakj2014-11-04
| | | | | | BUG=skia:3088 Review URL: https://codereview.chromium.org/702473004
* PictureRecordBench's benchmarks are no longer relevant with SkRecord.Gravatar mtklein2014-11-04
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/698163004
* add more typeface methods to luaGravatar reed2014-11-04
| | | | | | | | BUG=skia: NOTRY=True TBR= Review URL: https://codereview.chromium.org/697053004
* Allow all font weights on Android and respect overrides.Gravatar bungeman2014-11-04
| | | | | | | This removes the code which forces 400 and 700 weights only, and also overrides the font weight with the configured weight. Review URL: https://codereview.chromium.org/694533006
* With ↵Gravatar bungeman2014-11-04
| | | | | | | | https://chromium.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 blink_perf.layout regressed. It appears that the typeface cache is being missed. This is a partial revert of the Skia change which reverts the smallest amount of code to restore performance. BUG=chromium:425566 Review URL: https://codereview.chromium.org/693213002
* Fix PictureTest for new GPU vetoGravatar jvanverth2014-11-04
| | | | | | NOTREECHECKS=true Review URL: https://codereview.chromium.org/702733002
* Include SkTypes so that SK_SUPPORT_GPU is meaningful.Gravatar scroggo2014-11-04
| | | | | | | | | | For the Android framework build, we get our defines from SkUserConfig, rather than from the makefile, so we need to include it (via SkTypes) before we can use our defines. Fixes Android framework build. Review URL: https://codereview.chromium.org/700893002
* Enable distance field path rendering in Chrome.Gravatar jvanverth2014-11-04
| | | | | | | | | | - Add stat tracking for df-renderable paths - Modify GPU rasterization veto to account for df-renderable paths - Remove #define hiding df paths from Chromium and Android BUG=skia:2935 Review URL: https://codereview.chromium.org/685113003
* Roll common to d7c2e2b9464.Gravatar bungeman2014-11-04
| | | | | | | | Picks up code removal and changes to download_file. https://skia.googlesource.com/common.git/+log/5eee100ab..d7c2e2b9464 Review URL: https://codereview.chromium.org/700763003
* removing setVertexArraySource from drawtargetGravatar joshualitt2014-11-04
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/699733002
* Separate JSON functions from DMWriteTask.Gravatar scroggo2014-11-04
| | | | | | | | | Add JsonWriter, which handles Json output from DM, in preparation for adding json output for tests. This change should not affect behavior. BUG=skia:2454 Review URL: https://codereview.chromium.org/702513003
* Fix layer cache memory leakGravatar robertphillips2014-11-04
| | | | | | The issue was that, with caching disabled, the layer cache code was removing layers outside of a purge (i.e., in unlock) but not correctly cleaning up the GrPictureInfo objects (as is done in purgePlot). Review URL: https://codereview.chromium.org/703643002
* remove dead SK_DISABLE_DASHING_OPTIMIZATION flagGravatar reed2014-11-04
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/698003004
* Update SKP versionGravatar skia.buildbots2014-11-03
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/698223002
* update slide contentGravatar reed2014-11-03
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/698563004
* add textblobs to luaGravatar reed2014-11-03
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/688363003
* update baselines and ignores for texture_domainGravatar joshualitt2014-11-03
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/697233003
* Turn SkTaskGroups back on.Gravatar mtklein2014-11-03
| | | | | | | | | | | | | Revert "Disable SkTaskGroup in SkMultiPictureDraw temporarily." Revert "Revert harder, removing SkTaskGroup.cpp from core temporarily." NOTREECHECKS=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2100c5ed7a5e5470a04e7af7309d8bd3fc4249f7 Review URL: https://codereview.chromium.org/687263007
* Manually load CONDITION_VARIABLE methods on Windows, checking for failure (XP).Gravatar mtklein2014-11-03
| | | | | | | | | | | | Tested by running DM on XP. Before this patch, it fails at startup (even just out/Debug/dm --help). Now it asserts for other reasons later on in user code, which is just fine by me. The net effect is that SkTaskGroups will always be synchronous on XP. That's not ideal, but a step up from crashing. CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Release-Trybot,Test-Win7-ShuttleA-HD2000-x86_64-Release-Trybot BUG=skia: Review URL: https://codereview.chromium.org/700683002
* Export (SK_API) SkSurfacePropsGravatar fmalita2014-11-03
| | | | | | R=reed@google.com Review URL: https://codereview.chromium.org/693973003
* Cleanup: Remove SimpleiOSApp xcode project file.Gravatar tfarina2014-11-03
| | | | | | | | | | | There is already an GYP version for it in: https://skia.googlesource.com/skia/+/master/gyp/SimpleiOSApp.gyp BUG=None TEST=None R=caryclark@google.com Review URL: https://codereview.chromium.org/691133004
* move SkTextBox into utilsGravatar reed2014-11-03
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/696293005
* Optimize SkRect::sort()Gravatar qiankun.miao2014-11-03
| | | | | | | | | This optimization can reduce comparison and assignments. For geo_rect_sort benchmark, performance improved to 1.63us from 3.28us. BUG=skia: Review URL: https://codereview.chromium.org/695443005
* Rename and clarify semantics of GrContext::resolveRenderTarget.Gravatar bsalomon2014-11-03
| | | | Review URL: https://codereview.chromium.org/696293004
* Temporary fix to remove drawrect call from GpuGLGravatar joshualitt2014-11-03
| | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/d4a5c2028117c100ccf44263c0118a0b4745f627 Review URL: https://codereview.chromium.org/694933002
* Improve quality of distance field renderingGravatar jvanverth2014-11-03
| | | | | | | | | | - Update spacing of LODs to get better results scaling up to 256 - Remove unnecessary "bolding" from dftext - Add debug colors for dftext LODs BUG=skia:2933,skia:2935 Review URL: https://codereview.chromium.org/703463002
* Detect Mesa OpenGL ESGravatar derekf2014-11-03
| | | | | | Original-Author: Henry Song <henrysong@samsung.com> Review URL: https://codereview.chromium.org/700633002
* Revert changes to GrContext::resolveRenderTargetGravatar bsalomon2014-11-03
| | | | | | TBR=joshualitt@google.com,egdaniel@google.com Review URL: https://codereview.chromium.org/700483003
* Add comments to SkRecordDraw to help people follow.Gravatar danakj2014-11-03
| | | | | | | | | | The calls to visit() to execute the SkRecord::Draw::operator() code path is not clear to read, so adding some comments to help other new-comers follow this through to the SkCanvas calls. R=mtklein@chromium.org Review URL: https://codereview.chromium.org/695403003
* Test factory uses the inorder draw bufferGravatar joshualitt2014-11-03
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/696353002
* add bullets to slidesGravatar reed2014-11-03
| | | | | | | | BUG=skia: TBR= NOTRY=True Review URL: https://codereview.chromium.org/699723002
* Don't allow renderTarget==NULL to GrContext::clear() and friends.Gravatar bsalomon2014-11-03
| | | | Review URL: https://codereview.chromium.org/680413005
* rebase and ignore dash cubics winnvprGravatar joshualitt2014-11-03
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/691803005
* release expectations rebaseGravatar joshualitt2014-11-03
| | | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/700613002
* rebase nvpr expectationsGravatar joshualitt2014-11-03
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/688413004
* Remove GrGLTexIDGravatar bsalomon2014-11-03
| | | | | | BUG=skia:2889 Review URL: https://codereview.chromium.org/695133003
* ignoring degenerat segments across all nvprmGravatar joshualitt2014-11-03
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/696373002
* patch from issue 697743002Gravatar mtklein2014-11-03
| | | | | | | | | | working The key here was to get everything into a single library. Our shared library build is the easiest way to do that. Some light skimming online makes it look like perhaps cgo requires shared libraries, so that may be at play here too. BUG=skia: Review URL: https://codereview.chromium.org/698943002
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-19 14:29:41 +0000