aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Use SkArenaAlloc instead of SkSmallAllocator in the SkAutoBlitterChoose code.Gravatar Herb Derby2017-02-07
| | | | | | | | | TBR=reed@google.com Change-Id: Iefb044bf7657fbf982f23aa91a3f4d013ce2c626 Reviewed-on: https://skia-review.googlesource.com/7786 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Fix canvas size of new tiled bitmap GMGravatar Brian Osman2017-02-07
| | | | | | | | | | | Copy-paste error. BUG=skia: Change-Id: Ifebe23ee7ac4a46e351f10ebe0f4c68490bfeb44 Reviewed-on: https://skia-review.googlesource.com/8110 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Use SkVertices for tessellated spot and ambient shadow rendering.Gravatar Brian Salomon2017-02-07
| | | | | | | Change-Id: Ia81e7a771d345286533752708e4304c1ae3b97c9 Reviewed-on: https://skia-review.googlesource.com/8042 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stan Iliev <stani@google.com>
* gen_tasks.go: Add --builder_name_schema flagGravatar Eric Boren2017-02-07
| | | | | | | | | | BUG=skia:6070 Change-Id: I66ac3057f7863f822445d5163e54ca3b11755068 Reviewed-on: https://skia-review.googlesource.com/8107 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* ShadowUtils: Fix umbra inset calculation when determining if umbra is fully ↵Gravatar Brian Salomon2017-02-07
| | | | | | | | | occluded. Change-Id: Id0db49ad45b341d39abf7ee532ecc0799a832192 Reviewed-on: https://skia-review.googlesource.com/8079 Commit-Queue: Stan Iliev <stani@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* Add GM to exercise some of the darker corners of SkMagnifierImageFilterGravatar Robert Phillips2017-02-07
| | | | | | | | | | | An upcoming CL (https://skia-review.googlesource.com/c/7995/ (Remove asTextureRef from SkSpecialImage & update effects accordingly)) modifies some untested portions of the SkMagnifierImageFilter. This adds a test to prevents regressions. Change-Id: I9fa406f699e39fa393212e7f63a457b015b36edb Reviewed-on: https://skia-review.googlesource.com/8023 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Add 64-bit iOS bots.Gravatar Mike Klein2017-02-07
| | | | | | | | | | | Because it's 2017. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-iOS-Clang-iPadMini4-GPU-GX6450-arm64-Debug,Perf-iOS-Clang-iPadMini4-GPU-GX6450-arm64-Release,Test-iOS-Clang-iPadMini4-GPU-GX6450-arm64-Debug,Test-iOS-Clang-iPadMini4-GPU-GX6450-arm64-Release Change-Id: I8708585a3416962d2563c17e6cc357da48ad9519 Reviewed-on: https://skia-review.googlesource.com/8106 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add a fast case for copying vertices in GrDrawVerticesOp.Gravatar Brian Salomon2017-02-07
| | | | | | | | | | | Uses Sk2f to apply a translation-only matrix when the vertex attributes contain only positions and colors. We should look at how to generalize this for other draw vertices cases and other ops. Change-Id: I5eb692982dc216b1c0a71209c969672b0562143c Reviewed-on: https://skia-review.googlesource.com/8103 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Fix rounding error with tiled bitmap drawsGravatar Brian Osman2017-02-06
| | | | | | | | | | | | | | | We were snapping the top-left of the destination rectangle to integers, but using the original (fractional) size. This led to us losing rows or columns of pixels at the first tile boundary. Also added a GM that demonstrates the bug (now renders correctly). BUG=skia: Change-Id: I50629dab9dd90fedad2c7e3393a1b1d1c7a8d45e Reviewed-on: https://skia-review.googlesource.com/8102 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* GrTessellator (AA): improve antialiasing of thin shapes.Gravatar Stephen White2017-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (Long description, but actually quite a small change.) This is the first change inspired by the "straight skeleton" algorithm. This algorithm gives us a mental model to describe the edge-antialiasing problem: consider the shape as walls of a house, the outer alpha geometry is a 45-degree "roof" up to a flat top at a height of 1.0 (the filled interior). The faces of the sloping roof join at the bisectors between the inner and outer points. When the shape being drawn is sufficiently thin, there should be no flat roof, and the sloping roof meets at an edge (the straight skeleton). This patch detects cases where an edge inverts on stroking, which indicates that the flat roof has turned inside out, and should be reduced to a point instead. The model above describes what to do: follow down the "roof" along the bisectors to their intersection. This is the point to which an inverted edge should be collapsed. Fortunately, the bisector edges are easy to compute: they're the connector edges joining inner and outer points. Linearly interpolating the distance from the top to the bottom point gives the alpha we should use to approximate coverage. Now that we are correctly handling inversions, bevelling outer edges is no longer necesary, since pointy outer edges won't cause nasty opaque artifacts. A couple of other quality improvements: on intersection, always lerp the alpha of connector edge, even if the opposite edge is an inner edge (later, when these edges are collapsed, we need this value to compute the correct alpha). Fix the case where an intruding outer vertex intersects exactly with an inner edge by maxing its alpha with the computed value in check_for_intersection(). Finally, we also no longer round off the intersections produced by Line::intersect(), since it introduces a loss of quality with no measurable performance benefit. Change-Id: I6fd93df3a57fffc0895e8cb68adbdba626ded0f1 Reviewed-on: https://skia-review.googlesource.com/8028 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephan White <senorblanco@chromium.org>
* Make recipes upload results to bucket specified in top-level configGravatar Eric Boren2017-02-06
| | | | | | | | | BUG=skia:6070 Change-Id: I67c040239ca2cf77a7430aa1a45b1bb69fef3b91 Reviewed-on: https://skia-review.googlesource.com/8069 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Set IOS_BUNDLE_ID in recipes.Gravatar Mike Klein2017-02-06
| | | | | | | | | | | | Instead of hard coding to com.google.dm, which will only work for Test bots, set it in the environment when we know which bundle we're using. CQ_INCLUDE_TRYBOTS=skia.primary:Test-iOS-Clang-iPadMini4-GPU-GX6450-arm-Release,Perf-iOS-Clang-iPadMini4-GPU-GX6450-arm-Debug Change-Id: I43a0c832ff70e3b3c9bb987173784f4b6b992403 Reviewed-on: https://skia-review.googlesource.com/8076 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Make workaround for std::unique_ptr<const T[]> bug in old libstdc++ work.Gravatar Brian Salomon2017-02-06
| | | | | | | | | | BUG=skia: Change-Id: I58a07d4ce35bdd03e7edcf50e88d9982b3885546 Reviewed-on: https://skia-review.googlesource.com/8101 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Work around broken std::unique_ptr<const T[]> constructor from ↵Gravatar Brian Salomon2017-02-06
| | | | | | | | std::unique_ptr<T>&& in older libstdc++. Change-Id: Ie4190800369515168203ff98b3e3fe0e2d790f1a Reviewed-on: https://skia-review.googlesource.com/8072 Reviewed-by: Robert Phillips <robertphillips@google.com>
* Update image cipd version.Gravatar Joe Gregorio2017-02-06
| | | | | | | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=8083 Change-Id: Ie3750b6a4b5d49e2b45dc9b9a5f2de8da8d31c49 Reviewed-on: https://skia-review.googlesource.com/8083 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Joe Gregorio <jcgregorio@google.com>
* Add sk_sp make variant to SkArenaAlloc.Gravatar Herb Derby2017-02-06
| | | | | | | | | | R=bungeman@google.com BUG=skia: Change-Id: Iec588cb6946f0230ff3d3ec46499c365aa6b8d09 Reviewed-on: https://skia-review.googlesource.com/8067 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Revert "Added dead variable / code elimination to skslc."Gravatar Ethan Nicholas2017-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 113628d76176a1ab3e6719c59efff23cd10ab213. Reason for revert: Looks to have caused https://bugs.chromium.org/p/chromium/issues/detail?id=688939 Original change's description: > Added dead variable / code elimination to skslc. > > BUG=skia: > > Change-Id: Ib037730803a8f222f099de0e001fe06ad452a22c > Reviewed-on: https://skia-review.googlesource.com/7584 > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > Reviewed-by: Ben Wagner <benjaminwagner@google.com> > TBR=egdaniel@google.com,benjaminwagner@google.com,ethannicholas@google.com,reviews@skia.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG=skia: Change-Id: I85599e4ca2bc6bfd782edc163f67b64195d6ae65 Reviewed-on: https://skia-review.googlesource.com/8077 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Have ShadowTessellators transform path; add SkShadowTessellator base classGravatar Jim Van Verth2017-02-06
| | | | | | | | | BUG=skia:6119 Change-Id: I37639ebab43c9f32f48d2d7dbb8d4619efb9b09e Reviewed-on: https://skia-review.googlesource.com/8061 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Revert "Allow conversion from non-opaque to opaque"Gravatar Matt Sarett2017-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit bfe8dca7dfdd9cafbccba0a637f2fcd58c7a54fb. Reason for revert: I believe I've fixed all the call sites, so this is now ok. Original change's description: > Allow conversion from non-opaque to opaque > > BUG:683787 > > Change-Id: I1b78cc8d1b5d3917a2a952da036b93022e99e053 > Reviewed-on: https://skia-review.googlesource.com/7374 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Matt Sarett <msarett@google.com> > TBR=msarett@google.com,robertphillips@google.com,reviews@skia.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I2369c9b81321ca83a7063bb85e66ddbc03914d2b Reviewed-on: https://skia-review.googlesource.com/8073 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
* Fix two bugs when deciding to tile. Large images were always tiling.Gravatar Brian Osman2017-02-06
| | | | | | | | | | | | | | | | | | usedTileBytes was actually usedTileTexels, so we underestimated how much of the image we were using by a factor of 4. Then, to determine if we were using more than 50% of the image, we wrote: usedTileBytes < 2 * bmpSize; That meant we were off by another factor of 4. BUG=skia: Change-Id: Iba2acc75c5e7603543f05e4473b73f76a2937d7a Reviewed-on: https://skia-review.googlesource.com/8063 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* SkXPS: new document API.Gravatar Hal Canary2017-02-06
| | | | | | | | | | | | Now requires a IXpsOMObjectFactory pointer. This will allow sandboxing to be used in Chromium. (Chrome will create a IXpsOMObjectFactory, then go into sandbox mode, then call SkDocumenent::MakeXPS().) Change-Id: Ic4b48d4b148c44e188d12a9481fb74735546528a Reviewed-on: https://skia-review.googlesource.com/8052 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Reland "Respect canvas size and frame offset in webp decoder"Gravatar Matt Sarett2017-02-06
| | | | | | | | | | | | | | Original Change Reviewed At: https://skia-review.googlesource.com/c/7800 CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-MSAN BUG=skia:6185 Change-Id: I92baa9070e15ef3c62dd347c08c906c2715dda10 Reviewed-on: https://skia-review.googlesource.com/8050 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* SK_USE_SDL is never definedGravatar Hal Canary2017-02-06
| | | | | | | | | This CL also removes dead code, SkOSWindow_SDL.cpp. Change-Id: I659dc271a4bcceba7fe29ac5ac6e79d684153870 Reviewed-on: https://skia-review.googlesource.com/8070 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Hal Canary <halcanary@google.com>
* Get linux vulkan running on Intel NUCGravatar Kevin Lubick2017-02-06
| | | | | | | | | | | | | | | | | | | | | | | | This CL includes a few things. First, it creates two CIPD assets, a Debug and Release version of the Linux Vulkan Intel Driver. The driver is still young, so the Debug version helps us submit better bugs to the developers. The current version is Mesa 13.04: ftp://ftp.freedesktop.org/pub/mesa/13.0.4/ Second, it fixes the GN flavor to not purge out all environment variables - a leftover from the GYP -> GN migration. Third, it sets environment variables on both Test and Perf such that the vulkan sdk, libraries and drivers all linked in from their homes in CIPD. BUG=skia:6133 Change-Id: I9a999e24a0203ab7a9f4733bee1110b79e616935 Reviewed-on: https://skia-review.googlesource.com/7994 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Remove unused files in third_party/libsdl.Gravatar Mike Klein2017-02-06
| | | | | | | | Change-Id: I44c95341e7bc631322a9802bce3fdc5a0e8c4bb5 Reviewed-on: https://skia-review.googlesource.com/8066 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
* Make iOS main() functions normal.Gravatar Mike Klein2017-02-06
| | | | | | | | | | | The weird foo_mains are no longer needed when we build with GN. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Mac-Clang-arm-Debug-iOS Change-Id: Iae50696741e0dc277d96dda4968a1ae41cb17c8a Reviewed-on: https://skia-review.googlesource.com/8064 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Stephan Altmueller <stephana@google.com>
* Clean up more references to GYP.Gravatar Mike Klein2017-02-06
| | | | | | | | | | Delete files only used by GYP, and files that used GYP. Neither can possibly be actively used. Beyond that, just a couple doc tweaks. Change-Id: I0220d7226e7bb9ed7c54a7d8f2906a718313c521 Reviewed-on: https://skia-review.googlesource.com/8062 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Hal Canary <halcanary@google.com>
* Add refcnt'ed immutable vertices class for SkCanvas::drawVertices.Gravatar Brian Salomon2017-02-06
| | | | | | | Change-Id: I44a62f5efc674d0adbbf4a33690c3ded9fab3803 Reviewed-on: https://skia-review.googlesource.com/8040 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* SkXPS: Begin refactoring SkXPSDeviceGravatar Hal Canary2017-02-06
| | | | | | | | | | | | | | | | | | | | | | A later CL will move all document-level fields and methods into SkXPSDocument. * SkXPSDocument cnstructor requires a xps factory ptr. * All device layers share ownership of a single factory. * renames SkDocument_XPS to the easier-to-say SkXPSDocument. * Moves autocoinitialize to DM. TODO: pipe the IXpsOMObjectFactory* into the SkDocument api. No change in rendered documents. Change-Id: I8a4680a3603951b1ce5f6c1de48714d4902061a9 Reviewed-on: https://skia-review.googlesource.com/7998 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Fix getMaxResidentSetSizeMB() on iOS.Gravatar Mike Klein2017-02-06
| | | | | | | | | It's reporting numbers rather too large to be plausible. Change-Id: I09a32ebcf6d5c9cbab18d2099cfd394efe650b24 Reviewed-on: https://skia-review.googlesource.com/8055 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add back a gaggle of iOS bots.Gravatar Mike Klein2017-02-06
| | | | | | | | | | | These should match the old ones I removed last week. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Mac-Clang-arm-Debug-iOS,Build-Mac-Clang-arm64-Debug-iOS,Build-Mac-Clang-arm64-Release-iOS Change-Id: I2d56332c11cdd410ab6e60d888231cf7ecd5eafd Reviewed-on: https://skia-review.googlesource.com/8051 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* remove all GYP filesGravatar Hal Canary2017-02-06
| | | | | | | Change-Id: I66e4fb028664f1e20cd307da0a784ff5d7b9eb5e Reviewed-on: https://skia-review.googlesource.com/8056 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* start removing uses of SkScalarMulGravatar Mike Reed2017-02-06
| | | | | | | | | BUG=skia:6197 Change-Id: Ic444c7ee4ca547f483dc8232dcacd6d4ba87d913 Reviewed-on: https://skia-review.googlesource.com/8041 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Reed <reed@google.com>
* iOS: cd into Documents folder at startupGravatar Mike Klein2017-02-06
| | | | | | | | | CQ_INCLUDE_TRYBOTS=skia.primary:Test-iOS-Clang-iPadMini4-GPU-GX6450-arm-Release Change-Id: I7beadad742bc9444491c7a315a827297a636d70d Reviewed-on: https://skia-review.googlesource.com/8049 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Start updating iOS docs.Gravatar Mike Klein2017-02-06
| | | | | | | | | | | | This removes the docs for the old GYP-based local development and replaces them with ones for GN-based development. I have not yet updated the docs for iOS on the bots... still in flux. Change-Id: I1f9c5c1a3331ae192dc08c614ef7da26924f808e Reviewed-on: https://skia-review.googlesource.com/8002 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add toXYZD50() to SkColorSpace APIGravatar Matt Sarett2017-02-06
| | | | | | | | | | BUG=skia: Change-Id: I996877c9482453fc5ff58b0f66fa29715bea2191 Reviewed-on: https://skia-review.googlesource.com/8024 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Revert "Respect canvas size and frame offset in webp decoder"Gravatar Robert Phillips2017-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0f33970c8d950a68b7d83cc626ac0500953d6b15. Reason for revert: msan complaint Original change's description: > Respect canvas size and frame offset in webp decoder > > BUG=skia:6185 > > Change-Id: Id543cb689a5e33b800ebbc18f4a234e78a4c4298 > Reviewed-on: https://skia-review.googlesource.com/7800 > Commit-Queue: Matt Sarett <msarett@google.com> > Reviewed-by: Leon Scroggins <scroggo@google.com> > TBR=borenet@google.com,msarett@google.com,scroggo@google.com,reviews@skia.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG=skia:6185 Change-Id: Ie01dc7d7ebfebe36a235335d0d8cb28bccb2ecff Reviewed-on: https://skia-review.googlesource.com/8046 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Roll recipe DEPSGravatar Eric Boren2017-02-06
| | | | | | | | | BUG=skia: Change-Id: Ie29ddf2e13149b5904817f244aca87da9bfcba0c Reviewed-on: https://skia-review.googlesource.com/8045 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Remove unused assignment in SkScan::AntiFillXRect.Gravatar Jeremy Roman2017-02-05
| | | | | | | | | Found by static analysis. Change-Id: I566da96938a735d29acc854cd700fcb944bc09fc Reviewed-on: https://skia-review.googlesource.com/8026 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Update SKP versionGravatar UpdateSKPs2017-02-05
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I5d0141c2727b59e7453df8a69b6020f4c2957894 Reviewed-on: https://skia-review.googlesource.com/8027 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Respect canvas size and frame offset in webp decoderGravatar Matt Sarett2017-02-03
| | | | | | | | | BUG=skia:6185 Change-Id: Id543cb689a5e33b800ebbc18f4a234e78a4c4298 Reviewed-on: https://skia-review.googlesource.com/7800 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Improved SkShadowUtils cachingGravatar Brian Salomon2017-02-03
| | | | | | | | | | | | | Multiple ambient and spot shadows can be cached for each geometry. Spot shadows can be reused when x,y light offset is different. We categorize spot shadows for rrects as either transparent, opaque with partial umbra occlusion, or opaque with full umbra occlusion and use that to improve cache performance. Change-Id: Id530bdaa5092edb46c8f584979090fbb766307fc Reviewed-on: https://skia-review.googlesource.com/7987 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Disable unpremul f16 image testsGravatar Matt Sarett2017-02-03
| | | | | | | | | | | | | | Testing premul f16 is enough test coverage, and we aren't doing this correctly right now anyways (the drawing code assumes a premul bitmap, we would need to premultiply after the unpremul decode). BUG=skia: Change-Id: I798f56db67faadd0348974453a05cd726b9a509c Reviewed-on: https://skia-review.googlesource.com/8020 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* iOS: set up device dirs to be relativeGravatar Mike Klein2017-02-03
| | | | | | | | | | | Hopefully this get things pushed to and reading from directories under com.google.dm's Documents. I've hardcoded to DM's app for now. CQ_INCLUDE_TRYBOTS=skia.primary:Test-iOS-Clang-iPadMini4-GPU-GX6450-arm-Release Change-Id: Iea54b3604b65551e4a486b50d6c7ea9aba26f869 Reviewed-on: https://skia-review.googlesource.com/8004 Reviewed-by: Mike Klein <mtklein@chromium.org>
* Revert "Revert "Don't instantiate shaders with non-invertible local matrix""Gravatar Florin Malita2017-02-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0e86725ba4f667056ff1ef65275165853a47303b. Reason for revert: landed Blink fix, should pass layout tests now Original change's description: > Revert "Don't instantiate shaders with non-invertible local matrix" > > This reverts commit ebfbba9bbdacd754c8ad7429ee066f53f17bc66b. > > Reason for revert: breaks chrome blink tests for linux_trusty_blink_rel > > Original change's description: > > Don't instantiate shaders with non-invertible local matrix > > > > Change-Id: If11f7d57cbf45929632d858f91c02d8f5fa9f442 > > Reviewed-on: https://skia-review.googlesource.com/7885 > > Reviewed-by: Mike Reed <reed@google.com> > > Commit-Queue: Florin Malita <fmalita@chromium.org> > > > > TBR=fmalita@chromium.org,reed@google.com,reviews@skia.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I41c5513523c27dc4bad68008f08369185897b7a2 > Reviewed-on: https://skia-review.googlesource.com/7948 > Commit-Queue: Hal Canary <halcanary@google.com> > Reviewed-by: Hal Canary <halcanary@google.com> > TBR=halcanary@google.com,reviews@skia.org,fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I373ea6c61a256fd8cfbfb34f8b2d39a3ff8109db Reviewed-on: https://skia-review.googlesource.com/8003 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* expose new tight-bounds method on SkPathGravatar Mike Reed2017-02-03
| | | | | | | | | BUG=skia: Change-Id: Ie50df49c1758af203042a84dc2cd505046373d2c Reviewed-on: https://skia-review.googlesource.com/7996 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Restore ios_flavor.Gravatar Mike Klein2017-02-03
| | | | | | | | | | | Just like Android, there's enough special ceremony needed to move files to and from iOS devices that this reads most clearly as its own flavor. CQ_INCLUDE_TRYBOTS=skia.primary:Test-iOS-Clang-iPadMini4-GPU-GX6450-arm-Release Change-Id: I01c8e5494c364cc61e219568f022219f7c3f5fdc Reviewed-on: https://skia-review.googlesource.com/7988 Reviewed-by: Mike Klein <mtklein@chromium.org>
* Make shadow tessellators fail gracefully and add unit test for this.Gravatar Brian Salomon2017-02-03
| | | | | | | Change-Id: I42a9d06a18928588347a6dea2f6150518ba29aa8 Reviewed-on: https://skia-review.googlesource.com/7886 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* GrTessellator (AA): Fix for missing fill artifacts.Gravatar Stephen White2017-02-03
| | | | | | | | | | | | | | | | | | | | Some regions were being incorrectly filled due to setting connector edges winding to zero *after* merging collinear edges. This would cause the merge to add the wrong winding value. Putting the adjust before the call to merge_collinear_edges() fixes the problem. Also, some pixels were not getting coverage due the inner edge being +1 winding. Using -2 winding for inner edges ensure the interior regions are -1 winding, which gives coverage in more cases of self-intersection. This required flipping the comparisons on the intruding-vertices workaround. BUG=skia: Change-Id: I216fa3d30c196a6b7773637e48802f6572c993c7 Reviewed-on: https://skia-review.googlesource.com/7962 Commit-Queue: Stephan White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Initialize some more variables in SpotShadowTessellatorGravatar Jim Van Verth2017-02-03
| | | | | | | | | | BUG=skia:6119 Change-Id: Id3a3042df6254e3367713b82f3b08257e0be71b1 Reviewed-on: https://skia-review.googlesource.com/7992 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>