aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* GrTessellator (AA): restore rounding in Line::intersect().Gravatar Stephen White2017-03-02
| | | | | | | | | | | | | | | | | | I removed this in https://skia-review.googlesource.com/8028, but that was actually just masking a problem properly fixed in https://skia-review.googlesource.com/8364. Now that it is fixed, we can restore the rounding, which actually improves performance by 5-10% on Canvas Arcs (when run with the tess verb limit disabled). NOTE: this change will affect many GMs, including strokes_poly, addarc, parsedpaths, dashcubics, beziers, nested_aa, etc. BUG=skia: Change-Id: Id10f82e35a344247cab27e6d59a0dd2e11c9944d Reviewed-on: https://skia-review.googlesource.com/9051 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* SkJumper: handle the <kStride tail in AVX+ mode.Gravatar Mike Klein2017-03-02
| | | | | | | | | | | | | | | | | | | We have plenty general purpose registers to spare on x86-64, so the cheapest thing to do is use one to hold the usual 'tail'. Speedups on HSW: SkRasterPipeline_srgb: 292 -> 170 SkRasterPipeline_f16: 122 -> 90 There's plenty more room to improve here, e.g. using mask loads and stores, but this seems to be enough to get things working reasonably. BUG=skia:6289 Change-Id: I8c0ed325391822e9f36636500350205e93942111 Reviewed-on: https://skia-review.googlesource.com/9110 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Use GrTextureProvider's uniqueKey setting method rather than directly setting itGravatar Robert Phillips2017-03-02
| | | | | | | | | Clients will not be able to directly set the uniqueKey on GrTextureProxies. This CL sets up the choke point for the switch over to having uniqueKeys be managed by a third party (the textureProvider). Change-Id: I5061a970faf77ea0c4a320e021ff7c3ef90a0900 Reviewed-on: https://skia-review.googlesource.com/9140 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Determine whether any fp uses local coords in FragmentProcessorAnalysis ↵Gravatar Brian Salomon2017-03-02
| | | | | | | | | rather than GrPipeline creation Change-Id: I3b6253cd2b0081dfece51125082fd78f647e45e1 Reviewed-on: https://skia-review.googlesource.com/9133 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Fix flutter compile botGravatar Ravi Mistry2017-03-02
| | | | | | | | | BUG=skia:6310 Change-Id: I540ea1b8a4e4c4faa8fa0f5550f25023763c3fea Reviewed-on: https://skia-review.googlesource.com/9135 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* SkJumper: allow the compiler to generate FMAsGravatar Mike Klein2017-03-02
| | | | | | | | | | | | | | | Today we use mad() to get FMAs where possible. -ffp-contract=fast lets the compiler generate them if it spots an opportunity. It looks like it's found a mix of FMAs and FMSs. I will follow up by seeing if we can relax the use of mad(). Quick experiments say no, but less quick experiments may say otherwise. Change-Id: I5228811cfbf11cccc0d715672a464fd1e1cea3b0 Reviewed-on: https://skia-review.googlesource.com/9136 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Update Skia milestone to 59Gravatar Heather Miller2017-03-02
| | | | | | | | BUG=skia: Change-Id: Ifa8fa20a838b2899a1230bf51cea7c4cf28971d8 Reviewed-on: https://skia-review.googlesource.com/9139 Reviewed-by: Heather Miller <hcm@google.com>
* Test sRGB with non-linear blending using new "srgbnl" sinkGravatar Matt Sarett2017-03-02
| | | | | | | | | BUG=skia: Change-Id: Ief7516c1505f8e447f83121ed4ba75b9fa9ba75b Reviewed-on: https://skia-review.googlesource.com/8976 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* fix leak in SPIRV code generatorGravatar Ethan Nicholas2017-03-02
| | | | | | | | | BUG=skia:6101 Change-Id: Ic083becfb44e36b029ef9511825f4a681b7495f4 Reviewed-on: https://skia-review.googlesource.com/9103 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Symbolize all Ubuntu dm/nanobench runsGravatar Kevin Lubick2017-03-02
| | | | | | | | | BUG=skia:6206 Change-Id: Ic73b04ee832c7c603a032c5726b34ecb3ac3b4ff Reviewed-on: https://skia-review.googlesource.com/9131 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Add some thread safety notes.Gravatar Mike Klein2017-03-02
| | | | | | | | | These are the main problems we tend to hit with multithreaded drawing. Change-Id: I63dc56f38a533eb839d36833e865af5fcc700d3b Reviewed-on: https://skia-review.googlesource.com/9100 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
* Remove atlas creation from GrResourceProviderGravatar Robert Phillips2017-03-02
| | | | | | | | | This is pulled out of: https://skia-review.googlesource.com/c/6680/ (Make SkImage_Gpu be deferred) and is only tangentially related to the goal of that CL. Change-Id: I6b6db4869597070f85ab3b9fea178fc88c104f87 Reviewed-on: https://skia-review.googlesource.com/9106 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Some small SkJumper refactoring.Gravatar Mike Klein2017-03-02
| | | | | | | | | No generated code changes. Change-Id: I2d480b5391f8246a01118766a9522d528a87f75a Reviewed-on: https://skia-review.googlesource.com/9129 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Revert "Revert "Move GrTextureProvider to src"""Gravatar Brian Osman2017-03-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2fe8373bb1d56f531f8a2e03a3087b0aa73e199c. Reason for revert: Google3 fix isn't landing. Original change's description: > Revert "Revert "Move GrTextureProvider to src"" > > This reverts commit 13d7f5d7c2872ed4298330758e173ae605578cb2. > > Reason for revert: Fixed client code. Re-landing. > > Original change's description: > > Revert "Move GrTextureProvider to src" > > > > This reverts commit 24429c68c56683252e3fc2a79d9b660eaf96ec0c. > > > > Reason for revert: Breaking a roll > > > > Original change's description: > > > Move GrTextureProvider to src > > > > > > With this hidden, we can make further simplification. Just want to test > > > this change against our external clients first, to make sure we're okay > > > to proceed. > > > > > > BUG=skia: > > > > > > Change-Id: I47f8c8f2912201c2890bc2f9a9d68aa92649a2d4 > > > Reviewed-on: https://skia-review.googlesource.com/9072 > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > > > > > > TBR=bsalomon@google.com,brianosman@google.com,benjaminwagner@google.com,reviews@skia.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=skia: > > > > Change-Id: I43cc135731245c29e24bbecf06ee46c562955c03 > > Reviewed-on: https://skia-review.googlesource.com/9123 > > Reviewed-by: Brian Osman <brianosman@google.com> > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > TBR=bsalomon@google.com,benjaminwagner@google.com,reviews@skia.org,brianosman@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Change-Id: Ibcb2ea34654315327c46ea8e4de5bf14376d9bdf > Reviewed-on: https://skia-review.googlesource.com/9127 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Osman <brianosman@google.com> > TBR=bsalomon@google.com,benjaminwagner@google.com,reviews@skia.org,brianosman@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: If5c06c7608d76c45438d03fefb21c4edd7da4f36 Reviewed-on: https://skia-review.googlesource.com/9128 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Add support for Semaphores (gpu waiting on gpu) in GaneshGravatar Greg Daniel2017-03-02
| | | | | | | | | | BUG=skia: Change-Id: I4324b65bc50a3dfd90372459899870d5f1952fdc Reviewed-on: https://skia-review.googlesource.com/9120 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Make SkTypeface::onGetVariationDesignPosition pure virtual.Gravatar Ben Wagner2017-03-01
| | | | | | | | | | It was non-pure until it could be implemented everywhere. Now that it is implemented everywhere, mark it as pure virtual. Change-Id: I985eda37d52e6d194fb39c27cb6bc0ce641238ec Reviewed-on: https://skia-review.googlesource.com/9125 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* SkJumper: upgrade to Clang 3.9Gravatar Mike Klein2017-03-01
| | | | | | | | | | | Mostly I think this will help me handle the AVX tails better. But there are some wins here already, particularly in AVX and ARM code. Change-Id: Ie79b4c2c4ab455277c313f15d360cbf8e4bb7836 Reviewed-on: https://skia-review.googlesource.com/9126 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Remove SK_HAS_DWRITE_X defines.Gravatar Ben Wagner2017-03-01
| | | | | | | | | | | | While developing DirectWrite it was ncessary to support building with older Windows SDKs which may not have certain headers. Now that the minimum required Windows SDK is 8.1 (0x0603) we can remove these difficult to use macros to simplify future development. Change-Id: Ia780466b7c9b86198116c5974c43363f49a0ebac Reviewed-on: https://skia-review.googlesource.com/9124 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Call FT_Set_Default_Properties when available.Gravatar Ben Wagner2017-03-01
| | | | | | | | | | | | | | | | | | | FreeType 2.7.0 added the ability to read some global properties from environment variables to configure an FT_Library. However, this did not apply to FT_New_Library. After 2.7.1 FT_Set_Default_Properties was added so that users of FT_New_Library can also repect these properties. This also removes SK_FONTHOST_FREETYPE_USE_NORMAL_LCD_FILTER and associated code since there are no users of this flag, the behavior it guards is now more or less in upstream FreeType, and the pattern in the code it guards is now in use for calling FT_Set_Default_Properties. BUG=skia:6165 Change-Id: I9fca86cc8b1bb9709c0b980330cf974455be3b57 Reviewed-on: https://skia-review.googlesource.com/9109 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Revert "Revert "Move GrTextureProvider to src""Gravatar Brian Osman2017-03-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 13d7f5d7c2872ed4298330758e173ae605578cb2. Reason for revert: Fixed client code. Re-landing. Original change's description: > Revert "Move GrTextureProvider to src" > > This reverts commit 24429c68c56683252e3fc2a79d9b660eaf96ec0c. > > Reason for revert: Breaking a roll > > Original change's description: > > Move GrTextureProvider to src > > > > With this hidden, we can make further simplification. Just want to test > > this change against our external clients first, to make sure we're okay > > to proceed. > > > > BUG=skia: > > > > Change-Id: I47f8c8f2912201c2890bc2f9a9d68aa92649a2d4 > > Reviewed-on: https://skia-review.googlesource.com/9072 > > Commit-Queue: Brian Osman <brianosman@google.com> > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > > > TBR=bsalomon@google.com,brianosman@google.com,benjaminwagner@google.com,reviews@skia.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Change-Id: I43cc135731245c29e24bbecf06ee46c562955c03 > Reviewed-on: https://skia-review.googlesource.com/9123 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Osman <brianosman@google.com> > TBR=bsalomon@google.com,benjaminwagner@google.com,reviews@skia.org,brianosman@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: Ibcb2ea34654315327c46ea8e4de5bf14376d9bdf Reviewed-on: https://skia-review.googlesource.com/9127 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* FuzzCanvas: fix text generation BUG=skia:6299Gravatar Hal Canary2017-03-01
| | | | | | | Change-Id: Ia87aee1e21bb3429d9f0bab0943190b48e0d76f2 Reviewed-on: https://skia-review.googlesource.com/9122 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Revert "Move GrTextureProvider to src"Gravatar Brian Osman2017-03-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 24429c68c56683252e3fc2a79d9b660eaf96ec0c. Reason for revert: Breaking a roll Original change's description: > Move GrTextureProvider to src > > With this hidden, we can make further simplification. Just want to test > this change against our external clients first, to make sure we're okay > to proceed. > > BUG=skia: > > Change-Id: I47f8c8f2912201c2890bc2f9a9d68aa92649a2d4 > Reviewed-on: https://skia-review.googlesource.com/9072 > Commit-Queue: Brian Osman <brianosman@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > TBR=bsalomon@google.com,brianosman@google.com,benjaminwagner@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: I43cc135731245c29e24bbecf06ee46c562955c03 Reviewed-on: https://skia-review.googlesource.com/9123 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Add Galaxy J5 bots.Gravatar Ben Wagner2017-03-01
| | | | | | | | | | BUG=skia:6097 NOTRY=true Change-Id: I34bd1b10201c4f38b00b80a59e30776414844e05 Reviewed-on: https://skia-review.googlesource.com/9107 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add path renderer options to viewer GUIGravatar Brian Osman2017-03-01
| | | | | | | | | | BUG=skia: Change-Id: I248ba081f0229d7fcf2071009076acc88b80b076 Reviewed-on: https://skia-review.googlesource.com/9088 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Remove stencil related flags from GrInstancedPipelineInfo.Gravatar Brian Salomon2017-03-01
| | | | | | | Change-Id: Ieeb8ada92b5196473d5cea77350fd994bfff8916 Reviewed-on: https://skia-review.googlesource.com/9086 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* remove unneeded android flag for textdecorationsGravatar Mike Reed2017-03-01
| | | | | | | | | BUG=skia: Change-Id: I8d2d15fca9b009ef87075497f58b14d913e2e6b1 Reviewed-on: https://skia-review.googlesource.com/9119 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* fix fuzzerGravatar Cary Clark2017-03-01
| | | | | | | | | | | | turn asserts into error returns to fix fuzz R=kjlubick@google.com BUG=skia:6162 Change-Id: I7508eb5cb41425dcfc2718aaa9cc1ee8aa00acc9 Reviewed-on: https://skia-review.googlesource.com/9118 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
* Unpremul the blend constant in PDLCDXferProcessor.Gravatar Brian Salomon2017-03-01
| | | | | | | | | | | This was accidentally dropped in https://skia.googlesource.com/skia.git/+/eec6f7be5461e588210f383b8af18f324a2bdb46 BUG=chromium:695626 Change-Id: If715fdc673fafa4baf6a61545c2b3b9d3ded9232 Reviewed-on: https://skia-review.googlesource.com/9117 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* GrTessellator: minor cleanups and speedups.Gravatar Stephen White2017-03-01
| | | | | | | | | | | | | | | Don't null out vertex's fPrev and fNext ptrs during MonotonePoly::emit(); list_insert() will do it for us. Don't normalize the tangent returned by get_unit_normal() to unit length, since we can do the dot product comparison without it. Copy Lines where possible, rather than recomputing them. Change-Id: I733b00dd9d9d493313ac9a1c71aac0b708e78201 Reviewed-on: https://skia-review.googlesource.com/9047 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Use SkArenaAlloc in SkEdgeBuilder.Gravatar Herb Derby2017-03-01
| | | | | | | Change-Id: Ie3557469d018b857dc6fb4543d367fcd8768f0b7 Reviewed-on: https://skia-review.googlesource.com/9115 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Move GrTextureProvider to srcGravatar Brian Osman2017-03-01
| | | | | | | | | | | | | With this hidden, we can make further simplification. Just want to test this change against our external clients first, to make sure we're okay to proceed. BUG=skia: Change-Id: I47f8c8f2912201c2890bc2f9a9d68aa92649a2d4 Reviewed-on: https://skia-review.googlesource.com/9072 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Set window dimensions in raster on UnixGravatar Brian Osman2017-03-01
| | | | | | | | | | | | These values were left uninitialized, leading to problems with the GUI in raster configs. BUG=skia: Change-Id: Ia8c16112e53b74daf66941d2923327c9732cf432 Reviewed-on: https://skia-review.googlesource.com/9114 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Use GrAAType in instanced rendering.Gravatar Brian Salomon2017-03-01
| | | | | | | Change-Id: Ifb5a33f908de618d66fcb0dd329f064c1ecfcd63 Reviewed-on: https://skia-review.googlesource.com/9082 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Initialize XImage struct fullyGravatar Brian Osman2017-03-01
| | | | | | | | | | | | I was getting sporadic failures from XInitImage (causing the raster backend to not draw anything). BUG=skia: Change-Id: Ied79f2b5354d89c146aca64d70fde8cf9f3ab62e Reviewed-on: https://skia-review.googlesource.com/9102 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* changed skslc layout parsing strategyGravatar Ethan Nicholas2017-03-01
| | | | | | | Change-Id: I322f0682a8753beb858012b00ee7e4ec6b206c2f Reviewed-on: https://skia-review.googlesource.com/9081 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* SkAndroidCodec: Leave pixels in encoded colorspace when tf is numericalGravatar Matt Sarett2017-03-01
| | | | | | | | | Color space conversion will be deferred until later. Change-Id: I0fbade9bb374fe2ee9328f87284a2d86a199f7b4 Reviewed-on: https://skia-review.googlesource.com/9080 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Define canvas fuzzers like the other API fuzzersGravatar Kevin Lubick2017-03-01
| | | | | | | | | | | | | | | | | Invoke these like: out/Clang/fuzz -n RasterN32Canvas -b [fuzz] out/Clang/fuzz -n NullCanvas -b [fuzz] out/Clang/fuzz -n PDFCanvas -b [fuzz] For debugging: out/Clang/fuzz -n _DumpCanvas -b [fuzz] BUG=skia: Change-Id: I19bd215df09ad2e4ceb7ab16ac6b232fb3f905ed Reviewed-on: https://skia-review.googlesource.com/9097 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Add imgui.ini to .gitignoreGravatar Brian Osman2017-03-01
| | | | | | | | | | | This file is auto-generated by viewer's GUI library (to remember size and position of windows). BUG=skia: Change-Id: Id363301d71d3df1d665c4e495a0d5062cdbc472b Reviewed-on: https://skia-review.googlesource.com/9095 Reviewed-by: Brian Osman <brianosman@google.com>
* Fix Memcheck:Overlap in setting up rect bench namesGravatar Brian Salomon2017-03-01
| | | | | | | Change-Id: Ie34da42198971606222d1cffe5bf6171a5ce4846 Reviewed-on: https://skia-review.googlesource.com/9093 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* fuzz: dump_canvasGravatar Hal Canary2017-03-01
| | | | | | | | | | | | For example: `fuzz --type _dump_canvas -b fuzz_file` Note well: this command-line usage is subject to change. Change-Id: Ida7368a699bafe2395604d8428a2d50cb0eff6aa Reviewed-on: https://skia-review.googlesource.com/9025 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Allow dm threads for GalaxyS*Gravatar Ben Wagner2017-03-01
| | | | | | | | | | | | | | | This appears to have been added for the GalaxyS4 in https://codereview.chromium.org/1106173004/, but we no longer test the GalaxyS4. BUG=skia:3214 NOTRY=true Change-Id: I10c4e1457ebf0e65133ac914cd9fdf0964c74003 Reviewed-on: https://skia-review.googlesource.com/9090 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Disable deferred gpu resources for Chrome branchGravatar Robert Phillips2017-03-01
| | | | | | | | | | | | | Chrome's branch is coming up and it seems unlikely that I will be able to push instantiation all the way to flush time (where failure will be easier to deal with) before then. This CL should silence the P1 bug but could introduce layout test diffs. Ideally this wouldn't land until after: https://codereview.chromium.org/2718353004/ (Add flag for upcoming Skia change) so the layout test differences will be visible on the DEPS roll BUG=688811 Change-Id: I86c42ee02e6672834353aa7126b00ed4f3521948 Reviewed-on: https://skia-review.googlesource.com/9064 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* add isolate (init-with-previous) savelayer flagGravatar Mike Reed2017-03-01
| | | | | | | | | BUG=skia:4884 Change-Id: If7fabf5cc2c87b870f48dfb87e27a2524fec5ae5 Reviewed-on: https://skia-review.googlesource.com/9045 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Clarify what is passed to AutoDrawLooper.Gravatar Mike Reed2017-03-01
| | | | | | | | | | | Explicitly pass the raw bounds to AutoDrawLooper, regardless of the calculations needed for quickreject. Deliberately move temp rects (e.g. storage) right where needed, so they are not in scope after their use. Change-Id: I392bda7857566b2fc14429d8ea632ab712dd37d1 Reviewed-on: https://skia-review.googlesource.com/9044 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Stephen White <senorblanco@chromium.org>
* Add AVX-512 detection to SkCpu, try 2.Gravatar Mike Klein2017-03-01
| | | | | | | | | | | | | This time, don't call xgetbv() before checking we can. This reverts commit b26373cfd8151b2fa56bdf532ddcde4919cce09f. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug Change-Id: I148302cb36446891b1d79b2e60cde0b43420c1a8 Reviewed-on: https://skia-review.googlesource.com/9089 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Clean up/remove unused GrFragmentProcessor-derived ctorsGravatar Robert Phillips2017-02-28
| | | | | | | | | This is the simple (i.e., non-TextureAdjuster) portion of: https://skia-review.googlesource.com/c/8823/ (Remove GrFragmentProcessor-derived class' GrTexture-based ctors) Change-Id: I8f673ebe922e03c69473c18c166bcf818507c662 Reviewed-on: https://skia-review.googlesource.com/8997 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Fix -Wshadow-field warningsGravatar Brian Salomon2017-02-28
| | | | | | | | | BUG=skia: Change-Id: I44f1e11787eab88bdc5ed25c34ea802e9001d427 Reviewed-on: https://skia-review.googlesource.com/9083 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Add backend selection to viewer's GUIGravatar Brian Osman2017-02-28
| | | | | | | | | BUG=skia: Change-Id: I3314013538792c2aa82cc49f3f072aab2cdc4a55 Reviewed-on: https://skia-review.googlesource.com/9079 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* Remove SkDataTableBuilder. It is not used.Gravatar Herb Derby2017-02-28
| | | | | | | Change-Id: Ieae9adba73b8ada959e08d69a06d0f3d010209c6 Reviewed-on: https://skia-review.googlesource.com/9076 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Add GrExternalTextureData and SkCrossContextImageDataGravatar Brian Osman2017-02-28
| | | | | | | | | | | | | | | | | | | | | | | | GrExternalTextureData is an API for exporting the backend-specific information about a texture in a type-safe way, and without pointing into the GrTexture. The new detachBackendTexture API lets us release ownership of a texture to the client. SkCrossContextImageData is the public API that lets clients upload textures on one thread/GrContext, then safely transfer ownership to another thread and GrContext for rendering. Only GL is implemented/supported right now. Vulkan support requires that we add thread-safe memory pools, or otherwise transfer the actual memory block containing the texture to the new context. Re-land of https://skia-review.googlesource.com/c/8529/ BUG=skia: Change-Id: I48ebd57d1ea0cfd3a1db10c475f2903afb821966 Reviewed-on: https://skia-review.googlesource.com/8960 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-05 22:23:00 +0000