aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* SkPDF: add canon assert before adding code that might break itGravatar halcanary2015-03-25
| | | | | | | | | | | Motivation: We can write subsets (by page) of pdf documents (but this in't yet exposed in the public API), but it is a bad idea to mix pages from multiple documents (de-duping will break). This assert verifies that we don't do this by accident in the future. BUG=skia:3585 Review URL: https://codereview.chromium.org/1037573005
* SkPDF: unclass skpdfdocumentGravatar halcanary2015-03-25
| | | | | | BUG=skia:3585 Review URL: https://codereview.chromium.org/1030193002
* More file types to check for (C).Gravatar mtklein2015-03-25
| | | | | | | | | | | | - objective C++ (31) - objective C (4) - C (2) - alternate C++ extension (1) - Go (1) BUG=skia: Review URL: https://codereview.chromium.org/1032143002
* Fix for ClipMaskManager drawSimpleRectGravatar joshualitt2015-03-25
| | | | | | BUG=chromium:466819 Review URL: https://codereview.chromium.org/1031143002
* Add copyright to gyp/codec.gyp.Gravatar scroggo2015-03-25
| | | | Review URL: https://codereview.chromium.org/1023673010
* SkPDF: clean up skpdfdocument, add static functionsGravatar halcanary2015-03-25
| | | | | | | | | | | | | Add SkPDFDocument::EmitPDF and SkPDFDocument::GetCountOfFontTypes Also, make SkPDFDocument::appendPage return void, not bool. Motivation: These static functions can be used to print subsets of a pdf document (functionality to be added in a later CL). BUG=skia:3585 Review URL: https://codereview.chromium.org/1036853002
* Add copyright headers DM.Gravatar scroggo2015-03-25
| | | | Review URL: https://codereview.chromium.org/1037713003
* Fixing memory leak in ico decoderGravatar msarett2015-03-25
| | | | | | | | | | BUG=skia: NOTREECHECKS=true TBR=scroggo@google.com NOTRY=true Review URL: https://codereview.chromium.org/1036873002
* Enabling ico decoding with use of png and bmp decodersGravatar msarett2015-03-25
| | | | | | | | BUG=skia:3257 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1011343003
* SkPDF refactor skpdfdocumentGravatar halcanary2015-03-25
| | | | | | | | | | | | | | | | | | | | | Most fields removed, made local to emitPDF function (since we never emit twice). Variables made into stack variables or auto-unrefed. we hold devices, not pages. addResourcesToCatalog inlined unused setPage function removed. deprecated getCountOfFontTypes function removed private functions removed BUG=skia:3585 Review URL: https://codereview.chromium.org/1034583002
* Add copyright check to PRESUBMITGravatar borenet2015-03-25
| | | | | | BUG=skia:1724 Review URL: https://codereview.chromium.org/1003363005
* SkChopCubicAt2 using Sk2s -- 2x fasterGravatar reed2015-03-24
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1036753002
* SkPDF: unit test cleanupGravatar halcanary2015-03-24
| | | | | | BUG=skia:3585 Review URL: https://codereview.chromium.org/1033833002
* Revert of pathops version two (patchset #16 id:150001 of ↵Gravatar reed2015-03-24
| | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1002693002/) Reason for revert: ASAN investigation Original issue's description: > pathops version two > > R=reed@google.com > > marked 'no commit' to attempt to get trybots to run > > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/ccec0f958ffc71a9986d236bc2eb335cb2111119 TBR=caryclark@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1029993002
* Revert of remove obsolete tests (patchset #1 id:1 of ↵Gravatar caryclark2015-03-24
| | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1030883002/) Reason for revert: working on asan fix Original issue's description: > remove obsolete tests > > remove tests that are breaking the build -- uninitialized memory > > TBR=reed > > Committed: https://skia.googlesource.com/skia/+/e02c944e97ad6a3b8befb1f4f784919767941ba6 TBR=reed@android.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1036633002
* Revert of fix destructor order to fix build (patchset #1 id:1 of ↵Gravatar caryclark2015-03-24
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1033703002/) Reason for revert: working on asan fix Original issue's description: > fix destructor order to fix build > > TBR=reed > > Committed: https://skia.googlesource.com/skia/+/c207f9b2e8d6fb5386197fa8a8d258d2c4603418 TBR=reed@android.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1033803002
* Revert of Enabling ico decoding with use of png and bmp decoders (patchset ↵Gravatar tomhudson2015-03-24
| | | | | | | | | | | | | | | | | | | | | | #10 id:280001 of https://codereview.chromium.org/1011343003/) Reason for revert: Reverting on suspicion of massive bot failures - possible command line too long? Original issue's description: > Enabling ico decoding with use of png and bmp decoders > > BUG=skia:3257 > > Committed: https://skia.googlesource.com/skia/+/15bfd075d38e4422a477e22940d06a137f66cc97 TBR=scroggo@google.com,reed@google.com,djsollen@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3257 Review URL: https://codereview.chromium.org/1022843005
* Switch DM to use utils/android/SkAndroidSDKCanvasGravatar tomhudson2015-03-24
| | | | | | | | | Use (better) paint filter shared with nanobench, instead of custom implementation. R=djsollen@google.com Review URL: https://codereview.chromium.org/1036523002
* Enabling ico decoding with use of png and bmp decodersGravatar msarett2015-03-24
| | | | | | BUG=skia:3257 Review URL: https://codereview.chromium.org/1011343003
* Fix assert in debuggerGravatar robertphillips2015-03-24
| | | | Review URL: https://codereview.chromium.org/1029903002
* Increase timeout of ukwsj to get more consistent SKP capturesGravatar rmistry2015-03-24
| | | | | | | | BUG=skia:3574 TBR=borenet NOTRY=true Review URL: https://codereview.chromium.org/1038443002
* SkPDF: Fix leak in SkPDFShaderGravatar halcanary2015-03-24
| | | | | | TBR=mtklein@google.com Review URL: https://codereview.chromium.org/1006813010
* enable color-matrix-floats again, watching arm64 botsGravatar reed2015-03-24
| | | | | | | BUG=skia: TBR=mtklein@google.com Review URL: https://codereview.chromium.org/1035493002
* Go back to storeAligned / LoadAligned for SkPMFloat <->Sk4f.Gravatar mtklein2015-03-24
| | | | | | | | | | This seems to fix the miscompilation bug on ARM64 / Release / GCC 4.9. We switched this over originally for perf issues with NEON, but I can't see any now. Will keep an eye out. BUG=skia:3570 Review URL: https://codereview.chromium.org/1026403002
* fix destructor order to fix buildGravatar caryclark2015-03-24
| | | | | | TBR=reed Review URL: https://codereview.chromium.org/1033703002
* remove obsolete testsGravatar caryclark2015-03-24
| | | | | | | | remove tests that are breaking the build -- uninitialized memory TBR=reed Review URL: https://codereview.chromium.org/1030883002
* SkPDF: clean up extra referencesGravatar halcanary2015-03-24
| | | | | | This cleans up code left behind from http://crrev.com/870333002 Review URL: https://codereview.chromium.org/1029263004
* Move SkMatrixImageFilter.h into src/core.Gravatar senorblanco2015-03-24
| | | | | | | | | Callers in Blink have been updated to call SkImageFilter::CreateMatrixFilter() instead. BUG=skia:3568 Review URL: https://codereview.chromium.org/1013753013
* pathops version twoGravatar caryclark2015-03-24
| | | | | | | | | | R=reed@google.com marked 'no commit' to attempt to get trybots to run TBR=reed@google.com Review URL: https://codereview.chromium.org/1002693002
* Revert of Revert of remove colorfilter native-565 support. complicating w/ ↵Gravatar reed2015-03-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | no real value. (patchset #1 id:1 of https://codereview.chromium.org/1022673007/) Reason for revert: fix for chrome has landed... Original issue's description: > Revert of remove colorfilter native-565 support. complicating w/ no real value. (patchset #2 id:20001 of https://codereview.chromium.org/1015533011/) > > Reason for revert: > skia/ext/benchmarking_canvas.cc references HasFilter16 :( > > Original issue's description: > > remove colorfilter native-565 support. complicating w/ no real value. > > > > BUG=skia: > > TBR= > > > > Committed: https://skia.googlesource.com/skia/+/2151353d161fe389cdc0db62cfe1932c7680f710 > > TBR=reed@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/92b47c49016749249ff8521e424c4373b4a74241 TBR=reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1016103004
* aacc + bbddGravatar mtklein2015-03-24
| | | | | | | | | | | | | | SkMatrix::mapPts() using aacc/bbdd was always worse than using badc(): - On Intel, it was faster than exisiting swizzle, but badc() is 10% faster still (one pshufd instead of two). - On ARM, existing swizzle < badc() < aacc()+bbdd(), even though aacc() then bbdd() is really a single vtrn instruction. I will revert SkMatrix.cpp before submitting. Just thought you might like to look. Will think more and try to gear up Instruments on ARM. BUG=skia: Review URL: https://codereview.chromium.org/1012573003
* Revert of remove colorfilter native-565 support. complicating w/ no real ↵Gravatar reed2015-03-24
| | | | | | | | | | | | | | | | | | | | | | | value. (patchset #2 id:20001 of https://codereview.chromium.org/1015533011/) Reason for revert: skia/ext/benchmarking_canvas.cc references HasFilter16 :( Original issue's description: > remove colorfilter native-565 support. complicating w/ no real value. > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/2151353d161fe389cdc0db62cfe1932c7680f710 TBR=reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1022673007
* Revert "Revert of impl colormatrix w/ floats (patchset #7 id:120001 of ↵Gravatar reed2015-03-24
| | | | | | | | | | | | | https://codereview.chromium.org/967943002/)" disabled for the momment -- need to understand arm64 glitches This reverts commit 374a4c3b744e8c77455efa73b139950136f7b374. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1028403002
* remove colorfilter native-565 support. complicating w/ no real value.Gravatar reed2015-03-24
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1015533011
* Revert of correct reporting of kAlphaUnchanged_Flag in ModeFilter (patchset ↵Gravatar reed2015-03-24
| | | | | | | | | | | | | | | | | | | | | | | | | #1 id:1 of https://codereview.chromium.org/1033583002/) Reason for revert: reverting experiment. need to rebaseilne layouttest svg/css/text-gradient-shadow.svg Original issue's description: > correct reporting of kAlphaUnchanged_Flag in ModeFilter > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/afced66b508ac4cd3616e2f707db27b7d6f670e1 TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1026313002
* correct reporting of kAlphaUnchanged_Flag in ModeFilterGravatar reed2015-03-23
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1033583002
* Revert of impl colormatrix w/ floats (patchset #7 id:120001 of ↵Gravatar reed2015-03-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/967943002/) Reason for revert: Arm64 seems to be having glitches :( See gm:colormatrix on Arm64/TegraK1/Nexus9 last square should be all white, but it has stripes Original issue's description: > impl colormatrix w/ floats > > this needs to land first https://codereview.chromium.org/1031713003 > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7971def11be91ed08eae7107b372322d24e67544 TBR=mtklein@google.com,caryclark@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1030743003
* impl colormatrix w/ floatsGravatar reed2015-03-23
| | | | | | | | this needs to land first https://codereview.chromium.org/1031713003 BUG=skia: Review URL: https://codereview.chromium.org/967943002
* Start fresh on swizzlesGravatar mtklein2015-03-23
| | | | | | | | | This removes all the existing Sk4x swizzles and adds badc(), which is both fast on all implementations and currently useful. BUG=skia: Review URL: https://codereview.chromium.org/997353005
* Both DM and nanobench need this, so moving the duplicated code toGravatar tomhudson2015-03-23
| | | | | | | | | | | | | one common spot. (It's incomplete, and has had bugs, so it's not like we can confidently write once, copy-paste, and not maintain again.) Because SkPathEffect::exposedInAndroidJavaAPI() only builds in the Android Framework, we might want to make all this code Framework-only? R=djsollen@google.com,mtklein@google.com Review URL: https://codereview.chromium.org/1021823003
* Replace _mm_cvtps_epi32(x) with _mm_cvttps_epi32(_mm_add_ps(0.5f), x).Gravatar mtklein2015-03-23
| | | | | | | | | | | | | We don't have control over which way _mm_cvtps_epi32 rounds. - This makes the SSE SkPMFloat rounding consistent with _neon and _none. - Sk4f::cast<Sk4i>() is closer to (int)float's behavior. (Correct when >=0). Add tests that would fail at head. BUG=skia: Review URL: https://codereview.chromium.org/1029163002
* Add font "index" to lmp parser.Gravatar bungeman2015-03-23
| | | | | | | When ttc index support was added, it was added and tested on Android with the jb parser. This adds it to the lmp parser. Review URL: https://codereview.chromium.org/1023313002
* remove meaningless matrix benches, add mapPts() and add new benchesGravatar reed2015-03-23
| | | | | | | | | | mapPts definitely faster than mapPoints (identity and perspective same speed). Up to 3x for large values of N. cloned from https://codereview.chromium.org/1031443002/ BUG=skia: Review URL: https://codereview.chromium.org/1030653002
* Initial change to move text blob to GrTextContextGravatar joshualitt2015-03-23
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1019633002
* Get rid of excess cleverness in benchmarkGravatar tomhudson2015-03-23
| | | | | | | | | | | | RotatedRectBench was asking for its base layer size, which may not be what it expects with odd canvas modes (particularly proxies). Most benchmarks are not so sophisticated; they hard-wire their size and just use that (expected) value. R=mtklein@google.com,djsollen@google.com BUG=skia:3566 Review URL: https://codereview.chromium.org/1015013004
* Make SkCanvas::getBaseLayerSize() virtualGravatar tomhudson2015-03-23
| | | | | | | | | | | | | | | Subclasses of SkCanvas may need to override the behavior here - for example, any proxy or deferred canvas may not know its own size and need to delegate to another object. We'll also work on reducing use of this function (https://skbug.com/3569), but some of the current uses seem to be semantically necessary. R=reed@google.com BUG=skia:3566 Review URL: https://codereview.chromium.org/1022423002
* Fix two typos in coding styleGravatar kkinnunen2015-03-23
| | | | | | | | | | Fix two typos in coding style: - Memory Managemt - if (NULL == x) equated to if (x) NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1032463002 Review URL: https://codereview.chromium.org/1032463002
* Preserve texture compression when saving a revised skp from debuggerGravatar robertphillips2015-03-23
| | | | | | Without this CL, saving a revised skp out the debugger can greatly expand the memory it requires. Review URL: https://codereview.chromium.org/1020103005
* Do not playback pending commands for full deferred canvas writePixelsGravatar kkinnunen2015-03-23
| | | | | | | | | Do not playback pending commands for full deferred canvas writePixels. Changes the test to catch cases where discard is done without a snapshot. Review URL: https://codereview.chromium.org/939103002
* Update SKP versionGravatar skia.buildbots2015-03-22
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/1030453002