aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Whitespace change to trigger buildbotsGravatar epoger@google.com2013-10-24
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11944 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add note to ignored-tests.txtGravatar epoger@google.com2013-10-24
| | | | | | | | | | | BUG=skia:1748 (SkipBuildbotRuns) R=scroggo@google.com Review URL: https://codereview.chromium.org/40353002 git-svn-id: http://skia.googlecode.com/svn/trunk@11943 2bbb7eff-a529-9590-31e7-b0007b416f81
* update pdf-mac gms, after adding duport for perspective shaders in pdfGravatar edisonn@google.com2013-10-24
| | | | | | Review URL: https://codereview.chromium.org/40313002 git-svn-id: http://skia.googlecode.com/svn/trunk@11942 2bbb7eff-a529-9590-31e7-b0007b416f81
* Borrow Android's ARMv6 memory barrier for SkOnce.Gravatar commit-bot@chromium.org2013-10-24
| | | | | | | | | | | BUG=skia:1743 R=bungeman@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/34353009 git-svn-id: http://skia.googlecode.com/svn/trunk@11941 2bbb7eff-a529-9590-31e7-b0007b416f81
* Minor changesGravatar robertphillips@google.com2013-10-24
| | | | | | | | https://codereview.chromium.org/39973004/ git-svn-id: http://skia.googlecode.com/svn/trunk@11940 2bbb7eff-a529-9590-31e7-b0007b416f81
* Always create an instance when testing GrEffects for SkXfermode and ↵Gravatar commit-bot@chromium.org2013-10-24
| | | | | | | | | | | | | | | | | | SkArithmeticMode Previously the TestCreate methods of the effects would create a static instance and return that for all invocations. This is probably a copy-paste error going back to initial TestCreate method in r8449. At that time, the effect was always the same and thus static usage made sense. R=bsalomon@google.com, senorblanco@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/39393002 git-svn-id: http://skia.googlecode.com/svn/trunk@11939 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix ModeColorFilterEffect assert during GLProgramsTestGravatar commit-bot@chromium.org2013-10-24
| | | | | | | | | | | | | | | | | | Select random filter mode for the test-case until the mode is not Dst. SkModeColorFilter with Dst mode will not create a ModeColorFilterEffect, and thus the case is not implemented. Also changes it so that each call to ModeColorFilterEffect::TestCreate creates a new GrEffect. Previously only one static effect was ever created, due to copy-paste error. R=bsalomon@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/39403002 git-svn-id: http://skia.googlecode.com/svn/trunk@11938 2bbb7eff-a529-9590-31e7-b0007b416f81
* PDF: support perspective in simple shaders. (this version does not work well ↵Gravatar edisonn@google.com2013-10-24
| | | | | | | | | | with tilling) R=vandebo@chromium.org Review URL: https://codereview.chromium.org/26389006 git-svn-id: http://skia.googlecode.com/svn/trunk@11937 2bbb7eff-a529-9590-31e7-b0007b416f81
* Replacing SkTDArray with SkAutoSTArray to reduce memory allocation overhead ↵Gravatar commit-bot@chromium.org2013-10-24
| | | | | | | | | | | | | in SkTileGrid::search BUG=https://code.google.com/p/skia/issues/detail?id=1735 R=tomhudson@chromium.org Author: junov@chromium.org Review URL: https://codereview.chromium.org/35633002 git-svn-id: http://skia.googlecode.com/svn/trunk@11936 2bbb7eff-a529-9590-31e7-b0007b416f81
* Expose SkPicture::willPlayBackBitmaps()Gravatar tomhudson@google.com2013-10-24
| | | | | | | | | | | | | | This returns true if (1) the picture has finished recording and (2) this picture or any picture drawn into it refers to any bitmaps. It allows clients doing complicated manipulations of the picture to early-out when there are no bitmaps present. BUG=303281 R=reed@google.com git-svn-id: http://skia.googlecode.com/svn/trunk@11935 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-10-24
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11934 2bbb7eff-a529-9590-31e7-b0007b416f81
* Apply matrix early in draw bitmapGravatar commit-bot@chromium.org2013-10-24
| | | | | | | | | | | | | | Committed: http://code.google.com/p/skia/source/detail?r=11930 Reverted: https://code.google.com/p/skia/source/detail?r=11932 R=robertphillips@google.com, senorblanco@chromium.org Author: bsalomon@google.com Review URL: https://codereview.chromium.org/30593003 git-svn-id: http://skia.googlecode.com/svn/trunk@11933 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Apply matrix early in draw bitmap"Gravatar scroggo@google.com2013-10-23
| | | | | | | | This reverts commit 4c446c8eb50b7a6e6f917fae7b4c4ffe5658a949. Fix build. git-svn-id: http://skia.googlecode.com/svn/trunk@11932 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "[PDF] Add unpremultiply support and a GM (try4)"Gravatar vandebo@chromium.org2013-10-23
| | | | | | | | | | This reverts commit r11928 gm seems to crash on windows. Review URL: https://codereview.chromium.org/38153003 git-svn-id: http://skia.googlecode.com/svn/trunk@11931 2bbb7eff-a529-9590-31e7-b0007b416f81
* Apply matrix early in draw bitmapGravatar commit-bot@chromium.org2013-10-23
| | | | | | | | | | R=robertphillips@google.com, senorblanco@chromium.org Author: bsalomon@google.com Review URL: https://codereview.chromium.org/30593003 git-svn-id: http://skia.googlecode.com/svn/trunk@11930 2bbb7eff-a529-9590-31e7-b0007b416f81
* [PDF] Add unpremultiply support and a GM (try4)Gravatar vandebo@chromium.org2013-10-23
| | | | | | | | | | | | This is a resubmit of https://codereview.chromium.org/22831039 which was reverted because it causes issues on Windows (really, release builds). BUG=chromium:175548 R=edisonn@google.com Review URL: https://codereview.chromium.org/33493003 git-svn-id: http://skia.googlecode.com/svn/trunk@11928 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline scaled tilemodes gms on the GPUGravatar humper@google.com2013-10-23
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11927 2bbb7eff-a529-9590-31e7-b0007b416f81
* Split up SkXfermode::asNewEffectOrCoeff() into asNewEffect(), asCoeff().Gravatar senorblanco@chromium.org2013-10-23
| | | | | | | | R=bsalomon@google.com Review URL: https://codereview.chromium.org/37593002 git-svn-id: http://skia.googlecode.com/svn/trunk@11926 2bbb7eff-a529-9590-31e7-b0007b416f81
* Follow up to serialization validation codeGravatar commit-bot@chromium.org2013-10-23
| | | | | | | | | | | | | | | | | 1 ) Added check for bool to make sure is it either 0 or 1 and not garbage 2 ) Added more solid kernel size checks in SkMatrixConvolutionImageFilter 3 ) Make sure array size is validated in SkMergeImageFilter BUG= R=reed@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/23548034 git-svn-id: http://skia.googlecode.com/svn/trunk@11925 2bbb7eff-a529-9590-31e7-b0007b416f81
* Initial error handling codeGravatar commit-bot@chromium.org2013-10-23
| | | | | | | | | | | | | | | | I made it as simple as possible. The impact seems minimal and it should do what's necessary to make this code secure. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11247 R=reed@google.com, scroggo@google.com, djsollen@google.com, sugoi@google.com, bsalomon@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/23021015 git-svn-id: http://skia.googlecode.com/svn/trunk@11922 2bbb7eff-a529-9590-31e7-b0007b416f81
* use the supplied matrix instead of the texture w/h div for the bicubic GPU ↵Gravatar commit-bot@chromium.org2013-10-23
| | | | | | | | | | | | | effect BUG= R=bsalomon@google.com, caryclark@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/37003005 git-svn-id: http://skia.googlecode.com/svn/trunk@11921 2bbb7eff-a529-9590-31e7-b0007b416f81
* Lighting filter uses input on raster pathGravatar commit-bot@chromium.org2013-10-23
| | | | | | | | | | | BUG= R=senorblanco@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/35703002 git-svn-id: http://skia.googlecode.com/svn/trunk@11918 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add support for reading non-rendertarget textures.Gravatar commit-bot@chromium.org2013-10-23
| | | | | | | | | | | | | Also removes rendertarget flag from GrAtlas texture creation (no longer needed) and re-enables GrFontCache::dump(). R=robertphillips@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/29263004 git-svn-id: http://skia.googlecode.com/svn/trunk@11917 2bbb7eff-a529-9590-31e7-b0007b416f81
* TSAN build fix: forgot to pass the address into ANNOTATE_BENIGN_RACE.Gravatar mtklein@google.com2013-10-23
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/37403002 git-svn-id: http://skia.googlecode.com/svn/trunk@11916 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: add tabs, and ability to submit new baselines to the serverGravatar epoger@google.com2013-10-23
| | | | | | | | | | | | | Tabs allow the user to divide the tests into groups: hide these for now, approve these, etc. (SkipBuildbotRuns) R=borenet@google.com Review URL: https://codereview.chromium.org/28903008 git-svn-id: http://skia.googlecode.com/svn/trunk@11915 2bbb7eff-a529-9590-31e7-b0007b416f81
* SK_ONCE for SkData and SkPathRefGravatar commit-bot@chromium.org2013-10-23
| | | | | | | | | | | | | Adds SK_ONCE_FRIEND, to allow SK_DEF_ONCE code to be friends with a class. This had to go in include/core to be visible to headers there. BUG= R=reed@google.com, bungeman@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/26491003 git-svn-id: http://skia.googlecode.com/svn/trunk@11914 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove GrContext from SkXfermode::[Aa]sNewEffectOrCoeff() and all subclasses,Gravatar senorblanco@chromium.org2013-10-23
| | | | | | | | | | since it's unused. R=bsalomon@google.com Review URL: https://codereview.chromium.org/31853003 git-svn-id: http://skia.googlecode.com/svn/trunk@11913 2bbb7eff-a529-9590-31e7-b0007b416f81
* Implement SkColorFilter as a GrGLEffectGravatar commit-bot@chromium.org2013-10-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds GrEffect::willUseInputColor() which indicates whether or not the input color affects the output of the effect. This is needed for certain Xfermodes, such as kSrc_Mode. For these modes the color filter will not use the input color. An effect with GrEffect::willUseInputColor() true will cause all color or coverage effects before it to be discarded, as their computations cannot affect the output. In these cases program is marked as having white input color. This fixes an assert when Skia is compiled in a mode that prefers using uniforms instead of attributes for constants. (Flags GR_GL_USE_NV_PATH_RENDERING or GR_GL_NO_CONSTANT_ATTRIBUTES). Using attributes hides the problem where the fragment shader does not need input color for color filters that ignore DST part of the filter. The assert would be hit when uniform manager tries to bind an uniform which has been optimized away by the shader compiler. Adds specific GrGLSLExpr4 and GrGLSLExpr1 classes. This way the GLSL expressions like "(v - src.a)" can remain somewhat readable in form of "(v - src.a())". The GrGLSLExpr<typename> template implements the generic functionality, GrGLSLExprX is the specialization that exposes the type-safe interface to this functionality. Also adds operators so that GLSL binary operators of the form "(float * vecX)" can be expressed in C++. Before only the equivalent "(vecX * float)" was possible. This reverts the common blending calculations to more conventional order, such as "(1-a) * c" instead of "c * (1-a)". Changes GrGLSLExpr1::OnesStr from 1 to 1.0 in order to preserve the color filter blending formula string the same (with the exception of variable name change). Shaders change in case of input color being needed: - vec4 filteredColor; - filteredColor = (((1.0 - uFilterColor.a) * output_Stage0) + uFilterColor); - fsColorOut = filteredColor; + vec4 output_Stage1; + { // Stage 1: ModeColorFilterEffect + output_Stage1 = (((1.0 - uFilterColor_Stage1.a) * output_Stage0) + uFilterColor_Stage1); + } + fsColorOut = output_Stage1; Shaders change in case of input color being not needed: -uniform vec4 uFilterColor; -in vec4 vColor; +uniform vec4 uFilterColor_Stage0; out vec4 fsColorOut; void main() { - vec4 filteredColor; - filteredColor = uFilterColor; - fsColorOut = filteredColor; + vec4 output_Stage0; + { // Stage 0: ModeColorFilterEffect + output_Stage0 = uFilterColor_Stage0; + } + fsColorOut = output_Stage0; } R=bsalomon@google.com, robertphillips@google.com, jvanverth@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/25023003 git-svn-id: http://skia.googlecode.com/svn/trunk@11912 2bbb7eff-a529-9590-31e7-b0007b416f81
* New gm expectations for imagemagnifierGravatar sugoi@google.com2013-10-22
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11911 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix a test warning on some linux machinesGravatar edisonn@google.com2013-10-22
| | | | | | | | R=sugoi@google.com Review URL: https://codereview.chromium.org/34803004 git-svn-id: http://skia.googlecode.com/svn/trunk@11910 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "If the path is a rect, call drawRect to raster the geometry in ↵Gravatar bsalomon@google.com2013-10-22
| | | | | | | | | | SkCanvas::drawPath to get better performance." This reverts commit r11904 Review URL: https://codereview.chromium.org/35543002 git-svn-id: http://skia.googlecode.com/svn/trunk@11909 2bbb7eff-a529-9590-31e7-b0007b416f81
* if fBitmap is still NULL, return falseGravatar reed@google.com2013-10-22
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11908 2bbb7eff-a529-9590-31e7-b0007b416f81
* add tests for SkDocumentGravatar commit-bot@chromium.org2013-10-22
| | | | | | | | | | R=reed@google.com, vandebo@chromium.org Author: edisonn@google.com Review URL: https://codereview.chromium.org/33423002 git-svn-id: http://skia.googlecode.com/svn/trunk@11907 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add strokerect to ignored tests listGravatar bsalomon@google.com2013-10-22
| | | | | | Review URL: https://codereview.chromium.org/35223003 git-svn-id: http://skia.googlecode.com/svn/trunk@11906 2bbb7eff-a529-9590-31e7-b0007b416f81
* If the path is a rect, call drawRect to raster the geometry in ↵Gravatar bsalomon@google.com2013-10-22
| | | | | | | | | | | | SkCanvas::drawPath to get better performance. Committed: http://code.google.com/p/skia/source/detail?r=11842 R=bsalomon@google.com Review URL: https://codereview.chromium.org/23484007 git-svn-id: http://skia.googlecode.com/svn/trunk@11904 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-10-22
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11903 2bbb7eff-a529-9590-31e7-b0007b416f81
* More work to integrate skimage with rebaseline tools.Gravatar scroggo@google.com2013-10-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tools/skimage_main.cpp: Add the ability to write the results to checksum based filenames, much like GM uses. This will allow using the skpdiff server to rebaseline images. Write the keys in the JSON file as <original image>_<pref config>.png, so it matches gm_json.IMAGE_FILENAME_PATTERN. Also replace '_' with '-' in the original file name, to avoid confusing the pattern matcher. The '_' to '-' replacement also happens on the output filename. Read the keys in a similar manner. In make_outname, no longer remove a suffix. This fixes a bug where subset decoding writes multiple subsets to the same file. tools/rebaseline.py: Since the filenames written to json files now match gm_json.IMAGE_FILENAME_PATTERN, enable the option to match based on configs/tests when rebaselining skimage. test json files: Update to match the new format of output. gm/gm_expectations: Add a constructor that takes a BitmapAndDigest as input. tools/tests/skimage_self_test.py: Test that reading the expectations file just created by skimage with the same file actually compares to the original file (rather than just succeeding because expectations were missing). Change the expectations files to match the new format. Will require a buildbot change to use the new flag: https://codereview.chromium.org/27389002/ BUG=1466 R=epoger@google.com Review URL: https://codereview.chromium.org/26297004 git-svn-id: http://skia.googlecode.com/svn/trunk@11902 2bbb7eff-a529-9590-31e7-b0007b416f81
* Xoom rebaselines.Gravatar senorblanco@chromium.org2013-10-21
| | | | | | | | | | Note: Some of these had no base versions in GS corresponding to the hashes in the JSON, causing the svndiff script to barf. I hacked it up to let me finish, but it should probably handle the case of a missing hash more gracefully. TBR=epoger Review URL: https://codereview.chromium.org/33303007 git-svn-id: http://skia.googlecode.com/svn/trunk@11900 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert r11880 (Apply matrix early in draw bitmap - ↵Gravatar robertphillips@google.com2013-10-21
| | | | | | https://codereview.chromium.org/30593003) due to layout test failure git-svn-id: http://skia.googlecode.com/svn/trunk@11899 2bbb7eff-a529-9590-31e7-b0007b416f81
* GrTHashCache -> GrTHashTableGravatar mtklein@google.com2013-10-21
| | | | | | | | | | | The class is Table, but the file's Cache. That's confusing. BUG= R=bsalomon@google.com Review URL: https://codereview.chromium.org/32523004 git-svn-id: http://skia.googlecode.com/svn/trunk@11898 2bbb7eff-a529-9590-31e7-b0007b416f81
* Image decoder fixes (mostly) around A8.Gravatar scroggo@google.com2013-10-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Opaquness: When decoding Gray to A8 in libpng, set reallyHasAlpha to true and add a comment why we do not check for the real answer. Add comments in jpeg decoder explaining why A8 is not opaque. Fix a bug where an A8 subset is considered to be opaque. Other fixes: In SkJPEGImageDecoder, only allocate as much memory as needed for each source row, based on the input config. Also pull out common code into a static function. When performing the check for requiring unpremultiplied colors, allow A8 to succeed, since that setting should have no effect on A8. Add the check for requiring unpremultiplied colors to subset decoding. Fix a bug where attempting to sample gray to A8 does not sample. R=reed@google.com Review URL: https://codereview.chromium.org/26210007 git-svn-id: http://skia.googlecode.com/svn/trunk@11897 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Revert "cache SkImage::Info calculation in lazypixelref""Gravatar reed@google.com2013-10-21
| | | | | | | | | | | | This reverts commit 81eba32ab10f9210c742938819cf1218be5611c9. ImageDecoder is changed to allow info to be NULL, since it is an output-only parameter. R=scroggo@google.com Review URL: https://codereview.chromium.org/33573002 git-svn-id: http://skia.googlecode.com/svn/trunk@11896 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "cache SkImage::Info calculation in lazypixelref"Gravatar reed@google.com2013-10-21
| | | | | | This reverts commit a2537480710aa10b9ab9f8aec98538b79539f47e. git-svn-id: http://skia.googlecode.com/svn/trunk@11894 2bbb7eff-a529-9590-31e7-b0007b416f81
* cache SkImage::Info calculation in lazypixelrefGravatar reed@google.com2013-10-21
| | | | | | | | | BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/28493003 git-svn-id: http://skia.googlecode.com/svn/trunk@11893 2bbb7eff-a529-9590-31e7-b0007b416f81
* Roll gyp from r1684 to r1765.Gravatar bungeman@google.com2013-10-21
| | | | | | | | R=epoger@google.com Review URL: https://codereview.chromium.org/32963002 git-svn-id: http://skia.googlecode.com/svn/trunk@11892 2bbb7eff-a529-9590-31e7-b0007b416f81
* ChromeOS and IntelRhb rebaselines.Gravatar senorblanco@chromium.org2013-10-21
| | | | | | | | TBR=robertphillips Review URL: https://codereview.chromium.org/32533004 git-svn-id: http://skia.googlecode.com/svn/trunk@11891 2bbb7eff-a529-9590-31e7-b0007b416f81
* DM: add --serializeGravatar commit-bot@chromium.org2013-10-21
| | | | | | | | | | | | | | | | | Plus: - minor ReplayTask refactoring to share code with SerializeTask - move --replay to ReplayTask and --serialize to SerializeTask like WriteTask - when --writePath is given, write failures for Replay and Serialize tasks - function names have fewer blatant Skia style violations BUG= R=bsalomon@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/32613003 git-svn-id: http://skia.googlecode.com/svn/trunk@11890 2bbb7eff-a529-9590-31e7-b0007b416f81
* Third round of matrixconvolution rebaselines, and removal from ↵Gravatar senorblanco@chromium.org2013-10-21
| | | | | | | | | | | | | ignored-tests.txt. "We have normality. I repeat, we have normality. Anything you still can't cope with is therefore your own problem." TBR=robertphillips BUG= Review URL: https://codereview.chromium.org/33323002 git-svn-id: http://skia.googlecode.com/svn/trunk@11889 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix out of order destruction errorGravatar robertphillips@google.com2013-10-21
| | | | | | | | https://codereview.chromium.org/33203002/ git-svn-id: http://skia.googlecode.com/svn/trunk@11888 2bbb7eff-a529-9590-31e7-b0007b416f81
* GM: remove deprecated --ignoreTests flagGravatar epoger@google.com2013-10-21
| | | | | | | | | BUG=skia:1730 R=borenet@google.com Review URL: https://codereview.chromium.org/27983004 git-svn-id: http://skia.googlecode.com/svn/trunk@11887 2bbb7eff-a529-9590-31e7-b0007b416f81