aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* fix expectations for arcofzorroGravatar caryclark@google.com2013-11-01
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12093 2bbb7eff-a529-9590-31e7-b0007b416f81
* ignore gm roundrect errors including arcofzorroGravatar caryclark@google.com2013-11-01
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12092 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reverting r12082 (Add bevel-stroke support in GrAARectRenderer) due to GM ↵Gravatar robertphillips@google.com2013-11-01
| | | | | | failures git-svn-id: http://skia.googlecode.com/svn/trunk@12091 2bbb7eff-a529-9590-31e7-b0007b416f81
* ignore gm roundrect errorsGravatar caryclark@google.com2013-11-01
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12090 2bbb7eff-a529-9590-31e7-b0007b416f81
* pathops work in progressGravatar caryclark@google.com2013-11-01
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/52653002 git-svn-id: http://skia.googlecode.com/svn/trunk@12089 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: make default landing page list supported query URLsGravatar epoger@google.com2013-11-01
| | | | | | | | | | | | | | | (SkipBuildbotRuns) Originally, the default landing page redirected to view.html?resultsToLoad=all (which displays all results, and can take a while). Instead, start with a fast-loading page that shows the user all the result sets that are available. R=scroggo@google.com Review URL: https://codereview.chromium.org/46413004 git-svn-id: http://skia.googlecode.com/svn/trunk@12088 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Avoid re-rendering stencil clip for every draw with reducable clip ↵Gravatar reed@google.com2013-11-01
| | | | | | | | | | | | | | | | stack" This reverts commit 92a7d4bf6a371f1f864154be902e8d86938e560b. Revert "fix mac 10.6 build" This reverts commit 114cd1a9f2734aaed6914718814364811b78bd7f. BUG= Review URL: https://codereview.chromium.org/54543008 git-svn-id: http://skia.googlecode.com/svn/trunk@12087 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix mac 10.6 buildGravatar reed@google.com2013-11-01
| | | | | | | | | | | - double -> float implicit conversion (for literals like 1.3) - locally defined (and named) struct R=scroggo@google.com Review URL: https://codereview.chromium.org/56103002 git-svn-id: http://skia.googlecode.com/svn/trunk@12086 2bbb7eff-a529-9590-31e7-b0007b416f81
* Construct round rects with perpendicular tangents.Gravatar commit-bot@chromium.org2013-11-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The round rects are constructed as before out of quadratics, but without fudging the control points. Instead, the mid on- curve point is nudged slightly outward to prevent the convexity test from failing. The convexity test now includes an error term for sign inequality after computing the cross product of the control lines. When the control points are represented as vectors, the number of bits of precision may be greatly reduced. Account for this by passing the number of bits available from the original control point values into the equality check. Making round rect construction lines perpendicular improves the chances of success when path ops encounters clips. No new tests are needed -- this change is exercised by the convex Path unit tests and the gm tests arcofzorro and hairlines. R=robertphillips@google.com, reed@google.com Author: caryclark@google.com Review URL: https://codereview.chromium.org/48783002 git-svn-id: http://skia.googlecode.com/svn/trunk@12085 2bbb7eff-a529-9590-31e7-b0007b416f81
* Avoid re-rendering stencil clip for every draw with reducable clip stackGravatar commit-bot@chromium.org2013-11-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes the cases where clip stack reduction would cause clip to be re-rendered to stencil for each draw call. This causes unneeded slowdown. Stencil cache would not be used because the clip stack generation id communicated by the clip stack element list would be invalid. This happended due to a) clip stack reduction creating new elements in the element list. b) purging logic removing the generation id, but reduction logic selecting already purged element, and thus the generation id, as the representative state of the clip. Cases of a) where reduction would flatten the stack to a single new element were fixed by assigning the generation id of the top-most element of the clip stack as the generation id of the new element. This is not strictly minimal, but enables more caching than using invalid id. Cases of a) where reduction would substitute a stack element with a new element the generation id of the substituted element is used. The b) part was fixed by removing the purging logic. It was not exactly correct, as the previously purged states were actually used. The purging was not used for anything. Changes SkClipStack API to highlight that invalid generation id is never returned by SkClipStack. Empty stacks are wide open. Changes the clients to reflect this. Fixes a crash when not passing anti-alias out parameter to GrReducedClip::ReduceClipStack. The crash is not exercised in the current code. R=bsalomon@google.com, robertphillips@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/48593003 git-svn-id: http://skia.googlecode.com/svn/trunk@12084 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make GrContext cache the gpu pathsGravatar commit-bot@chromium.org2013-11-01
| | | | | | | | | | | | | | | | | | Creating paths for nv_path_rendering is costly. Try to reduce this cost by caching paths based on the SkPath "hash" (i.e. SkPathRef generation id) and stroke properties. Adds the paths to GrContext::fTextureCache instance. Later this should be renamed and the GrContext API should reflect the nature of the cache better. R=bsalomon@google.com, mtklein@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/26557003 git-svn-id: http://skia.googlecode.com/svn/trunk@12083 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add bevel-stroke support in GrAARectRendererGravatar commit-bot@chromium.org2013-11-01
| | | | | | | | | | R=robertphillips@google.com, bsalomon@google.com Author: yunchao.he@intel.com Review URL: https://codereview.chromium.org/23712005 git-svn-id: http://skia.googlecode.com/svn/trunk@12082 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline improved N4 imagesGravatar robertphillips@google.com2013-11-01
| | | | | | | | https://codereview.chromium.org/49983005/ git-svn-id: http://skia.googlecode.com/svn/trunk@12081 2bbb7eff-a529-9590-31e7-b0007b416f81
* Only disable scratch texture reuse on the N10 and N4Gravatar robertphillips@google.com2013-11-01
| | | | | | | | https://codereview.chromium.org/48903017/ git-svn-id: http://skia.googlecode.com/svn/trunk@12080 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: right-align "select/clear/toggle all tests" buttons with ↵Gravatar epoger@google.com2013-11-01
| | | | | | | | | | | | results table (SkipBuildbotRuns) R=edisonn@google.com Review URL: https://codereview.chromium.org/55073003 git-svn-id: http://skia.googlecode.com/svn/trunk@12079 2bbb7eff-a529-9590-31e7-b0007b416f81
* move SkImage::ColorType into SkColorTypeGravatar reed@google.com2013-11-01
| | | | | | | | | | | | | | | | | | objective -- move clients over to SkImage tasks - use SkImageInfo instead of SkBitmap::Config - add support for colortables to SkImage - add drawImage to SkCanvas - return SkImage from readPixels This CL works towards the first task R=robertphillips@google.com Review URL: https://codereview.chromium.org/54363008 git-svn-id: http://skia.googlecode.com/svn/trunk@12077 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update results for a Nexus4 tests that don't render well with perspectiveGravatar edisonn@google.com2013-11-01
| | | | | | Review URL: https://codereview.chromium.org/55633003 git-svn-id: http://skia.googlecode.com/svn/trunk@12076 2bbb7eff-a529-9590-31e7-b0007b416f81
* Adding a way to disable SkOffsetImageFilter's optimized path in blink/chromeGravatar commit-bot@chromium.org2013-11-01
| | | | | | | | | | | BUG= R=senorblanco@chromium.org, reed@google.com, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/54543005 git-svn-id: http://skia.googlecode.com/svn/trunk@12075 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix two inconsistencies in handling fixed-function texture coordinate set ↵Gravatar commit-bot@chromium.org2013-11-01
| | | | | | | | | | | | | | | | | | | generation Prevent off-by-one bug leaving the texture coordinate set 0 always enabled if it ever was used. This makes the code consistent with its apparent purpose. When enabling / disabling texture coordinate sets, call glPathTexGen only if path rendering is applicable. This makes the functions consistent with GrGpuGL::resetContext. R=cdalton@nvidia.com, bsalomon@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/54403003 git-svn-id: http://skia.googlecode.com/svn/trunk@12074 2bbb7eff-a529-9590-31e7-b0007b416f81
* add some GM tests for rectsGravatar commit-bot@chromium.org2013-11-01
| | | | | | | | | | | BUG= R=robertphillips@google.com, bsalomon@google.com Author: yunchao.he@intel.com Review URL: https://codereview.chromium.org/54213002 git-svn-id: http://skia.googlecode.com/svn/trunk@12073 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-11-01
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12071 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix for r12069 (actually turn on don't-reuse-scratch-textures feature)Gravatar robertphillips@google.com2013-11-01
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12070 2bbb7eff-a529-9590-31e7-b0007b416f81
* Turn on don't-reuse-scratch-textures for all Android devicesGravatar robertphillips@google.com2013-11-01
| | | | | | | | https://codereview.chromium.org/54493005/ git-svn-id: http://skia.googlecode.com/svn/trunk@12069 2bbb7eff-a529-9590-31e7-b0007b416f81
* Another rebaselineGravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/46043021/ git-svn-id: http://skia.googlecode.com/svn/trunk@12068 2bbb7eff-a529-9590-31e7-b0007b416f81
* Disabling SK_ATTR_DEPRECATED the hard wayGravatar robertphillips@google.com2013-10-31
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12067 2bbb7eff-a529-9590-31e7-b0007b416f81
* More image rebaselinesGravatar robertphillips@google.com2013-10-31
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12066 2bbb7eff-a529-9590-31e7-b0007b416f81
* Yet more rebaselinesGravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/55303004/ git-svn-id: http://skia.googlecode.com/svn/trunk@12065 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add can-ignore-rect hint to clear callGravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/53823003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12064 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add suppressions for Issue 1784Gravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/49533006/ git-svn-id: http://skia.googlecode.com/svn/trunk@12063 2bbb7eff-a529-9590-31e7-b0007b416f81
* Partial fix for Skia issue 1769: GenerateGMs crashing (out of memory)Gravatar commit-bot@chromium.org2013-10-31
| | | | | | | | | | | | | | | | | | | | GenerateGMs was crashing because we were adding genID listeners for textures even when creation failed -- in this case the key generated is not valid, so when it comes time to purge it, it triggers an assert and then an apparent crash. The solution is to not add a genID listener in this case. This doesn't solve the problem of running out of memory, it just prevents it from causing a crash in Debug builds. BUG= R=bsalomon@google.com, robertphillips@google.com, mtklein@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/55023005 git-svn-id: http://skia.googlecode.com/svn/trunk@12062 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline images that improved with 12037Gravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/55193002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12061 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline lingering RoundRect RHB imagesGravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/52713011/ git-svn-id: http://skia.googlecode.com/svn/trunk@12060 2bbb7eff-a529-9590-31e7-b0007b416f81
* Adding size parameter to read array functionsGravatar commit-bot@chromium.org2013-10-31
| | | | | | | | | | | | | | | | | | | In some cases, the allocated array into which the data will be read is using getArrayCount() to allocate itself, which should be safe, but some cases use fixed length arrays or compute the array size before reading, which could overflow if the stream is compromised. To prevent that from happening, I added a check that will verify that the number of bytes to read will not exceed the capacity of the input buffer argument passed to all the read...Array() functions. I chose to use the byte array for this initial version, so that "size" represents the same value across all read...Array() functions, but I could also use the element count, if it is preferred. Note : readPointArray and writePointArray are unused, so I could also remove them BUG= R=reed@google.com, mtklein@google.com, senorblanco@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/37803002 git-svn-id: http://skia.googlecode.com/svn/trunk@12058 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, ↵Gravatar reed@google.com2013-10-31
| | | | | | | | | | | | since it triggers a warning"" This reverts commit 1e787c38fa71f2a21fd728f1b1d620b9b09b0d3d. BUG= Review URL: https://codereview.chromium.org/54603004 git-svn-id: http://skia.googlecode.com/svn/trunk@12057 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it ↵Gravatar reed@google.com2013-10-31
| | | | | | | | triggers a warning" This reverts commit 1d22c4aaf9d8f053f25194a1ed74b137bfb19497. git-svn-id: http://skia.googlecode.com/svn/trunk@12056 2bbb7eff-a529-9590-31e7-b0007b416f81
* add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers ↵Gravatar reed@google.com2013-10-31
| | | | | | | | | | | a warning BUG= R=robertphillips@google.com, senorblanco@chromium.org, vandebo@chromium.org Review URL: https://codereview.chromium.org/51033004 git-svn-id: http://skia.googlecode.com/svn/trunk@12055 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix bug in don't-reuse-scratch-textures pathGravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/50853003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12054 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline for r12034Gravatar vandebo@chromium.org2013-10-31
| | | | | | | | | | | | xfermodes changed in all configs - added more src types. The following gms changed only for pdf configs: xfermodes2, xfermodes3, aarectmodes, colormatrix, lumafilter, mixed_xfermodes R=edisonn@google.com Review URL: https://codereview.chromium.org/54763003 git-svn-id: http://skia.googlecode.com/svn/trunk@12053 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove suppression of morphology image diffsGravatar robertphillips@google.com2013-10-31
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12050 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaselines of morphology GM for r11966Gravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/54353004/ git-svn-id: http://skia.googlecode.com/svn/trunk@12049 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to trigger builds after buildbot script changesGravatar borenet@google.com2013-10-31
| | | | | | Review URL: https://codereview.chromium.org/54673002 git-svn-id: http://skia.googlecode.com/svn/trunk@12047 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-10-31
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12043 2bbb7eff-a529-9590-31e7-b0007b416f81
* No longer use scratch textures on ARM devicesGravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/50643003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12042 2bbb7eff-a529-9590-31e7-b0007b416f81
* Speculative Android build fix.Gravatar senorblanco@chromium.org2013-10-30
| | | | | | | | TBR=robertphillips Review URL: https://codereview.chromium.org/52693003 git-svn-id: http://skia.googlecode.com/svn/trunk@12041 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert r1784: SK_API on a non-concrete template is strange.Gravatar bungeman@google.com2013-10-30
| | | | | | | | TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/52843004 git-svn-id: http://skia.googlecode.com/svn/trunk@12040 2bbb7eff-a529-9590-31e7-b0007b416f81
* Mac build fix.Gravatar senorblanco@chromium.org2013-10-30
| | | | | | | | TBR=robertphillips Review URL: https://codereview.chromium.org/45963007 git-svn-id: http://skia.googlecode.com/svn/trunk@12039 2bbb7eff-a529-9590-31e7-b0007b416f81
* Implement SSE2-based implementations of the morphology filters (dilate & ↵Gravatar senorblanco@chromium.org2013-10-30
| | | | | | | | | | | | erode). This gives a 3-5X speedup over the naive implementation, and also mitigates a timing-based security attack in Chrome (https://code.google.com/p/chromium/issues/detail?id=251711). NOTE: this will require a corresponding GYP change on the Skia roll into Chrome: https://codereview.chromium.org/52453004/ R=mtklein@google.com, reed@google.com Review URL: https://codereview.chromium.org/52603004 git-svn-id: http://skia.googlecode.com/svn/trunk@12038 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make not-reusing-scratch-textures only apply to texture uploadsGravatar robertphillips@google.com2013-10-30
| | | | | | | | https://codereview.chromium.org/53133002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12037 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix int/SkScalar mismatch in gm.Gravatar vandebo@chromium.org2013-10-30
| | | | | | Review URL: https://codereview.chromium.org/45953005 git-svn-id: http://skia.googlecode.com/svn/trunk@12036 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix int/SkScalar mismatch.Gravatar vandebo@chromium.org2013-10-30
| | | | | | Review URL: https://codereview.chromium.org/51043005 git-svn-id: http://skia.googlecode.com/svn/trunk@12035 2bbb7eff-a529-9590-31e7-b0007b416f81