aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Fix undefined behavior.Gravatar herb2015-07-15
| | | | | | BUG=skia:4050 Review URL: https://codereview.chromium.org/1232003008
* Optimize RGB16 blitV functions with NEON for ARM platform.Gravatar yang.zhang2015-07-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Here are some performance resultsi on Nexus 9: SkRGB16BlitterBlitV_neon: +--------+-----------+ |height | C/NEON | +--------+-----------+ |1 | 0.765230 | +--------+-----------+ |8 | 1.273330 | +--------+-----------+ |18 | 1.441462 | +--------+-----------+ |32 | 1.627798 | +--------+-----------+ |76 | 1.683131 | +--------+-----------+ |85 | 1.679456 | +--------+-----------+ |120 | 1.721311 | +--------+-----------+ |128 | 1.725482 | +--------+-----------+ |512 | 1.784117 | +--------+-----------+ BUG=skia: Review URL: https://codereview.chromium.org/1213723002
* Revert of Added a GLBench for testing performance of vec4 vs scalar for ↵Gravatar scroggo2015-07-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | coverage in generated shaders. (patchset #6 id:90001 of https://codereview.chromium.org/1225383002/) Reason for revert: Still failing on Windows. e.g. https://uberchromegw.corp.google.com/i/client.skia/builders/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-ANGLE/builds/231/steps/nanobench/logs/stdio skbug.com/4053 Original issue's description: > Added a glBench for testing performance of vec4 vs scalar coverage in generated shaders. > > Added bench for timing vec4 vs scalar type for coverage in shaders > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/6104ced165f17eb2f765ace354d5895c0bc890c5 > > Committed: https://skia.googlesource.com/skia/+/c734e69e8cf94bacaf68d3d8ee3310d1ad1fe8b8 TBR=joshualitt@google.com,tomhudson@google.com,wangyix@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1239503003
* Fix VisualBench to hold onto a surfaceGravatar joshualitt2015-07-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1236723003
* make linepaths gm portableGravatar caryclark2015-07-15
| | | | | | TBR=reed@google.com Review URL: https://codereview.chromium.org/1225303010
* remove funkster from dcshader gmGravatar caryclark2015-07-15
| | | | | | | | | | | | | | The multicolored font that funster enables only draws and measures on some platforms. Removing it from the dcshader gm allows the layout to be uniform on all devices, making it easier to compare the output in gold. TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/1231853004
* Document new CQ keywordGravatar rmistry2015-07-15
| | | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1237693005 TBR=jcgregorio Review URL: https://codereview.chromium.org/1237693005
* Fixed valgrind issues with libjpeg-turboGravatar msarett2015-07-14
| | | | | | | | | | | The fixes are in the updated libjpeg-turbo repository pulled in by DEPS. The fixes are detailed in the linked skia bug. To summarize briefly, we now use calloc() instead of malloc(). BUG=skia:4030 Review URL: https://codereview.chromium.org/1237213004
* Updated PDFViewer drawImageRect() overridesGravatar fmalita2015-07-14
| | | | | | R=reed@google.com Review URL: https://codereview.chromium.org/1240573008
* Let Android use old version of onDrawBitmapRect.Gravatar scroggo2015-07-14
| | | | | | | | | | | | Define SK_SUPPORT_LEGACY_ONDRAWIMAGERECT when building for the Android framework, since SkiaCanvasProxy overrides the old version of the method. Fixes master-skia build. NOTRY=True Review URL: https://codereview.chromium.org/1237903002
* Fix buggy blend modes.Gravatar mtklein2015-07-14
| | | | | | | | | | | | The problem turns out to be not over- or underflow like I thought, but that I used different math for x*y/255 for alphas and colors, sometimes resulting in colors where alpha was one less than the maximum color component, which is not a valid SkPMColor. To be safe, I've switched over all four of these similar complex modes to use exact math everywhere. They now match the byte-by-byte code in SkXfermode.cpp exactly. This will slow down Darken and Lighten by about 2x. I plan to follow up with a CL to see if I can eek out some speed there, and another CL to add asserts that Sk4px code always writes valid SkPMColors. BUG=skia:4052 Review URL: https://codereview.chromium.org/1241683003
* Preserve SKP cullrects on deserializationGravatar fmalita2015-07-14
| | | | | | | | Let's not ignore the offset. R=reed@google.com,mtklein@google.com Review URL: https://codereview.chromium.org/1235953004
* Very tiny paths are subsumed by the ConvexicatorGravatar caryclark2015-07-14
| | | | | | | | | | | | | | | and are treated as convex when they are not. Allow the SkPath::Iter to leave degenerate path segments unmolested by passing an additional exact bool to next(). Treat any non-zero length as significant in addPt(). R=reed@google.com,robertphillips@google.com BUG=493450 Review URL: https://codereview.chromium.org/1228383002
* Remove GrRedBlackTreeGravatar joshualitt2015-07-14
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1226203013
* Rename backing texture testing routinesGravatar jvanverth2015-07-14
| | | | Review URL: https://codereview.chromium.org/1230193006
* Another trivial cleanupGravatar joshualitt2015-07-14
| | | | | | | | | TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/52e7657cd850f95e66eb23c6d138ee45149a1039 Review URL: https://codereview.chromium.org/1229303003
* Disable optimization as HWUI does not yet support color shaders.Gravatar djsollen2015-07-14
| | | | Review URL: https://codereview.chromium.org/1235913005
* Implement support for CHROMIUM_path_rendering pseudo extensionGravatar kkinnunen2015-07-14
| | | | | | | | | | | | | | | | Implement support for path rendering in Chromium through CHROMIUM_path_rendering pseudo extension. The extension defines a new pseudo-gl function, BindFragmentInputLocation. This behaves similarly to the BindUniformLocation pseudo-gl function. The idea is to assign fragment input location to a fragment input before linking the program. BUG=chromium:344330 Committed: https://skia.googlesource.com/skia/+/eeef46d181f9f8db388ecea81df699fc1b3c9280 Review URL: https://codereview.chromium.org/1192663002
* 3-15% speedup to HardLight / Overlay xfermodes.Gravatar mtklein2015-07-14
| | | | | | | | | | | | | | | While investigating my bug (skia:4052) I saw this TODO and figured it'd make me feel better about an otherwise unsuccessful investigation. This speeds up HardLight and Overlay (same code) by about 15% with SSE, mostly by rewriting the logic from 1 cheap comparison and 2 expensive div255() calls to 2 cheap comparisons and 1 expensive div255(). NEON speeds up by a more modest ~3%. BUG=skia: Review URL: https://codereview.chromium.org/1230663005
* add src-rect-constraint to drawImageRectGravatar reed2015-07-14
| | | | | | | | | | | Follow-on work - unify around SrcRectConstraint (i.e. drawBitmapRect) - remove silly drawBitmapRectToRect alias - clean-up (possibly remove) alias problems around drawBitmapRect + IRect parameter BUG=skia: Review URL: https://codereview.chromium.org/1228083004
* Add a GYP flag to define SKNX_NO_SIMD when set.Gravatar mtklein2015-07-14
| | | | | | | | Will use this with a new -SKNX_NO_SIMD bot. BUG=skia: Review URL: https://codereview.chromium.org/1227163016
* Fix typo in non-SIMD Sk4f::thenElse().Gravatar mtklein2015-07-14
| | | | | | | | | This was causing the 3 xfermodes that use floats and conditionals to draw wrong when SKNX_NO_SIMD was defined. BUG=skia:4051 Review URL: https://codereview.chromium.org/1229013003
* Revert of Another trivial cleanup (patchset #6 id:100001 of ↵Gravatar joshualitt2015-07-13
| | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1229303003/) Reason for revert: breaking things Original issue's description: > Another trivial cleanup > > TBR=bsalomon@google.com > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/52e7657cd850f95e66eb23c6d138ee45149a1039 TBR=robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1233853004
* Add new SkPoint3 classGravatar robertphillips2015-07-13
| | | | | | The existing Light filter and the upcoming Lighting Shader both need a Point3 class Review URL: https://codereview.chromium.org/1229693009
* Another trivial cleanupGravatar joshualitt2015-07-13
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1229303003
* Added a glBench for testing performance of vec4 vs scalar coverage in ↵Gravatar wangyix2015-07-13
| | | | | | | | | | | | generated shaders. Added bench for timing vec4 vs scalar type for coverage in shaders BUG=skia: Committed: https://skia.googlesource.com/skia/+/6104ced165f17eb2f765ace354d5895c0bc890c5 Review URL: https://codereview.chromium.org/1225383002
* Get rid of GrMurmur3HashGravatar joshualitt2015-07-13
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1233933002
* use portable typefaceGravatar caryclark2015-07-13
| | | | | | TBR=reed@google.com Review URL: https://codereview.chromium.org/1235873004
* Add a GM that reproduces layout test failures with my new xfermode code.Gravatar mtklein2015-07-13
| | | | | | | | | | | | | | Inspired by https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/69169/layout-test-results/results.html I think the root cause is overflow. Also, adds tests for Sk16b::operator<(). It wasn't wrong, but it was suspect (used in all three of these xfermode implementations) and so it's best to have tests. BUG=skia: Review URL: https://codereview.chromium.org/1228393006
* Revert of Added a GLBench for testing performance of vec4 vs scalar for ↵Gravatar scroggo2015-07-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | coverage in generated shaders. (patchset #4 id:40002 of https://codereview.chromium.org/1225383002/) Reason for revert: This is breaking a buildbot. See https://chromegw.corp.google.com/i/client.skia/builders/Test-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Debug-ANGLE/builds/172/steps/nanobench/logs/stdio We get the following error: ERROR::SHADER::COMPLIATION_FAILED: ERROR: 0:8: '0.f' : Floating-point suffix unsupported prior to GLSL ES 3.00 ERROR: 0:8: '0.f' : syntax error Original issue's description: > Added a glBench for testing performance of vec4 vs scalar coverage in generated shaders. > > Added bench for timing vec4 vs scalar type for coverage in shaders > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/6104ced165f17eb2f765ace354d5895c0bc890c5 TBR=joshualitt@google.com,tomhudson@google.com,wangyix@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1235533004
* Added a glBench for testing performance of vec4 vs scalar coverage in ↵Gravatar wangyix2015-07-13
| | | | | | | | | | generated shaders. Added bench for timing vec4 vs scalar type for coverage in shaders BUG=skia: Review URL: https://codereview.chromium.org/1225383002
* Fix for partially-specified crop rects.Gravatar senorblanco2015-07-13
| | | | | | | | | | | When only the left or top edge of a crop rect is given, the right and bottom should be computed based on the incoming width and height, not based on the crop rect's width & height. This complies more accurately with SVG semantics. BUG=240827 Review URL: https://codereview.chromium.org/1232873002
* small cleanups after fixing const of GrPipelineBuilder on DrawTargetGravatar joshualitt2015-07-13
| | | | | | | | Fuse AutoRestoreFragmentProcessors and AutoRestoreProcessorDataManager into new AutoRestoreFragmentProcessorState class BUG=skia: Review URL: https://codereview.chromium.org/1228763005
* Add GrNonAtomicRefGravatar joshualitt2015-07-13
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1238523002
* reenabled GrAALinearizingConvexPathRenderer, but only for stroked pathsGravatar ethannicholas2015-07-13
| | | | Review URL: https://codereview.chromium.org/1237693002
* ovals now take a const GrPipelineBuilderGravatar joshualitt2015-07-13
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1232163002
* make gm text and colors portableGravatar caryclark2015-07-13
| | | | | | TBR=reed@google.com Review URL: https://codereview.chromium.org/1236893002
* Do not attempt to scale webp.Gravatar scroggo2015-07-13
| | | | | | | | | | Scaling webp ends triggers warnings on our valgrind bot. It also results in generating many images in Skia Gold that look mostly the same except for a few pixels along the right edge. BUG=skia:4038 Review URL: https://codereview.chromium.org/1227843005
* Tweak GYP to also link with XCode 7.Gravatar mtklein2015-07-13
| | | | | | | | | | | | | | Using the XCode 7 beta, the file in the GYP doesn't exist, instead we get /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/lib/libz.tbd which is a text file describing libz and pointing to /usr/lib/libz.1.dylib. There's a weird easy fix, which is that GYP looks for things in libraries like 'libz.dylib' and pattern match translates that to '-lz' on the command line. (Infuriatingly, a literal '-lz' is interpreted as a file path...) BUG=skia: Review URL: https://codereview.chromium.org/1234493002
* Start to propagate constness of GrPipelineBuilder up the stackGravatar joshualitt2015-07-13
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1229143007
* Modify GrClipMaskManager to reflect logical constnessGravatar joshualitt2015-07-13
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1230023003
* Remove GL-specific code from GMs and testsGravatar jvanverth2015-07-13
| | | | | | TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/1232173002
* Revert of Whitespace change to test Skia's new bugdroid configuration ↵Gravatar rmistry2015-07-13
| | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/1237653002/) Reason for revert: More testing of bugdroid Original issue's description: > Whitespace change to test Skia's new bugdroid configuration > > BUG=chromium:509664 > NOTRY=true > TBR= > > Committed: https://skia.googlesource.com/skia/+/17708398145a8ef9a7d905e2ec14017ee688f4ae TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:509664 Review URL: https://codereview.chromium.org/1234873004
* Revert of Bilinear optimization for 1D convolution. (patchset #5 id:200001 ↵Gravatar scroggo2015-07-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/1216623003/) Reason for revert: Breaks MSAA Original issue's description: > Bilinear optimization for 1D convolution. > > Splits GrGLConvolutionEffect into GrGLBilerpConvolutionEffect and > GrGLBoundedConvolutionEffect. When doing a non-bounded convolution we now > always use the GrGLBilerpConvolutionEffect which uses bilinear filtering to > perform half as many samples in the texture. > > BUG=skia:3986 > > Committed: https://skia.googlesource.com/skia/+/91abe10af417148939548551e210c001022d3bda TBR=bsalomon@google.com,senorblanco@chromium.org,ericrk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3986 Review URL: https://codereview.chromium.org/1231383005
* Whitespace change to test Skia's new bugdroid configurationGravatar rmistry2015-07-13
| | | | | | | | BUG=chromium:509664 NOTRY=true TBR= Review URL: https://codereview.chromium.org/1237653002
* Skia project metadataGravatar nodir2015-07-13
| | | | | | | | | | | | Added project.cfg metadata file for chrome-infra R=borenet@google.com, rmistry@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507723 Review URL: https://codereview.chromium.org/1231383004
* Fix up -Winconsistent-missing-overrideGravatar mtklein2015-07-13
| | | | | | | | | | | | | | (and a couple presubmit fixes) This allows us to turn back on -Werror for LLVM coverage builds, and more generally supports building with Clang 3.7. No public API changes. TBR=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/1232463006
* Use SK_DECLARE_STATIC_MUTEX for global mutex.Gravatar mtklein2015-07-13
| | | | | | | | | This initializes the mutex at link time on non-Windows platforms, rather than at pre-main-runtime like `static SkMutex gFoo;` BUG=skia: Review URL: https://codereview.chromium.org/1226403007
* Cleanup skia test harness due to changes to DisplayListCanvasGravatar Derek Sollenberger2015-07-13
| | | | Review URL: https://codereview.chromium.org/1235823003 .
* make convex poly clip portableGravatar caryclark2015-07-13
| | | | | | TBR=reed@google.com Review URL: https://codereview.chromium.org/1238483002