aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Remove GrStagedProcessor, remove the word Stage as it applies to FPsGravatar bsalomon2015-08-26
| | | | Review URL: https://codereview.chromium.org/1307223004
* Remove include of stdlib.h from SkTypes.h.Gravatar bungeman2015-08-26
| | | | | | | | | | | | | | | Unfortunately, immintrin.h (which is also included by SkTypes) includes xmmintrin.h which includes mm_malloc.h which includes stdlib.h for malloc even though, from the implementation, it is difficult to see why. Fortunately, arm_neon.h does not seem to be involved in such shenanigans, so building for Android will keep things sane. TBR=reed@google.com Doesn't change Skia API, just moves an include. Review URL: https://codereview.chromium.org/1313203003
* Add markdown for Infra troopersGravatar rmistry2015-08-25
| | | | | | | | BUG=skia:4251 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1313993002 Review URL: https://codereview.chromium.org/1313993002
* Reland of ix zero-length tangent (patchset #1 id:1 of ↵Gravatar caryclark2015-08-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1312243002/ ) Reason for revert: Layout suppression has landed, and verified that Skia gm test changes are correct. Original issue's description: > Revert of fix zero-length tangent (patchset #2 id:20001 of https://codereview.chromium.org/1311273002/ ) > > Reason for revert: > causes layout test to draw differently -- new drawing is more correct. Reverting until layout test ignore is landed. > > Original issue's description: > > fix zero-length tangent > > > > If the end point and the control point are the same, computing > > the tangent will result in (0, 0). In this case, use the prior > > control point instead. > > > > R=reed@google.com > > > > BUG=skia:4191 > > > > Committed: https://skia.googlesource.com/skia/+/7544124fb8ee744f68f549a353f8a9163cd7432d > > TBR=reed@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia:4191 > > Committed: https://skia.googlesource.com/skia/+/91298b47c547b2ab4697038c04685af957bd1416 TBR=reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4191 Review URL: https://codereview.chromium.org/1320473002
* Fix for MSAN unintialized valueGravatar joshualitt2015-08-25
| | | | | | BUG=524094 Review URL: https://codereview.chromium.org/1320433002
* Remove SK_OFFSETOF from SkTypes, clean up offsetof usage.Gravatar bungeman2015-08-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The motivation for this was to remove SK_OFFSETOF from SkTypes, but this CL is mostly about cleaning up our use of offsetof generally. SK_OFFSETOF is removed to SkTypes and added to the two places it is actually used (for the non standard behavior of finding the offset of fields in types which are not standard layout). Older versions of gcc required POD for offsetof to be used without warning. Newer versions require the more relaxed standard layout. Now that we no longer build on older versions of gcc, remove the old warning suppressions. PODMatrix is renamed to AggregateMatrix. SkMatrix is already POD (trivial and standard layout). The PODMatrix name implies that the POD-ness is needed for the offsetof, but it is actually the aggregate attribute which is needed for compile time constant initialization. This makes it more obvious that this can be revisited after we can rely on constexpr constructors. This also adds skstd::declval since this allows removal of existing awkward code which casts a constant to a pointer to find the size of a field. TBR=reed@google.com No API change, only removes unused macro. Review URL: https://codereview.chromium.org/1309523003
* Fix for distance field draw large glyph as pathsGravatar joshualitt2015-08-25
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1315933002
* DM: "wb" (binary mode) may matter on WindowsGravatar mtklein2015-08-25
| | | | | | | | | | | I suspect we might be doing some funky /n -> /r/n translations without 'b'. This kills the PNG. BUG=skia: NOTREECHECKS=true Review URL: https://codereview.chromium.org/1303063008
* Revert of fix zero-length tangent (patchset #2 id:20001 of ↵Gravatar caryclark2015-08-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1311273002/ ) Reason for revert: causes layout test to draw differently -- new drawing is more correct. Reverting until layout test ignore is landed. Original issue's description: > fix zero-length tangent > > If the end point and the control point are the same, computing > the tangent will result in (0, 0). In this case, use the prior > control point instead. > > R=reed@google.com > > BUG=skia:4191 > > Committed: https://skia.googlesource.com/skia/+/7544124fb8ee744f68f549a353f8a9163cd7432d TBR=reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4191 Review URL: https://codereview.chromium.org/1312243002
* Speculative valgrind fixGravatar robertphillips2015-08-25
| | | | | | I wasn't able to repro locally but it seems like it has to be this. Review URL: https://codereview.chromium.org/1309653003
* fix zero-length tangentGravatar caryclark2015-08-25
| | | | | | | | | | | | If the end point and the control point are the same, computing the tangent will result in (0, 0). In this case, use the prior control point instead. R=reed@google.com BUG=skia:4191 Review URL: https://codereview.chromium.org/1311273002
* Skip scaled_tilemodes_npot on Galaxy S4Gravatar borenet2015-08-25
| | | | | | | | It's hanging. BUG=skia:3932 Review URL: https://codereview.chromium.org/1318503003
* Add build targets for advanced Intel instruction sets (1.5 of 3)Gravatar mtklein2015-08-25
| | | | | | | | | | | | | | | | This is a follow-up to https://codereview.chromium.org/1290423007/, with a couple small changes: - turn on AVX and AVX2 for Windows using /arch ('EnabledEnhancedInstructionSet') - reformat and de-conditionalize where possible / irrelevant Picked up this while poking around in libvpx's Chrome GYPs. And yes, AVX = 3, AVX2 = 5. Don't even ask what 4 means... BUG=skia:4117 Review URL: https://codereview.chromium.org/1309253002
* Enable debug builds in the Android frameworkGravatar djsollen2015-08-24
| | | | Review URL: https://codereview.chromium.org/1297093004
* DM: use SkBitmap::reset()Gravatar mtklein2015-08-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1310373004
* Have DM manually encode its .png outputs.Gravatar mtklein2015-08-24
| | | | | | | | | | | | This eliminates some variability on various axes: different PNG encoders, different libpng versions, different formats (RGB, indexed), different unpremultiplication, different sRGB tags. BUG=skia: Committed: https://skia.googlesource.com/skia/+/3cc0dfffb70c0bd08ed8899efcd2e98da86a6ec7 CQ_EXTRA_TRYBOTS=client.skia:Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Debug-Trybot Review URL: https://codereview.chromium.org/1304443002
* Add buildbot_spec info for Appurify botGravatar borenet2015-08-24
| | | | | | BUG=skia:4093 Review URL: https://codereview.chromium.org/1296593003
* Explicitly friend ::SkPrivateEffectInitializer to flattenables.Gravatar mtklein2015-08-24
| | | | | | | | | | | | | Looks like the -Wmicrosoft warnings in the bug are coming up specificically because many the effects in SkLightingImageFilter are defined inside an anonymous namespace (spanning, I think, lines 33-702 today). BUG=skia:4091 No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/1311783004
* Update giflib to 5.1.1 (AOSP hash)Gravatar msarett2015-08-24
| | | | | | | | | | This also disables warnings in giflib and fixes compile warnings in icu, in order to fix a skia bug. BUG=skia:4220 Review URL: https://codereview.chromium.org/1314633002
* Add build targets for advanced Intel instruction sets (1 of 3).Gravatar mtklein2015-08-24
| | | | | | | | | | | | | | | | | | | | | | | CL (1 of 3) adds empty lists in our .gypi, and builds the files in those empty lists with the appropriate flags. CL (2 of 3) will have Chrome's GYP and GN files read these lists, and build them with the appropriate flags. CL (3 of 3) will add runtime detection and stub files to the lists with empty Init_sse42(), Init_avx(), Init_avx2() methods. After that, we should be able to use SSE 4.2, AVX, and AVX2 if desired. Some motivation: - SSE 4.2 adds some sweet string-oriented methods that can help us write fast high quality 32-bit hashes. - AVX is SSE doubled, e.g. 8 floats or two SkPMFloat at a time. - AVX2 is SSE2 doubled, e.g. 8 pixels at a time. BUG=skia:4117 Review URL: https://codereview.chromium.org/1290423007
* Revert of Modify GrBWFillRectBatch to use GrQuad (patchset #3 id:40001 of ↵Gravatar joshualitt2015-08-24
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1311793002/ ) Reason for revert: on some bots this patch creates bad diffs Original issue's description: > Modify GrBWFillRectBatch to use GrQuad > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c611b5afbef6df6c02e949fdf092aab2bb7e0e2e TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1313683002
* Modify GrBWFillRectBatch to use GrQuadGravatar joshualitt2015-08-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1311793002
* Update debugger print out of drawImageRect informationGravatar robertphillips2015-08-24
| | | | Review URL: https://codereview.chromium.org/1311523003
* Remove unused calcPOIs with color/coverage input.Gravatar egdaniel2015-08-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1311763003
* Update SKP versionGravatar rmistry2015-08-23
| | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS Review URL: https://codereview.chromium.org/1309783003
* Revert of experiment with zero-length round capped line segments (patchset ↵Gravatar caryclark2015-08-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #4 id:60001 of https://codereview.chromium.org/1309753002/ ) Reason for revert: More GMs changed than I expected. Will probably affect layout tests as well; reverting until I can verify that the changes are correct. Original issue's description: > experiment with zero-length round capped line segments > > If the endcap is not butt, draw the endcaps even when the line > has zero length. > > If the dash length is zero, generate a zero length line segment. > > Treat a move followed by a close as a move followed by a zero-length > line. > > R=reed@google.com,schenney@google.com > BUG=422974 > > Committed: https://skia.googlesource.com/skia/+/dd3c165828fffb369d0f4b13b48381169a0249a9 TBR=reed@google.com,schenney@google.com,schenney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=422974 Review URL: https://codereview.chromium.org/1304163008
* experiment with zero-length round capped line segmentsGravatar caryclark2015-08-21
| | | | | | | | | | | | | | | If the endcap is not butt, draw the endcaps even when the line has zero length. If the dash length is zero, generate a zero length line segment. Treat a move followed by a close as a move followed by a zero-length line. R=reed@google.com,schenney@google.com BUG=422974 Review URL: https://codereview.chromium.org/1309753002
* Fix for copy surface not handling dirty contextGravatar joshualitt2015-08-21
| | | | | | BUG=521943 Review URL: https://codereview.chromium.org/1304263003
* wire up reduced atlas and zero textblob cache to testGravatar joshualitt2015-08-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1300813007
* Standardize BW to NonAAGravatar joshualitt2015-08-21
| | | | | | | TBR=bsalomon@google.com, robertphillips@google.com BUG=skia: Review URL: https://codereview.chromium.org/1310533004
* fill rect batch refactor into separate batchesGravatar joshualitt2015-08-21
| | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/ae41b3834301444cf27b8aa729b8ad36666bdc08 Review URL: https://codereview.chromium.org/1295773003
* Create separate entry points for the various flavors of drawRectGravatar joshualitt2015-08-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1308503002
* Add instructions to authenticate for fetch.Gravatar herb2015-08-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1305143002
* Return failure if getInputResultsGPU fails in SkXfermodeImageFilterGravatar robertphillips2015-08-21
| | | | | | SkXfermodeImageFilter::filterImageGPU is the only call site that does anything fancy when getInputResultsGPU fails. It seems like we can just return like everyone else (for uniformity). Review URL: https://codereview.chromium.org/1302033004
* add old fix for iOS SampleAppGravatar caryclark2015-08-21
| | | | | | | TBR=jvanverth@google.com BUG=skia:3845 Review URL: https://codereview.chromium.org/1302413003
* GMs: change some GMs to use SkImage over SkBitmapGravatar halcanary2015-08-21
| | | | | | | | Also, add GetResourceAsImage() to Resources.h Motivation: test drawImage() as much as we test drawBitmap() Review URL: https://codereview.chromium.org/1306133003
* Clean up ifdefs in SkGifCodecGravatar msarett2015-08-21
| | | | | | | | | Since codec uses the same version of giflib everywhere, I believe these are unnecessary. BUG=skia: Review URL: https://codereview.chromium.org/1309763002
* This code should've been part of the CL that added registerChildProcessor(); ↵Gravatar wangyix2015-08-21
| | | | | | | | without updating fUsesLocalCoords in the parent when a child proc is registered, batching will not work properly. BUG=skia:4182 Review URL: https://codereview.chromium.org/1308513004
* Use stencil ops that don't issue writes whenever possibleGravatar vbuzinov2015-08-21
| | | | | | | | | Minimize the number of stencil writes by using GL_KEEP whenever possible. This can positively affect the HW performance of the stencil test. BUG=skia:3952 Review URL: https://codereview.chromium.org/1288923005
* add gm for image->newShaderGravatar reed2015-08-20
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1302943004
* SkCanvas::onDrawPicture() quick-rejectGravatar fmalita2015-08-20
| | | | | | R=reed@google.com,mtklein@google.com Review URL: https://codereview.chromium.org/1264133003
* Reland of Implement canComputeFastBounds() for image filters. (patchset #1 ↵Gravatar senorblanco2015-08-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/1300403003/ ) Reason for revert: The Mac compile issue was fixed here: https://chromium.googlesource.com/chromium/src/+/fdd331a42ae0b9a6909a121020735161ab61c6e5 Original issue's description: > Revert of Implement canComputeFastBounds() for image filters. (patchset #8 id:130001 of https://codereview.chromium.org/1296943002/ ) > > Reason for revert: > This causes a syntax error. > > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/87819/steps/compile%20%28with%20patch%29/logs/stdio > > Original issue's description: > > Implement canComputeFastBounds() for image filters. > > > > Image filters have never implemented this check, which means that > > filters which affect transparent black falsely claim they can compute > > their bounds. > > > > Implemented an affectsTransparentBlack() virtual for image > > filters, and a similar helper function for color filters. > > > > This will affect the following GMs: imagefiltersscaled > > (lighting, perlin noise now filter to clip), > > colorfilterimagefilter (new test case), imagefiltersclipped > > (perlin noise now filters to clip). > > > > Note: I de-inlined SkPaint::canComputeFastBounds() to avoid adding > > a dependency from SkPaint.h to SkImageFilter.h.h. Skia benches show > > no impact from this change, but will watch the perf bots carefully. > > > > BUG=4212 > > > > Committed: https://skia.googlesource.com/skia/+/915881fe743f9a789037695f543bc6ea189cd0cb > > TBR=reed@google.com,senorblanco@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=4212 > > Committed: https://skia.googlesource.com/skia/+/12d8472d31ea5edb636d7d5214db253570115c40 TBR=reed@google.com,herb@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=4212 Review URL: https://codereview.chromium.org/1301823005
* fix overrideGravatar caryclark2015-08-20
| | | | | | TBR=herb@google.com Review URL: https://codereview.chromium.org/1301763006
* fix cubic clip in yGravatar caryclark2015-08-20
| | | | | | | | | | | | | | | | | | | Follow on to https://codereview.chromium.org/1299243002/ Clip using a geometric solution if the algebraic solution fails in Y as well as in X. If the root finder discovers real roots that are sufficiently far apart, the root in the range of 0..1 can contain so much error that it is computed to be slightly smaller than 0 or larger than 1. In this case, binary search the mono curve for the actual answer. R=reed@google.com Review URL: https://codereview.chromium.org/1303873003
* Add ANGLE workaround to prefer flushes over VRAM usageGravatar robertphillips2015-08-20
| | | | | | | | | | | On the whole, https://codereview.chromium.org/1286203002/ (Defer flushes if kPreferNoIO is specified) improved performance but it did cause a performance regression on ANGLE. This CL disables the deferral of flushes on ANGLE until we can add a separate incremental flushing mechanism. TBR=bsalomon@google.com BUG=skia:4201 BUG=521529 Review URL: https://codereview.chromium.org/1287193008
* Revert of Implement canComputeFastBounds() for image filters. (patchset #8 ↵Gravatar herb2015-08-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:130001 of https://codereview.chromium.org/1296943002/ ) Reason for revert: This causes a syntax error. http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/87819/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > Implement canComputeFastBounds() for image filters. > > Image filters have never implemented this check, which means that > filters which affect transparent black falsely claim they can compute > their bounds. > > Implemented an affectsTransparentBlack() virtual for image > filters, and a similar helper function for color filters. > > This will affect the following GMs: imagefiltersscaled > (lighting, perlin noise now filter to clip), > colorfilterimagefilter (new test case), imagefiltersclipped > (perlin noise now filters to clip). > > Note: I de-inlined SkPaint::canComputeFastBounds() to avoid adding > a dependency from SkPaint.h to SkImageFilter.h.h. Skia benches show > no impact from this change, but will watch the perf bots carefully. > > BUG=4212 > > Committed: https://skia.googlesource.com/skia/+/915881fe743f9a789037695f543bc6ea189cd0cb TBR=reed@google.com,senorblanco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=4212 Review URL: https://codereview.chromium.org/1300403003
* VisualBenchTest: Write JSON outputGravatar borenet2015-08-20
| | | | | | BUG=skia:4093 Review URL: https://codereview.chromium.org/1302103002
* SkImage method for detecting lazy decodingGravatar fmalita2015-08-20
| | | | | | | BUG=skia:4224 R=reed@google.com Review URL: https://codereview.chromium.org/1305453007
* subdivide path when side-clipping failsGravatar caryclark2015-08-20
| | | | | | | | | | | | | Please review concept; I'm OK not to check this in. If the root finder fails, subdivide the curve and try again. This is complicated by the reversed nature of the curves; maybe it can be simpler, but how to do that escapes me. R=reed@google.com BUG=514246 Review URL: https://codereview.chromium.org/1299243002
* SkPDF: Memory improvements for PDF StreamsGravatar halcanary2015-08-20
| | | | | | | | | ΔMEM = -15% ΔCPU = -7% BUG=skia:3030 Review URL: https://codereview.chromium.org/1227913008
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-14 09:16:29 +0000