aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Introduce interface for memory dumpsGravatar primiano2015-08-20
| | | | | | BUG=chromium:503168 Review URL: https://codereview.chromium.org/1300103004
* Use static_assert instead of SK_COMPILE_ASSERT.Gravatar bungeman2015-08-20
| | | | | | | Now that static_assert is allowed, there is no need to use a non- standard compile time assertion Review URL: https://codereview.chromium.org/1306443004
* Implement canComputeFastBounds() for image filters.Gravatar senorblanco2015-08-20
| | | | | | | | | | | | | | | | | | | | | | Image filters have never implemented this check, which means that filters which affect transparent black falsely claim they can compute their bounds. Implemented an affectsTransparentBlack() virtual for image filters, and a similar helper function for color filters. This will affect the following GMs: imagefiltersscaled (lighting, perlin noise now filter to clip), colorfilterimagefilter (new test case), imagefiltersclipped (perlin noise now filters to clip). Note: I de-inlined SkPaint::canComputeFastBounds() to avoid adding a dependency from SkPaint.h to SkImageFilter.h.h. Skia benches show no impact from this change, but will watch the perf bots carefully. BUG=4212 Review URL: https://codereview.chromium.org/1296943002
* For a frag proc, its key will be a concatenation of all its descendant ↵Gravatar wangyix2015-08-20
| | | | | | | | procs' keys in postorder traversal. BUG=skia:4182 Review URL: https://codereview.chromium.org/1297503007
* Revert "fill rect batch refactor into separate batches"Gravatar joshualitt2015-08-20
| | | | | | | | | This reverts commit ae41b3834301444cf27b8aa729b8ad36666bdc08. TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1301203002
* Update SkLightingShader to support rotationGravatar robertphillips2015-08-20
| | | | | | | | | | | | | This also: makes the SkLightingShader handle normal maps where the rects aren't aligned between the diffuse and normal maps. adds a light aggregating class (Lights) to SkLightingShader (along with a Builder nested class). Split out of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call) Committed: https://skia.googlesource.com/skia/+/45b59ed6e4e231814dbdb9f707b3d2a7ee50de84 Review URL: https://codereview.chromium.org/1291783003
* SkColorCubeFilter: require alpha == 0xFF.Gravatar mtklein2015-08-19
| | | | | | | | This is about a 12% improvement on my desktop, from 134 to 118ms on our bench. BUG=skia: Review URL: https://codereview.chromium.org/1295873004
* Bug fix: we're using SkPMFloat methods on SkColor.Gravatar mtklein2015-08-19
| | | | | | | | | Annoyingly our test bot that forces SkPMFloat_none is a Linux bot using BGRA SkPMColors, so we'd never notice the bug there. BUG=skia: Review URL: https://codereview.chromium.org/1296383006
* Thou shalt use override consistently.Gravatar mtklein2015-08-19
| | | | | | | TBR=herb@google.com BUG=skia: Review URL: https://codereview.chromium.org/1285973006
* Add asserts for shared mutex.Gravatar herb2015-08-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1285973003
* Put drawPath in GrBatch.Gravatar bsalomon2015-08-19
| | | | | | TODO: Implement path range version of this (and preserve combining consecutive ranges). Review URL: https://codereview.chromium.org/1301823002
* Revert "Update SkLightingShader to support rotation"Gravatar robertphillips2015-08-19
| | | | | | | | This reverts commit 45b59ed6e4e231814dbdb9f707b3d2a7ee50de84. TBR=herb@google.com Review URL: https://codereview.chromium.org/1304673002
* SkPDF: Simplify PDFStream / emitObject() constGravatar halcanary2015-08-19
| | | | | | | | | | Compress SkPDFStream's data on setData(), not emitObject(); no longer stateful. SkPDFObject::emitObject is now const. This makes it easier to reason about state. Minimal performance gains. Review URL: https://codereview.chromium.org/1304493002
* private iterator to visit all resource cache entriesGravatar reed2015-08-19
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1271033002
* Fix transformed stroke width in GrAALinearizingConvexPathRenderer.Gravatar ethannicholas2015-08-19
| | | | | | BUG=520476 Review URL: https://codereview.chromium.org/1302503003
* Add VisualBenchTestActivity for instrumentation-testing VisualBenchGravatar borenet2015-08-19
| | | | | | BUG=skia:4093 Review URL: https://codereview.chromium.org/1295823004
* Move SkTemplates.h to private.Gravatar bungeman2015-08-19
| | | | | | | | SkTemplates.h contains a number of Skia specific utilities which are not designed for external use. In addition to reducing the external support burden, this will allow Skia to freely refactor this file. Review URL: https://codereview.chromium.org/1272293004
* stop dropping AA when rect stays rectGravatar joshualitt2015-08-19
| | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/1bef9f59c566cc54c2259cc4d0171c115157cd1c Review URL: https://codereview.chromium.org/1295523002
* change asABitmap to isABitmap on shaderGravatar reed2015-08-19
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1287263005
* No need to re-declare pure virtual name().Gravatar mtklein2015-08-19
| | | | | | | | | Fixes inconsistent override warning. BUG=skia: TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/1293413003
* Patches on top of Radu's latest.Gravatar mtklein2015-08-19
| | | | | | | | | | patch from issue 1273033005 at patchset 120001 (http://crrev.com/1273033005#ps120001) BUG=skia: Committed: https://skia.googlesource.com/skia/+/2d141ba2df8f7506848aa9369f502944e837cd09 Review URL: https://codereview.chromium.org/1288323004
* Update SkLightingShader to support rotationGravatar robertphillips2015-08-19
| | | | | | | | | | | This also: makes the SkLightingShader handle normal maps where the rects aren't aligned between the diffuse and normal maps. adds a light aggregating class (Lights) to SkLightingShader (along with a Builder nested class). Split out of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call) Review URL: https://codereview.chromium.org/1291783003
* Revert of cast SK_ARRAY_COUNT to make it sign agnostic (patchset #1 id:1 of ↵Gravatar caryclark2015-08-19
| | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1299943002/ ) Reason for revert: fails on chrome build on windows Original issue's description: > cast SK_ARRAY_COUNT to make it sign agnostic > > By adding a cast to SK_ARRAY_COUNT, the compiler treats the > compile-time value as if it were a const int, and like regular > numbers, permits it to be compared to signed and unsigned > numbers freely. > > R=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/bca86202a48b2afa527b6e40d8b360ce3bc7c2e7 TBR=reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1285263007
* unsigned -> int for counts and indices in picture-related codeGravatar mtklein2015-08-19
| | | | | | | | also, (C) BUG=skia: Review URL: https://codereview.chromium.org/1300163002
* Add rendertarget flag to prevent a debug assert in SampleApp.Gravatar senorblanco2015-08-19
| | | | | | BUG=skia:4223 Review URL: https://codereview.chromium.org/1301583006
* Create GrQuadGravatar joshualitt2015-08-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1294713009
* cast SK_ARRAY_COUNT to make it sign agnosticGravatar caryclark2015-08-19
| | | | | | | | | | | By adding a cast to SK_ARRAY_COUNT, the compiler treats the compile-time value as if it were a const int, and like regular numbers, permits it to be compared to signed and unsigned numbers freely. R=reed@google.com Review URL: https://codereview.chromium.org/1299943002
* Use calloc to allocate data that will be uploaded to vertex/index buffers in ↵Gravatar bsalomon2015-08-19
| | | | | | | | | Chrome BUG=chromium:454267 BUG=chromium:522315 Review URL: https://codereview.chromium.org/1300123002
* This change is in preparation for updating how processor keys and meta keys ↵Gravatar wangyix2015-08-19
| | | | | | | | are generated for frag procs. BUG=skia:4182 Review URL: https://codereview.chromium.org/1298233002
* Adding sucessful exit message to VisualBenchGravatar joshualitt2015-08-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1287763004
* remove SkDeferredCanvasGravatar reed2015-08-19
| | | | | | | | Waiting a day or so to see if the blink-removal of SkDeferredCanvas sticks BUG=skia: Review URL: https://codereview.chromium.org/1269093002
* Allow setting of GrBatchFontCache atlas sizesGravatar joshualitt2015-08-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1255943006
* Forgot to add resources with new testGravatar msarett2015-08-19
| | | | | | | | | | I created these images using mandrill_16.png (already in resources) and an online tool. https://codereview.chromium.org/1287863004/ BUG=skia: Review URL: https://codereview.chromium.org/1297723004
* Revert of Have DM manually encode its .png outputs. (patchset #2 id:20001 of ↵Gravatar mtklein2015-08-19
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1304443002/ ) Reason for revert: derek + Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Debug Original issue's description: > Have DM manually encode its .png outputs. > > This eliminates some variability on various axes: different PNG encoders, different libpng versions, different formats (RGB, indexed), different unpremultiplication, different sRGB tags. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/3cc0dfffb70c0bd08ed8899efcd2e98da86a6ec7 TBR=stephana@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1297383002
* Revert of SkCanvas::onDrawPicture() quick-reject (patchset #3 id:40001 of ↵Gravatar herb2015-08-19
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1264133003/ ) Reason for revert: Seems to be breaking some blink tests. https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/75812/layout-test-results/results.html Original issue's description: > SkCanvas::onDrawPicture() quick-reject > > R=reed@google.com,mtklein@google.com > > Committed: https://skia.googlesource.com/skia/+/48ed62b29d45e42b971aac8858da06781c93e6d7 > > Committed: https://skia.googlesource.com/skia/+/d3d07245e29504dbffa0083e84ace5bab85853d4 TBR=mtklein@google.com,reed@google.com,mtklein@chromium.org,fmalita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1301973002
* Have DM manually encode its .png outputs.Gravatar mtklein2015-08-19
| | | | | | | | This eliminates some variability on various axes: different PNG encoders, different libpng versions, different formats (RGB, indexed), different unpremultiplication, different sRGB tags. BUG=skia: Review URL: https://codereview.chromium.org/1304443002
* SkStream Testing: fix bug in new unit test.Gravatar halcanary2015-08-19
| | | | Review URL: https://codereview.chromium.org/1297143004
* add missing overrideGravatar mtklein2015-08-19
| | | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1292073003
* fill rect batch refactor into separate batchesGravatar joshualitt2015-08-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1295773003
* Init class ID in GrStencilPathBatchGravatar Brian Salomon2015-08-19
| | | | | | TBR=joshualitt@google.com Review URL: https://codereview.chromium.org/1300093007
* Fix stack overuse errorGravatar halcanary2015-08-19
| | | | Review URL: https://codereview.chromium.org/1283193008
* Fix VS 2015 buildGravatar bsalomon2015-08-19
| | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/1297283003
* SkCanvas::onDrawPicture() quick-rejectGravatar fmalita2015-08-19
| | | | | | | | R=reed@google.com,mtklein@google.com Committed: https://skia.googlesource.com/skia/+/48ed62b29d45e42b971aac8858da06781c93e6d7 Review URL: https://codereview.chromium.org/1264133003
* widen gm to show entire image, add place-holder for no contextGravatar reed2015-08-19
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1294113003
* SkPDF/Deflate: clean up old SkFlate codeGravatar halcanary2015-08-18
| | | | | | | | Factor out some of https://crrev.com/1227913008 BUG=skia:3030 Review URL: https://codereview.chromium.org/1298243002
* Path stenciling in GrBatchGravatar bsalomon2015-08-18
| | | | Review URL: https://codereview.chromium.org/1293973003
* Test scaling for small imagesGravatar msarett2015-08-18
| | | | | | | | | | We don't want to test small images on Gold because they are not interested to look at. Instead, I wrote a unit test to verify that scaling small images does not cause crashes. BUG=skia: Review URL: https://codereview.chromium.org/1287863004
* Try enabling all nanobenches on Nexus7Gravatar egdaniel2015-08-18
| | | | | | BUG=skia:2774 Review URL: https://codereview.chromium.org/1290223005
* handle no shader from image in drawAtlasGravatar reed2015-08-18
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1298233003
* Remove Cmd in GrTargetCommands that is no longer needed with GrCopySurfaceBatchGravatar bsalomon2015-08-18
| | | | | | TBR=joshualitt@google.com Review URL: https://codereview.chromium.org/1292623004