aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* SkData need not be a Flattenable, since it does not need subclass/factoriesGravatar reed@google.com2013-10-14
| | | | | | | | | BUG= R=mtklein@google.com Review URL: https://codereview.chromium.org/26928002 git-svn-id: http://skia.googlecode.com/svn/trunk@11754 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update Housekeeper-PerCommit after adding a new type of gm result.Gravatar edisonn@google.com2013-10-14
| | | | | | | | R=epoger@google.com Review URL: https://codereview.chromium.org/27191002 git-svn-id: http://skia.googlecode.com/svn/trunk@11753 2bbb7eff-a529-9590-31e7-b0007b416f81
* Spin off incidental changes from DM CL (22839016).Gravatar commit-bot@chromium.org2013-10-14
| | | | | | | | | | | BUG= R=epoger@google.com, bsalomon@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/27023004 git-svn-id: http://skia.googlecode.com/svn/trunk@11752 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add SkPDFDeviceFlatenner which extends SkPDFDevice to add support to flatten ↵Gravatar commit-bot@chromium.org2013-10-14
| | | | | | | | | | | | | | | the path and the text when we have perspective. prepare to deprecate SkPDFDevice constructor, and route gm and render_pdfs to use SkDocument::Create pdf interface instead. - controlled by a flag add comments where we are supposed to flatten other features (paint, shaders, ... ) R=reed@google.com, bungeman@google.com, scroggo@google.com, vandebo@chromium.org, bsalomon@google.com Author: edisonn@google.com Review URL: https://codereview.chromium.org/24811002 git-svn-id: http://skia.googlecode.com/svn/trunk@11751 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove SkLumaXfermode.Gravatar commit-bot@chromium.org2013-10-14
| | | | | | | | | | | | | | Possibly the shortest-lived Skia feature, SkLumaXfermode is now replaced by a color filter implementation (SkLumaColorFilter). All known existing clients (Blink) have been converted. R=reed@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/26916002 git-svn-id: http://skia.googlecode.com/svn/trunk@11750 2bbb7eff-a529-9590-31e7-b0007b416f81
* Simplify code for configuring suppression of ImageDecoder warningsGravatar halcanary@google.com2013-10-14
| | | | | | | | | | | | | | | | | | | For images.png.suppressDecoderWarnings and images.jpeg.suppressDecoderWarnings, the default behavior is now: Debug - DON'T suppress Developer Release - suppress Release - suppress This behavior can be changed in Debug and in Developer through the SkRTConf mechanism. BUG=skia:1680 R=caryclark@google.com Review URL: https://codereview.chromium.org/26863003 git-svn-id: http://skia.googlecode.com/svn/trunk@11749 2bbb7eff-a529-9590-31e7-b0007b416f81
* SampleApp - reduce unnecessary verbosity [with --picture $path]Gravatar halcanary@google.com2013-10-14
| | | | | | | | | | | | | Before this change, `SampleApp --picture $path` prints out usage (as well as --pictureDir) as if there was a syntax error in the command line arguments. BUG=skia:1677 R=reed@google.com Review URL: https://codereview.chromium.org/24503003 git-svn-id: http://skia.googlecode.com/svn/trunk@11748 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove unnamed namespace usage from tests.Gravatar commit-bot@chromium.org2013-10-12
| | | | | | | | | | | | | | Skia code prefers static over unnamed namespace. BUG=None TEST=None R=bsalomon@google.com, robertphillips@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/26962002 git-svn-id: http://skia.googlecode.com/svn/trunk@11747 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-10-12
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11746 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add stdio include to SkFonrConfigParser_android.Gravatar bungeman@google.com2013-10-11
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11745 2bbb7eff-a529-9590-31e7-b0007b416f81
* Try to work around VS2010 intsafe/stdint multiple define issues.Gravatar bungeman@google.com2013-10-11
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11744 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add stdio include to SkDebug_android.Gravatar bungeman@google.com2013-10-11
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11743 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add stdio include for Android specific code in SkRegion.Gravatar bungeman@google.com2013-10-11
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11741 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add stdio include to skdiff_image.Gravatar bungeman@google.com2013-10-11
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11740 2bbb7eff-a529-9590-31e7-b0007b416f81
* Correct 32bit pointer assumption in assert in SkMatrix.Gravatar bungeman@google.com2013-10-11
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11739 2bbb7eff-a529-9590-31e7-b0007b416f81
* Clean up SkTypes.h.Gravatar bungeman@google.com2013-10-11
| | | | | | | | | | | | | | | | | | | This change removes sk_stdint.h since it is only needed for vs2008 and earlier. This change removes SK_MMAP_SUPPORT define since it is no longer used. This change removes the stdio.h include from SkTypes.h since on many systems this is a very large header, few Skia files actually use it, it is available everywhere standard, and SkDebugf should be used instead. After this change there is no need for external users to put Skia's include/config into their own list of includes, saving the headache of having two header files of the same name and sometimes getting the wrong one depending on include order. R=bsalomon@google.com, djsollen@google.com Review URL: https://codereview.chromium.org/27044002 git-svn-id: http://skia.googlecode.com/svn/trunk@11738 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: allow client to pull all results, or just failuresGravatar epoger@google.com2013-10-11
| | | | | | | | | | | | | (SkipBuildbotRuns) This will be handy for constrained networks or devices, where we don't want to bother downloading info about all the successful tests. R=jcgregorio@google.com Review URL: https://codereview.chromium.org/26891003 git-svn-id: http://skia.googlecode.com/svn/trunk@11737 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add valgrind suppressions for driver bugsGravatar robertphillips@google.com2013-10-11
| | | | | | | | https://codereview.chromium.org/27019005/ git-svn-id: http://skia.googlecode.com/svn/trunk@11736 2bbb7eff-a529-9590-31e7-b0007b416f81
* pdfviewer: more code comments + concat the pdf matrix with the existing ↵Gravatar edisonn@google.com2013-10-11
| | | | | | | | matrix in canvas, instead of reseting it. Review URL: https://codereview.chromium.org/27057003 git-svn-id: http://skia.googlecode.com/svn/trunk@11735 2bbb7eff-a529-9590-31e7-b0007b416f81
* GIF decode: optional error messages and fault tolerance.Gravatar halcanary@google.com2013-10-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add new runtime configuration variable, images.gif.suppressDecoderWarnings, which suppresses warning and errors from the GIF library. It defaults to "true", which is current behavior. (This setting can be changed by setting the environment variable skia_images_gif_suppressDecoderWarnings="false".) Some conditions which were errors before are now warnings: - If the image width or height is greater than the GIF screen width or height (respectively) we expand the screen to hold the image. - If the offset of the image inside the screen would place the image outside of the screen, we shift the image to fix this. - If the image lacks a color table, we create a default color table. - If the image is truncated, then the rest of the image is filled with the fill color. In all four cases, if images.gif.suppressDecoderWarnings is set to false, then a warning message is printed via SkDebugf. In the event of another kind of error, SkGIFImageDecoder::onDecode() will still return false. But with this change, if images.gif.suppressDecoderWarnings is set to false, a description of the error is printed via SkDebugf. Also, added a new unit test GifTest, which tests the deconing of both good GIf files and corrupted files that should now work with this change. This unit test is disabled on Win32, iOS, and Mac. BUG=skia:1689 R=scroggo@google.com Review URL: https://codereview.chromium.org/26743002 git-svn-id: http://skia.googlecode.com/svn/trunk@11734 2bbb7eff-a529-9590-31e7-b0007b416f81
* SkRectShaderImageFilter: add a workaround for the zero-sized rects currently ↵Gravatar senorblanco@chromium.org2013-10-11
| | | | | | | | | | | passed by Blink. BUG=306488 R=robertphillips@google.com, robertphillips Review URL: https://codereview.chromium.org/26799004 git-svn-id: http://skia.googlecode.com/svn/trunk@11733 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use #if insteadof #ifdef DYNAMIC_ANNOTATIONS_ENABLED. It's always defined, ↵Gravatar senorblanco@chromium.org2013-10-11
| | | | | | | | | | | just to 0 or 1. BUG= R=mtklein Review URL: https://codereview.chromium.org/26358010 git-svn-id: http://skia.googlecode.com/svn/trunk@11731 2bbb7eff-a529-9590-31e7-b0007b416f81
* pdfviewer: (more code cleanup): class documentation and commentsGravatar edisonn@google.com2013-10-11
| | | | | | Review URL: https://codereview.chromium.org/27043002 git-svn-id: http://skia.googlecode.com/svn/trunk@11730 2bbb7eff-a529-9590-31e7-b0007b416f81
* save/restore the canvas around every bench draw callGravatar commit-bot@chromium.org2013-10-11
| | | | | | | | | | | BUG= R=djsollen@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/26848013 git-svn-id: http://skia.googlecode.com/svn/trunk@11728 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove the old skimage expectations.Gravatar scroggo@google.com2013-10-11
| | | | | | | | | | | | | | As of https://code.google.com/p/skia/source/detail?r=11712 , the bots are now reading the expectations from a new place, so these are no longer needed. Unreviewed. BUG=skia:1466 Review URL: https://codereview.chromium.org/26909004 git-svn-id: http://skia.googlecode.com/svn/trunk@11727 2bbb7eff-a529-9590-31e7-b0007b416f81
* Format-only changes to skimage expectations files.Gravatar scroggo@google.com2013-10-11
| | | | | | | | | | | | | When running rebaseline.py, the format of the file changes from what is currently checked in, but the actual data remains the same. Update the format so future changes will be easier to see visually (not mixed in with format changes). Unreviewed. Review URL: https://codereview.chromium.org/26888010 git-svn-id: http://skia.googlecode.com/svn/trunk@11726 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix leak in BlurTestGravatar robertphillips@google.com2013-10-11
| | | | | | | | https://codereview.chromium.org/26941002/ git-svn-id: http://skia.googlecode.com/svn/trunk@11725 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix double ref issue in SkPDFFont ctorGravatar robertphillips@google.com2013-10-11
| | | | | | | | https://codereview.chromium.org/26799003/ git-svn-id: http://skia.googlecode.com/svn/trunk@11724 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-10-11
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11723 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix uninitialized memory read in BitmapCopy test with A1 configGravatar robertphillips@google.com2013-10-10
| | | | | | | | https://codereview.chromium.org/26890002/ git-svn-id: http://skia.googlecode.com/svn/trunk@11722 2bbb7eff-a529-9590-31e7-b0007b416f81
* SK_ONCE for SkMatrix::I()Gravatar commit-bot@chromium.org2013-10-10
| | | | | | | | | | | | | | Going to start doing these in progressively larger and larger bulk, but I figured the first few changes probably merit caution. BUG= R=reed@google.com, bungeman@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/26905002 git-svn-id: http://skia.googlecode.com/svn/trunk@11721 2bbb7eff-a529-9590-31e7-b0007b416f81
* Implement crop rect support for SkRectShaderImageFilter: remove fRect and ↵Gravatar senorblanco@chromium.org2013-10-10
| | | | | | | | | | use the cropRect from SkImageFilter in its place. R=reed@google.com Review URL: https://codereview.chromium.org/26009004 git-svn-id: http://skia.googlecode.com/svn/trunk@11720 2bbb7eff-a529-9590-31e7-b0007b416f81
* Temporarily disable FilterBitmapBenches while I fix it.Gravatar mtklein@google.com2013-10-10
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/26254003 git-svn-id: http://skia.googlecode.com/svn/trunk@11718 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add ability to rebaseline skimage to rebaseline.pyGravatar scroggo@google.com2013-10-10
| | | | | | | | | | | | | | | | | | | | Skip pattern matching for skimage, since the skimage results do not match the pattern. Automatically fill in expectations_root and actuals_base_url when --skimage is specified. Requires a change to move the expectations files to the right place. Depends on https://codereview.chromium.org/26734006 (SkipBuildBotRuns) BUG=skia:1466 R=epoger@google.com Review URL: https://codereview.chromium.org/26666004 git-svn-id: http://skia.googlecode.com/svn/trunk@11717 2bbb7eff-a529-9590-31e7-b0007b416f81
* mode code cleanup (100c / l, comments)Gravatar edisonn@google.com2013-10-10
| | | | | | Review URL: https://codereview.chromium.org/26912005 git-svn-id: http://skia.googlecode.com/svn/trunk@11716 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix a minor regex bug.Gravatar scroggo@google.com2013-10-10
| | | | | | | | | | | | | Match against '.', rather than any character (how '.' is treated in a regular expression). Previous to this, xfermodes_8888*png matched the expression. R=epoger@google.com Review URL: https://codereview.chromium.org/26709003 git-svn-id: http://skia.googlecode.com/svn/trunk@11714 2bbb7eff-a529-9590-31e7-b0007b416f81
* Align SkLumaColorFilter with the spec.Gravatar commit-bot@chromium.org2013-10-10
| | | | | | | | | | | | | | | | | | | | | | | | | The spec requires the resulting RGB channels for LuminanceToAlpha to be 0 (and not just scaled by the luminance value</facepalm>): | R' | | 0 0 0 0 0 | | R | | G' | | 0 0 0 0 0 | | G | | B' | = | 0 0 0 0 0 | * | B | | A' | | 0.2125 0.7154 0.0721 0 0 | | A | | 1 | | 0 0 0 0 1 | | 1 | (http://www.w3.org/TR/2011/REC-SVG11-20110816/filters.html#feColorMatrixElement) This doesn't affect luminance masking (which depends only on the resulting alpha channel), but other color filter users may care about all color components. R=bsalomon@google.com, reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/26467003 git-svn-id: http://skia.googlecode.com/svn/trunk@11713 2bbb7eff-a529-9590-31e7-b0007b416f81
* SkThreadPool: tweak two little things that have been annoying meGravatar commit-bot@chromium.org2013-10-10
| | | | | | | | | | | | | | 1) it's pretty annoying that SkThreadPool doesn't include SkRunnable for us; 2) add wait() so we don't have to keep using SkAutoTDelete/free() to wait for completion. BUG= R=scroggo@google.com, reed@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/26470005 git-svn-id: http://skia.googlecode.com/svn/trunk@11711 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix warnings when running a no gpu buildGravatar djsollen@google.com2013-10-10
| | | | | | | | R=mtklein@google.com Review URL: https://codereview.chromium.org/26908002 git-svn-id: http://skia.googlecode.com/svn/trunk@11710 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix mac10.6 buildGravatar djsollen@google.com2013-10-10
| | | | | | Review URL: https://codereview.chromium.org/26882003 git-svn-id: http://skia.googlecode.com/svn/trunk@11708 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline nexus7 perf improvementGravatar djsollen@google.com2013-10-10
| | | | | | Review URL: https://codereview.chromium.org/26884002 git-svn-id: http://skia.googlecode.com/svn/trunk@11707 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix android_gdb_exe scriptGravatar djsollen@google.com2013-10-10
| | | | | | | | R=mtklein@google.com Review URL: https://codereview.chromium.org/26871003 git-svn-id: http://skia.googlecode.com/svn/trunk@11706 2bbb7eff-a529-9590-31e7-b0007b416f81
* make explicit the requirement that all colorfilters are reentrant-safeGravatar reed@google.com2013-10-10
| | | | | | | | | BUG= R=mtklein@google.com Review URL: https://codereview.chromium.org/26876002 git-svn-id: http://skia.googlecode.com/svn/trunk@11705 2bbb7eff-a529-9590-31e7-b0007b416f81
* Insert swapbuffers into GPU benchmarks.Gravatar djsollen@google.com2013-10-10
| | | | | | | | R=mtklein@google.com Review URL: https://codereview.chromium.org/26489003 git-svn-id: http://skia.googlecode.com/svn/trunk@11704 2bbb7eff-a529-9590-31e7-b0007b416f81
* gm: if test has no expectations, record its result as no-expectations ↵Gravatar epoger@google.com2013-10-10
| | | | | | | | | | | | | | | | regardless of ignoreFailure After https://code.google.com/p/skia/source/detail?r=11640 ('Ignore any pdf-poppler GM failures'), there are a bunch of pdf-poppler tests showing up as failure-ignored at http://c128.i.corp.google.com/production-gm-diffs/latest/view.html Make them go away. R=scroggo@google.com Review URL: https://codereview.chromium.org/26650005 git-svn-id: http://skia.googlecode.com/svn/trunk@11703 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add -fPIC fro tsan (isn't alrady set in non-library).Gravatar bungeman@google.com2013-10-10
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11702 2bbb7eff-a529-9590-31e7-b0007b416f81
* Enable -fPIE, and -pie in tsan build. We're already -fPIC.Gravatar bungeman@google.com2013-10-10
| | | | | | | | R=mtklein@google.com Review URL: https://codereview.chromium.org/26142003 git-svn-id: http://skia.googlecode.com/svn/trunk@11701 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add leak to valgrind.suppGravatar robertphillips@google.com2013-10-10
| | | | | | | | https://codereview.chromium.org/26869002/ git-svn-id: http://skia.googlecode.com/svn/trunk@11700 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline Nexus 7 GM results after upgrading devices to 4.3Gravatar djsollen@google.com2013-10-10
| | | | | | | | | | | The fonts have changed as a result of the upgrade so all GMs with text are reporting as mismatches. R=robertphillips@google.com Review URL: https://codereview.chromium.org/26866002 git-svn-id: http://skia.googlecode.com/svn/trunk@11699 2bbb7eff-a529-9590-31e7-b0007b416f81
* New expectations files for skimage.Gravatar scroggo@google.com2013-10-10
| | | | | | | | | | | | | | | | | | | | | | | Copies them from expectations/skimage/buildername.json to expectations/skimage/buildername/expected-results.json. Required for https://codereview.chromium.org/26734006/ and ultimately BUG=skia:1466 A follow up change will delete the old expectations files once https://codereview.chromium.org/26734006/ has landed. (SkipBuildbotRuns) - Since the new expectations files aren't even read yet (they won't be until https://codereview.chromium.org/26734006/ is checked in), this need not be tested by the buildbots (yet). Unreviewed. BUG=skia:1466 Review URL: https://codereview.chromium.org/26865002 git-svn-id: http://skia.googlecode.com/svn/trunk@11698 2bbb7eff-a529-9590-31e7-b0007b416f81