aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Roll skia/third_party/externals/angle2/ 8b92c53b8..107c72476 (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/8b92c53b8a8c..107c724765a9 $ git log 8b92c53b8..107c72476 --date=short --no-merges --format='%ad %ae %s' 2018-03-20 oetuaho ShaderVariable: separate fields for staticUse and active 2018-03-16 oetuaho Move AST utilities to a subdirectory Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: I90ecd1f2439154385ee6447124fe28fffb8e1cf5 Reviewed-on: https://skia-review.googlesource.com/115980 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* lock before using fCacheKeys in ~SkImageFilter()Gravatar Mike Klein2018-03-22
| | | | | | | | | | | | | | | | | | No other code can be using an SkImageFilter() while it's being destroyed, so there's not a chance of a race per-se here. But, because we have not acquired fMutex, there is technically a possibility that the destructor sees an outdated version of fCacheKeys, not necessarily reflecting the last change(s) made while another core held the mutex. This is an unlikely case, but it's worth fixing by locking in the destructor. This will always be uncontended, and so very cheap. Bug: skia:7666 Change-Id: I9f705bc6e8e99162b90d59b30b8dd51c4f238970 Reviewed-on: https://skia-review.googlesource.com/115929 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* dm: fix unused-private-field error when skia_use_expat=falseGravatar Hal Canary2018-03-22
| | | | | | | | Change-Id: I309aa420a7900c048c34873ede618f123719823c Reviewed-on: https://skia-review.googlesource.com/115928 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* add repro case for skia:7674Gravatar Mike Klein2018-03-22
| | | | | | | | | | | Nice to have something to trigger this issue. Bug: skia:7674 Change-Id: I653699b82f3a8a4d551f3cd98b6a7e7620c6e035 Reviewed-on: https://skia-review.googlesource.com/115920 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* rm SkTDArray::{Deleter,release()}Gravatar Mike Klein2018-03-22
| | | | | | | | | | These are unused, and would make it conceptually tricky to replace with something like std::vector that does not have a .release() method. Change-Id: Iaee913d6a513d078989166c6e97097eeec0100ba Reviewed-on: https://skia-review.googlesource.com/115921 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* [sksg] Simplify TrimEffectGravatar Florin Malita2018-03-22
| | | | | | | | | | | | Move the Lottie-specific bits to Skottie and keep TrimEffect as a thin SkTrimPathEffect wrapper. TBR= Change-Id: Iecc6624d01ba61eb96a2056ef8e9e24e731f8979 Reviewed-on: https://skia-review.googlesource.com/115923 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Remove the last uses of auto glyph cache.Gravatar Herb Derby2018-03-22
| | | | | | | Change-Id: I15fdc5bbe29aaa969fe6ec57010919b52249fd7f Reviewed-on: https://skia-review.googlesource.com/115886 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Better decisions about choosing AAA versus DAAGravatar Yuqian Li2018-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Chrome perf regressions (817942, 819185) are caused by the bad choices to use DAA instead of AAA for stroking simple curves. (BTW, in my tests, DAA is still faster than SAA so it's not too much of a regression.) We previously only considered the number of line segments, but not the length of each segment. That leads to our wrong judgement of the path complexity (the number of intersections per scan line) when there are many short line segments. The change will bring the following performance change to our nanobench: 8.45% slower in clip_strategy_path_10 8.39% slower in draw_stroke_bezier_quad_square_bevel_10 3.91% slower in chart_aa 3.76% faster in lines 6.29% faster in path_stroke_big_oval 22.81% faster in path_stroke_big_circle 24.44% faster in giantdashline_vert_2 The two slower cases, clip_strategy_path_10 and draw_stroke_bezier_quad_square_bevel_10 are caused by choosing AAA over DAA. Those two tests do seem to be simple strokes. I'll later investigate why AAA is slower than DAA for those two cases. For now, I think that this change is sufficient to address those chromium perf regresssions. Bug: chromium:817942 chromium:819185 Change-Id: I1d13c968b17f257b4ede4c70e552db5016baf1ab Reviewed-on: https://skia-review.googlesource.com/115583 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
* Reland "Remove legacy precision boundary"Gravatar Yuqian Li2018-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit dab15f7a02ddaa2a6977a14d5d04955bd39350ab. Reason for revert: the Android roll is broken by something else: b/76126268 Original change's description: > Revert "Remove legacy precision boundary" > > This reverts commit a2513c14c4e143984b2eec07f5263b5cdc6c84bb. > > Reason for revert: This is breaking the Android roll. > > Original change's description: > > Remove legacy precision boundary > > > > Bug: skia:7731 > > Change-Id: I86a87b960541c2bc7b099ca9f609342cb0bbf563 > > Reviewed-on: https://skia-review.googlesource.com/115652 > > Reviewed-by: Cary Clark <caryclark@google.com> > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > TBR=caryclark@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > Change-Id: I45b14f5a84e97cc1022b99c414f90126d368f598 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:7731 > Reviewed-on: https://skia-review.googlesource.com/115840 > Reviewed-by: Derek Sollenberger <djsollen@google.com> > Commit-Queue: Derek Sollenberger <djsollen@google.com> TBR=djsollen@google.com,caryclark@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com Change-Id: I5d957cb7be9cc578672079e98ab5e131ad249f70 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7731 Reviewed-on: https://skia-review.googlesource.com/115940 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Support GL_RGB textures and render targets.Gravatar Brian Salomon2018-03-22
| | | | | | | | | Bug= skia:7533 Change-Id: Iba30e90dbf2574368b773bb5cf2ebd5219559717 Reviewed-on: https://skia-review.googlesource.com/108188 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* switched SPIR-V vertexid to vertexindexGravatar Ethan Nicholas2018-03-22
| | | | | | | | Bug: skia: Change-Id: I32c10e2874feea63d7fa048057ef57e27d5874bc Reviewed-on: https://skia-review.googlesource.com/115880 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Revert "Remove legacy precision boundary"Gravatar Derek Sollenberger2018-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a2513c14c4e143984b2eec07f5263b5cdc6c84bb. Reason for revert: This is breaking the Android roll. Original change's description: > Remove legacy precision boundary > > Bug: skia:7731 > Change-Id: I86a87b960541c2bc7b099ca9f609342cb0bbf563 > Reviewed-on: https://skia-review.googlesource.com/115652 > Reviewed-by: Cary Clark <caryclark@google.com> > Commit-Queue: Yuqian Li <liyuqian@google.com> TBR=caryclark@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com Change-Id: I45b14f5a84e97cc1022b99c414f90126d368f598 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7731 Reviewed-on: https://skia-review.googlesource.com/115840 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
* update SkIRect centerx centery docsGravatar Cary Clark2018-03-22
| | | | | | | | | | | R=caryclark@google.com Docs-Preview: https://skia.org/?cl=115820 Bug: skia:6898 Change-Id: I1d3c32d40ed4000f060a535cbcd20b39d0ff9fc3 Reviewed-on: https://skia-review.googlesource.com/115820 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* Roll skia/third_party/externals/angle2/ 3395c8b96..8b92c53b8 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/3395c8b96333..8b92c53b8a8c $ git log 3395c8b96..8b92c53b8 --date=short --no-merges --format='%ad %ae %s' 2018-03-22 jmadill Skip EnableQueryExtensions test on Win/AMD/GL. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: I426605ce837e923ad0318891070acc8d4c7ec45a Reviewed-on: https://skia-review.googlesource.com/115784 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Update markdown filesGravatar Update Docs2018-03-22
| | | | | | | | | | | | Automatic commit by the Housekeeper-Nightly-Bookmaker bot. TBR=update-docs@skia.org NO_MERGE_BUILDS Change-Id: I45266ef6d16220b223f60062248e9ad8ad4d7402 Reviewed-on: https://skia-review.googlesource.com/115782 Reviewed-by: Update Docs <update-docs@skia.org> Commit-Queue: Update Docs <update-docs@skia.org>
* Roll skia/third_party/externals/angle2/ 8574357f1..3395c8b96 (5 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/8574357f1798..3395c8b96333 $ git log 8574357f1..3395c8b96 --date=short --no-merges --format='%ad %ae %s' 2018-03-21 cwallez Make infra.cq to point to new Mac configs. 2018-03-21 ynovikov Revert "Skip TransformFeedbackLifetimeTest.DeletedBuffer on Win Intel GL" 2018-03-20 lucferron Vulkan: Support of npot textures 2018-03-19 oetuaho Fix asserts related to writing nameless parameters in HLSL 2018-03-15 jiawei.shao ES31: Support queries on primitives generated by geometry shader Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: I1c50c92c322b0724e33ec2e623b0739d3509dd37 Reviewed-on: https://skia-review.googlesource.com/115763 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* back to individual flags for :hswGravatar Mike Klein2018-03-22
| | | | | | | | | | We still have some bots that use GCC 4.8 that don't understand -march=haswell. I hope to fix that, then revert this. Change-Id: I8ba99d7170d00945e07da33b893a63981b64f5ca Reviewed-on: https://skia-review.googlesource.com/115761 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Remove some MSVC 32-bit Perf/Test jobs.Gravatar Ben Wagner2018-03-21
| | | | | | | | No-Try: true Change-Id: Iaf292ac9875312d3f1fcc81fdc64c3c587f68286 Reviewed-on: https://skia-review.googlesource.com/113674 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* update_meta_config: Use new LUCI optional GPU Android trybotGravatar Yuly Novikov2018-03-21
| | | | | | | | | BUG=chromium:731979 Change-Id: Ief5917b06e6c9164cc3bccdd89da169d1e169ba7 Reviewed-on: https://skia-review.googlesource.com/115703 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* [infra] Use new LUCI Mac trybotGravatar Eric Boren2018-03-21
| | | | | | | | | Bug: 824467 Change-Id: I30b34620fa3dd3ce8b21550f7bcdfa9b8c68a2bc Reviewed-on: https://skia-review.googlesource.com/115702 Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* limit discrete path effect iterationsGravatar Cary Clark2018-03-21
| | | | | | | | | R=fmalita@google.com, reed@google.com Bug: skia:7737 Change-Id: I339548f7a39618d7559182487e8969d591953b89 Reviewed-on: https://skia-review.googlesource.com/115659 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* Add Node as a bot asset.Gravatar Joe Gregorio2018-03-21
| | | | | | | | | | | Should be used for running karma tests on skia-elements and also for running lottiecap on bots. Bug: skia: Change-Id: I5c48cb741017be4eda014faea77ab88dec2e9637 Reviewed-on: https://skia-review.googlesource.com/115622 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Joe Gregorio <jcgregorio@google.com>
* small ABI + narrow/wide code updatesGravatar Mike Klein2018-03-21
| | | | | | | | | | | | | | | | | | | | The only tangible effect this CL should have is to use __vectorcall on all Windows builds, including scalar ones. The code generation is a little better there with __vectorcall than not, so might as well. This is a baby step towards vector stages with MSVC, but a very baby step indeed. Mostly this refactors and regroups a bunch of logic to reflect my current thoughts. The BUILD.gn changes are essentially no-ops, but they simplify things and make our flags more similar to how those targets are built in Chromium. (And I cleaned up other /arch: uses so this works.) Change-Id: I73dd39d15cdc7b3d268231a707952bbbfd91496e Reviewed-on: https://skia-review.googlesource.com/115644 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Remove deprecated version of SkImage::MakeFromAdoptedTexture that does not ↵Gravatar Brian Salomon2018-03-21
| | | | | | | | | | take SkColorType Bug: skia:6718 Change-Id: Ia2762855078bcbad8faf2f538f0afc64913e5e9b Reviewed-on: https://skia-review.googlesource.com/115364 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove legacy precision boundaryGravatar Yuqian Li2018-03-21
| | | | | | | | Bug: skia:7731 Change-Id: I86a87b960541c2bc7b099ca9f609342cb0bbf563 Reviewed-on: https://skia-review.googlesource.com/115652 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* ccpr: Use a more stable formula to find quadratic coordinatesGravatar Chris Dalton2018-03-21
| | | | | | | | | | | | | | | The 3x3 inverse grew unstable on small curves with large coordinates, not to mention being inefficient. This fixes many bad pixels on the chalkboard. Also begins scaling curve gradients by the AA bloat, in order to match triangle edges more closely and visualize curve AA in the ccpr sample. Bug: skia: Change-Id: I0f7da2e7599d4d5c458b3dd307185679dc78bb50 Reviewed-on: https://skia-review.googlesource.com/115527 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* change canvas-state to just record clip boundsGravatar Mike Reed2018-03-21
| | | | | | | | | | | | This reflects the long-standing restrictions in our clients (webview) and the reality of the gpu target which just uses scissors. It also removes one of the few callers of canvas::clipRegion, which we'd like to remove. Bug: skia: Change-Id: Ie3b3c6e8752f82cddef256f753000f9da4bdbdee Reviewed-on: https://skia-review.googlesource.com/113260 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Mike Reed <reed@google.com>
* GrGLExtensions: remove unneded unique_ptrGravatar Hal Canary2018-03-21
| | | | | | | Change-Id: Ic949b186fbb4f503d2edbea7033ad242c12ad101 Reviewed-on: https://skia-review.googlesource.com/115640 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Update Android build file for SkQP to point to ndk compliant libjsoncppGravatar Derek Sollenberger2018-03-21
| | | | | | | | Bug: b/74442448 Change-Id: If5e0e349cdb13352d580e55b0af26c908cc80003 Reviewed-on: https://skia-review.googlesource.com/115605 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
* Fix version check for vulkan layersGravatar Greg Daniel2018-03-21
| | | | | | | | Bug: skia: Change-Id: I9520899c4b86d6436e3697d0cc6358c2b8641169 Reviewed-on: https://skia-review.googlesource.com/114686 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Add texture-specific flags for External & Rectangle texturesGravatar Robert Phillips2018-03-21
| | | | | | | | | | | | | | | | For DDLs, Ganesh needs to know about External & Rectangle textures prior to instantiation (or PromiseImage fulfillment). These new flags allow the client to provide this information when the lazyProxy is created. The new texture flags work analogously to the render target flags: GrSurface and GrSurfaceProxy get a new set of accessors for the new flags The new flags are set appropriately on a GrGLTexture when it is created For wrapped texture proxies the flags are just copied off of the GrSurface For lazy-proxies/promise-images the flags are computed up front and passed to the proxy The GrSurfaceProxy/GrSurface flags equivalence is verified in GrSurfaceProxy::assign Change-Id: Ia8e1998aa0a36ce4481bfd9e56be21f990e83148 Reviewed-on: https://skia-review.googlesource.com/114985 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/externals/angle2/ b2c60b1a1..8574357f1 (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/b2c60b1a1950..8574357f1798 $ git log b2c60b1a1..8574357f1 --date=short --no-merges --format='%ad %ae %s' 2018-03-19 oetuaho Share parameter arrays more between built-in functions 2018-03-15 oetuaho Remove desktop GLSL builtins from symbol lookups Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: Ib426b7e7e770c049ad679ca749b83ba5236b91d3 Reviewed-on: https://skia-review.googlesource.com/115623 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Simplify format_rowbyts calculation.Gravatar Herb Derby2018-03-21
| | | | | | | | | As per comment in change 114371. Change-Id: I9724d5df205bb1430ebd3371677cce344372decc Reviewed-on: https://skia-review.googlesource.com/115610 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Try to have glyph count go through to allow easier glyphid setsGravatar Herb Derby2018-03-21
| | | | | | | Change-Id: I402e7240629db58c4212049583d6a06bcf7dcc40 Reviewed-on: https://skia-review.googlesource.com/115606 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Remove more uses of SkAutoGlyphCache.Gravatar Herb Derby2018-03-21
| | | | | | | Change-Id: I438bfb1a43857aa9e7e29b19e53dd921ec6eab1a Reviewed-on: https://skia-review.googlesource.com/115604 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Herb Derby <herb@google.com>
* handle extreme dashesGravatar Cary Clark2018-03-21
| | | | | | | | | | | | | Make searching indices unsigned so intermediate middle doesn't overflow. Verified fix runs test in skia:7675 successfully. R=reed@google.com Bug: skia:7675 Change-Id: I76be1d3fee8875ae9eb2b18eb070ef66c8006c03 Reviewed-on: https://skia-review.googlesource.com/114798 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* Port 2 Canvas fuzzers to oss-fuzzGravatar Kevin Lubick2018-03-21
| | | | | | | | Bug: skia: Change-Id: I0d34bfff4a53f831986614844bdc955935f28501 Reviewed-on: https://skia-review.googlesource.com/115582 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* fixed attributes of sk_InvocationIDGravatar Ethan Nicholas2018-03-21
| | | | | | | | Bug: skia: Change-Id: I549fdfa75f536e00f14bca445753f4c1354fa5d0 Reviewed-on: https://skia-review.googlesource.com/115361 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* fix MakeFromImage examplesGravatar Cary Clark2018-03-21
| | | | | | | | | | | deprecated flavor, erroneously used, have been removed Docs-Preview: https://skia.org/?cl=115581 Bug: skia:6898 Change-Id: Idc47411831985d4504ce1b230cb02731ec8a2edb Reviewed-on: https://skia-review.googlesource.com/115581 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Move DDL TSAN bot to Release & add Release DDL ASAN botGravatar Robert Phillips2018-03-21
| | | | | | | Change-Id: Icbbbe7275cf9bc62cbc175d4453affa12ded495a Reviewed-on: https://skia-review.googlesource.com/115526 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/externals/angle2/ 427071ea3..b2c60b1a1 (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/427071ea307a..b2c60b1a1950 $ git log 427071ea3..b2c60b1a1 --date=short --no-merges --format='%ad %ae %s' 2018-03-20 ynovikov cq.cfg: equivalent_to to 100% for Android tryservers. 2018-03-01 ynovikov Rename vulkan_loader to libvulkan Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: I3b10736bbf6a790a3c49bb9872b2a86a03ec5b0f Reviewed-on: https://skia-review.googlesource.com/115541 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll skia/third_party/externals/angle2/ b391ec408..427071ea3 (3 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/b391ec40837c..427071ea307a $ git log b391ec408..427071ea3 --date=short --no-merges --format='%ad %ae %s' 2018-03-19 jiawei.shao ES31: Add link validation on geometry shader interface block limits 2018-03-12 lfy GLES1: Revise entry points 2018-03-20 cwallez cq.cfg: equivalent_to to 100% for Mac tryservers. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: I7ed8950262abb9695fc888fda0a44dd5076f6d24 Reviewed-on: https://skia-review.googlesource.com/115530 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Switch to new NVIDIA drivers on Win2k8 Golo bots.Gravatar Ben Wagner2018-03-20
| | | | | | | | | Bug: chromium:823867 Change-Id: Ic6a738907beb573c8f66b38b6a7e56e330c08f5b No-Try: true Reviewed-on: https://skia-review.googlesource.com/115522 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Don't add change listeners to pixelRefs in DDL modeGravatar Robert Phillips2018-03-20
| | | | | | | | Change-Id: I1ddfec1e0d697dd4ed183c304514b14c89aca11d Reviewed-on: https://skia-review.googlesource.com/115400 Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* [lottiecap] Fix timestamp calculation to exactly match skottie in DM.Gravatar Joe Gregorio2018-03-20
| | | | | | | | | | Also use the much faster goToAndStop() call. Bug: skia: Change-Id: I22b8ac2b3d2fd70da4b396cb6b4ad50485a6f408 Reviewed-on: https://skia-review.googlesource.com/115324 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Joe Gregorio <jcgregorio@google.com>
* Reland "Switch Win Exceptions Build to Clang."Gravatar Ben Wagner2018-03-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2f2419b936150e24ca1aea891ba405c8ea8ebdc7. Reason for revert: Creating CL to reland Original change's description: > Revert "Switch Win Exceptions Build to Clang." > > This reverts commit e1cb4778c70a6bef543a8936c5521a71a037f551. > > Reason for revert: Need to revert dependency https://skia-review.googlesource.com/c/skia/+/114093 > > Original change's description: > > Switch Win Exceptions Build to Clang. > > > > No-Try: true > > Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431 > > Reviewed-on: https://skia-review.googlesource.com/113673 > > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > > Reviewed-by: Mike Klein <mtklein@google.com> > > TBR=mtklein@google.com,benjaminwagner@google.com > > Change-Id: I36f4c6cdf890043d4b77b8d5347b4752f58ebd33 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/114420 > Reviewed-by: Ben Wagner <benjaminwagner@google.com> > Commit-Queue: Ben Wagner <benjaminwagner@google.com> TBR=mtklein@google.com,benjaminwagner@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ie4ba6c264b3ab2b3c63ac0e225638b0a4e70cda1 Reviewed-on: https://skia-review.googlesource.com/114822 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* ccpr: Update the sample to use proper coverage count buffersGravatar Chris Dalton2018-03-20
| | | | | | | | Bug: skia: Change-Id: I6ce3ec567e671fa2ab3f05403015b48251518227 Reviewed-on: https://skia-review.googlesource.com/115072 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* fix pathop fuzzerGravatar Cary Clark2018-03-20
| | | | | | | | | | | turn assert into fail R=kjlubick@google.com Bug: skia: Change-Id: I1124573959c90c7dae1a8cd54199dae429b8ca73 Reviewed-on: https://skia-review.googlesource.com/115481 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>
* more SkImageInfo docsGravatar Cary Clark2018-03-20
| | | | | | | | | | | | | | | fix a couple of fiddles with changed output rewrite some SkSurface image makers move towards replacing SkImageInfo.h R=caryclark@google.com Docs-Preview: https://skia.org/?cl=115163 Bug: skia:6898 Change-Id: Id9895b051cd457336c30250a69cf95359d1d34d7 Reviewed-on: https://skia-review.googlesource.com/115163 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Reland "Add Win x86 Clang Perf/Test jobs."Gravatar Ben Wagner2018-03-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9aef424b71a3b200b4c8cf12a7541991622ccabf. Reason for revert: Creating CL to reland Original change's description: > Revert "Add Win x86 Clang Perf/Test jobs." > > This reverts commit 40091fd4fc453eb514bf7ca903326fa3538ab6c9. > > Reason for revert: Need to revert dependency https://skia-review.googlesource.com/c/skia/+/114093 > > Original change's description: > > Add Win x86 Clang Perf/Test jobs. > > > > Also switch CQ Win 32-bit Build from MSVC to Clang. > > > > No-Try: true > > Change-Id: Ic312ee611b1e99143480840c08a9266a4d8b448b > > Reviewed-on: https://skia-review.googlesource.com/113672 > > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > > Reviewed-by: Mike Klein <mtklein@google.com> > > TBR=mtklein@google.com,benjaminwagner@google.com > > Change-Id: I6a13e97df461bd61eac92bbc3c498146b5322a4a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/114421 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Ben Wagner <benjaminwagner@google.com> TBR=mtklein@google.com,benjaminwagner@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I15f1d9fbc8cc91d62690c59ec8d4264a6959f7a0 Reviewed-on: https://skia-review.googlesource.com/114821 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>