aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Avoid possible memory leak with inner blurs.Gravatar Ben Wagner2018-05-11
| | | | | | | | | | | | | | | If the inner blur dst is too big, SkBlurMask::BoxBlur can return without freeing the intermediate blur mask. Fix this by using SkAutoMaskFreeImage. Use SkAutoMaskFreeImage instead of custom SkAutoTCallVProc in SkBlurMask::BlurGroundTruth. Make SkAutoMaskFreeImage a special kind of std::unique_ptr. Change-Id: I93dc54265416ca69254633b00f14be75009d990f Reviewed-on: https://skia-review.googlesource.com/127402 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com>
* reject large paths to avoid potential float overflowsGravatar Mike Reed2018-05-11
| | | | | | | | | | | I think this change can catch a host of potential fuzzer issues up-front, rather than adding finite tests in lots and lots of places down-stream. Bug: oss-fuzz:8131 Change-Id: I421aa72c6ca3df57b40dd32b805d6c847d8e8d29 Reviewed-on: https://skia-review.googlesource.com/127388 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Define ~GrContextThreadSafeProxy in GrContext.cppGravatar Brian Salomon2018-05-11
| | | | | | | | | | | | Otherwise GrCaps.h may be required in GrContext.h Change-Id: I67b2116b3bad2e7ebbb2157375c48023d2964f5c Reviewed-on: https://skia-review.googlesource.com/127394 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com>
* Shadow fixes to avoid popping.Gravatar Jim Van Verth2018-05-11
| | | | | | | | | | | * Make geometric shadow generation more tolerant of nearly-convex paths. * Ensure analytic and geometric shadow positions match with large blurs. Bug: skia: Change-Id: I8d3ba43b90d1520cb20f89de9f0b13d11a1a08c3 Reviewed-on: https://skia-review.googlesource.com/127045 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-11
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2ee036b744812ca2e9b30fae453ebe3e4dd83f5e api.py: Check if to_leak directory exists before deleting it (charliea@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I94cbbfcc274f47f609710c5526361012cc3b7786 Reviewed-on: https://skia-review.googlesource.com/127392 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* ccpr: Bugfix for cropped pathsGravatar Chris Dalton2018-05-11
| | | | | | | | | | | TBR=bsalomon@google.com Bug: skia:7948 Change-Id: I606bbad95260995dd3ea43c858591ae2d5c9cea1 Reviewed-on: https://skia-review.googlesource.com/127354 Reviewed-by: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Make GrCaps and GrShaderCaps private.Gravatar Brian Salomon2018-05-11
| | | | | | | | | Moves getCaps() from GrContext to GrContextPriv and removes unused refCaps(). Change-Id: Ic6a8951b656c0d1b2773eae73bff8e88af819866 Reviewed-on: https://skia-review.googlesource.com/127389 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Roll third_party/externals/angle2/ 2fc0806f5..8073a9511 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/2fc0806f5595..8073a9511a1e $ git log 2fc0806f5..8073a9511 --date=short --no-merges --format='%ad %ae %s' 2018-05-09 oetuaho Enable warning for non-virtual destructors Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=egdaniel@google.com Change-Id: Ib1b341bd8e4bc583d00bf39c068e22630234ec1b Reviewed-on: https://skia-review.googlesource.com/127540 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* [skottie] Guard against asset cyclesGravatar Florin Malita2018-05-11
| | | | | | | | | | Track assets being attached, and break cycles. Bug: oss-fuzz:8220 Change-Id: I146cf35eba8cfea487c00544fe82f89c3a859803 Reviewed-on: https://skia-review.googlesource.com/127381 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-11
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/e7273d25017a27aab7026bc0ef48fe9ab4e09f22 Reland "gclient: Get rid of parsed_url." (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4aaefe70d029b40f62ecdf7624900227e3a498d2 Reviewed-on: https://skia-review.googlesource.com/127307 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Roll third_party/externals/angle2/ 6110763fe..2fc0806f5 (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/6110763fec16..2fc0806f5595 $ git log 6110763fe..2fc0806f5 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 jmadill Micro-optimize uniform updates. 2018-05-09 lucferron Vulkan: Fix use-after-free with DynamicBuffer. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=egdaniel@google.com Change-Id: Ia4ba958265a70ae9dd196428a860b83dd492717b Reviewed-on: https://skia-review.googlesource.com/127385 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-10
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/3d894aa45e08b1d0d93483aa885df11e8156d93d bot_update: Fix manifest creation. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I015a27949f6212a96644755e840792a448b97b84 Reviewed-on: https://skia-review.googlesource.com/127382 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Non-normal blur styles to work with non-a8.Gravatar Ben Wagner2018-05-10
| | | | | | | | | BUG=skia:7941 Change-Id: I500561c2fec1bcab324fd9519f1d20d356afdfb5 Reviewed-on: https://skia-review.googlesource.com/127500 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Roll skia/third_party/skcms 5b9549a..28e8b32 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/5b9549a..28e8b32 2018-05-10 mtklein@chromium.org alternate isfinitef_() The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@google.com Change-Id: I7f97daac4d2caa153425e43ce6bd10cda400e91f Reviewed-on: https://skia-review.googlesource.com/127443 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Fix unchecked allocation in kImageFilter::Common::unflatten()Gravatar Florin Malita2018-05-10
| | | | | | | | | | | | | | | | | | | The bad news is we don't have a good way to validate the count against the available data size. The good news is we don't have to: most filters only use two inputs, which will fit in the stack-reserved storage; for those who don't, growing the input vector during deserialization should not be problematic. The CL drops the prea-allocation, and instead appends inputs iteratively. Also switches the storage to SkSTArray for append/push_back() support. Bug: oss-fuzz:8219 Change-Id: Ic6bf6e435e6e18b9e026aeb393612210c9e6e57a Reviewed-on: https://skia-review.googlesource.com/127306 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
* Revert "Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter."Gravatar Greg Daniel2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 333031b921264508ca1869769c1021bc08e4e07a. Reason for revert: Flutter roll into fuchsia got reverted so now this breaks fuchsia again.... Original change's description: > Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter. > > Bug: skia: > Change-Id: I2c8c116f825278cae4001d169aaef42ce9a21873 > Reviewed-on: https://skia-review.googlesource.com/125725 > Commit-Queue: Greg Daniel <egdaniel@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> TBR=egdaniel@google.com,robertphillips@google.com,brianosman@google.com Change-Id: I78f3cfae9ba690a34372d2081e47ec793cda3392 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/127481 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Revert "Remove GrBackendObject and all related functions from Skia."Gravatar Brian Osman2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ccd4cfc23ebbbecbc6b292359352aad335ad7b73. Reason for revert: Fuchsia not building again. (Flutter roll may have been reverted?) Original change's description: > Remove GrBackendObject and all related functions from Skia. > > Bug: skia: > Change-Id: I59434b7477c0bc26fd982bd81eb97ab94bbba073 > Reviewed-on: https://skia-review.googlesource.com/125822 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: Ie2c518b84b0c9513c0c622082de2831088b1ad8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/127480 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Revert "strip down SkICC.cpp"Gravatar Mike Klein2018-05-10
| | | | | | | | | | | | This reverts commit eab50eb9c6117c2a9d0e5648f89cebbb4dbd9d30 and this tiny bit of e61b969a07ba3ebe9e47e61381ad16c5d2c549a2: https://skia-review.googlesource.com/c/skia/+/127122/3/tests/ICCTest.cpp Change-Id: I4306e5118a4e5eb88c05078186a28bd443fd76f7 Reviewed-on: https://skia-review.googlesource.com/127305 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-10
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/2191308678e40e04930727589e11b26405afa165 Revert "gclient: Get rid of parsed_url." (jbudorick@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9cd80112f6de11d64c43304898de1f47efdc9a5f Reviewed-on: https://skia-review.googlesource.com/127400 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/d3f2c8e7834616e48fbe7cef9286029361b043c5 win_toolchain: Add another source dir for dbghelp.dll when packaging the toolchain (kkinnunen@nvidia.com) https://crrev.com/e877b1776a14eb96a5fa201e160022b85df488fe gclient: Get rid of parsed_url. (ehmaldonado@chromium.org) https://crrev.com/31a8da265a86aa3fec97edd5606cb443f633e6d7 bot_update: Assert no syncing of refs/remotes/* (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2981229dfec061e340bf75b3ad01fe63da4ebcb0 Reviewed-on: https://skia-review.googlesource.com/127339 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Add SkColorSpace::toProfileGravatar Brian Osman2018-05-10
| | | | | | | | | | | | | | Now that A2B parsing is at least as strict as skcms_Parse, this can never fail, so switch to void. Also use the new programmatic profile helpers, which also ensures the data and profile space fields are set correctly. Bug: skia: Change-Id: Ifc4d89a919ca178c484839bdf88dae8a162c3e4f Reviewed-on: https://skia-review.googlesource.com/127336 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
* Add GrContextThreadSafeProxy and remove most friends of GrContextThreadSafeProxyGravatar Brian Salomon2018-05-10
| | | | | | | | | | | A step towards removing GrCaps from GrContext.h Also adds operator== to GrContextThreadSafeProxy. Change-Id: Ic0bae12299dfb0ac8817d9f1c56a1219d6df97d9 Reviewed-on: https://skia-review.googlesource.com/127329 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* non-linear blending first stepsGravatar Mike Klein2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | Code: - Add a non-linear blending bit and makeNonlinearBlending() to SkColorSpace - remove enough F16=linear checks to make it possible to create surfaces and encode pngs with nonlinear F16 Testing: - add "esrgb" software config to DM, run it - add "srgbnl" software config, run it - deemphasize importance of "srgb" config on bots - update unit tests to reflect relaxed F16 constraints - add a new unit test file with _really_ basic tests, and a new unit test that's not working yet Bug: skia:7942 Change-Id: I8ac042bdf9f3d791765393b68fd9256375184d83 Reviewed-on: https://skia-review.googlesource.com/127325 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Add driver bug workarounds to GrCaps"Gravatar Greg Daniel2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 328490c6a1625ce51d0e81688e0c85c79c400d86. Reason for revert: Breaking compiles inside chrome Original change's description: > Add driver bug workarounds to GrCaps > > This moves GrDriverBugWorkarounds to include so that it can be included > by GrCaps. This also makes GrContextOptions a nearly empty class in > the case of !SK_SUPPORT_GPU so that non-gpu builds don't need to build > in GrDriverBugWorkarounds.cpp. > > Bug: chromium: 829614 > Change-Id: Iedf73677fd09e9a487cfe618a696fd4b25c8703d > Reviewed-on: https://skia-review.googlesource.com/126581 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Adrienne Walker <enne@chromium.org> TBR=bsalomon@google.com,enne@chromium.org Change-Id: I3b35bf65a7b78d2fe16d7c2bcd0e4b3f9bb7fdff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium: 829614 Reviewed-on: https://skia-review.googlesource.com/127303 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Revert "Driver bug workaround: disable_blend_equation_advanced"Gravatar Greg Daniel2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f31fece6581a46b40403fc78c83c7eebe50816ba. Reason for revert: need to revert to revert original change breaking chrome compile Original change's description: > Driver bug workaround: disable_blend_equation_advanced > > Bug: chromium: 829614 > Change-Id: If8eaec6d22412ec36aad8a143f84080be05f2926 > Reviewed-on: https://skia-review.googlesource.com/126748 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Adrienne Walker <enne@chromium.org> TBR=bsalomon@google.com,enne@chromium.org Change-Id: Ic870fbbad615d13569254c355ef6b8281332d60d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium: 829614 Reviewed-on: https://skia-review.googlesource.com/127301 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Revert "Driver bug workaround: disable_discard_framebuffer"Gravatar Greg Daniel2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8aa0dca395d49b136ab59f6e96c4446342c9ebd2. Reason for revert: need to revert to revert original change breaking chrome compile Original change's description: > Driver bug workaround: disable_discard_framebuffer > > Bug: chromium: 829614 > Change-Id: I285b39b31a370247518e3a0b56ac4ea54f38c0c0 > Reviewed-on: https://skia-review.googlesource.com/126749 > Commit-Queue: Adrienne Walker <enne@chromium.org> > Commit-Queue: Brian Salomon <bsalomon@google.com> > Auto-Submit: Adrienne Walker <enne@chromium.org> > Reviewed-by: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,enne@chromium.org Change-Id: I563808025a8f77807478c0f0d42c3009c3b57ea5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium: 829614 Reviewed-on: https://skia-review.googlesource.com/127302 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* [skottie] Clean up AttachLayerContextGravatar Florin Malita2018-05-10
| | | | | | | | | | | Avoid double "ind" lookups, avoid repeated AttachParentLayerMatrix calls, hide private functions. TBR= Change-Id: I78f11593ffe241de3cdfabf7b3a88e8f4e62aa0c Reviewed-on: https://skia-review.googlesource.com/127327 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Driver bug workaround: disable_discard_framebufferGravatar Adrienne Walker2018-05-10
| | | | | | | | | | Bug: chromium: 829614 Change-Id: I285b39b31a370247518e3a0b56ac4ea54f38c0c0 Reviewed-on: https://skia-review.googlesource.com/126749 Commit-Queue: Adrienne Walker <enne@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* rm SkColorSpace_NewGravatar Mike Klein2018-05-10
| | | | | | | | | | We think we can evolve SkColorSpace_XYZ into the One True SkColorSpace. Change-Id: If93493145d78b388f3a0739cc7ccd6e232380733 Reviewed-on: https://skia-review.googlesource.com/127326 Auto-Submit: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Roll third_party/externals/angle2/ a932b6b51..6110763fe (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/a932b6b51505..6110763fec16 $ git log a932b6b51..6110763fe --date=short --no-merges --format='%ad %ae %s' 2018-05-09 geofflang Refactor the GL surfaces and framebuffers to not hold renderer objects. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=egdaniel@google.com Change-Id: Iff9132819915df8d71bb8039c5cad85a9978be4a Reviewed-on: https://skia-review.googlesource.com/127349 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Driver bug workaround: disable_blend_equation_advancedGravatar Adrienne Walker2018-05-10
| | | | | | | | Bug: chromium: 829614 Change-Id: If8eaec6d22412ec36aad8a143f84080be05f2926 Reviewed-on: https://skia-review.googlesource.com/126748 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org>
* Switch machine-type for Coverage tasks.Gravatar Ben Wagner2018-05-10
| | | | | | | | | | | | | | | | Coverage doesn't seem to deal well with multiple threads. Using 2-core VMs is faster than using 64-core VMs. On the other hand, the Coverage Upload task performs much better on a 64-core VM. Bug: skia:7415 No-Try: true Change-Id: Ieb58fc47970dd66fa64cf6a8c9de1f9236e2f3a0 Reviewed-on: https://skia-review.googlesource.com/127053 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* use 64bit math in TArray reallocGravatar Mike Reed2018-05-10
| | | | | | | | Bug: oss-fuzz:8217 Change-Id: Idecd1867e7047744477c7dfbb6c9bc5654a36ade Reviewed-on: https://skia-review.googlesource.com/127324 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Reed <reed@google.com>
* [skottie] Allow divide-by-zero in PolyStarAdapter::applyGravatar Florin Malita2018-05-10
| | | | | | | | | | This is safe because count == 0 will produce an empty path. Bug: oss-fuzz:8213 Change-Id: Ie3b546c614ba22eef1ba16a182016c2edd0bd641 Reviewed-on: https://skia-review.googlesource.com/127323 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* allow divide by zeroGravatar Mike Reed2018-05-10
| | | | | | | | Bug: oss-fuzz:8214 Change-Id: Ieb2e61b23f88e399df3bfb284742d4604b7d27fa Reviewed-on: https://skia-review.googlesource.com/127322 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Validate readByteArrayAsData sizeGravatar Florin Malita2018-05-10
| | | | | | | | | | | | Check that the reader has enough data before attempting to allocate the buffer. Also update to return nullptr on read failures. Change-Id: Ia1ea8f611bad95cf3a4493b12582ac3fa7c2b00f Reviewed-on: https://skia-review.googlesource.com/127129 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Add driver bug workarounds to GrCapsGravatar Adrienne Walker2018-05-10
| | | | | | | | | | | | | This moves GrDriverBugWorkarounds to include so that it can be included by GrCaps. This also makes GrContextOptions a nearly empty class in the case of !SK_SUPPORT_GPU so that non-gpu builds don't need to build in GrDriverBugWorkarounds.cpp. Bug: chromium: 829614 Change-Id: Iedf73677fd09e9a487cfe618a696fd4b25c8703d Reviewed-on: https://skia-review.googlesource.com/126581 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org>
* Remove GrBackendObject and all related functions from Skia.Gravatar Greg Daniel2018-05-10
| | | | | | | | Bug: skia: Change-Id: I59434b7477c0bc26fd982bd81eb97ab94bbba073 Reviewed-on: https://skia-review.googlesource.com/125822 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Validate gradient DescriptorScope size during deserializationGravatar Florin Malita2018-05-10
| | | | | | | | | | Check that the reader has sufficient data before allocating buffers. Bug: skia:7937 Change-Id: I2352d9a5cbace77b77c150a3a6439e8ac18b0dc5 Reviewed-on: https://skia-review.googlesource.com/127132 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Revert "Revert "Don't use GrRRectBlurEffect for large rects when highp is ↵Gravatar Brian Salomon2018-05-10
| | | | | | | | | | | | | not full float"" This reverts commit 729715298c8af1d2ecc4cbe887eeeb9a1c17c595. Changed std::abs() to SkScalarAbs() and #include "SkScalar.h" Change-Id: I9a02ca1a63eef748f9a11d324e8bb89e14571bc9 Reviewed-on: https://skia-review.googlesource.com/127320 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter.Gravatar Greg Daniel2018-05-10
| | | | | | | | | Bug: skia: Change-Id: I2c8c116f825278cae4001d169aaef42ce9a21873 Reviewed-on: https://skia-review.googlesource.com/125725 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Add all SkPaint::Flags to Viewer app.Gravatar Ben Wagner2018-05-10
| | | | | | | | | | Originally a change to add just one more, turned into adding all of them. Change-Id: Ibd6b6cab75d5a018744661038cfccdb50470c234 Reviewed-on: https://skia-review.googlesource.com/127134 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Fix clipping of SkMatrixImageFilter input (take 2)Gravatar Robert Phillips2018-05-10
| | | | | | | | | | This cannot land before the Chrome CL https://chromium-review.googlesource.com/c/chromium/src/+/1052850 (Add a flag to ignore an upcoming Skia bug fix that changes layout and unit tests) Bug: skia:7931 Change-Id: I2951a727bd3f61aeda0e1e322cd76e48f677f75f Reviewed-on: https://skia-review.googlesource.com/127125 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Update markdown filesGravatar skia-bookmaker2018-05-10
| | | | | | | | | | | | Automatic commit by the Housekeeper-Nightly-Bookmaker bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: Ib0606cbde7503bf15575f9ac7b0f8f407c2fcc08 Reviewed-on: https://skia-review.googlesource.com/127229 Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com> Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
* Roll third_party/externals/angle2/ 7348fc5b9..a932b6b51 (4 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/7348fc5b9e0d..a932b6b51505 $ git log 7348fc5b9..a932b6b51 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 lucferron Vulkan: Fix in DynamicBuffer, allocating too many buffers for no reason 2018-05-08 jmadill Reland "Update cq.cfg with new builders." 2018-05-09 geofflang Merge the Framebuffer onDestroy and onDestroyDefault methods. 2018-05-09 geofflang Pass a context pointer to Framebuffer[Impl]::getSamplePosition Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=egdaniel@google.com Change-Id: I17b6ebe367c0db1af71052f03b88e1f36236bd03 Reviewed-on: https://skia-review.googlesource.com/127227 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-10
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/7c3ff1311a4568e3d369c35560ff77b6b2bdef96 Introduce GIT_TRACE_PERFORMANCE (tikuta@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I6a25699d6434dee6f1aade3ff7f59842ba5334a0 Reviewed-on: https://skia-review.googlesource.com/127260 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-10
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/5623aeebe84fec98b7ae313368d1e57a6abfad65 Introduce GIT_TRACE for chromium/src in bot_update step (tikuta@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ief1196978f9bb1d5eca6bc255629588f9be77440 Reviewed-on: https://skia-review.googlesource.com/127240 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-10
| | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/b61d387fa2d4e0ea7da1807d2922a4f946343d2d gclient: Make GetScmName and CreateSCM abstract methods. (ehmaldonado@chromium.org) https://crrev.com/04065d39f743413a5dd57d8eb89c281454e03df8 Reland "bot_update: Fetch references to be synced." (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If6dbf9cd9367f1ccf6cce259c744b49bfbfd1cbb Reviewed-on: https://skia-review.googlesource.com/127135 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Fix extra texture creation in GrResourceProvider::createTexture() with SRGB ↵Gravatar Brian Salomon2018-05-09
| | | | | | | | | | | | | | | | | | | | data. We would make a temporary surface context around a scratch texture with a SRGB color space and then attempt writePixels with a src SkImageInfo with no color space. Then we'd fall back to creating a texture with initial data. Now we will make the src SkImageInfo have a SRGB color space and then assume success. Bug: b/78866720 Change-Id: I541a3b73c72f610533cfbc6892b2782c90e5121d Reviewed-on: https://skia-review.googlesource.com/127130 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove SkPaint::Flags::kDevKernFlag.Gravatar Ben Wagner2018-05-09
| | | | | | | | | It isn't used any more. Change-Id: I79fbbac13bb2595da0ae0cea7e42bca8fcccd8e8 Reviewed-on: https://skia-review.googlesource.com/127127 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Herb Derby <herb@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-10-23 15:08:33 +0000