aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Revert of add a Chrome builder to the CQ (patchset #1 id:1 of ↵Gravatar rmistry2016-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2085333002/ ) Reason for revert: Reverting due to purple trybots in https://codereview.chromium.org/2087343002/ We will have to investigate.. Original issue's description: > add a Chrome builder to the CQ > > This appears to be the fastest Chrome builder, averaging 8-9 minutes. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002 > > Committed: https://skia.googlesource.com/skia/+/cb4efa90ab5f6ea7cf5e0f44aec6f4e6418aad3d TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2087913003
* add a Chrome builder to the CQGravatar mtklein2016-06-22
| | | | | | | | | This appears to be the fastest Chrome builder, averaging 8-9 minutes. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002 Review-Url: https://codereview.chromium.org/2085333002
* Add guards around access to font cache global fields.Gravatar herb2016-06-22
| | | | | | | BUG=589439 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2082423002 Review-Url: https://codereview.chromium.org/2082423002
* Revert of GN (patchset #12 id:220001 of ↵Gravatar mtklein2016-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2087593002/ ) Reason for revert: gclient not happy on some bots Original issue's description: > GN > > What we've got here is a little GN MVP. It's lacking any knobs and doesn't yet build anything but libskia, zlib, libpng, and libjpeg-turbo. I've been hopping back and forth between Linux at work and Mac at home. These seem to be at least partially working, enough to build and run cmake/example.cpp. > > The xcode backend seems to work. From here, we can start exploring how to handle other backends (cmake,Android make, Google3). There are a couple things I want to try: > - add another backend like vs or xcode to GN directly > - intercept via a custom toolchain > - reverse from ninja -t commands > That last option seems kind of fun. > > This tries to piggyback on Chrome's GN setup as much as possible. Chrome's got quite a lot figured out, and we're basically required to do this if we want to have a single GN build system shareable by Chrome, our bots, and other clients. > > This pulls in some new DEPS: > - build: Chrome's GN configuration, and much more > - buildtools: hashes for gn binary, pulled via hooks > - tools/clang: hashes for Chrome's clang, pulled via hooks into third_party/llvm-build > It additionally symlinks tools/gyp to third_party/externals/gyp. GN pulls some stuff from tools/gyp on Mac. > > Have not yet tried building for Windows, Android, or iOS. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087593002 > > Committed: https://skia.googlesource.com/skia/+/1d8de594f126b9a80bd8f8fa2005e90faf3b5b17 TBR=bsalomon@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2088253002
* GNGravatar mtklein2016-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | What we've got here is a little GN MVP. It's lacking any knobs and doesn't yet build anything but libskia, zlib, libpng, and libjpeg-turbo. I've been hopping back and forth between Linux at work and Mac at home. These seem to be at least partially working, enough to build and run cmake/example.cpp. The xcode backend seems to work. From here, we can start exploring how to handle other backends (cmake,Android make, Google3). There are a couple things I want to try: - add another backend like vs or xcode to GN directly - intercept via a custom toolchain - reverse from ninja -t commands That last option seems kind of fun. This tries to piggyback on Chrome's GN setup as much as possible. Chrome's got quite a lot figured out, and we're basically required to do this if we want to have a single GN build system shareable by Chrome, our bots, and other clients. This pulls in some new DEPS: - build: Chrome's GN configuration, and much more - buildtools: hashes for gn binary, pulled via hooks - tools/clang: hashes for Chrome's clang, pulled via hooks into third_party/llvm-build It additionally symlinks tools/gyp to third_party/externals/gyp. GN pulls some stuff from tools/gyp on Mac. Have not yet tried building for Windows, Android, or iOS. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087593002 Review-Url: https://codereview.chromium.org/2087593002
* Tab -> spacesGravatar brianosman2016-06-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2082393002 Review-Url: https://codereview.chromium.org/2082393002
* Enable flattening and unflattening of SkColorSpaceGravatar msarett2016-06-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085653003 Review-Url: https://codereview.chromium.org/2085653003
* Use single alloc for vulkan optimal image heaps to fix memory crashGravatar egdaniel2016-06-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087283002 Review-Url: https://codereview.chromium.org/2087283002
* Revert of Bring back compiling third_party/libpng in public.bzl (patchset #3 ↵Gravatar scroggo2016-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | id:40001 of https://codereview.chromium.org/2044703006/ ) Reason for revert: Breaking Google3 Original issue's description: > Bring back compiling third_party/libpng in public.bzl > > Disable the optimizations for simplicity, as suggested in [1]. > > Remove PNG_SKIP_SETJMP_CHECK, which is not defined in version 1.6.22. > > [1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84 > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044703006 > > Committed: https://skia.googlesource.com/skia/+/e6939c15dc0c09f1348988dc56e50b6bea27b7ce TBR=benjaminwagner@google.com,msarett@google.com,mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2090643002
* Revert of Store mipmap levels in deferred texture image (patchset #15 ↵Gravatar brianosman2016-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:280001 of https://codereview.chromium.org/2034933003/ ) Reason for revert: Crashes on a few different bots (including ASAN). Examples: https://build.chromium.org/p/client.skia.android/builders/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release/builds/6324 https://build.chromium.org/p/client.skia/builders/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug/builds/5400 https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Debug-ASAN/builds/3539 Original issue's description: > Store mipmap levels in deferred texture image > > When creating the deferred texture image, detect if using medium / high > quality. If so, generate and store mipmaps in the deferred texture > image. > > When creating a texture from that be sure to read it back out. > > BUG=578304 > R=bsalomon@google.com > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2034933003 > > Committed: https://skia.googlesource.com/skia/+/b3105190a6e02d37f1d7f07a3a8bdd368ec7f157 TBR=bsalomon@google.com,ericrk@chromium.org,cblume@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=578304 Review-Url: https://codereview.chromium.org/2083393002
* Remove bubbles GMGravatar fmenozzi2016-06-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087263002 Review-Url: https://codereview.chromium.org/2087263002
* Revert of Support GL_SAMPLES queries in null contexts (patchset #2 id:20001 ↵Gravatar brianosman2016-06-22
| | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/2085043002/ ) Reason for revert: Chrome unit tests failing (eg https://codereview.chromium.org/2085243002) Original issue's description: > Support GL_SAMPLES queries in null contexts > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002 > > Committed: https://skia.googlesource.com/skia/+/64b92a59294a2f73448b3fa8f36f39079f032521 TBR=bsalomon@google.com,csmartdalton@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2089013003
* Support GL_SAMPLES queries in null contextsGravatar csmartdalton2016-06-21
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085043002 Review-Url: https://codereview.chromium.org/2085043002
* Bring back compiling third_party/libpng in public.bzlGravatar scroggo2016-06-21
| | | | | | | | | | | | Disable the optimizations for simplicity, as suggested in [1]. Remove PNG_SKIP_SETJMP_CHECK, which is not defined in version 1.6.22. [1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044703006 Review-Url: https://codereview.chromium.org/2044703006
* Store mipmap levels in deferred texture imageGravatar cblume2016-06-21
| | | | | | | | | | | | | | When creating the deferred texture image, detect if using medium / high quality. If so, generate and store mipmaps in the deferred texture image. When creating a texture from that be sure to read it back out. BUG=578304 R=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2034933003 Review-Url: https://codereview.chromium.org/2034933003
* Add new GM that exercises Gray 8 mipmapping and sRGB-nessGravatar brianosman2016-06-21
| | | | | | | | | | This demonstrates the bug that was fixed by: https://codereview.chromium.org/2088883002/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087933002 Review-Url: https://codereview.chromium.org/2087933002
* Remove check for cmake in android make script.Gravatar stani2016-06-21
| | | | | | | | | | Update docs explaining how to setup Android SDK. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084763003 DOCS_PREVIEW= https://skia.org/?cl=2084763003 Review-Url: https://codereview.chromium.org/2084763003
* Never use CPU-built mips for Gray_8.Gravatar brianosman2016-06-21
| | | | | | | | | | Fixes a bug where Gray_8 textures would still render as Alpha_8 (if the first draw was detected as needing mips). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2088883002 Review-Url: https://codereview.chromium.org/2088883002
* update callers to not use SkColorProfileTypeGravatar reed2016-06-21
| | | | | | | | | Requires https://codereview.chromium.org/2087833002/ to land first. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2086583002 Review-Url: https://codereview.chromium.org/2086583002
* Fix Mac clang linkerGravatar msarett2016-06-21
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2077353006 Review-Url: https://codereview.chromium.org/2077353006
* Integers can now be passed as uniforms; needed for passing color count to ↵Gravatar fmenozzi2016-06-21
| | | | | | | | | | fragment shader BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003 Committed: https://skia.googlesource.com/skia/+/cc3a22b369e1a60fa2acf2987f2934baf7c4b198 Review-Url: https://codereview.chromium.org/2076143003
* Add --simpleCodec to nanobench flags to run a smaller set of benchmarksGravatar msarett2016-06-21
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084683002 Review-Url: https://codereview.chromium.org/2084683002
* Apply canonicalizations to path GrShapes.Gravatar bsalomon2016-06-21
| | | | | | | | | | | | | | | | The following canonicalizations of path-backed GrShapes are added: *convex shapes are stored with even/odd (or inv even/odd) fill. *filled paths are closed. *dashed paths ignore inverseness of the fill This will improve the results of queries about the geometry that will be added in a future change. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067283003 Review-Url: https://codereview.chromium.org/2067283003
* Support texel and draw-indirect buffers in null GL contextsGravatar csmartdalton2016-06-21
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2081183002 Review-Url: https://codereview.chromium.org/2081183002
* Update SKP versionGravatar update-skps2016-06-21
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2086843002 Review-Url: https://codereview.chromium.org/2086843002
* Reorder colorspaces in GM to match previous behaviorGravatar brianosman2016-06-20
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2088493002 Review-Url: https://codereview.chromium.org/2088493002
* Benchmark rotated rect with AA/noAAGravatar liyuqian2016-06-20
| | | | | | | | | | | Using this benchmark, we verify that AA is about 4x slower than noAA in path_fill_big_rotated_rect. This is what I aim to improve in the next CL. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087453003 Review-Url: https://codereview.chromium.org/2087453003
* Buildbot spec: Add device_type for Android OneGravatar borenet2016-06-20
| | | | | | | BUG=skia:5185 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085713002 Review-Url: https://codereview.chromium.org/2085713002
* Exempt GrShape test from running on AndroidGravatar bsalomon2016-06-20
| | | | | | | BUG=skia:5438 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2074403003 Review-Url: https://codereview.chromium.org/2074403003
* Some simplifications of GrShape reductions/canonicalizationsGravatar bsalomon2016-06-20
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064113004 Review-Url: https://codereview.chromium.org/2064113004
* assert that non-empty clips have non-empty boundsGravatar reed2016-06-20
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084603002 TBR= Review-Url: https://codereview.chromium.org/2084603002
* Respect color type and gamma settings in nanobench GPU configsGravatar brianosman2016-06-20
| | | | | | | | | | We were ignoring the requested properties in things like gpuf16 and gpusrgb. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2075133003 Review-Url: https://codereview.chromium.org/2075133003
* More removal of SkColorProfileType...Gravatar brianosman2016-06-20
| | | | | | | | | | | Scrub GMs. Remove the gDefaultProfile thing (it's unused now), along with the command line flag that was setting it in DM and nanobench. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2071393002 Committed: https://skia.googlesource.com/skia/+/944876f2745a62a839e49275daf93a0329372e67 Review-Url: https://codereview.chromium.org/2071393002
* Sanitize parsing of color look-up tableGravatar msarett2016-06-20
| | | | | | | BUG=skia:5443 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2079243003 Review-Url: https://codereview.chromium.org/2079243003
* Support sRGB dsts in opt codeGravatar msarett2016-06-20
| | | | | | | | | | | | | | | 201295.jpg on HP z620 (300x280) QCMS Xform 0.418 ms Skia NEW Xform 0.378 ms Vs QCMS 1.11x BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2078623002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2078623002
* Revert of Integers can now be passed as uniforms (patchset #1 id:1 of ↵Gravatar brianosman2016-06-19
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2076143003/ ) Reason for revert: Compile failures on Vulkan platforms (eg https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan) Original issue's description: > Integers can now be passed as uniforms; needed for passing color count to fragment shader > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003 > > Committed: https://skia.googlesource.com/skia/+/cc3a22b369e1a60fa2acf2987f2934baf7c4b198 TBR=tomhudson@google.com,bsalomon@google.com,fmenozzi@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Review-Url: https://codereview.chromium.org/2080133002
* Simplify mask/clip intersection, making sure to explicitly check for an ↵Gravatar mtklein2016-06-19
| | | | | | | | | | | | | | | empty mask. Previously we were only asserting the mask wasn't empty, which isn't necessarily true when we're given pathological float coordinates like +Inf or NaN. A local run of nanobench --match text_ was not able to show this is faster or slower. This patch fixed this first Chrome bug on my desktop, and the second is probably a dupe. BUG=chromium:619378,chromium:613912 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2073873002 Review-Url: https://codereview.chromium.org/2073873002
* Integers can now be passed as uniforms; needed for passing color count to ↵Gravatar fmenozzi2016-06-18
| | | | | | | | | fragment shader BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003 Review-Url: https://codereview.chromium.org/2076143003
* Revert of More removal of SkColorProfileType... (patchset #2 id:20001 of ↵Gravatar egdaniel2016-06-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2071393002/ ) Reason for revert: This was still used in chrome Original issue's description: > More removal of SkColorProfileType... > > Scrub GMs. Remove the gDefaultProfile thing (it's unused now), along with > the command line flag that was setting it in DM and nanobench. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2071393002 > > Committed: https://skia.googlesource.com/skia/+/944876f2745a62a839e49275daf93a0329372e67 TBR=msarett@google.com,reed@google.com,bsalomon@google.com,brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2074103004
* Fix mixup where SamplePathOverstroke wasn't addedGravatar hstern2016-06-17
| | | | | | | | | | - My sampleapp for the stroking bugs was inflight or something when this change got made, so it didn't get added to this file. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076283002 Review-Url: https://codereview.chromium.org/2076283002
* Quick bandaid for chromium:611002.Gravatar mtklein2016-06-17
| | | | | | | | | | | | | | | | | | | | We're somehow receiving non-premultiplied src inputs like 0x00ffffff to this SrcOver blend. That's a bug I intend to follow up on. But for a quick compatibility fix, go back to treating values like 0x00ffffff as transparent, like we used to before crrev.com/1820313002. This will not affect the correctness of code paths using properly premultiplied colors. This should not change performance in any meaningful way. The SIMD code paths (handling strides of 16 pixels at a time) happen to treat invalid colors like 0x00fffff as transparent already. BUG=chromium:611002 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2075173002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2075173002
* More removal of SkColorProfileType...Gravatar brianosman2016-06-17
| | | | | | | | | | Scrub GMs. Remove the gDefaultProfile thing (it's unused now), along with the command line flag that was setting it in DM and nanobench. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2071393002 Review-Url: https://codereview.chromium.org/2071393002
* SkPDF: Use type 2/3 shading for gradient shadersGravatar cabanier2016-06-17
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1925233003 Review-Url: https://codereview.chromium.org/1925233003
* port SkColorXform_opts to Sk4fGravatar mtklein2016-06-17
| | | | | | | | | | I have tested that this compiles. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2078913003 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2078913003
* Update GYP for linux Vulkan to support SDK 1.0.13Gravatar egdaniel2016-06-17
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2077043002 Review-Url: https://codereview.chromium.org/2077043002
* Keep drawer open in xlarge-land and add float fpsGravatar liyuqian2016-06-17
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2071333002 Review-Url: https://codereview.chromium.org/2071333002
* Enable viewer in non-Vulkan buildsGravatar jvanverth2016-06-17
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067023002 Committed: https://skia.googlesource.com/skia/+/746b792a9aad1230ab69158a51c49b2e5437d95b Review-Url: https://codereview.chromium.org/2067023002
* remove colorprofiletype from imageinfoGravatar reed2016-06-17
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2075853002 Review-Url: https://codereview.chromium.org/2075853002
* Don't try to set gamma treatment if texture creation fails.Gravatar brianosman2016-06-17
| | | | | | | | | Guessing this will fix the valgrind failure. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2075133002 Review-Url: https://codereview.chromium.org/2075133002
* Quickly fix the Compile Problem of Unused kkImageColorXformMetaDataGravatar liyuqian2016-06-16
| | | | | | | | | | | | TBR=msarett@google.com I don't know why the compiler is complaining that since ImageSlide.cpp is still using it. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2075873003 Review-Url: https://codereview.chromium.org/2075873003
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-28 11:44:09 +0000