aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Add --properties for things like gitHash that describe the current nanobench ↵Gravatar mtklein2014-08-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | run. --key describes the type of run (describes the line on the chart), --properties describes the run itself (describes the dot on the chart). We'll pass --properties gitHash <git hash> build_number <build number> --key ... to nanobench from the bots. And... delete a whole lot of dead code. Example: nanobench --properties gitHash foo build_number 1234 --key bar baz { "build_number" : "1234", "gitHash" : "foo", "key" : { "bar" : "baz" }, "results" : { .... Friends with https://codereview.chromium.org/491943002 BUG=skia: R=jcgregorio@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/488213002
* rebaseline_server: if creating brand new expectations files, include the headerGravatar epoger2014-08-20
| | | | | | | | | | | | | | Otherwise, the first time you compare against these expectations, you get failures. NOTREECHECKS=true NOTRY=true R=stephana@google.com TBR=stephana Author: epoger@google.com Review URL: https://codereview.chromium.org/491063002
* update experimental SKP expectations using the new toolGravatar epoger2014-08-20
| | | | | | | | | | | | BUG=skia:1918 NOTREECHECKS=true NOTRY=true R=stephana@google.com TBR=stephana Author: epoger@google.com Review URL: https://codereview.chromium.org/488203002
* rebaseline_server: add download link for SKP diff patchfileGravatar epoger2014-08-20
| | | | | | | | | | | | | BUG=skia:1918 NOTREECHECKS=true NOTRY=true R=stephana@google.com TBR=stephana (SkipBuildbotRuns) Author: epoger@google.com Review URL: https://codereview.chromium.org/489183002
* Dump out more information if this assert fails.Gravatar mtklein2014-08-20
| | | | | | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/ec924b9696277df4c684e73315194482e1d43e50 R=caryclark@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/491903002
* Dump out more information if this assert fails.Gravatar mtklein2014-08-20
| | | | | | | | | BUG=skia: R=caryclark@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/491903002
* add 2 missing SKP expectations files within experimental dirGravatar epoger2014-08-20
| | | | | | | | | | | | NOTREECHECKS=true NOTRY=true R=stephana@google.com TBR=stephana (SkipBuildbotRuns) Author: epoger@google.com Review URL: https://codereview.chromium.org/470193006
* copy points in array that may stretchGravatar caryclark2014-08-20
| | | | | | | | | | | | | | | | | | Description: Potential SkOpSegment::addT() use-after-free The 'pt' arg can be a reference to a point stored in the local fTs TDArray => appending may cause a realloc and leave the reference pointing to deallocated mem. Copy the points from the stretchy array before adding them. R=fmalita@google.com, fmalita@chromium.org, fmalita BUG=405417 Author: caryclark@google.com Review URL: https://codereview.chromium.org/489853002
* Implement SkPicture::hasText() for SkRecord backend.Gravatar mtklein2014-08-20
| | | | | | | | | | | | Plus, some small tweaks to the existing code surrounding it. Just proposals, will undo whatever you don't like. BUG=skia: R=mtklein@google.com, tomhudson@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/494683003
* Remove SK_FONT_HOST_DOES_NOT_USE_FONTMGR and guarded code.Gravatar bungeman2014-08-20
| | | | | | | | | | This define is no longer needed or set, so remove it from the code. R=tomhudson@google.com, djsollen@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/488083004
* rebaseline_server: allow users to generate SKP diff patches on a shared instanceGravatar epoger2014-08-20
| | | | | | | | | | | | | | | | | This will allow developers to maintain SKP baselines without ever running their own rebaseline_server instance! For now, the developer must manually apply the resulting patchset to his local Skia checkout to actually modify expectations; in the near future, we hope to make the UI upload the patchset to Rietveld on the user's behalf. BUG=skia:1918 NOTRY=true R=stephana@google.com, rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/487853004
* start maintaining some experimental SKP expectationsGravatar epoger2014-08-20
| | | | | | | | | | | | BUG=skia:1942 NOTREECHECKS=true NOTRY=true R=stephana@google.com TBR=stephana Author: epoger@google.com Review URL: https://codereview.chromium.org/491003002
* Define NDEBUG instead of SK_DEBUG/SK_RELEASE.Gravatar mtklein2014-08-20
| | | | | | | | | | | | This makes our builds more like Chrome's, and will make our builds fail if we accidentally use if SK_DEBUG instead of ifdef SK_DEBUG. BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/481513004
* fix Image::isOpaque test to not leakGravatar reed2014-08-20
| | | | | | | | | BUG=skia: R=halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/495523002
* Revert to old autohinting behavior on Android.Gravatar djsollen2014-08-20
| | | | | | | | | | | | | | | This CL reverts to the NO_AUTOHINT behavior when autohinting is not explicitly requested. This should be removed when Skia supports a better API for selecting the correct variation. This CL has landed in the Android repo and is being upstreamed to avoid fragmenting the codebase. R=bungeman@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/490913003
* ignore release as wellGravatar caryclark2014-08-20
| | | | | | | | | | | | | | | This GM is flaky as Brian expected on both Release and Debug, so suppress the Release expectation as well. NOTREECHECKS=true NOTRY=true R=bsalomon@google.com TBR=bsalomon BUG=skia:2826 Author: caryclark@google.com Review URL: https://codereview.chromium.org/489083002
* Rename Recipes bot expectationsGravatar borenet2014-08-20
| | | | | | | | | | | | Accidentally used the wrong name :-/ R=epoger@google.com, rmistry@google.com TBR=epoger, rmistry BUG=skia:761 Author: borenet@google.com Review URL: https://codereview.chromium.org/495493002
* Move the code over using the same template type approach previously used for ↵Gravatar tomhudson2014-08-20
| | | | | | | | | | | | | | | willPlayBackBitmaps in http://skbug.com/2702. Also unifies that flag and this one into a struct so they and others can be computed together. The struct is stored const to enforce lifetime expectations. Adds a few new cases to the unit test. BUG=skia:2700 R=mtklein@google.com, reed@google.com, robertphillips@google.com, tomhudson@google.com Committed: https://skia.googlesource.com/skia/+/60c2a79cfa8ceebcbafc243407564dc71f5e3b4f Author: tomhudson@chromium.org Review URL: https://codereview.chromium.org/364823009
* Copy skimage expectations for Recipes botsGravatar borenet2014-08-20
| | | | | | | | | | BUG=skia:761 NOTRY=true R=epoger@google.com, rmistry@google.com Author: borenet@google.com Review URL: https://codereview.chromium.org/480333003
* fix #if to #ifdef for SK_DEBUGGravatar caryclark2014-08-20
| | | | | | | | | | | | | | fix the chrome build R=mtklein@google.com TBR=mtklein NOTREECHECKS=true NOTRY=true BUG=skia: Author: caryclark@google.com Review URL: https://codereview.chromium.org/495453003
* Simplify GrGLPathRendering interfaceGravatar kkinnunen2014-08-20
| | | | | | | | | | | | | | | | | | | | | | | Simplify GrGLPathRendering interface by removing polymorphism and functions that simply wrap GL functions unnecessarily. Replace the polymorphism by if -condition. Call the unconditional GL functions directly. GrGLPath, GrGLPathRange and GrGLPathRendering are part of the same logical subsystem. This means that the subsystem implementation details are taken into account within these classes. Example: if support for using conics would be added, the feature flag would go to GrGLPathRendering::Caps, the emulation would go to GrGLPath instead of GrGLPathRendering::pathCommands. Wrapping glPathCommandsNV is not useful. Try to expose the interface fully in same logical level; rename fragment input function to reflect this. R=bsalomon@google.com, cdalton@nvidia.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/450283002
* Separate GL path rendering state from GrGpuGL to GrGLPathRenderingGravatar kkinnunen2014-08-20
| | | | | | | | | | | | | | | | | | | Separate GL path rendering state from GrGpuGL to GrGLPathRendering. This makes GrGpuGL code simpler. The intention is that while GrGpuGL represents the global environment for GL, the GrGLPathRendering represents the global environment for path rendering extension. Add GrPathRendering, a base class for path rendering, and inherit GrGLPathRendering from that. Move the path rendering virtual functions from GrGpu to GrPathRendering. R=bsalomon@google.com, cdalton@nvidia.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/452823002
* Make GrGLConfigConversionEffect work for Imagination and some other GPUs.Gravatar changjun.yang2014-08-19
| | | | | | | | | | | | BUG=372341 Committed: https://skia.googlesource.com/skia/+/93cf46f7d687128d2ad05762bd65fea6c4539553 R=bsalomon@google.com, tomhudson@chromium.org Author: changjun.yang@intel.com Review URL: https://codereview.chromium.org/277323002
* Cheat to go fast, but be careful in debug mode.Gravatar mtklein2014-08-19
| | | | | | | | | | | | Turns out recording actual text metrics is currently really slow. If we want to compete with the (cheating) status quo, gotta cheat too. BUG=skia: R=reed@google.com, robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/494483002
* Print max RSS in GM and nanobench too.Gravatar mtklein2014-08-19
| | | | | | | | | | | Everyone used MB, so update the API to just return that. BUG=skia: R=halcanary@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/483323002
* Add the method isOpaque() to SkImageGravatar piotaixr2014-08-19
| | | | | | | | | BUG=skia:2766 R=junov@chromium.org, halcanary@google.com, scroggo@google.com, reed@google.com, bsalomon@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/406673003
* Revert of Add GrResourceCache2. (patchset #4 of ↵Gravatar bsalomon2014-08-19
| | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/481443002/) Reason for revert: Likely caused a leak detected in Chromium after last Skia roll. Original issue's description: > Add GrResourceCache2. > > Currently it just replaces GrGpu as the owner of the linked list of resources. > > Committed: https://skia.googlesource.com/skia/+/94ce9ac8624dbb45656b8f5c992fad9c9ff3ee5f R=mtklein@google.com, robertphillips@google.com TBR=mtklein@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: bsalomon@google.com Review URL: https://codereview.chromium.org/477323006
* Trim down OSX GYP rules. Same effect, shorter.Gravatar mtklein2014-08-19
| | | | | | | | | BUG=skia: R=bungeman@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/486233003
* Treat embedded bitmaps as a hinting method.Gravatar bungeman2014-08-19
| | | | | | | | R=reed@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/483313002
* Add --options to nanobench, similar to --key but for non-identifying options.Gravatar mtklein2014-08-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Friends with https://codereview.chromium.org/487233003/ Example of out/Release/nanobench --options build_number 12374 --match patch_grid_texs_small { "gitHash":"unknown-revision", "options":{ "build_number":"12374", "system":"UNIX" }, "results":{ "patch_grid_texs_small_640_480":{ "565":{ "max_ms":0.268116, "mean_ms":0.2318529, "median_ms":0.235337, "min_ms":0.219158, "options":{ "source_type":"bench" }, "stddev_ms":0.01491263917658814 }, "8888":{ "max_ms":0.231881, "mean_ms":0.2214668, "median_ms":0.219356, "min_ms":0.218887, "options":{ "source_type":"bench" }, "stddev_ms":0.004595541070791701 }, "gpu":{ "max_ms":0.1398304782608696, "mean_ms":0.128833402173913, "median_ms":0.1316798695652174, "min_ms":0.1111915434782609, "options":{ "GL_RENDERER":"Quadro 600/PCIe/SSE2", "GL_SHADING_LANGUAGE_VERSION":"4.40 NVIDIA via Cg compiler", "GL_VENDOR":"NVIDIA Corporation", "GL_VERSION":"4.4.0 NVIDIA 331.79", "source_type":"bench" }, "stddev_ms":0.008923738937837156 } } } } BUG=skia: R=jcgregorio@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/490683002
* rebaseline_server: in Pending Approval tab, change expected/actual labels to ↵Gravatar epoger2014-08-19
| | | | | | | | | | | | | | old/new BUG=skia:1918 NOTREECHECKS=true NOTRY=true R=stephana@google.com TBR=stephana Author: epoger@google.com Review URL: https://codereview.chromium.org/484763004
* Add GrResourceCache2.Gravatar bsalomon2014-08-19
| | | | | | | | | | Currently it just replaces GrGpu as the owner of the linked list of resources. R=robertphillips@google.com, mtklein@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/481443002
* remove unused SkIntToFloatCast_NoOverflowCheckGravatar caryclark2014-08-19
| | | | | | | | | R=reed@google.com, reed BUG=skia:2849 Author: caryclark@google.com Review URL: https://codereview.chromium.org/483273003
* Roll jsoncpp, drop dependency on Chromium overrides.Gravatar mtklein2014-08-19
| | | | | | | | | | | | | | | | This rolls jsoncpp to head, crucially past "Added missing includes for std::istream." which has given us some grief in the past. And it's required to build jsoncpp against libc++. Vanilla jsoncpp works just fine for us, so no need for Chromium's overrides. Like all DEPS, only tools depend on jsoncpp. BUG=skia: R=bungeman@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/481823003
* Record concat as setMatrix.Gravatar mtklein2014-08-19
| | | | | | | | | | | | | Mainly this cuts out a type to have to think about in SkRecord world. It also means all the CTMs are recorded directly in the SkRecord, so we can track the current CTM by pointer rather than by copying. BUG=skia: R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/484673003
* Quickfix for incorrect PICTURE_MATRIX_PAINT & PATCH optimization.Gravatar fmalita2014-08-19
| | | | | | | | | | DRAW_PICTURE_MATRIX_PAINT & DRAW_PATCH are drawing ops. R=reed@google.com, robertphillips@google.com, mtklein@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/480463004
* Move SkReadBuffer.h and SkReader32.h out of include.Gravatar halcanary2014-08-19
| | | | | | | | | | Committed: https://skia.googlesource.com/skia/+/2a51d7c74cec217195f861677de8998b382b39e4 R=mtklein@google.com, reed@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/481053002
* add patch grid update for 64 bit armGravatar caryclark2014-08-19
| | | | | | | | | | TBR= NOTREECHECKS=true NOTRY=true Author: caryclark@google.com Review URL: https://codereview.chromium.org/463353003
* Update SKP version to 78Gravatar borenet2014-08-18
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/487073003
* Revert "Move the code over using the same template type approach previously ↵Gravatar Mike Klein2014-08-18
| | | | | | | | | | used for willPlayBackBitmaps in http://skbug.com/2702." This reverts commit 60c2a79cfa8ceebcbafc243407564dc71f5e3b4f. BUG=skia: Review URL: https://codereview.chromium.org/481173003
* rebaseline_server: constrain setADir/setBDir to consistently refer to single ↵Gravatar epoger2014-08-18
| | | | | | | | | | | | | | | directories, not lists Before this CL, we supported multiple setADirs/setBDirs for some operations but not others... now we consistently support a single pair of directories. NOTRY=true R=stephana@google.com TBR=stephana Author: epoger@google.com Review URL: https://codereview.chromium.org/480293002
* Move the code over using the same template type approach previously used for ↵Gravatar tomhudson2014-08-18
| | | | | | | | | | | | | willPlayBackBitmaps in http://skbug.com/2702. Also unifies that flag and this one into a struct so they and others can be computed together. The struct is stored const to enforce lifetime expectations. Adds a few new cases to the unit test. BUG=skia:2700 R=mtklein@google.com, reed@google.com, robertphillips@google.com, tomhudson@google.com Author: tomhudson@chromium.org Review URL: https://codereview.chromium.org/364823009
* Revert "Move SkReadBuffer.h and SkReader32.h out of include."Gravatar halcanary2014-08-18
| | | | | | | | | | | | | | This reverts commit 2a51d7c74cec217195f861677de8998b382b39e4. Breaking Blink NOTRY=true R=bungeman@google.com TBR=bungeman@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/472303006
* Counterproposal for skirting the BBH when the query fully contains the picture.Gravatar mtklein2014-08-18
| | | | | | | | | BUG=skia: R=reed@google.com, robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/485703002
* This adds renderMode and builder as columns to the front end when looking at ↵Gravatar stephana2014-08-18
| | | | | | | | | | | | SKPs. BUG=skia:2833 NOTRY=true R=epoger@google.com Author: stephana@google.com Review URL: https://codereview.chromium.org/480153002
* Move SkReadBuffer.h and SkReader32.h out of include.Gravatar halcanary2014-08-18
| | | | | | | | R=mtklein@google.com, reed@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/481053002
* Expose API for whether an SkPicture contains textGravatar ajuma2014-08-18
| | | | | | | | | BUG=chromium:399728 R=reed@google.com, nduca@chromium.org Author: ajuma@chromium.org Review URL: https://codereview.chromium.org/478673002
* Fix srcAlpaWillBeOne() for coverage drawingGravatar bsalomon2014-08-18
| | | | | | | | R=egdaniel@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/480113002
* Start actually bounding some draw ops.Gravatar mtklein2014-08-18
| | | | | | | | | | | This covers most of the common draws. BUG=skia: R=robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/469213007
* Fix copyright on SkTLS.h.Gravatar bungeman2014-08-18
| | | | | | | | R=reed@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/481783002
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-06 13:04:23 +0000