aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Temporarily add Ubuntu IntelHD4400 jobs.Gravatar Ben Wagner2017-11-29
| | | | | | | | | | | I want to compare this with the IntelBayTrail and if the results are similar, replace those bots. No-Try: true Change-Id: Ib5476fe91dc446182cd1b37e93fe17962dcf961a Reviewed-on: https://skia-review.googlesource.com/76900 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "Revert "Make PathGeoBuilder use consistent iterators.""Gravatar Brian Salomon2017-11-29
| | | | | | | | | | This reverts commit b4513213245c2550683236b3aae829c8f3086469. Bug: chromium:788500 Change-Id: I6028b20770009b703f76ce2d9b451c561eaa705a Reviewed-on: https://skia-review.googlesource.com/77582 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove temporary image Swarming dimension.Gravatar Ben Wagner2017-11-29
| | | | | | | Change-Id: Iee28f684bd6fa541e36f677ee4261e637cbd4611 Reviewed-on: https://skia-review.googlesource.com/77201 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "Make PathGeoBuilder use consistent iterators."Gravatar Robert Phillips2017-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9c8a16bb1ef5b6663c7b2c98fc2ec7f6499f72a8. Reason for revert: An assert seems to be firing Original change's description: > Make PathGeoBuilder use consistent iterators. > > Previously it used a degenerate consuming iterator to determine the whether there were multiple contours. This was inconsistent with the tessellating step. > > Bug: chromium:788500 > Change-Id: I3938c69cf40bc551acdb8d5fa9b54d2c96e2a460 > Reviewed-on: https://skia-review.googlesource.com/76961 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,brianosman@google.com Change-Id: I3a591086293d21f1a04dc3875242b96198aeddd8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:788500 Reviewed-on: https://skia-review.googlesource.com/77441 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Make PathGeoBuilder use consistent iterators."Gravatar Brian Salomon2017-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9c8a16bb1ef5b6663c7b2c98fc2ec7f6499f72a8. Reason for revert: <INSERT REASONING HERE> Original change's description: > Make PathGeoBuilder use consistent iterators. > > Previously it used a degenerate consuming iterator to determine the whether there were multiple contours. This was inconsistent with the tessellating step. > > Bug: chromium:788500 > Change-Id: I3938c69cf40bc551acdb8d5fa9b54d2c96e2a460 > Reviewed-on: https://skia-review.googlesource.com/76961 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,brianosman@google.com Change-Id: I18005ea2d7ba88c66334f110a5a74c6d82e4ab90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:788500 Reviewed-on: https://skia-review.googlesource.com/77440 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Make PathGeoBuilder use consistent iterators.Gravatar Brian Salomon2017-11-29
| | | | | | | | | | Previously it used a degenerate consuming iterator to determine the whether there were multiple contours. This was inconsistent with the tessellating step. Bug: chromium:788500 Change-Id: I3938c69cf40bc551acdb8d5fa9b54d2c96e2a460 Reviewed-on: https://skia-review.googlesource.com/76961 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Roll skia/third_party/externals/angle2/ 57ea533f7..f13cadd8b (1 commit)Gravatar angle-deps-roller@chromium.org2017-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/57ea533f79a7..f13cadd8bd5f $ git log 57ea533f7..f13cadd8b --date=short --no-merges --format='%ad %ae %s' 2017-11-28 oetuaho Fix checking negative index when indexing matrix/vector Created with: roll-dep skia/third_party/externals/angle2 BUG=789029 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=allanmac@google.com Change-Id: I6d6b6eac2ae363aa76dbcbb2e7bf56ab27afc1b4 Reviewed-on: https://skia-review.googlesource.com/77380 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Avoid double-destruction of Sk3DShaderContext-wrapped objectsGravatar Florin Malita2017-11-29
| | | | | | | | | | | | | | | Sk3DShaderContext creates its nested shader context on a SkArenaAlloc, which handles destruction when going out of scope. Hence, the explicit context dtor call in ~Sk3DShaderContext() is incorrect (likely left over from before SkArenaAlloc). BUG=chromium:787712 Change-Id: I176222e449151dcce532a839ef9587d06f61d297 Reviewed-on: https://skia-review.googlesource.com/77203 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Roll skia/third_party/externals/angle2/ 5201ce127..57ea533f7 (1 commit)Gravatar angle-deps-roller@chromium.org2017-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/5201ce127afe..57ea533f79a7 $ git log 5201ce127..57ea533f7 --date=short --no-merges --format='%ad %ae %s' 2017-11-22 kainino TType: Store array sizes vector as a pointer. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=allanmac@google.com Change-Id: I9dd0c88a4fb5e6ee7b8dbd9681f1307a7f2ccfe3 Reviewed-on: https://skia-review.googlesource.com/77300 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Update SkTLazy for move only types.Gravatar Ben Wagner2017-11-28
| | | | | | | Change-Id: Id812d4f6ac47ae41e5a938310aa8f30eaf33a42d Reviewed-on: https://skia-review.googlesource.com/76901 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com>
* Roll skia/third_party/externals/angle2/ df68ca50b..5201ce127 (1 commit)Gravatar angle-deps-roller@chromium.org2017-11-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/df68ca50b310..5201ce127afe $ git log df68ca50b..5201ce127 --date=short --no-merges --format='%ad %ae %s' 2017-11-28 geofflang Fix MSVC 2015 warnings. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=allanmac@google.com Change-Id: Id42639e2aeda492b42687ebd9ffd573e30f54b11 Reviewed-on: https://skia-review.googlesource.com/77140 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* SkPDF: fix fTextScaleX errorGravatar Hal Canary2017-11-28
| | | | | | | | BUG=skia:7315 Change-Id: Ic613cb6fb8faed5b0840db4f500940bd6823de66 Reviewed-on: https://skia-review.googlesource.com/76981 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* remove unused readBitmapAsImage from readbufferGravatar Mike Reed2017-11-28
| | | | | | | | Bug: skia: Change-Id: Ic200ec39999a06f407de29e15b646baddb9e341d Reviewed-on: https://skia-review.googlesource.com/76982 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* drop 32-bit Android NDK builds down to API 16Gravatar Mike Klein2017-11-28
| | | | | | | Change-Id: I40ded57601da605a1393ce56589455909f66ad00 Reviewed-on: https://skia-review.googlesource.com/77020 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* remove writeBitmap from SkWriteBuffer -- unusedGravatar Mike Reed2017-11-28
| | | | | | | | Bug: skia: Change-Id: I8809e7e138d64cc30389e8efc76265011b287611 Reviewed-on: https://skia-review.googlesource.com/77060 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Make Skia compatible with Android NDK r16Gravatar bsheedy2017-11-28
| | | | | | | | | | | | | | | Changes to Skia that are necessary to make Chromium compile with Android NDK r16, which switches to unified headers. Sister CLs: src/third_party/android_tools/ndk: https://chromium-review.googlesource.com/c/android_ndk/+/784230 src/: https://chromium-review.googlesource.com/c/chromium/src/+/777822 Bug: chromium:771171 Change-Id: I3d35df5b99d8eb7d7d938d21b5aecdf4c2d5da0f Reviewed-on: https://skia-review.googlesource.com/75422 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Make RecreateSKPs bot fail if capturing SKPs fails + exclude failing page setsGravatar Ravi Mistry2017-11-28
| | | | | | | | Bug: skia:7348 Change-Id: I8dd6337d2efeb1aaa71ac41fcb82b9a22bbd7531 Reviewed-on: https://skia-review.googlesource.com/76220 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Upgrade GalaxyS6.Gravatar Ben Wagner2017-11-28
| | | | | | | | | Bug: skia:7308 Change-Id: Ia84f67c310104fc75e81757de8cb8e57add763d0 Reviewed-on: https://skia-review.googlesource.com/76621 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* remove clip-bounds query overrides from SkColorSpaceXformCanvasGravatar Mike Klein2017-11-28
| | | | | | | | | | | | | | | | | | | | | | | This is the only SkCanvas subclass currently overriding these, and this leads to buggy interactions with this canvas, saveLayer(), and image filters. The base SkCanvas tracks and can answer these queries just as well as fTarget. A couple other SkCanvas subclasses do override isClipEmpty() and isClipRect(), and these conservative clip tracking SkCanvases can't really answer isClipRect() correctly, so I've left those both. I'm intentionally keeping this CL minimal in case it needs backporting to other branches. I'm going to follow up separately with a GM or unit test that would reproduce the Chrome bug, and with a CL that de-virtualizes these two methods. BUG=chromium:781238 Change-Id: I75bf6b0910115fafe17fa721082acc415bfdae23 Reviewed-on: https://skia-review.googlesource.com/76802 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Roll skia/third_party/externals/angle2/ 0b684ce3c..df68ca50b (1 commit)Gravatar angle-deps-roller@chromium.org2017-11-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/0b684ce3c9f5..df68ca50b310 $ git log 0b684ce3c..df68ca50b --date=short --no-merges --format='%ad %ae %s' 2017-11-27 geofflang Add missing break in StateManagerGL::syncState. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=allanmac@google.com Change-Id: I1e069f3d065e9c8952946ef524947ac9767ca6d0 Reviewed-on: https://skia-review.googlesource.com/76840 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
* shader cache now ignores shaders with a length of 0Gravatar Ethan Nicholas2017-11-28
| | | | | | | | Bug: skia: Change-Id: I1dd9794ea424d862e53414fcd96885972ac2ba76 Reviewed-on: https://skia-review.googlesource.com/73721 Reviewed-by: Stan Iliev <stani@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Fix shader initialization on a cache hitGravatar Ethan Nicholas2017-11-28
| | | | | | | | Bug: skia: Change-Id: I1ad93442df1b53ce5f1cfb7285479c6b860b7e24 Reviewed-on: https://skia-review.googlesource.com/71461 Reviewed-by: Stan Iliev <stani@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Add create_bundle support for GNGravatar Jim Van Verth2017-11-28
| | | | | | | | | Docs-Preview: https://skia.org/?cl=75383 Bug: skia:7339 Change-Id: I985734e8b7b5af21a82cb8ee59acbfb5ff1d3ff7 Reviewed-on: https://skia-review.googlesource.com/75383 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Switch Coverage GPU bot to Golo.Gravatar Ben Wagner2017-11-28
| | | | | | | | No-Try: true Change-Id: I0b9f6ef3651e5309af316d7ea7e170b48f54cdeb Reviewed-on: https://skia-review.googlesource.com/76620 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Don't scale CPU for internal botsGravatar Kevin Lubick2017-11-28
| | | | | | | | | | | | For internal hardware, it tends not to work - they work at one clock speed, despite advertising others. Bug: skia: NOTRY=true Change-Id: I10bf0fc1ab4d60bfbc2eefcef5b42ceab9e3f435 Reviewed-on: https://skia-review.googlesource.com/76720 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Fix issues related to backend texture/rendertarget creationGravatar Robert Phillips2017-11-28
| | | | | | | Change-Id: I640ea5f316e9e4aba778f450655e74636199e0b1 Reviewed-on: https://skia-review.googlesource.com/76440 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Roll skia/third_party/externals/angle2/ ebee5b3b7..0b684ce3c (2 commits)Gravatar angle-deps-roller@chromium.org2017-11-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/ebee5b3b7de5..0b684ce3c9f5 $ git log ebee5b3b7..0b684ce3c --date=short --no-merges --format='%ad %ae %s' 2017-11-23 jmadill Vulkan: Move RenderPass init into a helper function. 2017-11-23 jmadill ContextImpl: Make flush/finish take a gl::Context. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=allanmac@google.com Change-Id: Ia0d79aa4acf7a82850e290e9a05926a27f28e5f6 Reviewed-on: https://skia-review.googlesource.com/76602 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* CCPR: Transform path points before parsingGravatar Chris Dalton2017-11-27
| | | | | | | | | | | | | | | Transforms a path's points into a local buffer up front, rather than transforming as we parse. This hopefully gets better vector performance as well as allowing us to skip the transformation step for paths that are known to be in device space already. Introduces a test for parsing empty paths and does general cleanup. Bug: skia:7190 Change-Id: Ib86d2ffcdef6fa3ec66f6d9ad4b10c0b6d44c0dc Reviewed-on: https://skia-review.googlesource.com/74621 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* remove SkDebugCanvas clip query overridesGravatar Mike Klein2017-11-27
| | | | | | | | | | | | | | We don't think these are important, and it's looking like overriding these methods at all is a bad idea. While here we can remove kVizImageHeight and width too, as they're unused. After all these deletions the comment about methods inherited from SkCanvas no longer applies. Change-Id: I036eb9ccca4821516a287daec9847addd529a28c Reviewed-on: https://skia-review.googlesource.com/76480 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Cleanup yes/no enums in GaneshGravatar Chris Dalton2017-11-27
| | | | | | | | | | | | Yes/no enums should have a base type of bool, and kYes should always be true. Also, there is no need for a "GrEnumToBool()" function, as we can just use the enum itself directly: e.g. "GrAA(bool)". Bug: skia: Change-Id: I7bb3c2983f717f3467fca4ce6b32920d71026894 Reviewed-on: https://skia-review.googlesource.com/74860 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* update SkJumper docs to Clang 5Gravatar Mike Klein2017-11-27
| | | | | | | | | | We have been using Clang 5 since it was released, starting with this CL: https://skia-review.googlesource.com/44241 Change-Id: I8167223d9fffc3bf065b6889097ad37648b069d3 Reviewed-on: https://skia-review.googlesource.com/76540 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Batch ops together in SkAtasTextTargetGravatar Brian Salomon2017-11-27
| | | | | | | Change-Id: I7f2b03dd965079f801d66b670bdeb1d01bbf0fd6 Reviewed-on: https://skia-review.googlesource.com/76160 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* clean up SkDeferredCanvasGravatar Mike Klein2017-11-27
| | | | | | | | | | To our knowledge it's not used. Its defer- mode in DM isn't even run on the bots. Change-Id: Ifebfa2a77bfed8370eb421d379697f04fa2c8608 Reviewed-on: https://skia-review.googlesource.com/76420 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Include opList ids in GrOnFlushCallbackObject::postFlushGravatar Chris Dalton2017-11-27
| | | | | | | | Bug: skia:7190 Change-Id: Id20117ffc4ed5b875558473497507fd5cb12aa39 Reviewed-on: https://skia-review.googlesource.com/74641 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Fix caps for advanced blend extension with regards to layout qualifiersGravatar Greg Daniel2017-11-27
| | | | | | | | Bug: skia:7318 Change-Id: I8475e385b2086d416d13d80aa326a50cd05f6229 Reviewed-on: https://skia-review.googlesource.com/75981 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Revert "Make sure to visit clips and dst proxies during gather"Gravatar Robert Phillips2017-11-27
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit b9d98e36865796824dd2f839646f029cfa9ce4b5. Reason for revert: Assertion failure on a lot of bots Original change's description: > Make sure to visit clips and dst proxies during gather > > Bug: skia:7190 > Change-Id: I72b40743439a33f51b94592fa81cd6146f8e92c6 > Reviewed-on: https://skia-review.googlesource.com/74080 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Chris Dalton <csmartdalton@google.com> TBR=robertphillips@google.com,csmartdalton@google.com Change-Id: I980266a838b8e29bf0859e30a50986b05ed811b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7190 Reviewed-on: https://skia-review.googlesource.com/76340 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* roll GNGravatar Mike Klein2017-11-27
| | | | | | | | | | | | | The GN we sync is kind of old, 456551. This rolls up to 514519. I don't foresee any interesting effect from this roll. I just happened to notice that my Skia GN binary can't work with Chromium's configs on Mac anymore. Change-Id: I592b57747a1a43fbffc11d09d9f49281bad70418 Reviewed-on: https://skia-review.googlesource.com/76060 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Make sure to visit clips and dst proxies during gatherGravatar Chris Dalton2017-11-27
| | | | | | | | Bug: skia:7190 Change-Id: I72b40743439a33f51b94592fa81cd6146f8e92c6 Reviewed-on: https://skia-review.googlesource.com/74080 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* added SkSL support for all blend mode layoutsGravatar Ethan Nicholas2017-11-27
| | | | | | | | Bug: skia: Change-Id: Id39c068b15d0ae51520dc2169cdbf21402a43f69 Reviewed-on: https://skia-review.googlesource.com/76200 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Roll skia/third_party/externals/angle2/ 994ee3f23..ebee5b3b7 (2 commits)Gravatar angle-deps-roller@chromium.org2017-11-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/994ee3f23ec5..ebee5b3b7de5 $ git log 994ee3f23..ebee5b3b7 --date=short --no-merges --format='%ad %ae %s' 2017-11-23 oetuaho Add GLSL support for runtime-sized arrays in SSBOs 2017-11-13 yunchao.he ES31: Fix the issue when rendering against compute program. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=allanmac@google.com Change-Id: I97298a6d406bac4add599bc29b6f236a4c8790f1 Reviewed-on: https://skia-review.googlesource.com/76181 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Handle null colorspace in SkToSRGBColorFilter.Gravatar Mike Klein2017-11-27
| | | | | | | | | | | | | | | | | This was uncovered by the linked fuzzer issue. I haven't looked hard at it, but I'd guess it's fuzzed an ICC profile into one that can't be deserialized, and we get a null in CreateProc(). We could probably restrict the null check to just CreateProc(), but putting it in Make() and asserting in the constructor feels cozy. BUG=chromium:787718 Change-Id: Ic4b1dad28c00ee5870f22093eedbf34686c32120 Reviewed-on: https://skia-review.googlesource.com/76080 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* Add forceDAA parameter to AntiFillPathGravatar Yuqian Li2017-11-27
| | | | | | | | | | Threaded backend will need this to always fill path in DAA. Bug: skia: Change-Id: Ifbfb0137b89eb71b7c2a2722aee1dad196a52553 Reviewed-on: https://skia-review.googlesource.com/76120 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Add Fiddle DrawOptions for the backend objectsGravatar Robert Phillips2017-11-27
| | | | | | | Change-Id: I720125f134394a8b923d6e883941d20715945d73 Reviewed-on: https://skia-review.googlesource.com/73340 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Delete an opList's clips when it survives a flushGravatar Chris Dalton2017-11-27
| | | | | | | | Bug: skia:7190 Change-Id: I22454fc25f928b6892cbaa5533baa09aeec1b5f4 Reviewed-on: https://skia-review.googlesource.com/74066 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Make EGL test context access GL via GrGLInterfaceGravatar Brian Salomon2017-11-27
| | | | | | | | Bug: skia:7334 Change-Id: I5153ef83ae350648a15d6dc427b03d464258608b Reviewed-on: https://skia-review.googlesource.com/75980 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* bookmaker refreshGravatar Cary Clark2017-11-27
| | | | | | | | | | | | | | Add support for more operator overloads. Add SkSurface, SkPoint, SkIPoint, SkIPoint16 docs. (SkImage doc skeleton added, but not really started.) Force recompile all examples. Docs-Preview: https://skia.org/?cl=67726 Bug: skia:6898 Change-Id: If9e2d23f79d5db64146dd22588f5cac970614b8a Reviewed-on: https://skia-review.googlesource.com/67726 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
* saturate when converting float to fixedGravatar Mike Reed2017-11-27
| | | | | | | | Bug:783205 Change-Id: I30997e413f03f6ce2f8a8998efd78e350bdb43e3 Reviewed-on: https://skia-review.googlesource.com/75982 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkPDF: less tolerance for small circlesGravatar Hal Canary2017-11-27
| | | | | | | | BUG=chromium:772953 Change-Id: I9452ac8ad66ab8be26a9388f8c85a1f0e61bd392 Reviewed-on: https://skia-review.googlesource.com/75960 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Disallow negative radii in deserialized SkRRectsGravatar Brian Salomon2017-11-27
| | | | | | | | | bug= chromium:787124 Change-Id: I232ccd6bdfc2c176f97b97e24eabad6a9ce8e5e2 Reviewed-on: https://skia-review.googlesource.com/73901 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Update SKP versionGravatar UpdateSKPs2017-11-26
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I327662727f6ab0bf2b22d94f707940bf50e9005d Reviewed-on: https://skia-review.googlesource.com/75821 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>