aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Don't flush on read/write pixels unless necessaryGravatar bsalomon2014-09-22
| | | | | | | | | BUG=skia:2889 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/586073002
* Introduce Props to surface (patchset #27 id:520001 of ↵Gravatar reed2014-09-22
| | | | | | | | | | | | https://codereview.chromium.org/551463004/)" This reverts commit 29c857d0f3a1cb837f73406eeb6ba9771879b5e7. TBR= Author: reed@google.com Review URL: https://codereview.chromium.org/588143004
* Cleaning includes in SkImage-related filesGravatar piotaixr2014-09-22
| | | | | | | | | BUG=skia:2948 R=junov@chromium.org, tfarina@chromium.org, reed@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/586853003
* Update SKP version to 108Gravatar borenet2014-09-21
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/586403002
* Revert of introduce Props to surface (patchset #27 id:520001 of ↵Gravatar reed2014-09-21
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/551463004/) Reason for revert: Broke call site in WebKit Original issue's description: > introduce Props to surface (work in progress) > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/3716fd067a5621bb94a6cb08d72afec8bf3aceda R=robertphillips@google.com, bsalomon@google.com, jvanverth@google.com, bungeman@google.com, fmalita@google.com, vangelis@chromium.org, reed@google.com TBR=bsalomon@google.com, bungeman@google.com, fmalita@google.com, jvanverth@google.com, reed@google.com, robertphillips@google.com, vangelis@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@chromium.org Review URL: https://codereview.chromium.org/583773004
* introduce Props to surface (work in progress)Gravatar reed2014-09-21
| | | | | | | | | BUG=skia: R=robertphillips@google.com, bsalomon@google.com, jvanverth@google.com, bungeman@google.com, fmalita@google.com, vangelis@chromium.org, reed@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/551463004
* Update SKP version to 107Gravatar borenet2014-09-20
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/585313002
* Souped-up SkTextBlob.Gravatar fmalita2014-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactored text blob backend for improved performance: instead of using separate buffers for runs/positions/glyphs, everything is now packed in a consolidated slab (including the SkTextBlob object itself!). Benefits: * number of allocations per blob construction reduced from ~4 to 1 (also minimizes internal fragmentation) * run record size reduced by 8 bytes This takes the blob construction overhead down to negligible levels (for the current Blink uncached textblob implementation). Unfortunately, the code is much more finicky (run merging in particular) -- hence the assert spree. Multi-run blobs are vulnerable to realloc storms but this is not a problem at the moment because Blink is using one-run blobs 99% of the time. Will be addressed in the future. R=mtklein@google.com, reed@google.com, robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/13645ea0ea87038ebd71be3bd6d53b313069a9e4 Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/581173003
* Update SKP version to 106Gravatar borenet2014-09-19
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/590643003
* Revert of Souped-up SkTextBlob. (patchset #3 id:40001 of ↵Gravatar fmalita2014-09-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/581173003/) Reason for revert: Broke the new blobshader gm. Original issue's description: > Souped-up SkTextBlob. > > Refactored text blob backend for improved performance: instead of using > separate buffers for runs/positions/glyphs, everything is now packed in > a consolidated slab (including the SkTextBlob object itself!). > > Benefits: > > * number of allocations per blob construction reduced from ~4 to 1 > (also minimizes internal fragmentation) > * run record size reduced by 8 bytes > > This takes the blob construction overhead down to negligible levels > (for the current Blink uncached textblob implementation). > > Unfortunately, the code is much more finicky (run merging in > particular) -- hence the assert spree. > > Multi-run blobs are vulnerable to realloc storms but this is not a > problem at the moment because Blink is using one-run blobs 99% of the > time. Will be addressed in the future. > > > R=reed@google.com,mtklein@google.com,robertphillips@google.com > > Committed: https://skia.googlesource.com/skia/+/13645ea0ea87038ebd71be3bd6d53b313069a9e4 R=mtklein@google.com, reed@google.com, robertphillips@google.com TBR=mtklein@google.com, reed@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/588853002
* Souped-up SkTextBlob.Gravatar fmalita2014-09-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactored text blob backend for improved performance: instead of using separate buffers for runs/positions/glyphs, everything is now packed in a consolidated slab (including the SkTextBlob object itself!). Benefits: * number of allocations per blob construction reduced from ~4 to 1 (also minimizes internal fragmentation) * run record size reduced by 8 bytes This takes the blob construction overhead down to negligible levels (for the current Blink uncached textblob implementation). Unfortunately, the code is much more finicky (run merging in particular) -- hence the assert spree. Multi-run blobs are vulnerable to realloc storms but this is not a problem at the moment because Blink is using one-run blobs 99% of the time. Will be addressed in the future. R=mtklein@google.com, reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/581173003
* Get rid of SkImage_CodecGravatar piotaixr2014-09-19
| | | | | | | | | | | Use SkImage_Raster with an ImageGenerator instead. BUG=skia:2948 R=junov@chromium.org, reed@google.com, bsalomon@chromium.org Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/589713002
* Don't try to add large glyphs to the font atlas.Gravatar jvanverth2014-09-19
| | | | | | | | | | | When the glyph data is invalid we can try to allocate a ridiculous amount of memory. This adds a check to cover such cases. BUG=414581 R=egdaniel@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/585853003
* enable conservative clips for gpudeviceGravatar reed2014-09-19
| | | | | | | | TBR=bsalomon Author: reed@google.com Review URL: https://codereview.chromium.org/587793003
* Add UniqueID to GrDrawTargetCaps.Gravatar egdaniel2014-09-19
| | | | | | | | | | | | This is needed for creating the Optimized Draw State and checking that we have the same caps on subsequent calls to ODS BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/585043002
* Move IOType to GrGpuRef and rename that to GrIORef. Template GrPendingIORef ↵Gravatar bsalomon2014-09-19
| | | | | | | | | | | on IOType. BUG=skia:2889 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/579403003
* SkTextBlob shader space workaround.Gravatar fmalita2014-09-19
| | | | | | | | | | | | | | | Blink would like drawTextBlob(x,y) to behave the same as drawText(x,y) WRT shader space. Due to the current generic device base impl, that is not the case. This is a transitional workaround, pending proper drawTextBlob impls in SkDevice classes. R=reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/586743002
* Fix memory leak in MultiPictureDraw GMGravatar robertphillips2014-09-19
| | | | | | | | R=fmalita@google.com, fmalita@chromium.org Author: robertphillips@google.com Review URL: https://codereview.chromium.org/585033002
* Fix stack-allocated GPU path objectGravatar cdalton2014-09-19
| | | | | | | | | | | | Fixes nvpr text to dynamically allocate its template path object, as per the Skia policy. BUG=skia: R=robertphillips@google.com, bsalomon@google.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/582033003
* Make GrIODB keep pending IO refs on all resources it records into its cmd ↵Gravatar bsalomon2014-09-19
| | | | | | | | | | | stream. BUG=skia:2889 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/581123002
* Add a "mode" tag to key in DM json output.Gravatar mtklein2014-09-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This lets us distinguish the original ("direct") runs from their replay modes. There was a bit of a bug in here now fixed: we used the first entry in fSuffixes as the config. Actually, the last entry in suffixes is the config. This is moot when there's only one suffix (direct drawing), but for mode drawing we were recording the mode as config! Now it's correct. Here's some example output where I rigged a bunch of modes to fail: { "results" : [ { "key" : { "config" : "565", "mode" : "default-nobbh", "name" : "xfermodes2" }, "md5" : "2daf6f7e2b8e56543b92068a10d2179e", "options" : { "source_type" : "GM" } }, { "key" : { "config" : "8888", "mode" : "default-nobbh", "name" : "xfermodes2" }, "md5" : "490361e8a52800d29558bc23876da8c6", "options" : { "source_type" : "GM" } }, ... { "key" : { "config" : "565", "mode" : "direct", "name" : "xfermodes2" }, "md5" : "92a3801d5914d6c2662904a3bb50d2b9", "options" : { "source_type" : "GM" } }, ... { "key" : { "config" : "8888", "mode" : "direct", "name" : "xfermodes2" }, "md5" : "e7e8b3e9d31e601acaaff4633ed5f63a", "options" : { "source_type" : "GM" } }, BUG=skia: R=jcgregorio@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/586533005
* Extend MultiPictureDraw GMGravatar robertphillips2014-09-19
| | | | | | | | | | This new GM case is intended to exercise the matrix oriented aspects of layer caching. R=jvanverth@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/582113004
* Stop calling rand() in debug-only code for GLProgramsTestGravatar bsalomon2014-09-19
| | | | | | | | R=egdaniel@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/584913002
* Add ignored expectation for https://codereview.chromium.org/563283004.Gravatar jvanverth2014-09-19
| | | | | | | | | | BUG=skia:2951 R=bsalomon@google.com TBR=bsalomon@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/585943002
* fail early if coincidence can't be resolvedGravatar caryclark2014-09-19
| | | | | | | | | | | | Bail out if a very large value causes coincidence resolution to fail. TBR= BUG=415866 Author: caryclark@google.com Review URL: https://codereview.chromium.org/585913002
* remove RenderTargetFlags -- NewRenderTargetDirect will never clearGravatar reed2014-09-19
| | | | | | | | | BUG=skia: R=robertphillips@google.com, bsalomon@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/583043002
* Update SKP version to 105Gravatar borenet2014-09-18
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/580263003
* Restore old behavior of SkTypeface::CreateFromTypeface.Gravatar bungeman2014-09-18
| | | | | | | | | | | | | This reverts https://skia.googlesource.com/skia/+/9db509272a6fa2badbbdd2f5afce827370960a5f and completes https://skia.googlesource.com/skia/+/f91c47d91d72a1d85e2d6701864b8d7accc81647 . R=caryclark@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/586473002
* check for failed file->data (fails on mac)Gravatar reed2014-09-18
| | | | | | | | TBR= Author: reed@google.com Review URL: https://codereview.chromium.org/581263002
* Add counting of some GL callsGravatar robertphillips2014-09-18
| | | | | | | | | | I would like this facility for tracking FBO switch improvements. R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/553583008
* Uses a single pre-baked set of paths for drawing nvpr text of a givenGravatar cdalton2014-09-18
| | | | | | | | | | | | | | | | | | | | | | | | | typeface. Loads the paths using the driver's glyph loading routines. Refactors GrPathRange to accept a PathGenerator class that it uses to lazily initialize its paths. The client code is no longer expected to initialize the paths in a GrPathRange; instead it must provide a PathGenerator* instance to createPathRange(). Adds a new createGlyphs() method to GrPathRendering that creates a range of glyph paths, indexed by glyph id. GrPathRendering implements createGlyphs() with a PathGenerator that loads glyph paths using the skia frameworks. GrGLPathRendering uses glMemoryGlyphIndexArrayNV() instead, when possible, to load the glyph paths. Removes all GlyphPathRange logic from GrStencilAndCoverTextContext. It instead uses createGlyphs(). BUG=skia:2939 R=bsalomon@google.com, jvanverth@google.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/563283004
* remove no-op overrideGravatar reed2014-09-18
| | | | | | | | | | NOTREECHECKS=True NOTRY=True R=egdaniel@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/586463002
* Changes to remove program effects builderGravatar joshualitt2014-09-18
| | | | | | | | | BUG=skia: R=bsalomon@google.com Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/551253004
* Refactor layer hoisting codeGravatar robertphillips2014-09-18
| | | | | | | | | | This CL consolidates the layer hoisting functionality in GrLayerHoister in preparation for retiring SkDpuDevice::EXPERIMENTAL_drawPicture in favor of SkMultiPictureDraw::draw. R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/580173002
* Bis: Use SkImage::NewFromGenerator() instead of SkImage::newEncodedData()Gravatar piotaixr2014-09-18
| | | | | | | | | BUG=skia:2948 R=junov@chromium.org, reed@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/579923002
* use surface in SkView/SampleAppGravatar reed2014-09-18
| | | | | | | | | BUG=skia: R=bsalomon@google.com, robertphillips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/580073003
* Simplify a little in SkRecords.h:Gravatar mtklein2014-09-18
| | | | | | | | | | | | | - ACT_AS_PTR can just expose const methods to get at the pointers. (If the thing stored must stay const, we pass a const T.) - DrawPatch works fine with Record# macros, so use Record5. BUG=skia: R=fmalita@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/585523003
* update to accommodate latest clang in chrome toolchainGravatar caryclark2014-09-18
| | | | | | | | | | | remove asserts for null pointers to references change var args signature to pointer instead of array R=mtklein@google.com, reed@android.com, reed@google.com, mtklein, reed Author: caryclark@google.com Review URL: https://codereview.chromium.org/577243002
* fixes to linux build for webtryGravatar humper2014-09-18
| | | | | | | | | BUG=skia: R=jcgregorio@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/578013003
* Serialize the font index.Gravatar bungeman2014-09-18
| | | | | | | | | BUG=skia:1186 R=reed@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/567013002
* fix battlefield website by disallowing very small coordinatesGravatar caryclark2014-09-18
| | | | | | | | | | | also add and remove comments to document other attempts to fix this that had drawbacks R=fmalita@chromium.org BUG=414409 Author: caryclark@google.com Review URL: https://codereview.chromium.org/575553003
* Copy layer-hoisting related SkPaintsGravatar robertphillips2014-09-18
| | | | | | | | | | | | This is intended to disconnect the lifetimes of the optimization data, cached layers and replacement objects. Note that the optimization data already makes a copy of the paint in the SkPicture. Additionally the replacement object will probably go away at some point. R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/579843002
* nanobench: print max RSS in debug mode too.Gravatar mtklein2014-09-18
| | | | | | | | | BUG=skia:2949 R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/581083002
* Remove redundant assignment in GrDrawTarget.cppGravatar qiankun.miao2014-09-18
| | | | | | | | | BUG=skia: R=bsalomon@google.com Author: qiankun.miao@intel.com Review URL: https://codereview.chromium.org/552273003
* use surface instead of explicitly making gpudeviceGravatar reed2014-09-18
| | | | | | | | TBR=bsalomon Author: reed@google.com Review URL: https://codereview.chromium.org/585493002
* Update SKP version to 104Gravatar borenet2014-09-17
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/579993002
* Use SkBitmapCache to optimize readPixels on a texture-backed bitmapGravatar piotaixr2014-09-17
| | | | | | | | | BUG=skia:2786 R=junov@chromium.org, reed@google.com, bsalomon@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/533323002
* Use SkImage::NewFromGenerator() instead of SkImage::newEncodedData()Gravatar piotaixr2014-09-17
| | | | | | | | | BUG=skia:2948 R=junov@chromium.org, reed@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/575173002
* Small refactoring in SkImage_CodecGravatar piotaixr2014-09-17
| | | | | | | | | BUG=skia:2947 R=junov@chromium.org, reed@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/579773003
* DM: --gpu and --cpu should only control top-level tasks.Gravatar mtklein2014-09-17
| | | | | | | | | | | | | | | | | This fixes a bug where we run some Android bots with --nocpu, and the current behavior disables the (CPU-bound) WriteTasks the GPU bound GM runs spawn off. The WriteTasks don't run and we end up with "null" in our .json files. Tested locally: out/Release/dm --nocpu -w /tmp/out; ls /tmp/out dm.json gpu/ BUG=skia:2938 R=jcgregorio@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/578033002
generated by cgit v1.2.3 (git 2.39.1) at 2025-02-03 00:58:38 +0000