aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Fix lazy coding in ViaSingletonPictures.Gravatar mtklein2016-04-06
| | | | | | | | | | | | | | | | | | | I was using SkRect::MakeLargest() as bounds, which is sort of nutso, as that clearly is way out of bounds for how big a picture can feasibly be, i.e. something closer to SkIRect::MakeLargest(). This was causing spurious quick rejects in drawPatch(). I didn't really look much deeper to figure out why. It's easy enough to just feed it the proper bounds of the entire content. This means patch_primitive draws correctly in sp-8888 mode. I also noticed the GM was too small... it clipped off most of its content. So I've made it larger. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1865143002 Review URL: https://codereview.chromium.org/1865143002
* Track GL buffer state based on unique resource IDGravatar cdalton2016-04-06
| | | | | | | | | | | | | | | | Reworks GrGLGpu to track GL buffer state based on the unique GrGpuResource ID. This eliminates the need to notify the gpu object whenever a buffer is deleted. This change also allows us to remove the type specifier from GrBuffer. At this point a buffer is just a chunk of memory, and the type given at creation time is just a suggestion to the GL backend about which target to bind to for updates. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1854283004 Review URL: https://codereview.chromium.org/1854283004
* path_stroke_with_zero_length: turn off drawFat() by default.Gravatar mtklein2016-04-06
| | | | | | | | | | | | The replay modes cannot readback, and so cannot draw the fat parts, which means we've had to exempt them from checking that they draw identically. I don't mind if we leave it alone, but I thought I'd check to see your opinion. BUG=skia:4095 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862113004 Review URL: https://codereview.chromium.org/1862113004
* Make existing unit tests only run on GL contextsGravatar bsalomon2016-04-06
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1869503002 Review URL: https://codereview.chromium.org/1869503002
* alternate textblobgeometrychange fix... just make our own surface if neededGravatar mtklein2016-04-06
| | | | | | | | | This should decopple fixing the replay modes from revising the API. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1868553005 Review URL: https://codereview.chromium.org/1868553005
* Switch uniforms to be descriptor set 0 in VulkanGravatar egdaniel2016-04-06
| | | | | | | | | | This (plus some cleanup) gives us some minor perf gains and as a side effect the perf debug layer no longer complains when we bind certain descriptor sets. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864303002 Review URL: https://codereview.chromium.org/1864303002
* Fix null context GenBuffersGravatar cdalton2016-04-06
| | | | | | | | | Fixes the null context to not return 0 for GenBuffers. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1863923003 Review URL: https://codereview.chromium.org/1863923003
* Remove conditional flavor text on blend GM.Gravatar mtklein2016-04-06
| | | | | | | | | This was breaking replay modes for no good reason. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864253002 Review URL: https://codereview.chromium.org/1864253002
* Register SkLocalMatrixImageFilter for serialization.Gravatar mtklein2016-04-06
| | | | | | | | | This fixes one of the zillions of serialize-8888 backlisted tests. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1868453003 Review URL: https://codereview.chromium.org/1868453003
* Clean up input handling in VulkanViewerGravatar jvanverth2016-04-06
| | | | | | | Sets up proper handling of characters and keycodes, and event modifiers. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1865553005 Review URL: https://codereview.chromium.org/1865553005
* More iOS swarming bot fixesGravatar borenet2016-04-06
| | | | | | | | | | - Copy the packaged app into xcodebuild/... - Isolate ios/bin directory BUG=skia:5155 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1860333002 Review URL: https://codereview.chromium.org/1860333002
* Alter dm_flags.py logic flow for certain configs to be subtractiveGravatar bsalomon2016-04-06
| | | | | | | | | Replace msaa4 on Shield Tablet with glmsaa4. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1868473003 Review URL: https://codereview.chromium.org/1868473003
* cubic stroke fixGravatar caryclark2016-04-06
| | | | | | | | | | | | | | | Normally parallel tangents means that the stroke can be represented with a line. But looping cubics can have parallel tangents if the loop is 180 degrees. Check to see if the tangents direction is opposite to subdivide further. R=reed@google.com BUG=skia:5099 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862753002 Review URL: https://codereview.chromium.org/1862753002
* Update DropShadowImageFilter to sk_spGravatar robertphillips2016-04-06
| | | | | | | | TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1861843002 Review URL: https://codereview.chromium.org/1861843002
* Add exclusion for keymobi_shop_mobileweb_ebay_com.skp on N5Gravatar bsalomon2016-04-06
| | | | | | | BUG=skia:5178 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1857123005 Review URL: https://codereview.chromium.org/1857123005
* Update DownSampleImageFilter to sk_spGravatar robertphillips2016-04-06
| | | | | | | | TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864583005 Review URL: https://codereview.chromium.org/1864583005
* SkSurfaceProps now has a gamma-correct ("AllowSRGBInputs") flag. That's ↵Gravatar brianosman2016-04-06
| | | | | | | | | | | | propagated in a few places so that the backend can do the right thing for L32 vs S32 mode. Also added SkSurfaceProps to SkSpecialImage, so that Image -> Surface conversion can preserve the desired behavior during filtering. Many small changes, including a bunch of comments about places where we may be losing information right now. My approach was to ensure that if anything fails, it will always fall back to "legacy" mode - gamma-correctness is opt-in, so I'll just have to feed things through as missing cases are exposed. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1838953007 Review URL: https://codereview.chromium.org/1845283003
* Add mipmap procs for F16 format.Gravatar brianosman2016-04-06
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1831353002 Review URL: https://codereview.chromium.org/1831353002
* Enable RAW codec for WindowsGravatar yujieqin2016-04-06
| | | | | | | BUG=skia:4890 b/26973157 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853093002 Review URL: https://codereview.chromium.org/1853093002
* Another NDK release. Still just bug fixes.Gravatar mtklein2016-04-06
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864073002 Review URL: https://codereview.chromium.org/1864073002
* First pass at VulkanViewerGravatar jvanverth2016-04-06
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1848833005 Review URL: https://codereview.chromium.org/1848833005
* "Fix" compiler issue in SkRandomScalerContextGravatar robertphillips2016-04-05
| | | | | | | BUG=skia:5164 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862643002 Review URL: https://codereview.chromium.org/1862643002
* Update SkMatrixImageFilter to sk_spGravatar robertphillips2016-04-05
| | | | | | | | TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1858353002 Review URL: https://codereview.chromium.org/1858353002
* Get back on mainline libpng 1.6 now that 3bpp perf patches are merged.Gravatar mtklein2016-04-05
| | | | | | | | | Checked manually in Instruments that we're still running our SSE filters for both RGB and RGBA PNGs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1865633002 Review URL: https://codereview.chromium.org/1865633002
* One signature for creating unit tests that run on premade GrContextsGravatar bsalomon2016-04-05
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1860593002 Review URL: https://codereview.chromium.org/1860593002
* Do an in-place replacement of SkRandom with Fuzz for FilterFuzzGravatar kjlubick2016-04-05
| | | | | | | | | | This feels rather clunky, because we aren't using the full potential of the fuzzer, but it works, it seems. BUG=skia:4969 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1710183002 Review URL: https://codereview.chromium.org/1710183002
* Update SkXfermodeImageFilter to sk_spGravatar robertphillips2016-04-05
| | | | | | | | | | TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852123002 Committed: https://skia.googlesource.com/skia/+/3bc969264d4720d67f0b137552b3777a03b431a8 Review URL: https://codereview.chromium.org/1852123002
* Set 'device_cfg' parameter for iOS botsGravatar borenet2016-04-05
| | | | | | | | | For https://codereview.chromium.org/1859993003/ BUG=skia:5155 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862723002 Review URL: https://codereview.chromium.org/1862723002
* Revert of Delete SkFlattenable::Type (part 1) (patchset #1 id:1 of ↵Gravatar msarett2016-04-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1861013002/ ) Reason for revert: See sugoi's comment. Original issue's description: > Delete SkFlattenable::Type (part 1) > > This should allow me to delete uses of SkFlattenable::Type in Chrome. > Then I'll follow up with the full delete. > https://codereview.chromium.org/1834303003/ > > TBR=reed@google.com > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1861013002 > > Committed: https://skia.googlesource.com/skia/+/6b63536e917d86028630199c4eef4aa1597292ce TBR=reed@google.com,mtklein@google.com,sugoi@chromium.org,senorblanco@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1860693005
* Update SkColorFilterImageFilter to sk_spGravatar robertphillips2016-04-05
| | | | | | | | TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1858813002 Review URL: https://codereview.chromium.org/1858813002
* Create output directory in skdiffGravatar brianosman2016-04-05
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1865563002 Review URL: https://codereview.chromium.org/1865563002
* Rename enums in GrContextFactory to remove "GL"Gravatar bsalomon2016-04-05
| | | | | | | | | | Also, remove kNative as a separate context type and instead make it an alias for kGL or kGLES based on OS. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1845923004 Committed: https://skia.googlesource.com/skia/+/2d9c6f81353597aebf5934547e5cba7a872196fb Review URL: https://codereview.chromium.org/1845923004
* Fix vulkan dual source blendingGravatar egdaniel2016-04-05
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1856283003 Review URL: https://codereview.chromium.org/1856283003
* Remove 'native' context unit test macro.Gravatar bsalomon2016-04-05
| | | | | | | | | The only test ran long is GLPrograms. I halved its iteration count to preserve the runtime on devices that support GL and GLES. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1855993002 Review URL: https://codereview.chromium.org/1855993002
* Reland of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of ↵Gravatar borenet2016-04-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1861713002/ ) Reason for revert: Retry again Original issue's description: > Revert of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of https://codereview.chromium.org/1856373003/ ) > > Reason for revert: > Try again. > > Original issue's description: > > Whitespace change to test Bugdroid+AutoRoll > > > > BUG=598773 > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1856373003 > > > > Committed: https://skia.googlesource.com/skia/+/74f047b58b70935f21cc08d30b7cc789b22bc7cf > > TBR=borenet@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=598773 > > Committed: https://skia.googlesource.com/skia/+/cd76ae50e9bba22282a283eb18d092291b1f98ad TBR=borenet@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=598773 Review URL: https://codereview.chromium.org/1864573002
* Delete SkFlattenable::Type (part 1)Gravatar msarett2016-04-05
| | | | | | | | | | | | | This should allow me to delete uses of SkFlattenable::Type in Chrome. Then I'll follow up with the full delete. https://codereview.chromium.org/1834303003/ TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1861013002 Review URL: https://codereview.chromium.org/1861013002
* Update SkMorphology ImageFilters to sk_spGravatar robertphillips2016-04-05
| | | | | | | | TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1860573002 Review URL: https://codereview.chromium.org/1860573002
* Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly ↵Gravatar bsalomon2016-04-05
| | | | | | | | | | use OpenGL rather than GLES and use them on the X1 bot GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853103003 Committed: https://skia.googlesource.com/skia/+/74cb44dee50b5db94c1374cbcf0b0a1babd09d89 Review URL: https://codereview.chromium.org/1853103003
* Add valgrind suppression file to infrabots.isolateGravatar rmistry2016-04-05
| | | | | | | BUG=skia:5149 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1859083002 Review URL: https://codereview.chromium.org/1859083002
* Revert of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of ↵Gravatar borenet2016-04-05
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1856373003/ ) Reason for revert: Try again. Original issue's description: > Whitespace change to test Bugdroid+AutoRoll > > BUG=598773 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1856373003 > > Committed: https://skia.googlesource.com/skia/+/74f047b58b70935f21cc08d30b7cc789b22bc7cf TBR=borenet@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=598773 Review URL: https://codereview.chromium.org/1861713002
* Do not set do_perf_steps for Build-Ubuntu-GCC-x86_64-Release-SwarmingValgrindGravatar rmistry2016-04-05
| | | | | | | BUG=skia:5149 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1856403002 Review URL: https://codereview.chromium.org/1856403002
* give up if huge paths have unresolvable coincidenceGravatar caryclark2016-04-05
| | | | | | | | | | | | This fuzzy test has enormous curves with coincidence runs that break numerics. If the computed intersections identify that the span of coincidence has been deleted, give up and return that the path op failed. TBR=reed@google.com BUG=597926 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1854333002 Review URL: https://codereview.chromium.org/1854333002
* Revert of Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that ↵Gravatar bsalomon2016-04-05
| | | | | | | | | | | | | | | | | | | | | explictly use OpenGL rather than GL… (patchset #3 id:40001 of https://codereview.chromium.org/1853103003/ ) Reason for revert: causing crashes on win8 bot? Original issue's description: > Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GLES and use them on the X1 bot > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853103003 > > Committed: https://skia.googlesource.com/skia/+/74cb44dee50b5db94c1374cbcf0b0a1babd09d89 TBR=egdaniel@google.com,jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1857233002
* Implement blit image for copySurface in VulkanGravatar egdaniel2016-04-05
| | | | | | | | | Also allows CopyImage to handle GrRenderTargets which are not textures. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852413002 Review URL: https://codereview.chromium.org/1852413002
* Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly ↵Gravatar bsalomon2016-04-05
| | | | | | | | use OpenGL rather than GLES and use them on the X1 bot GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853103003 Review URL: https://codereview.chromium.org/1853103003
* remove avoid and pixelxor xfermodesGravatar reed2016-04-05
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853103005 Review URL: https://codereview.chromium.org/1853103005
* Whitespace change to test Bugdroid+AutoRollGravatar borenet2016-04-05
| | | | | | | BUG=598773 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1856373003 Review URL: https://codereview.chromium.org/1856373003
* Fix failed filter followed by an affects-transparent-black filter.Gravatar senorblanco2016-04-05
| | | | | | | | | | | | | | When an upstream filter returns null, either through failure or clipping, a downstream affects-transparent-black filter should still produce non-transparent pixels. This patch fixes SkColorFilterImageFilter. Note: this will affect the results of the imagefilterscropexpand GM. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1844593002 Review URL: https://codereview.chromium.org/1844593002
* Revert of Delete SkFlattenable::Type (patchset #2 id:20001 of ↵Gravatar mtklein2016-04-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1834303003/ ) Reason for revert: Used by Chrome. c:\b\build\slave\workdir\build\src\cc\playback\compositing_display_item.cc(53): error C2039: 'GetFlattenableType': is not a member of 'SkColorFilter' c:\b\build\slave\workdir\build\src\third_party\skia\include\core\skshader.h(19): note: see declaration of 'SkColorFilter' c:\b\build\slave\workdir\build\src\cc\playback\compositing_display_item.cc(53): error C3861: 'GetFlattenableType': identifier not found Original issue's description: > Delete SkFlattenable::Type > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834303003 > > Committed: https://skia.googlesource.com/skia/+/99d9231f6a4cb6b85b8637e9d8ae32f8bd7c466f TBR=reed@google.com,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1853383002
* Delete SkFlattenable::TypeGravatar msarett2016-04-04
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834303003 Review URL: https://codereview.chromium.org/1834303003
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-02 01:21:47 +0000