aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Reinitialize monit to changes take effect.Gravatar tfarina2014-09-26
| | | | | | | | | | | | | Otherwise changes made to the configuration won't take effect when they are synced. BUG=None TEST=None R=jcgregorio@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/602293002
* Update SKP version to 112Gravatar borenet2014-09-25
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/604983003
* Fix SkTableColorFilter deserialization validation.Gravatar senorblanco2014-09-25
| | | | | | | | | | | | | Broken in https://skia.googlesource.com/skia/+/9fa60daad4d5f54c0dbe3dbcc7608a8f6d721187. R=reed@google.com TBR=reed@google.com BUG=skia: Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/604873004
* Add doc on SkCanvas::drawImage*() methodsGravatar piotaixr2014-09-25
| | | | | | | | | BUG=skia:2947 R=junov@chromium.org, reed@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/595043002
* Make SkImage::draw() privateGravatar piotaixr2014-09-25
| | | | | | | | | BUG=skia:2947 R=junov@chromium.org, reed@google.com, bsalomon@chromium.org Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/608623002
* Seems that some of our compliers can't infer this type, though most can.Gravatar Mike Klein2014-09-25
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/603263002
* Remove SkPaint dirty bits.Gravatar mtklein2014-09-25
| | | | | | | | | | | | | | | | | | | | | | | fDirtyBits is only used by SkPaint::FlatteningTraits, which in turn was only used as a smaller, faster format to flatten paints in-memory to dedup them in the old picture backend. SkRecord obsoleted all this. Neither flatten()/unflatten() (disk format) nor FlatteningTraits is used anywhere performance or size matters. Here I revert the deduping code back to using the disk format for flattened paints. We stil do have to flatten and unflatten paints while coverting from SkRecord backend to the old backend, so we can't just delete this all yet, but any faithful round trip flatten()/unflatten() pair will be fine, however slow. NOTRY=true BUG=skia: R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/604813003
* SkCanvas::drawImage is the new way for drawing a SkImage to a CanvasGravatar piotaixr2014-09-24
| | | | | | | | | | | | BUG=skia:2947 Committed: https://skia.googlesource.com/skia/+/432789972c1e1f8a66165c75a250dba1853efa08 R=junov@chromium.org, reed@google.com, bsalomon@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/583453002
* Fix SkXfermode deserialization.Gravatar senorblanco2014-09-24
| | | | | | | | | | | Validation was failing due to an inverted test condition. BUG=417266 R=reed@google.com Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/596333002
* Correct glyph with non-bmp from typeface on Mac.Gravatar bungeman2014-09-24
| | | | | | | | | | | | | CTFontGetGlyphsForChars puts the glyph id at the index of the lead surrogate as is documented in comments, but the code is looking at the index of the trail surrogate. BUG=skia:2960 R=mtklein@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/596413002
* Revert of SkCanvas::drawImage is the new way for drawing an SkImage to a ↵Gravatar borenet2014-09-24
| | | | | | | | | | | | | | | | | | | | | | | | | | Canvas (patchset #9 id:160001 of https://codereview.chromium.org/583453002/) Reason for revert: Broke ChromiumOS Ozone builder: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/4087/steps/compile/logs/stdio Reverting to unblock DEPS roll. Original issue's description: > SkCanvas::drawImage is the new way for drawing a SkImage to a Canvas > > BUG=skia:2947 > > Committed: https://skia.googlesource.com/skia/+/432789972c1e1f8a66165c75a250dba1853efa08 R=junov@chromium.org, reed@google.com, bsalomon@google.com, piotaixr@chromium.org TBR=bsalomon@google.com, junov@chromium.org, piotaixr@chromium.org, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2947 Author: borenet@google.com Review URL: https://codereview.chromium.org/598133002
* Use OptDrawState instead of DrawState when flushing state in GrGpuGLGravatar egdaniel2014-09-24
| | | | | | | | | BUG=skia: R=bsalomon@google.com, joshualitt@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/599963002
* Swap iteration order in TileGrid::insert().Gravatar mtklein2014-09-24
| | | | | | | | | | | | | Was looking at performance here (it's the record hotspot) and noticed we iterate through the grid out of order. This is a tiny little thing, but it's probably orthogonal to any other performance improvements we'll make in here. BUG=skia: R=robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/598933004
* Update layer hoisting code to correctly render sub-picture layersGravatar robertphillips2014-09-24
| | | | | | | | | | | The prior code assumed all layers came from a single picture. BUG=skia:2315 R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/595543002
* Revert "Use draw buffer for texture copy impl."Gravatar Brian Salomon2014-09-24
| | | | | | | This reverts commit e3d4bf234a04e14b6b0f33e11b3e1132b560c145. Conflicts: src/gpu/GrContext.cpp
* Have nanobench --verbose mode always just print integer nanoseconds.Gravatar mtklein2014-09-24
| | | | | | | | | | | | | Don't know that anyone but me is using this. Speak up now! BUG=skia: NOTREECHECKS=true R=mtklein@google.com, tfarina@chromium.org Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/599913002
* Revert "Add support for EGL on linux"Gravatar borenet2014-09-24
| | | | | | | | | | | | | | | This reverts commit 1cea736c3280b6f0553e3eaa598e41370b305b57. Caused segfaults on all Android devices R=bsalomon@google.com, djsollen@google.com TBR=bsalomon, djsollen NOTRY=true BUG=skia: Author: borenet@google.com Review URL: https://codereview.chromium.org/599493003
* Update SKP version to 110Gravatar borenet2014-09-23
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/595203002
* Add support for EGL on linuxGravatar derekf2014-09-23
| | | | | | | | | | Allow setting skia_egl=1 to build skia against EGL instead of GLX on unix R=bsalomon@google.com, djsollen@google.com Author: derekf@osg.samsung.com Review URL: https://codereview.chromium.org/543363004
* SkCanvas::drawImage is the new way for drawing a SkImage to a CanvasGravatar piotaixr2014-09-23
| | | | | | | | | BUG=skia:2947 R=junov@chromium.org, reed@google.com, bsalomon@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/583453002
* We need to adjust the bounds of clip ops with SaveLayer paints too.Gravatar Mike Klein2014-09-23
| | | | | | | | | | | | | Before this CL, SkRecord only adjusted the bounds of draw ops for SaveLayers' paints. That worked fine, but as a final step we intersect the bounds of draw ops with the bounds of the current clip, essentially undoing all that work. I think the right fix here is to also adjust the bounds of the clip ops. BUG=skia:2957, 415468 R=robertphillips@google.com Review URL: https://codereview.chromium.org/595953002
* Remove unused fRequiresVertexShader data member from OptDrawStateGravatar egdaniel2014-09-23
| | | | | | | | | BUG=skia: R=jvanverth@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/578323003
* Patch to create a distinct geometry processor. The vast majority of this patchGravatar joshualitt2014-09-23
| | | | | | | | | | | | | is just a rename. The meat is in GrGeometryProcessor, GrProcessor, GrGL*Processor, GrProcessorStage, Gr*BackendProcessorFactory, GrProcessUnitTestFactory, and the builders BUG=skia: R=bsalomon@google.com Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/582963002
* Remove underscores from mode identifiers.Gravatar mtklein2014-09-23
| | | | | | | | | | | | | | Underscore is used as a field separator sometimes when parsing the task name into a list of config, mode, etc. (This itself is dumb and TODO(mtklein): fix.) Underscores in the field names will really mess that up, both in directories generated from human-mode -w, and in the .json file. BUG=skia: R=jcgregorio@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/599503002
* Use draw buffer for texture copy impl.Gravatar bsalomon2014-09-23
| | | | | | | | R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/589143004
* Use uniform color/coverage inputs when path rendering.Gravatar bsalomon2014-09-23
| | | | | | | | | BUG=skia:2954 R=egdaniel@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/600483002
* Fix inputCoverageIsUsed bug in GrGLProgramDescGravatar egdaniel2014-09-23
| | | | | | | | | BUG=skia: R=joshualitt@chromium.org Author: egdaniel@google.com Review URL: https://codereview.chromium.org/593803003
* Adding support for GL_CHROMIUM_copy_texture, part 1Gravatar junov2014-09-23
| | | | | | | | | | | | | | Part 1 of 2. This change just adds the gl API entrypoint so that the chromium/ganesh bindings can set it. Once the chromium part is landed, we will add full support for the extension BUG=crbug.com/415100 R=bsalomon@google.com Author: junov@chromium.org Review URL: https://codereview.chromium.org/594663002
* Update SKP version to 109Gravatar borenet2014-09-22
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/594783002
* Fix SDF font positions when using global scale.Gravatar jvanverth2014-09-22
| | | | | | | | | | | | Also fixes a crash in the dftext GM when using SampleApp, and adds new test case in dftext. BUG=skia:2928 R=joshualitt@google.com, egdaniel@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/588223002
* Calculate Primary and Secondary output types in the GrOptDrawStateGravatar egdaniel2014-09-22
| | | | | | | | | | | Follow up CL to https://codereview.chromium.org/545693004/ BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/554833002
* Change GrGLProgramDesc header to have DoPathRendering flag instead of ↵Gravatar egdaniel2014-09-22
| | | | | | | | | | | | | | RequiresVertexShader Also update GLProgramTests to fix bug where it would incorrectly try to PathRendering when we did not want to. BUG=skia: R=bsalomon@google.com, joshualitt@chromium.org Author: egdaniel@google.com Review URL: https://codereview.chromium.org/586793002
* Rebaseline gm expectations after nvpr text changeGravatar cdalton2014-09-22
| | | | | | | | | | BUG=skia:2951 BUG=skia:2954 R=bsalomon@google.com, borenet@google.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/580943003
* Don't try to scale embedded bitmaps.Gravatar bungeman2014-09-22
| | | | | | | | | | | | | | If a font is bitmap only we need to scale a bitmap to obtain the requested size if there isn't an exact match. If a font has embedded bitmaps then these bitmaps should never be scaled by Skia. Allow FreeType to do the scaling (as requested by the font). BUG=chromium:408059 R=mtklein@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/596513002
* Don't flush on read/write pixels unless necessaryGravatar bsalomon2014-09-22
| | | | | | | | | | | | BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/150723b9298772a5096bec7acd2999c5c9d66239 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/586073002
* Make a flipped fDirtyBit always mean "this field is not the default".Gravatar mtklein2014-09-22
| | | | | | | | | | | Haven't been able to measure any perf effect, so I figure I'll let the bots have at it. BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/595583003
* remove flags that now live in chrome's SkUserConfig.hGravatar reed2014-09-22
| | | | | | | | | NOTRY=True TBR=robertphilips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/591133003
* Fix typo in experimental/webtry/DESIGN.md.Gravatar jcgregorio2014-09-22
| | | | | | | | R=tfarina@chromium.org Author: jcgregorio@google.com Review URL: https://codereview.chromium.org/593723003
* Proposed fix for small bug in gpu conical gradientsGravatar joshualitt2014-09-22
| | | | | | | | | BUG=skia: R=bsalomon@google.com, egdaniel@google.com, senorblanco@chromium.org Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/593443002
* Revert of Don't flush on read/write pixels unless necessary (patchset #2 ↵Gravatar bsalomon2014-09-22
| | | | | | | | | | | | | | | | | | | | | | | | id:20001 of https://codereview.chromium.org/586073002/) Reason for revert: Breaking the tree Original issue's description: > Don't flush on read/write pixels unless necessary > > BUG=skia:2889 > > Committed: https://skia.googlesource.com/skia/+/150723b9298772a5096bec7acd2999c5c9d66239 R=robertphillips@google.com TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2889 Author: bsalomon@google.com Review URL: https://codereview.chromium.org/594543004
* Don't flush on read/write pixels unless necessaryGravatar bsalomon2014-09-22
| | | | | | | | | BUG=skia:2889 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/586073002
* Introduce Props to surface (patchset #27 id:520001 of ↵Gravatar reed2014-09-22
| | | | | | | | | | | | https://codereview.chromium.org/551463004/)" This reverts commit 29c857d0f3a1cb837f73406eeb6ba9771879b5e7. TBR= Author: reed@google.com Review URL: https://codereview.chromium.org/588143004
* Cleaning includes in SkImage-related filesGravatar piotaixr2014-09-22
| | | | | | | | | BUG=skia:2948 R=junov@chromium.org, tfarina@chromium.org, reed@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/586853003
* Update SKP version to 108Gravatar borenet2014-09-21
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/586403002
* Revert of introduce Props to surface (patchset #27 id:520001 of ↵Gravatar reed2014-09-21
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/551463004/) Reason for revert: Broke call site in WebKit Original issue's description: > introduce Props to surface (work in progress) > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/3716fd067a5621bb94a6cb08d72afec8bf3aceda R=robertphillips@google.com, bsalomon@google.com, jvanverth@google.com, bungeman@google.com, fmalita@google.com, vangelis@chromium.org, reed@google.com TBR=bsalomon@google.com, bungeman@google.com, fmalita@google.com, jvanverth@google.com, reed@google.com, robertphillips@google.com, vangelis@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@chromium.org Review URL: https://codereview.chromium.org/583773004
* introduce Props to surface (work in progress)Gravatar reed2014-09-21
| | | | | | | | | BUG=skia: R=robertphillips@google.com, bsalomon@google.com, jvanverth@google.com, bungeman@google.com, fmalita@google.com, vangelis@chromium.org, reed@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/551463004
* Update SKP version to 107Gravatar borenet2014-09-20
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/585313002
* Souped-up SkTextBlob.Gravatar fmalita2014-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactored text blob backend for improved performance: instead of using separate buffers for runs/positions/glyphs, everything is now packed in a consolidated slab (including the SkTextBlob object itself!). Benefits: * number of allocations per blob construction reduced from ~4 to 1 (also minimizes internal fragmentation) * run record size reduced by 8 bytes This takes the blob construction overhead down to negligible levels (for the current Blink uncached textblob implementation). Unfortunately, the code is much more finicky (run merging in particular) -- hence the assert spree. Multi-run blobs are vulnerable to realloc storms but this is not a problem at the moment because Blink is using one-run blobs 99% of the time. Will be addressed in the future. R=mtklein@google.com, reed@google.com, robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/13645ea0ea87038ebd71be3bd6d53b313069a9e4 Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/581173003
* Update SKP version to 106Gravatar borenet2014-09-19
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/590643003
* Revert of Souped-up SkTextBlob. (patchset #3 id:40001 of ↵Gravatar fmalita2014-09-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/581173003/) Reason for revert: Broke the new blobshader gm. Original issue's description: > Souped-up SkTextBlob. > > Refactored text blob backend for improved performance: instead of using > separate buffers for runs/positions/glyphs, everything is now packed in > a consolidated slab (including the SkTextBlob object itself!). > > Benefits: > > * number of allocations per blob construction reduced from ~4 to 1 > (also minimizes internal fragmentation) > * run record size reduced by 8 bytes > > This takes the blob construction overhead down to negligible levels > (for the current Blink uncached textblob implementation). > > Unfortunately, the code is much more finicky (run merging in > particular) -- hence the assert spree. > > Multi-run blobs are vulnerable to realloc storms but this is not a > problem at the moment because Blink is using one-run blobs 99% of the > time. Will be addressed in the future. > > > R=reed@google.com,mtklein@google.com,robertphillips@google.com > > Committed: https://skia.googlesource.com/skia/+/13645ea0ea87038ebd71be3bd6d53b313069a9e4 R=mtklein@google.com, reed@google.com, robertphillips@google.com TBR=mtklein@google.com, reed@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/588853002