aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* JUMPER_IS_AVX2 -> JUMPER_IS_HSWGravatar Mike Klein2017-12-12
| | | | | | | | | | | | | | | | | | | | We need to be a bit more pedantic here to support builds that may be using AVX2 as part of their baseline but perhaps not enabling all the related features SkJumper would like to use. E.g. we've seen Tensorflow build with AVX2 and FMA, but not F16C. So check all three {AVX2,FMA,F16C}, and only then build stages in HSW mode. I've updated the define as a reminder. This only affects builds using these features for their _baseline_ stages... the offline-compiled stages in SkJumper_generated.S are not affected. Change-Id: I9bfb3bae3589d35043b748782cefa8c213726d6a Reviewed-on: https://skia-review.googlesource.com/84221 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Store skiaserve binary in GS from Release Android compile botsGravatar Ravi Mistry2017-12-12
| | | | | | | | Bug: skia:7399 Change-Id: Id60773f77694b06a938f9a126f30ca56e4965d30 Reviewed-on: https://skia-review.googlesource.com/83981 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Handle small sigma in one directionGravatar Herb Derby2017-12-12
| | | | | | | | | | | | | | | Because GPU/CPU must interoperate, the border calculation code adds transparent black border pixels for sigmas that produce a window of 1. This is a very rare case and seems to only happen in fuzzers. In this case cleare everything to black before bluring. BUG=chromium:793285 Change-Id: I2b56f9ad88304abaa2669c9c9ef69b5443ba4333 Reviewed-on: https://skia-review.googlesource.com/83562 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Herb Derby <herb@google.com>
* Roll skia/third_party/externals/angle2/ 3c613c0d7..a98a28112 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/3c613c0d79fa..a98a28112b0e $ git log 3c613c0d7..a98a28112 --date=short --no-merges --format='%ad %ae %s' 2017-11-30 jiajia.qin ES31: Add support for GL_DISPATCH_INDIRECT_BUFFER_BINDING binding point Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=liyuqian@google.com Change-Id: If18ecdc6653031f972d7173c5e126b38c015ac14 Reviewed-on: https://skia-review.googlesource.com/84162 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
* Push much of the SkColorSpace_Base interface up to SkColorSpaceGravatar Brian Osman2017-12-12
| | | | | | | | | | | Some pieces still remain, but the next step looks less mechanical, so I wanted to land this piece independently. Bug: skia: Change-Id: Ie63afcfa08af2f6e4996911fa2225c43441dbfb2 Reviewed-on: https://skia-review.googlesource.com/84120 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
* Fuzz skpicture with ReadBufferGravatar Kevin Lubick2017-12-12
| | | | | | | | Bug: skia: Change-Id: Id581895b5248a8f24eed77cad20fc751257c2c95 Reviewed-on: https://skia-review.googlesource.com/83861 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Remove GrBackendObject from tests (except image_from_yuv_textures)Gravatar Robert Phillips2017-12-12
| | | | | | | | | This sets the stage for landing https://skia-review.googlesource.com/c/skia/+/82823 (Update SkImage::MakeFromYUVTexturesCopy to GrBackendTexture) Change-Id: I2c62f23dc447b9ad55c0b5f06bcd6d7ca0ec4d2b Reviewed-on: https://skia-review.googlesource.com/83920 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/externals/angle2/ 7f5c3eb76..3c613c0d7 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/7f5c3eb76834..3c613c0d79fa $ git log 7f5c3eb76..3c613c0d7 --date=short --no-merges --format='%ad %ae %s' 2017-11-16 fjhenigman Update docs for GN standalone and GYP deprecation. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=liyuqian@google.com Change-Id: I2d9fa893b638888323961ee3c505a4e97a40452a Reviewed-on: https://skia-review.googlesource.com/84081 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* dm: require tmpDir, reasonable defaultsGravatar Hal Canary2017-12-12
| | | | | | | Change-Id: I9d84ce1ebbe417160a29ca2221b1df04901238e3 Reviewed-on: https://skia-review.googlesource.com/83541 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* stabilize catalogGravatar Cary Clark2017-12-12
| | | | | | | | | | | | | | | Identify volatile stdout from examples to make site/user/api/catalog.htm the same from one run to the next. Remove a debugging printf from mdOut.cpp Docs-Preview: https://skia.org/?cl=83941 Bug: skia:6898 Change-Id: I52c7527394e00934f57bb6c02ff33b422f4770ca Reviewed-on: https://skia-review.googlesource.com/83941 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* a little SkJumper tidy upGravatar Mike Klein2017-12-12
| | | | | | | | | | | | | | | | I noticed these little bits while working on that old-Clang fix. - We can force-inline anytime we've got Clang, not just when JUMPER_IS_OFFLINE. - The _aarch64 and _vfp4 WRAP functions are dead code, as they're never compiled offline now. Change-Id: I5850daded2ffcfe50ceeadc43f89fa8597df3387 Reviewed-on: https://skia-review.googlesource.com/84060 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* only read color array if flag is fixed colorGravatar Cary Clark2017-12-12
| | | | | | | | | | | | | | Fixed color array shouldn't be required in Lattice if no flag is set to kFixedColor. Skip the read from the array if it is not set. R=stani@google.com Bug: skia:6898 Change-Id: I846b5fdf036cf110ce0ae4ffcf0654bca7029412 Reviewed-on: https://skia-review.googlesource.com/83942 Reviewed-by: Stan Iliev <stani@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>
* fix fractured fiddlesGravatar Cary Clark2017-12-12
| | | | | | | | | | | | | | Latest run of Ravi's bot found a couple of new fiddle failures. Fix them. Yay, tools! Docs-Preview: https://skia.org/?cl=83944 Bug: skia:6898 Change-Id: I98ecef6b034363dfea88bcc9c710fb3017fc1c21 Reviewed-on: https://skia-review.googlesource.com/83944 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Roll skia/third_party/externals/angle2/ feb2c63b7..7f5c3eb76 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/feb2c63b7b05..7f5c3eb76834 $ git log feb2c63b7..7f5c3eb76 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 cwallez Revert "Implement EGL_ANGLE_iosurface_client_buffer" Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=liyuqian@google.com Change-Id: I4ef8ab85f1b4c4f128f1b647baf68f6fcc162868 Reviewed-on: https://skia-review.googlesource.com/83884 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* drop to scalar mode in some armv7 debug buildsGravatar Mike Klein2017-12-12
| | | | | | | | | | | | | Older versions of Clang, at least vanilla 3.9 and "Apple LLVM version 8.1.0 (clang-802.0.42)" seem to crash when compiling SkJumper_stages.cpp with NEON for ARMv7 without at least -O1. So detect that case, and fall back to scalar code. Change-Id: I3c1595da491bef38c18f47f96690700c67fdc70e Reviewed-on: https://skia-review.googlesource.com/83980 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Use new bookmaker flag to status.jsonGravatar Ravi Mistry2017-12-12
| | | | | | | | Bug: skia:7310 Change-Id: I7eeb73eb6d9c07549bf7a5d7c2d8b4d3049ac3da Reviewed-on: https://skia-review.googlesource.com/83860 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Roll skia/third_party/externals/angle2/ 629a64498..feb2c63b7 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/629a64498dde..feb2c63b7b05 $ git log 629a64498..feb2c63b7 --date=short --no-merges --format='%ad %ae %s' 2017-12-08 jiajia.qin ES31: Fixed the SSBO instance array error Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=liyuqian@google.com Change-Id: I5ee04de6a0fc0d6111543146c11f36e75cd7eeb5 Reviewed-on: https://skia-review.googlesource.com/83961 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* converted vertex shaders to device coordsGravatar Ethan Nicholas2017-12-12
| | | | | | | | Bug: skia:6239 Change-Id: I1a3b67fe84d208d426d71deb7aea6b0cd433af37 Reviewed-on: https://skia-review.googlesource.com/75501 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Prefer fullscreen clears on Qualcomm/GLGravatar Chris Dalton2017-12-12
| | | | | | | | | | | | | | | | | Adds Qualcomm to the set of GL devices on which we prefer fullscreen clears. Renames fullscreenClearIsFree in GrCaps to preferFullscreenClears. Replaces 'bool canIgnoreClip' on GrRenderTargetContext::clear with an enum. Bug: skia: Change-Id: I5b30298c4d0b092c398b9fea6060f3e2bea91e46 Reviewed-on: https://skia-review.googlesource.com/83060 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* fix running on linuxGravatar Cary Clark2017-12-12
| | | | | | | | | | | | | | | | | Verified that bookmaker running on Linux generates same .md files as when it runs on Windows. Fixed a directory separator bug. Catalog has slightly different output because some tests generate volatile output -- need to fix this in general. Docs-Preview: https://skia.org/?cl=83940 Bug: skia:6898 Change-Id: I3c56c372d155b1b14a1fbdf616fa79f420b78150 Reviewed-on: https://skia-review.googlesource.com/83940 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
* Fix scaling logic for NexusPlayer and AndroidOneGravatar Kevin Lubick2017-12-12
| | | | | | | | | | | | They seem to be their own special cases for what governors they support. Bug: skia: NOTRY=true Change-Id: I7bb220e1d3ba6851c17c7e6ef327aab24ffdba42 Reviewed-on: https://skia-review.googlesource.com/83900 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Search more for stacktrace to symbolizeGravatar Kevin Lubick2017-12-12
| | | | | | | | | | | | | | | | If the stacktrace wasn't in the last 200 lines, we couldn't find and symbolize it. https://chromium-swarm.appspot.com/task?id=3a5e86a9d0e04e10&refresh=10 We increase the window to 500 lines to account for large memory maps. Bug: skia:7397 NOTRY=true Change-Id: Ic8583e383663a9beb62a32e90a5bd5d73d7446a7 Reviewed-on: https://skia-review.googlesource.com/83540 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Scale extra CPUs to powersave during nanobench.Gravatar Kevin Lubick2017-12-12
| | | | | | | | | | | | | | | | | | | | | | | | This scaling logic correctly accounts for some devices which have multiple CPUs. Previously, we were scaling the smaller of these CPUs, which likely had a negative impact on nanobench, given nanobench was single threaded and the CPUs weren't allowed to idle much (because we set the CPU). This CL sets those additional CPUs to powersave when we run nanobench and then correctly scales down the beefier CPU we want to run nanobench on. For DM, we just run it in ondemand mode, which will hopefully be "as fast as possible", but allow the CPU governor to scale down if overheating becomes a problem. Bug: skia:7378 notry=TRUE Change-Id: I45ca5d9fb32182233d1b2d094842c879f2b84da4 Reviewed-on: https://skia-review.googlesource.com/83240 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* remove vfpv4 requirement for SkJumper on ARMv7Gravatar Mike Klein2017-12-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | VFPv4 gives us two interesting features: - FMA - f16<->f32 conversions Even without FMAs, NEON still has non-fused MLA instructions. We don't really care about the fusedness of those mul-adds, so losing FMA here is kind of no big deal. We already maintain portable code to do f16<->f32 conversions, so it's not much of a maintanence hit to use that instead of the native instructions. To my knowledge software F16 rendering is not a performance critical mode of operation for any of our users. This drops our minimum requirement to basically just having NEON. Devices like the Nexus 7 2012 will now take SkJumper fast paths instead of portable code. (Though actually, we've only ever required NEON for _lowp... only the float code also needed vfpv4). The main file to look at here is actually SkJumper_vectors.h, where you will see all the substantive changes. The rest just kind of tears down most of the old complexity, add adds ABI to put just a little of it back. :) Change-Id: Ia9237117698729c91e5fa51126baf80748093bf4 Bug: skia: Reviewed-on: https://skia-review.googlesource.com/83521 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Roll skia/third_party/externals/angle2/ c7abc0803..629a64498 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/c7abc08034a3..629a64498dde $ git log c7abc0803..629a64498 --date=short --no-merges --format='%ad %ae %s' 2017-12-11 oetuaho Fix HLSL integer pow workaround Created with: roll-dep skia/third_party/externals/angle2 BUG=793115 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=liyuqian@google.com Change-Id: I73a2bee4cae25f79d0ccd1fe68e13bc62f9f7a63 Reviewed-on: https://skia-review.googlesource.com/83800 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Update markdown filesGravatar Update Docs2017-12-12
| | | | | | | | | | | | Automatic commit by the Housekeeper-Nightly-Bookmaker bot. TBR=update-docs@skia.org NO_MERGE_BUILDS Change-Id: Ie94b11512281516d52d165e0453cd50ecf353995 Reviewed-on: https://skia-review.googlesource.com/83724 Reviewed-by: Update Docs <update-docs@skia.org> Commit-Queue: Update Docs <update-docs@skia.org>
* [Bookmaker bot] Output fiddleout.json earlier and do not send to CQ for nowGravatar Ravi Mistry2017-12-11
| | | | | | | | Bug: skia:7310 Change-Id: Id6c2f15b72d6837f6536e25dbc3d01cac32af74b Reviewed-on: https://skia-review.googlesource.com/83640 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* resources: optionally link them into our binaryGravatar Hal Canary2017-12-11
| | | | | | | | | | | To enable, set skia_embed_resources=true in args.gn. Also add *-EmbededResouces bots. Change-Id: Ia69b26e926a3ad4676a4fa021894432ea2104538 Reviewed-on: https://skia-review.googlesource.com/82626 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Rename GrGLAssembleFooInterface to GrGLMakeAssembledFooInterface.Gravatar Brian Salomon2017-12-11
| | | | | | | | | | | | Add GrGLAssembleInterface with legacy bare pointer return. This allows existing clients of GrGLAssembleInterface to roll Skia without code changes. Change-Id: I0764a9f4583e554fff5574889adcc6fe004db159 Reviewed-on: https://skia-review.googlesource.com/83564 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* working on image and nightly housekeeping botGravatar Cary Clark2017-12-11
| | | | | | | | | | | | | | | | Add more examples and docs for SkImage; still a ways to go. Fix bit-rotted examples. Add typedef support. Add json driver to pick files to work on; remove special-casing. Fix unordered map traversal that made md output unreliable. TBR=rmistry@google.com Docs-Preview: https://skia.org/?cl=80060 Bug: skia:6898 Change-Id: Ib8eb9fdfa5a9db61c8332e657fa2e2f4b96a665f Reviewed-on: https://skia-review.googlesource.com/80060 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* Fix fuzzer crash in SkReadBuffer::readTypeface()Gravatar Florin Malita2017-12-11
| | | | | | | | | BUG=skia:7398 Change-Id: I1d0f7a37c6f02ec5f621f7c1b5983b668530dcd9 Reviewed-on: https://skia-review.googlesource.com/83561 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
* Roll skia/third_party/externals/angle2/ 9b88991c7..c7abc0803 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/9b88991c7211..c7abc08034a3 $ git log 9b88991c7..c7abc0803 --date=short --no-merges --format='%ad %ae %s' 2017-07-04 cwallez Implement EGL_ANGLE_iosurface_client_buffer Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=liyuqian@google.com Change-Id: I30c6dc83cb9a8a90514e99b32ca4a530ec0e2176 Reviewed-on: https://skia-review.googlesource.com/83505 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Fix Google3 link errors(?)Gravatar Brian Salomon2017-12-11
| | | | | | | Change-Id: If2d689dd34065fa5e71808170164adcb97580c75 Reviewed-on: https://skia-review.googlesource.com/83563 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Filter Windows SDK and Compiler directoriesGravatar Brian Osman2017-12-11
| | | | | | | | | | | This avoids bugs when other directories (like the Driver SDK) show up in those folders. Bug: skia:7395 Change-Id: Iee316a7daf8d71223b999de736d63e1dc7fa31f7 Reviewed-on: https://skia-review.googlesource.com/83542 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Re-add '--gpuThreads 0' tests.Gravatar Ben Wagner2017-12-11
| | | | | | | | | Bug: skia:7394 Change-Id: I2e7ed586d81d19a0b7895ff81ce6670eb7cc5003 No-Try: true Reviewed-on: https://skia-review.googlesource.com/83445 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Use first/second instead of min/max in 2pt conical gradientGravatar Yuqian Li2017-12-11
| | | | | | | | | | | | | | | | | | | | | | | | | Here's the tiny performance gain: $python tools/calmbench/calmbench.py firstsecond --extraarg "-m conic" firstsecond (compared to master) is likely 4.23% faster in gradient_conicalOut_clamp_3color 4.23% faster in gradient_conicalOutZero_clamp_3color 4.79% faster in gradient_conical_clamp_shallow_dither 6.04% faster in gradient_conical_clamp_3color 6.04% faster in gradient_conicalZero_clamp_3color 6.42% faster in gradient_conicalOut_clamp 6.43% faster in gradient_conicalOutZero_clamp 6.74% faster in gradient_conical_clamp 6.98% faster in gradient_conical_clamp_shallow 6.98% faster in gradient_conicalZero_clamp Bug: skia: Change-Id: Id74866908b99753ed8b16a657d3f67c9255d0043 Reviewed-on: https://skia-review.googlesource.com/76561 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* read signed 32 if we want to treat it as signedGravatar Mike Reed2017-12-11
| | | | | | | | Bug:793603 Change-Id: I040d775fcf76da095ea2a25c33408508b3466fd7 Reviewed-on: https://skia-review.googlesource.com/83280 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Turn on PGO for Skia on AndroidGravatar Zhizhou Yang2017-12-11
| | | | | | | | | | | | | | | | | | | | | | | This patch is to turn on PGO for skia on Android, which will provide a performance improvement of 7.6% for hwui when applied PGO for both. The patch specified a skia.profdata file, which locates in internal google_data/pgo_profile directory, to work as the profile to feed PGO. This profdata can be re-collected with PGO build system support. PGO can be turned off by setting ANDROID_PGO_NO_PROFILE_USE environment variable or set variable to false. Test: Build skia successfully and verified the performance improvement on device through benchmark. BUG=skia: Change-Id: I826f417569b2853630f6d4fcce236b5bc36547fa Reviewed-on: https://skia-review.googlesource.com/82880 Commit-Queue: Derek Sollenberger <djsollen@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Reviewed-by: John Reck <jreck@google.com>
* add virtual to confirm flattenable typeGravatar Mike Reed2017-12-11
| | | | | | | | | | | meant to replace https://skia-review.googlesource.com/c/skia/+/83381 Bug:793639 Change-Id: I972dc80725bf5ce5be24769aafa23269735e089c Reviewed-on: https://skia-review.googlesource.com/83444 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* bin/try: No prompt for a single matching jobGravatar Eric Boren2017-12-11
| | | | | | | | | NOTRY: true Bug: skia: Change-Id: I14e71f96b56b4288807bcc5189593b22d3078824 Reviewed-on: https://skia-review.googlesource.com/83443 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Implement a fast path for solid color lattice rectangleGravatar Stan Iliev2017-12-11
| | | | | | | | | | | | Add a flag that hints, which lattice rectangles are solid colors. Draw solid rectangles and 1x1 rectangles with drawRect. Test: Measured performance of a ninepatch drawn by HWUI Bug: b/69796044 Change-Id: Ib3b00ca608da42fa9f2d2038cc126a978421ec7c Reviewed-on: https://skia-review.googlesource.com/79821 Commit-Queue: Stan Iliev <stani@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
* fixed SkSL optimizing away side effectsGravatar Ethan Nicholas2017-12-11
| | | | | | | | Bug: skia:7196 Change-Id: I44676003d9ea7970efb40df2f7e40c2de05a5f67 Reviewed-on: https://skia-review.googlesource.com/83440 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Remove PixelC CPU jobs.Gravatar Ben Wagner2017-12-11
| | | | | | | | | | | | | The Nexus5x took these jobs in https://skia-review.googlesource.com/c/skia/+/82624 Also filed skia:7394 for missing coverage of "--gpuThreads 0". Bug: skia:7382 Change-Id: If0fd823722d8b8cc3845f8d96a0a285fec935f74 No-Try: true Reviewed-on: https://skia-review.googlesource.com/83360 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add GrGLMakeNativeInterface factory that returns sk_sp<const GrGLInterface>.Gravatar Brian Salomon2017-12-11
| | | | | | | | | | | | | | | Removes the concept of a configurable "default" interface and makes the default always be the "native" interface. Also removes unused functions: GrGLInterfaceAddTestDebugMarker and GrGLInterface::NewClone. Keeps around legacy GrGLCreateNativeInterface() until clients can be weened. Change-Id: I4a3bdafa8cf8c68ed13318393abd55686b045ccb Reviewed-on: https://skia-review.googlesource.com/83000 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Move ImGui support code to ImGuiLayerGravatar Brian Osman2017-12-11
| | | | | | | | | | | | | Viewer still has plenty of code that uses ImGui to create application specific UI, but the structural code that forwards input to ImGui, and converts per-frame ImGui rendering data to Skia draw commands is now in a single component that can be reused in any sk_app-based application. Bug: skia: Change-Id: Ic14ece659d4af8ee13b69c638bdaf7df6c24f5c0 Reviewed-on: https://skia-review.googlesource.com/82627 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* CCPR: Don't use instanced draw calls with geometry shadersGravatar Chris Dalton2017-12-11
| | | | | | | | | | | | It isn't necessary for the vertex shader to know all the points because everything happens in the geometry shader. It's simpler to use regular vertex arrays instead. Bug: skia: Change-Id: I7bf83180476fbe0ab01492611cd72e72b3f7d4f2 Reviewed-on: https://skia-review.googlesource.com/82881 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* apps/build.gradle: skiaOut is now absolute since a2e7f5ae10Gravatar Hal Canary2017-12-11
| | | | | | | Change-Id: I27df422a78209d60647db89a608fc31f9739a429 Reviewed-on: https://skia-review.googlesource.com/83361 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Fix SampleLua buildGravatar Florin Malita2017-12-11
| | | | | | | Change-Id: Ie0114ab16b99aed4343f6255dbc86fb15554ea74 Reviewed-on: https://skia-review.googlesource.com/83380 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Create a Window::Layer interface to reduce sk_app glue codeGravatar Brian Osman2017-12-11
| | | | | | | | | | | | This also makes it possible to manage other parts of viewer, etc (like the stats screen, command set, even samples) as additional layers in the stack. For now, it just removes a lot of boilerplate. Bug: skia: Change-Id: Ic2f80690fc76c683b3736287dc2b738c50d38614 Reviewed-on: https://skia-review.googlesource.com/82688 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* The downsamplebitmap_image GMs only use one image.Gravatar Mike Klein2017-12-11
| | | | | | | | | So there's no need to include the image name or path in the GM name. Change-Id: Idc510906ae77c5c73756f41bc13e859e231e9139 Reviewed-on: https://skia-review.googlesource.com/83320 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>