aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Fix some issues for Linux Vulkan buildGravatar jvanverth2016-03-09
| | | | | | | | lifecycle in GrVkGpu was tagged as uninitialized before use, and err in GrVkImage as unused. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1782453004 Review URL: https://codereview.chromium.org/1782453004
* Reenable dev bounds clip reductionGravatar bsalomon2016-03-09
| | | | | | | TBR=joshualitt@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1781663002 Review URL: https://codereview.chromium.org/1781663002
* Fix nullptr access in GrTextureProvider::createMipMappedTextureGravatar bsalomon2016-03-09
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1777013002 Review URL: https://codereview.chromium.org/1777013002
* partial switch over to sp usage of shadersGravatar reed2016-03-09
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1776973003 Review URL: https://codereview.chromium.org/1776973003
* Revert of don't create zero length intervals (patchset #1 id:1 of ↵Gravatar robertphillips2016-03-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1766243004/ ) Reason for revert: This may, or may not, be blocking the DEPS roll with: svg/W3C-SVG-1.1/painting-stroke-04-t.svg - LayoutSVGPath {path} at (50,127) size 380x26 [stroke={[type=SOLID] [color=#000000] [stroke width=25.00] [dash offset=10.00] [dash array={10.00, 10.00}]}] [data="M 50 140 L 430 140"] + LayoutSVGPath {path} at (60,127) size 370x26 [stroke={[type=SOLID] [color=#000000] [stroke width=25.00] [dash offset=10.00] [dash array={10.00, 10.00}]}] [data="M 50 140 L 430 140"] Original issue's description: > don't create zero length intervals > > Dashing a pattern without zero-length intervals should > not create them if the end of the on interval coincides > with the beginning of the initial dash offset. > > R=reed@google.com > BUG=591993 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1766243004 > > Committed: https://skia.googlesource.com/skia/+/18bbd00190623fb6cdb119df4a118ac3c1aed52a TBR=reed@google.com,fmalita@chromium.org,caryclark@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=591993 Review URL: https://codereview.chromium.org/1779803002
* SkPDF: use sk_ref_spGravatar halcanary2016-03-09
| | | | | | | | s/sk_sp<[^>]*>(SkRef(\([^)]*\)))/sk_ref_sp(\1)/ GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1777923002 Review URL: https://codereview.chromium.org/1777923002
* Add SkDrawPosTextHCommand JSON, fix skiaserve build.Gravatar bungeman2016-03-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds SkDrawPosTextHCommand ::fromJSON and ::toJSON. Both SkDrawPosTextCommand and SkDrawPosTextHCommand's ::toJSON write the correct number of positions, preventing reading uninitialized memory. The microhttpd build is now done in the build tree as opposed to in a temporary directory. The microhttpd build script uses os.path.join so that absolute paths do not confuse the build. This allows compatibility with the cmake gyp generator as CMake likes to pass absolute paths. The microhttpd gyp target is now marked as 'none' since it is not a 'static_library' target (which directs gyp to compile sources into a static library). The dependencies to the action are updated to the minimum required for sane re-building. The everything gyp target now depends on the skiaserve gyp target. This means that when using skia_build_server=1, building 'most' will build skiaserve, but when skia_build_server is not defined the skiaserve target will still be available if specified manually. The old json.gyp is removed as it currently does not build anything. All of the files currently referenced by it as sources no longer exist. Review URL: https://codereview.chromium.org/1775203002
* Deprecate SkImageDecoderGravatar msarett2016-03-09
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1776153003 Review URL: https://codereview.chromium.org/1776153003
* Don't allow nullptr in texels array params (unless using a transfer buffer).Gravatar bsalomon2016-03-09
| | | | | | | | | Require all levels in writePixels to have a non-nullptr. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1765633002 Committed: https://skia.googlesource.com/skia/+/8ee78f31b2a29a5f76403755ea17bad9be74a3ec Review URL: https://codereview.chromium.org/1765633002
* Remove usage of SkImageDecoder in debuggerGravatar msarett2016-03-09
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774313003 Review URL: https://codereview.chromium.org/1774313003
* don't create zero length intervalsGravatar caryclark2016-03-09
| | | | | | | | | | | | Dashing a pattern without zero-length intervals should not create them if the end of the on interval coincides with the beginning of the initial dash offset. R=reed@google.com BUG=591993 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1766243004 Review URL: https://codereview.chromium.org/1766243004
* Switch SkImageSource image filter over to new onFilterImage interfaceGravatar robertphillips2016-03-09
| | | | | | | | | | This CL relies on: https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated) TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772933002 Review URL: https://codereview.chromium.org/1772933002
* use Make instead of Create to return a shared shaderGravatar reed2016-03-08
| | | | | | | | | Partially updated call sites. Undefine the flag in SkSHader.h to convert the remaining sites. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772463002 Review URL: https://codereview.chromium.org/1772463002
* Initialize the font fallback when the direct write fontGravatar kulshin2016-03-08
| | | | | | | | | | | | manager is created. This ensures that the fallback is initialized prior to sandbox startup in Chromium. This enables the use of font fallback when combined with Chromium change https://codereview.chromium.org/1740593002/ Review URL: https://codereview.chromium.org/1740533003
* SkPDF: Add sk_sp setters; .release() becomes std::move()Gravatar halcanary2016-03-08
| | | | | | | | | | | | | | | | Note to reviewers: Start with changes to SkPDFTypes.h Many places that had a bare pointer owning a reference are refactored to use a sk_sp. There remain several places where a non-owning pointer `T*` should be replaced with `const sk_sp<T>&` to eliminate the common pattern `sk_sp<T>(SkRef(x))`. Committed: https://skia.googlesource.com/skia/+/9904c9212074279380e21f96575078734dbbd308 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1775043002 Review URL: https://codereview.chromium.org/1775043002
* Revert of nanobench: turn on f16 and sRGB on the bots (patchset #1 id:1 of ↵Gravatar mtklein2016-03-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1769163006/ ) Reason for revert: Debug bots failing at Running writepix_RGBA_UPM f16 ../../../src/core/SkBitmap.cpp:558: fatal error: ""false && \"Can't return addr for config\""" Original issue's description: > nanobench: turn on f16 and sRGB on the bots > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769163006 > > Committed: https://skia.googlesource.com/skia/+/6b5c5cc7b7bdffb4882706b915b544aba8714961 TBR=reed@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1780463003
* Fix skiaserve in debug modeGravatar joshualitt2016-03-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774263002 Review URL: https://codereview.chromium.org/1774263002
* Revert of SkPDF: Add sk_sp setters; .release() becomes std::move() (patchset ↵Gravatar halcanary2016-03-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | #2 id:20001 of https://codereview.chromium.org/1775043002/ ) Reason for revert: https://build.chromium.org/p/client.skia/builders/Linux%20Builder/builds/6405/steps/compile/logs/stdio Original issue's description: > SkPDF: Add sk_sp setters; .release() becomes std::move() > > Note to reviewers: Start with changes to SkPDFTypes.h > > Many places that had a bare pointer owning a reference are refactored to > use a sk_sp. > > There remain several places where a non-owning pointer `T*` should be > replaced with `const sk_sp<T>&` to eliminate the common pattern > `sk_sp<T>(SkRef(x))`. > > Committed: https://skia.googlesource.com/skia/+/9904c9212074279380e21f96575078734dbbd308 TBR=bungeman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1775143002
* Add sk_ref_sp helper function.Gravatar reed2016-03-08
| | | | Review URL: https://codereview.chromium.org/1773943004
* SkPDF: Add sk_sp setters; .release() becomes std::move()Gravatar halcanary2016-03-08
| | | | | | | | | | | | | Note to reviewers: Start with changes to SkPDFTypes.h Many places that had a bare pointer owning a reference are refactored to use a sk_sp. There remain several places where a non-owning pointer `T*` should be replaced with `const sk_sp<T>&` to eliminate the common pattern `sk_sp<T>(SkRef(x))`. Review URL: https://codereview.chromium.org/1775043002
* nanobench: turn on f16 and sRGB on the botsGravatar mtklein2016-03-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769163006 Review URL: https://codereview.chromium.org/1769163006
* Fill out more information in GrVkCapsGravatar egdaniel2016-03-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768083003 Review URL: https://codereview.chromium.org/1768083003
* Remove SkImageGeneratorUtils. None of this code is used.Gravatar brianosman2016-03-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1778613002 Review URL: https://codereview.chromium.org/1778613002
* Buffer fix for VkProgram cachingGravatar jvanverth2016-03-08
| | | | | | | | | | | | When caching VkPrograms, we can end up with situations where we overwrite uniform buffers while they're in use (or being prepared for use) in the command buffer. This fix will address that. This also addresses the rare but similar case of overwriting vertex or index buffers when they're in flight. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774963003 Review URL: https://codereview.chromium.org/1774963003
* Switch SkComposeImageFilter over to new onFilterImage interfaceGravatar robertphillips2016-03-08
| | | | | | | | | | This CL depends on https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated) TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768283002 Review URL: https://codereview.chromium.org/1768283002
* Expand coverage of vertices gmGravatar bsalomon2016-03-08
| | | | Review URL: https://codereview.chromium.org/1361173003
* Update DNG SDK version.Gravatar yujieqin2016-03-08
| | | | | | | | | | | | | * Integrate integer overflow changes from security branch BUG=b/26535130 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1748363004 Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567 Committed: https://skia.googlesource.com/skia/+/62c0f75159674087079140e09ef1396316577754 Review URL: https://codereview.chromium.org/1748363004
* add f16 and srgb --configs to nanobenchGravatar mtklein2016-03-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1775093002 Review URL: https://codereview.chromium.org/1775093002
* 4377: drawVertices crashes when shader+colorfilter in the paintGravatar aleksandar.stojiljkovic2016-03-08
| | | | | | | | | | | | | | | Fix memory corruption that is result of static_casting SkFilterShaderContext* to SkTriColorShaderContext* and then changing it's state using setup() SkTriColorShader and it's Context could be wrapped by Compose, 3DShader and SkFilterShader, but the link SkTriColorShaderContext -> SkTriColorShader (fShader) always remain - so this way, data about triangle is propagated. BUG=4377 Didn't add new unit test - it would be redundant since the GM vertices update here: https://codereview.chromium.org/1361173003/ is covering the bug. With this patch it passes. Review URL: https://codereview.chromium.org/1431713003
* Create a small python driver for skiaserveGravatar joshualitt2016-03-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1754213005 Review URL: https://codereview.chromium.org/1754213005
* Rename SkSpecialImage::getBitmap to getBitmapDeprecatedGravatar robertphillips2016-03-08
| | | | Review URL: https://codereview.chromium.org/1780433002
* Fix up GrAuditTrail to allow arbitrary reorderingGravatar joshualitt2016-03-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1765123002 Review URL: https://codereview.chromium.org/1765123002
* Fix 4f gradient swizzle post http://crrev.com/1774523002Gravatar fmalita2016-03-08
| | | | | | | | | | | | * store interval colors in pm4f-natural/RGBA order * swizzle to dst order during interval advance Also remove an unused Interval ctor. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1770153002 Review URL: https://codereview.chromium.org/1770153002
* make pm4f be RGBA always, not pmcolor orderGravatar reed2016-03-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774523002 Review URL: https://codereview.chromium.org/1774523002
* Lazy init batch unique IDGravatar joshualitt2016-03-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772023003 Review URL: https://codereview.chromium.org/1772023003
* Small GrTessellator refactor and cleanup.Gravatar senorblanco2016-03-08
| | | | | | | | | | Implement a VertexList, and use it. Rename insert<> -> list_insert<>. Rename remove<> -> list_remove<>. Remove some spurious returns. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1771373002 Review URL: https://codereview.chromium.org/1771373002
* work around leftshift for negative valuesGravatar reed2016-03-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774963002 Review URL: https://codereview.chromium.org/1774963002
* DM: verbose and quiet loggingGravatar mtklein2016-03-08
| | | | | | | | | | | | | | If you pass no flags, output is pretty much unchanged from today: calls to info() go to the console, calls to vlog() are ignored. If you pass --verbose and -w dir, all calls to info(), vlog() and all of stderr are redirected to dir/verbose.log. info() calls also go to the console, unless you pass --quiet, in which case nothing goes to the console at all. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1771143002 Review URL: https://codereview.chromium.org/1771143002
* Switch SkOffsetImageFilter over to new onFilterImage interfaceGravatar robertphillips2016-03-08
| | | | | | | | | | This CL relies on: https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated) TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1766743003 Review URL: https://codereview.chromium.org/1766743003
* Fix caching bug in new SkImageFilter::filterImage pathGravatar robertphillips2016-03-08
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1777573002 Review URL: https://codereview.chromium.org/1777573002
* Add element_type, swap, operators, fix reset on sk_sp.Gravatar bungeman2016-03-08
| | | | | | | | | | | | | | | The 'element_type' typedef is to play nice with std::pointer_traits. The full complement of operators and swap to match unique_ptr so that sk_sp can be properly compared to nullptr and used with standard containers. Update to 'reset' so that calling 'unref' is the last operation. This also adds tests for these changes, and sets the fPtr to nullptr in debug for easier bug finding. Review URL: https://codereview.chromium.org/1773453002
* SkPDF: use sk_make_sp<T> when it makes sense.Gravatar halcanary2016-03-08
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1773033002 Review URL: https://codereview.chromium.org/1773033002
* Circle GP/batch housecleaningGravatar bsalomon2016-03-08
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1764923003 Review URL: https://codereview.chromium.org/1764923003
* Swarming bots: fix trybotsGravatar borenet2016-03-08
| | | | | | | | | | Requires a recipe-side change as well. NOTRY=true BUG=skia:4763 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768333002 Review URL: https://codereview.chromium.org/1768333002
* Hide new methods from non-Android.Gravatar benjaminwagner2016-03-07
| | | | Review URL: https://codereview.chromium.org/1769933004
* Disable color space test for old versions of libpngGravatar msarett2016-03-07
| | | | | | | | | Should fix the Google3 build. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769953002 Review URL: https://codereview.chromium.org/1769953002
* Archive SkRemote-related code. I want to start fresh.Gravatar mtklein2016-03-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774013002 Review URL: https://codereview.chromium.org/1774013002
* Add support for 2x2 matricesGravatar cdalton2016-03-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1755483002 Review URL: https://codereview.chromium.org/1755483002
* SkPDF: s/SkAutoTUnref/sk_sp/gGravatar halcanary2016-03-07
| | | | Review URL: https://codereview.chromium.org/1771073002
* Add "sample locations" feature to GrProcessorGravatar cdalton2016-03-07
| | | | | | | | | | | | Adds a "sample locations" feature to GrProcessor. When enabled, this allows a processor to know inside the shader where all the samples are located. Also adds various infastructure to query, cache, and identify multisample data. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1717393002 Review URL: https://codereview.chromium.org/1717393002