aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Respect canvas size and frame offset in webp decoderGravatar Matt Sarett2017-02-03
| | | | | | | | | BUG=skia:6185 Change-Id: Id543cb689a5e33b800ebbc18f4a234e78a4c4298 Reviewed-on: https://skia-review.googlesource.com/7800 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Improved SkShadowUtils cachingGravatar Brian Salomon2017-02-03
| | | | | | | | | | | | | Multiple ambient and spot shadows can be cached for each geometry. Spot shadows can be reused when x,y light offset is different. We categorize spot shadows for rrects as either transparent, opaque with partial umbra occlusion, or opaque with full umbra occlusion and use that to improve cache performance. Change-Id: Id530bdaa5092edb46c8f584979090fbb766307fc Reviewed-on: https://skia-review.googlesource.com/7987 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Disable unpremul f16 image testsGravatar Matt Sarett2017-02-03
| | | | | | | | | | | | | | Testing premul f16 is enough test coverage, and we aren't doing this correctly right now anyways (the drawing code assumes a premul bitmap, we would need to premultiply after the unpremul decode). BUG=skia: Change-Id: I798f56db67faadd0348974453a05cd726b9a509c Reviewed-on: https://skia-review.googlesource.com/8020 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* iOS: set up device dirs to be relativeGravatar Mike Klein2017-02-03
| | | | | | | | | | | Hopefully this get things pushed to and reading from directories under com.google.dm's Documents. I've hardcoded to DM's app for now. CQ_INCLUDE_TRYBOTS=skia.primary:Test-iOS-Clang-iPadMini4-GPU-GX6450-arm-Release Change-Id: Iea54b3604b65551e4a486b50d6c7ea9aba26f869 Reviewed-on: https://skia-review.googlesource.com/8004 Reviewed-by: Mike Klein <mtklein@chromium.org>
* Revert "Revert "Don't instantiate shaders with non-invertible local matrix""Gravatar Florin Malita2017-02-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0e86725ba4f667056ff1ef65275165853a47303b. Reason for revert: landed Blink fix, should pass layout tests now Original change's description: > Revert "Don't instantiate shaders with non-invertible local matrix" > > This reverts commit ebfbba9bbdacd754c8ad7429ee066f53f17bc66b. > > Reason for revert: breaks chrome blink tests for linux_trusty_blink_rel > > Original change's description: > > Don't instantiate shaders with non-invertible local matrix > > > > Change-Id: If11f7d57cbf45929632d858f91c02d8f5fa9f442 > > Reviewed-on: https://skia-review.googlesource.com/7885 > > Reviewed-by: Mike Reed <reed@google.com> > > Commit-Queue: Florin Malita <fmalita@chromium.org> > > > > TBR=fmalita@chromium.org,reed@google.com,reviews@skia.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I41c5513523c27dc4bad68008f08369185897b7a2 > Reviewed-on: https://skia-review.googlesource.com/7948 > Commit-Queue: Hal Canary <halcanary@google.com> > Reviewed-by: Hal Canary <halcanary@google.com> > TBR=halcanary@google.com,reviews@skia.org,fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I373ea6c61a256fd8cfbfb34f8b2d39a3ff8109db Reviewed-on: https://skia-review.googlesource.com/8003 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* expose new tight-bounds method on SkPathGravatar Mike Reed2017-02-03
| | | | | | | | | BUG=skia: Change-Id: Ie50df49c1758af203042a84dc2cd505046373d2c Reviewed-on: https://skia-review.googlesource.com/7996 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Restore ios_flavor.Gravatar Mike Klein2017-02-03
| | | | | | | | | | | Just like Android, there's enough special ceremony needed to move files to and from iOS devices that this reads most clearly as its own flavor. CQ_INCLUDE_TRYBOTS=skia.primary:Test-iOS-Clang-iPadMini4-GPU-GX6450-arm-Release Change-Id: I01c8e5494c364cc61e219568f022219f7c3f5fdc Reviewed-on: https://skia-review.googlesource.com/7988 Reviewed-by: Mike Klein <mtklein@chromium.org>
* Make shadow tessellators fail gracefully and add unit test for this.Gravatar Brian Salomon2017-02-03
| | | | | | | Change-Id: I42a9d06a18928588347a6dea2f6150518ba29aa8 Reviewed-on: https://skia-review.googlesource.com/7886 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* GrTessellator (AA): Fix for missing fill artifacts.Gravatar Stephen White2017-02-03
| | | | | | | | | | | | | | | | | | | | Some regions were being incorrectly filled due to setting connector edges winding to zero *after* merging collinear edges. This would cause the merge to add the wrong winding value. Putting the adjust before the call to merge_collinear_edges() fixes the problem. Also, some pixels were not getting coverage due the inner edge being +1 winding. Using -2 winding for inner edges ensure the interior regions are -1 winding, which gives coverage in more cases of self-intersection. This required flipping the comparisons on the intruding-vertices workaround. BUG=skia: Change-Id: I216fa3d30c196a6b7773637e48802f6572c993c7 Reviewed-on: https://skia-review.googlesource.com/7962 Commit-Queue: Stephan White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Initialize some more variables in SpotShadowTessellatorGravatar Jim Van Verth2017-02-03
| | | | | | | | | | BUG=skia:6119 Change-Id: Id3a3042df6254e3367713b82f3b08257e0be71b1 Reviewed-on: https://skia-review.googlesource.com/7992 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* experimental tight-boundsGravatar Mike Reed2017-02-03
| | | | | | | | | | | | | not sure about api -- perhaps it could just return the bounds, and make them 0,0,0,0 if the path is empty -- the caller can trivially know if the path is empty themselves. BUG=skia: Change-Id: I2dbb861e8d981b27c5a6833643977f5bd6802217 Reviewed-on: https://skia-review.googlesource.com/7989 Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Added dead variable / code elimination to skslc.Gravatar Ethan Nicholas2017-02-03
| | | | | | | | | BUG=skia: Change-Id: Ib037730803a8f222f099de0e001fe06ad452a22c Reviewed-on: https://skia-review.googlesource.com/7584 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Batch across matrix changes in drawVertices and add GM to test.Gravatar Brian Salomon2017-02-03
| | | | | | | Change-Id: I6b08d37781e3c715a1d9d8c9729667ec78625836 Reviewed-on: https://skia-review.googlesource.com/7949 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* fix up shadow_utils gm dimensionsGravatar Brian Salomon2017-02-03
| | | | | | | Change-Id: I5204296871404065b4d55d53922b7cf05ca5a50f Reviewed-on: https://skia-review.googlesource.com/7990 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* iOS: dequote args one levelGravatar Mike Klein2017-02-02
| | | | | | | Change-Id: Ice2e1aeef724595844799ee26140f653a1acb0e4 Reviewed-on: https://skia-review.googlesource.com/7985 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* iOS: try running the binaryGravatar Mike Klein2017-02-02
| | | | | | | Change-Id: I723631d1744b128350546d480201da5d4159af65 Reviewed-on: https://skia-review.googlesource.com/7983 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Revert "Spot shadow cleanup and optimization""Gravatar Brian Salomon2017-02-02
| | | | | | | | | This reverts commit aa2bd8f726d98edafd28c8553e99cbae33c431dd. Change-Id: Iaa5d9e649d842889ff031eeb11d0547270968420 Reviewed-on: https://skia-review.googlesource.com/7981 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* bin/list-skia-botsGravatar Hal Canary2017-02-02
| | | | | | | | NOTRY=true Change-Id: Ie123bf796ff062972fd86319f0a20f3a81a9b2ff Reviewed-on: https://skia-review.googlesource.com/7982 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Blacklist large images on 32-bit Win 2k8Gravatar Matt Sarett2017-02-02
| | | | | | | | | BUG=skia: Change-Id: Ic423d2042f6b8b0bbadfd2ee1dc8b3f9f5992523 Reviewed-on: https://skia-review.googlesource.com/7940 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* add package_ios.py to ios_binGravatar Mike Klein2017-02-02
| | | | | | | Change-Id: I749e4fe8887f84a943cbef2c49971195ef381508 Reviewed-on: https://skia-review.googlesource.com/7980 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* SkXPSDevice inherits from SkBaseDeviceGravatar Hal Canary2017-02-02
| | | | | | | Change-Id: I81ed36da33821df36d11806a6349a2ede61c6f73 Reviewed-on: https://skia-review.googlesource.com/7942 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Revert "Don't instantiate shaders with non-invertible local matrix"Gravatar Hal Canary2017-02-02
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ebfbba9bbdacd754c8ad7429ee066f53f17bc66b. Reason for revert: breaks chrome blink tests for linux_trusty_blink_rel Original change's description: > Don't instantiate shaders with non-invertible local matrix > > Change-Id: If11f7d57cbf45929632d858f91c02d8f5fa9f442 > Reviewed-on: https://skia-review.googlesource.com/7885 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Florin Malita <fmalita@chromium.org> > TBR=fmalita@chromium.org,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I41c5513523c27dc4bad68008f08369185897b7a2 Reviewed-on: https://skia-review.googlesource.com/7948 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
* Revert "Spot shadow cleanup and optimization"Gravatar Hal Canary2017-02-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 47784c18adc20d1bfefebd00c3ee98c669d79b4d. Reason for revert: MSAN, ASAN Original change's description: > Spot shadow cleanup and optimization > > Fixes clip polygon and centroid calculation. > Clips interior umbra region against original path. > > BUG=skia:6119 > > Change-Id: I37a740ae004c38b75405e05158d92cf9fd954eda > Reviewed-on: https://skia-review.googlesource.com/7823 > Commit-Queue: Brian Salomon <bsalomon@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > TBR=jvanverth@google.com,bsalomon@google.com,robertphillips@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:6119 Change-Id: I7a4d9fa3af0d30feac999229f2e94aae2bdafc9c Reviewed-on: https://skia-review.googlesource.com/7947 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Temporarily remove unused iOS builds.Gravatar Mike Klein2017-02-02
| | | | | | | | | | | | Long-term we probably want to have all four of these builds (arm64 for real, arm for reference) but right now the only one we need is arm-Release to drive Test-iOS-Clang-iPadMini4-GPU-GX6450-arm-Release. The other builds just delay getting that Test bot working. Change-Id: Idf3d10dd9f66cc0a4c1000a1cb9295ea778827d2 Reviewed-on: https://skia-review.googlesource.com/7944 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* iOS: package and deployGravatar Mike Klein2017-02-02
| | | | | | | Change-Id: I3536cf695d7dfd07862beb23f1a459ba316cf8c5 Reviewed-on: https://skia-review.googlesource.com/7943 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Tear down old iOS bots, bring up one new one.Gravatar Mike Klein2017-02-02
| | | | | | | | | | | | | This replaces all GYP-based iOS bots with one new GN-based one. Ordinarily I'd do this more incrementally but we have only one iPad. This new bot will start very broken, but should be the quickest to cycle builds once I get it working. Change-Id: I41865e3ad431dea3cf023d0b33ccc88e175cf227 Reviewed-on: https://skia-review.googlesource.com/7941 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Spot shadow cleanup and optimizationGravatar Jim Van Verth2017-02-02
| | | | | | | | | | | | Fixes clip polygon and centroid calculation. Clips interior umbra region against original path. BUG=skia:6119 Change-Id: I37a740ae004c38b75405e05158d92cf9fd954eda Reviewed-on: https://skia-review.googlesource.com/7823 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Revert "Replaced all calls to fragmentPosition() with sk_FragCoord"Gravatar Ethan Nicholas2017-02-02
| | | | | | | | | | | | | This reverts commit de4d301881e7fd084f1f0b359ec6f9b2bf8bd4c5. Reason for revert: several Chrome rendering bugs on Mac BUG=skia: Change-Id: I492082b0b7e7c902ede4b598c5809f604d210ce1 Reviewed-on: https://skia-review.googlesource.com/7887 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Don't instantiate shaders with non-invertible local matrixGravatar Florin Malita2017-02-02
| | | | | | | Change-Id: If11f7d57cbf45929632d858f91c02d8f5fa9f442 Reviewed-on: https://skia-review.googlesource.com/7885 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Force instantiation in GaussianBlur to hopefully prevent (and diagnose) ↵Gravatar Robert Phillips2017-02-02
| | | | | | | | | | | Chrome crash BUG=687174 Change-Id: Ieb9930feca9abad9220a1a099e7dd247e6eff70e Reviewed-on: https://skia-review.googlesource.com/7920 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Revert "SkScalar: delete code that doesn't compile.""Gravatar Hal Canary2017-02-02
| | | | | | | | | This reverts commit 8233fc82b00763d37a7b0db7890b15c7d58939d4. Change-Id: Ia32ccdb3b385ed28e1b41e553c7d80cf803522cc Reviewed-on: https://skia-review.googlesource.com/7899 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Copy modules back in from skia-recipes repoGravatar Eric Boren2017-02-02
| | | | | | | | | BUG=skia:6070 Change-Id: I86b3f039c27bd8287516c1db8bd1cae62888171b Reviewed-on: https://skia-review.googlesource.com/7890 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Revert "SkScalar: delete code thqat doesn't compile."Gravatar Leon Scroggins2017-02-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 565da18f6e4a0f04dc836ce9d35f31bee31644f7. Reason for revert: breaking android roll: https://googleplex-android-review.git.corp.google.com/#/c/1853481/-1..1 Some code in Android references SK_SCALAR_IS_FLOAT: https://cs.corp.google.com/android/frameworks/base/core/jni/android/graphics/Interpolator.cpp?q=frameworks/base/core/jni/android/graphics/Interpolator.cpp&sq=package:android&l=30 Original change's description: > SkScalar: delete code thqat doesn't compile. > > Change-Id: I8a5c404d6151fca79af5c5a98d4b44924c0ade52 > Reviewed-on: https://skia-review.googlesource.com/7882 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Hal Canary <halcanary@google.com> > TBR=halcanary@google.com,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I4df06c4593abaa3ac3877b270a41aec7a9c3fc8f Reviewed-on: https://skia-review.googlesource.com/7888 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* gen_tasks.go: Read jobs, Android, and GPU mappings from a JSON fileGravatar Eric Boren2017-02-02
| | | | | | | | | BUG=skia:6070 Change-Id: I02edcb0b1a98967e5d84f89a5ef578b36efadd8f Reviewed-on: https://skia-review.googlesource.com/7825 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* make GR_TEST_UTILS=0 workGravatar Hal Canary2017-02-02
| | | | | | | Change-Id: Icce35140ca08b65217b32e6b1ffc6ad2f38ab37f Reviewed-on: https://skia-review.googlesource.com/7840 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Have Vulkan advertise that compressed textures are currently unsupportedGravatar Robert Phillips2017-02-02
| | | | | | | | | | This allows the ProxyTest to run on the Vulkan backend. Change-Id: I89a3212bdc2d4a1ceb0c27d0ff60f558d7b12647 Reviewed-on: https://skia-review.googlesource.com/7880 Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* SkScalar: delete code thqat doesn't compile.Gravatar Hal Canary2017-02-02
| | | | | | | Change-Id: I8a5c404d6151fca79af5c5a98d4b44924c0ade52 Reviewed-on: https://skia-review.googlesource.com/7882 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Prepare to test all image decode modes to F16Gravatar Matt Sarett2017-02-02
| | | | | | | | | | | | | | | I've only been running F16 tests in "colorImage" mode. We really should be running our "image" tests to F16 as well - so they can be tested with scaling, subsets, etc. This CL fixes bugs so that we can enable those tests. BUG=skia: Change-Id: I8137eb4fce7ea12f2c9d233a029d946d4a63e6b0 Reviewed-on: https://skia-review.googlesource.com/7801 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Add a GM for SkShadowUtils and fix a few issues.Gravatar Brian Salomon2017-02-01
| | | | | | | | | | | | | | | 1) Transform the path center to device space before computing the shadow offset. 2) Modulate the shadow color by the color filter's output color. 3) Make the scale of path points in the spot tessellator be relative to the path centroid. 4) Clamp the shadow alphas at 1. Change-Id: I480476df79b959f11c1eca0ba2a49a134d355cbb Reviewed-on: https://skia-review.googlesource.com/7860 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Roll skia-recipes to pick up shadow_utils blacklist.Gravatar Brian Salomon2017-02-01
| | | | | | | Change-Id: I11dd76fcb687e46c708feb725aef6f1102d74d0a Reviewed-on: https://skia-review.googlesource.com/7881 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Add caching of ambient and spot shadow meshes.Gravatar Brian Salomon2017-02-01
| | | | | | | Change-Id: If882186225621af4af4b4ddae0c786ec33ff40f3 Reviewed-on: https://skia-review.googlesource.com/7643 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* Disable Vulkan backend in DeferredProxyTest (for now)Gravatar Robert Phillips2017-02-01
| | | | | | | | | With the expansion in https://skia-review.googlesource.com/c/7864/ (Add test for proactive proxy-creation failure) the ProxyTest is now failing for the PixelXL and N6p in Vulkan mode Change-Id: Iebefa1be4f1a5deb450e1f2083a06f3f2249c382 Reviewed-on: https://skia-review.googlesource.com/7870 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Update to ubuntu 16.10 to see if a driver update helpsGravatar Kevin Lubick2017-02-01
| | | | | | | | | BUG=skia:6186 Change-Id: I7e76ca2c76b287e03c046076745130ebae50efbe Reviewed-on: https://skia-review.googlesource.com/7869 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Fix memory leak in DeferredProxyTestGravatar Robert Phillips2017-02-01
| | | | | | | | Change-Id: Ib183f71e972b0756b8558098dabe32b6934c0847 Reviewed-on: https://skia-review.googlesource.com/7866 Commit-Queue: Robert Phillips <robertphillips@google.com> Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
* Expand SkImage::getTextureHandle callGravatar Robert Phillips2017-02-01
| | | | | | | | | | | | | | | | AFAICT cc/output/gl_renderer.cc only calls SkImage:getTexture to determine the origin of the backing GrTexture. What do y'all think of this CL as a means of removing that call to getTexture? One alternative would be to add a new entry point like: bool SkImage::getBackendTextureDesc(GrBackendTextureDesc* desc) const; which fills in the entire desc and returns whether the image is texture backed. Change-Id: Idd302c0a11d69ad08e0100bcf546b3bbaa7cf27e Reviewed-on: https://skia-review.googlesource.com/7788 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Broaden checking of GrSurfaceProxy::MakeDeferred's return valueGravatar Robert Phillips2017-02-01
| | | | | | | | | | | | | We now expect MakeDeferred to baulk if the ultimate texture/rendertarget will not be instantiable. Added checks for MakeWrapped too since, technically, it too can baulk. BUG=676753 Change-Id: I3e052ebf98303fc46124272082c10f303d89da27 Reviewed-on: https://skia-review.googlesource.com/7830 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Add test for proactive proxy-creation failureGravatar Robert Phillips2017-02-01
| | | | | | | | | | | This is a follow up to https://skia-review.googlesource.com/c/7828/ (Add more pre-checks to surfaceProxy creation) BUG=687174 Change-Id: I97385afbdaf1881b806ee37737020564e3f4d444 Reviewed-on: https://skia-review.googlesource.com/7864 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* GR_PROXY_MOVE: Work around Win/Clang eval order bugGravatar Hans Wennborg2017-02-01
| | | | | | | | | | BUG=chromium:687259 Change-Id: I145dac240a3c4f89cf1b6bf6ff54ba73cd110ebf Reviewed-on: https://skia-review.googlesource.com/7831 Reviewed-by: Hans Wennborg <hwennborg@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Move presubmit bot to skia.swarmbucketGravatar Eric Boren2017-02-01
| | | | | | | | | BUG=skia:6183 Change-Id: Ib678c83f46f453b561101cdc12ee637a4e51fb17 Reviewed-on: https://skia-review.googlesource.com/7863 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Add more pre-checks to surfaceProxy creationGravatar Robert Phillips2017-02-01
| | | | | | | | | | | | | Chrome is seeing crashes in GrProcessor::TextureSampler::reset when the textures are being instantiated. This CL moves more potential failures cases up-stack. BUG=687174 Change-Id: I014acff9730ffd1e8ac178611372ed4dedbd82f3 Reviewed-on: https://skia-review.googlesource.com/7828 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-25 06:18:23 +0000