aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Make mixed samples contingent on auxiliary extensionsGravatar cdalton2015-05-21
| | | | | | | | | | | | | | | | | | | | | Moves the cap for mixed samples into GrShaderCaps and does not enable it unless we have support for both dual source blending and multisample disable. Creates a dedicated cap for multisample disable. Reconfigures the mixed samples cap to indicate the collective capability of three different extensions: GL_NV_framebuffer_mixed_samples GL_NV_sample_mask_override_coverage GL_EXT_raster_multisample Imports tokens and procedures for GL_EXT_raster_multisample. BUG=skia: Review URL: https://codereview.chromium.org/1151793002
* SkBlockMemoryStream implements peek()Gravatar halcanary2015-05-21
| | | | Review URL: https://codereview.chromium.org/1146903004
* Add RGBA half float texture format.Gravatar jvanverth2015-05-21
| | | | | | BUG=skia:3829 Review URL: https://codereview.chromium.org/1148243002
* add assert that the lock-count on pixelref is balancedGravatar reed2015-05-21
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1147153004
* Move font loading in gm tests and benches out of constructorsGravatar kkinnunen2015-05-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Constructing the gm tests and benches causes many calls to font loads. This is visible as profiling samples in fontconfig and freetype on Linux for all profiling runs of nanobench. This complicates analysis of test-cases that are suspected of being slow due to font-related issues. Move the font loading to GM::onOnceBeforeDraw and Benchmark::onPreDraw. This way the code is not executed if the testcase does not match the nanobench --match filter. This way the samples in font-related code are more easy to identify as legitimate occurances caused by the testcase. This should not cause differences in timings, because: * Benchmark::preDraw / onPreDraw is defined to be run outside the timer * GM::runAsBench is not enabled for any of the modified testcases. Also nanobench untimed warmup round should run the onOnceBeforeDraw. (and there are other GM::runAsBench gms already doing loading in onOnceBeforeDraw). Changes the behavior: In TextBench: Before, the test would report two different gms with the same name if the color emoji font was not loaded successfully. After, the test always reports all tests as individual names. Generally: The errors from loading fonts now print inbetween each testcase, as opposed to printing during construction phase. Sample output: ( 143/145 MB 1872) 14.7ms 8888 gm quadclosepathResource /fonts/Funkster.ttf not a valid font. ( 160/160 MB 1831) 575µs 8888 gm surfacenewResource /fonts/Funkster.ttf not a valid font. ( 163/165 MB 1816) 12.5ms 8888 gm linepathResource /fonts/Funkster.ttf not a valid font. ( 263/411 MB 1493) 118ms 8888 gm typefacestyles_kerningResource /fonts/Funkster.ttf not a valid font. ( 374/411 MB 1231) 7.16ms 565 gm getpostextpathResource /fonts/Funkster.ttf not a valid font. ( 323/411 MB 1179) 4.92ms 565 gm stringartResource /fonts/Funkster.ttf not a valid font. ( 347/493 MB 917) 191ms 565 gm patch_gridResource /fonts/Funkster.ttf not a valid font. ( 375/493 MB 857) 23.9ms gpu gm clipdrawdrawCannot render path (0) ( 393/493 MB 706) 2.91ms unit test ParsePath------ png error IEND: CRC error ( 394/493 MB 584) 166ms gpu gm hairmodesResource /fonts/Funkster.ttf not a valid font. Resource /fonts/Funkster.ttf not a valid font. Resource /fonts/Funkster.ttf not a valid font. ... Review URL: https://codereview.chromium.org/1144023002
* Improve caching of special case paths in GrStencilAndCoverPathRendererGravatar kkinnunen2015-05-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cache lines and oval paths in their own cache domains. Skia has many hard-to-replace codepaths that create volatile paths out of lines or ovals. Results for amd64: desk_tigersvg.skp_1 3.06ms -> 3.07ms 1x tabl_cnet.skp_1 2.3ms -> 2.3ms 1x desk_baidu.skp_1 8.99ms -> 8.98ms 1x desk_weather.skp_1 4.58ms -> 4.57ms 1x desk_samoasvg.skp_1 12.3ms -> 12.3ms 1x tabl_gamedeksiam.skp_1 15.8ms -> 15.7ms 1x desk_chalkboard.skp_1 14.9ms -> 14.9ms 1x desk_mapsvg.skp_1 6.57ms -> 6.54ms 1x desk_wordpress.skp_1 2.2ms -> 2.19ms 1x tabl_slashdot.skp_1 6.91ms -> 6.84ms 0.99x desk_linkedin.skp_1 7.7ms -> 7.58ms 0.98x desk_googlespreadsheet.skp_1 58.7ms -> 57.7ms 0.98x tabl_ukwsj.skp_1 7.67ms -> 7.53ms 0.98x tabl_engadget.skp_1 4.71ms -> 4.61ms 0.98x desk_carsvg.skp_1 116ms -> 114ms 0.98x tabl_nytimes.skp_1 3.71ms -> 3.61ms 0.97x desk_googlespreadsheetdashed.skp_1 25.8ms -> 24.9ms 0.97x tabl_hsfi.skp_1 5.3ms -> 5.1ms 0.96x tabl_techmeme.skp_1 2.9ms -> 2.8ms 0.96x tabl_cnn.skp_1 6.88ms -> 6.62ms 0.96x desk_espn.skp_1 9.12ms -> 8.64ms 0.95x desk_gws.skp_1 5.15ms -> 4.88ms 0.95x tabl_gspro.skp_1 4.48ms -> 4.2ms 0.94x desk_yahooanswers.skp_1 6.84ms -> 6.3ms 0.92x tabl_pravda.skp_1 11.1ms -> 10.1ms 0.91x tabl_sahadan.skp_1 11.8ms -> 10.7ms 0.91x desk_wowwiki.skp_1 8.48ms -> 7.58ms 0.89x tabl_googleblog.skp_1 6ms -> 5.34ms 0.89x tabl_worldjournal.skp_1 6.08ms -> 5.35ms 0.88x desk_booking.skp_1 15.3ms -> 13.4ms 0.88x tabl_androidpolice.skp_1 15.5ms -> 13.5ms 0.87x desk_twitter.skp_1 12.2ms -> 10.6ms 0.87x tabl_nofolo.skp_1 5.49ms -> 4.76ms 0.87x desk_mobilenews.skp_1 22ms -> 18.9ms 0.86x desk_forecastio.skp_1 9.47ms -> 8.05ms 0.85x tabl_culturalsolutions.skp_1 6.21ms -> 5.28ms 0.85x desk_youtube.skp_1 16.1ms -> 13.5ms 0.84x tabl_mlb.skp_1 9.75ms -> 8.01ms 0.82x tabl_digg.skp_1 5.2ms -> 4.22ms 0.81x desk_blogger.skp_1 10.2ms -> 8.24ms 0.81x desk_gmailthread.skp_1 26.8ms -> 21.6ms 0.81x desk_googleplus.skp_1 10.5ms -> 8.39ms 0.8x tabl_frantzen.skp_1 4.55ms -> 3.58ms 0.79x desk_pinterest.skp_1 8.85ms -> 6.88ms 0.78x desk_ebay.skp_1 10.5ms -> 8.15ms 0.77x tabl_transformice.skp_1 4.93ms -> 3.5ms 0.71x Results for arm_v7_neon: desk_samoasvg.skp_1 13.9ms -> 14.6ms 1.05x desk_mapsvg.skp_1 8.31ms -> 8.75ms 1.05x tabl_deviantart.skp_1 1.41ms -> 1.45ms 1.02x desk_weather.skp_1 3.8ms -> 3.88ms 1.02x desk_sfgate.skp_1 3.06ms -> 3.1ms 1.01x desk_css3gradients.skp_1 2.78ms -> 2.79ms 1x desk_espn.skp_1 6.52ms -> 6.43ms 0.99x desk_gws.skp_1 4.16ms -> 4.09ms 0.98x tabl_cnn.skp_1 4.66ms -> 4.58ms 0.98x tabl_hsfi.skp_1 3.49ms -> 3.42ms 0.98x tabl_cuteoverload.skp_1 2.41ms -> 2.35ms 0.98x desk_yahooanswers.skp_1 5.28ms -> 5.14ms 0.97x desk_carsvg.skp_1 90.8ms -> 87.9ms 0.97x tabl_gspro.skp_1 2.81ms -> 2.71ms 0.96x desk_wowwiki.skp_1 5.85ms -> 5.63ms 0.96x tabl_pravda.skp_1 7.8ms -> 7.5ms 0.96x desk_twitter.skp_1 8.14ms -> 7.8ms 0.96x tabl_androidpolice.skp_1 10.4ms -> 9.96ms 0.96x tabl_googleblog.skp_1 4.06ms -> 3.83ms 0.95x desk_mobilenews.skp_1 15.2ms -> 14ms 0.93x desk_booking.skp_1 9.89ms -> 9.08ms 0.92x desk_forecastio.skp_1 6.16ms -> 5.65ms 0.92x desk_blogger.skp_1 6.17ms -> 5.66ms 0.92x tabl_digg.skp_1 3.73ms -> 3.41ms 0.91x tabl_nofolo.skp_1 3.82ms -> 3.47ms 0.91x tabl_worldjournal.skp_1 4.24ms -> 3.84ms 0.9x desk_youtube.skp_1 10.5ms -> 9.39ms 0.9x desk_googleplus.skp_1 7.01ms -> 6.19ms 0.88x tabl_mlb.skp_1 5.91ms -> 5.22ms 0.88x tabl_googlecalendar.skp_1 10.7ms -> 9.44ms 0.88x desk_gmailthread.skp_1 19.2ms -> 16.8ms 0.88x desk_ebay.skp_1 5.68ms -> 4.93ms 0.87x desk_pinterest.skp_1 5.99ms -> 5.08ms 0.85x desk_googlehome.skp_1 3.31ms -> 2.71ms 0.82x tabl_transformice.skp_1 3.03ms -> 2.44ms 0.81x desk_amazon.skp_1 6.05ms -> 4.84ms 0.8x desk_facebook.skp_1 12.6ms -> 9.62ms 0.76x Review URL: https://codereview.chromium.org/1120023005
* Use high precision vertex attributes.Gravatar senorblanco2015-05-20
| | | | | | | | | | Specifying vertex attributes and the view matrix as mediump causes bad artifacts on Mali T6XX. Covered by the bigmatrix GM in msaa4 mode. BUG:skia=3545,3771 Review URL: https://codereview.chromium.org/1145273002
* purge imagefilter cache so we can better track leaksGravatar reed2015-05-20
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1148973002
* check for big sizes in NewDataGravatar reed2015-05-20
| | | | | | BUG=486977 Review URL: https://codereview.chromium.org/1148873004
* Don't serialize SkPictures in SkPictureShaders when in untrusted mode.Gravatar mtklein2015-05-20
| | | | | | | | This requires we "first" add a has-picture bool to SkPictureShader serialized format. BUG=chromium:486947, billions and billions of others. Review URL: https://codereview.chromium.org/1151663002
* Fix for bisector computation bug in GrAAConvexTessellatorGravatar robertphillips2015-05-20
| | | | Review URL: https://codereview.chromium.org/1151623002
* Have SkPicture inherit from SkRefCnt.Gravatar mtklein2015-05-20
| | | | | | | | | This re-enables adoption tracking for SkPictures in Blink, which should be green now that crrev.com/1136123011 has landed. BUG=skia:3847 Review URL: https://codereview.chromium.org/1145153002
* Make SkEmptyPicture a singleton.Gravatar mtklein2015-05-20
| | | | | | | | | | | | In my confusion yesterday I accidentally left this as a non-singleton. The issue in Blink was not related to this being a singleton, and it should be safe to make it one. This means recording an empty picture properly costs zero mallocs. BUG=skia: Review URL: https://codereview.chromium.org/1147053002
* More efficient SkRecorder::flushMiniRecorder()Gravatar mtklein2015-05-20
| | | | | | | | This should involve no mallocs, frees, or memcpys, and less refcounting. BUG=skia: Review URL: https://codereview.chromium.org/1144173002
* Sort build files for consistent link order.Gravatar bungeman2015-05-20
| | | | | | | | | | | Prior to the introduction of find.py, GMs were liked in the order they were listed in the gypi file, which was generally alphabetically. This made it fairly easy to predict where slides would show up in SampleApp and the order was consistent. This simply sorts the list of files in find.py to restore the expectation that files should be listed in the build in alphabetical order. Review URL: https://codereview.chromium.org/1144973003
* Font variations.Gravatar bungeman2015-05-20
| | | | | | | | | | | | Multiple Master and TrueType fonts support variation axes. This implements back-end support for axes on platforms which support it. Committed: https://skia.googlesource.com/skia/+/05773ed30920c0214d1433c07cf6360a05476c97 Committed: https://skia.googlesource.com/skia/+/3489ee0f4fa34f124f9de090d12bdc2107d52aa9 Review URL: https://codereview.chromium.org/1027373002
* fix win 8 botGravatar caryclark2015-05-20
| | | | | | | | | Comment out assert (runtime documentation) It fails on Win 8 because the result isn't bit identical. TBR=bungeman@google.com Review URL: https://codereview.chromium.org/1148053003
* Unmount before app-installGravatar stephana2015-05-20
| | | | | | | | | TBR=borenet NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1145093005
* Don't fail SkMergeImageFilter if one of the inputs are emptyGravatar fs2015-05-20
| | | | | | | | | | | | | | If one of the inputs to a SkMergeImageFilter was clipped away or otherwise caused the filterImage(...) invocation for it to return false, the entire effect would be "failed" and return false -- regardless of if it had produced a result or not. Instead of returning false directly if filterImage(...) for a source returned false, consider all the inputs, and then only return false if all of them do. BUG=chromium:489046 Review URL: https://codereview.chromium.org/1133523006
* small cleanup of GrAtlasGravatar joshualitt2015-05-19
| | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/d706f11b6e3f4398ab93b23458a7599ee324be2c Review URL: https://codereview.chromium.org/1142263002
* Revert of small cleanup of GrAtlas (patchset #2 id:20001 of ↵Gravatar bungeman2015-05-19
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1142263002/) Reason for revert: Broke compile on Linux Original issue's description: > small cleanup of GrAtlas > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/d706f11b6e3f4398ab93b23458a7599ee324be2c TBR=robertphillips@google.com,joshualitt@google.com,jvanverth@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1142273002
* small cleanup of GrAtlasGravatar joshualitt2015-05-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1142263002
* Adding immediate mode draw target for debugGravatar joshualitt2015-05-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1126043007
* implement --quiet for DMGravatar reed2015-05-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1139413003
* Add a newline to the font load debug messageGravatar kkinnunen2015-05-19
| | | | | | | | Add a newline to the font load debug message. Helps reading nanobench results. Otherwise the message "Resource /fonts/Funkster.ttf not a valid font." causes first result be hard to read or missing. Review URL: https://codereview.chromium.org/1142183002
* Sketch splitting SkPicture into an interface and SkBigPicture.Gravatar mtklein2015-05-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds small pictures for drawRect(), drawTextBlob(), and drawPath(). These cover about 89% of draw calls from Blink SKPs, and about 25% of draw calls from our GMs. SkPicture handles: - serialization and deserialization - unique IDs Everything else is left to the subclasses: - playback(), cullRect() - hasBitmap(), hasText(), suitableForGPU(), etc. - LayerInfo / AccelData if applicable. The time to record a 1-op picture improves a good chunk (2 mallocs to 1), and the time to record a 0-op picture greatly improves (2 mallocs to none): picture_overhead_draw: 450ns -> 350ns picture_overhead_nodraw: 300ns -> 90ns BUG=skia: Committed: https://skia.googlesource.com/skia/+/c92c129ff85b05a714bd1bf921c02d5e14651f8b Latest blink_linux_rel: http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/61248 Committed: https://skia.googlesource.com/skia/+/15877b6eae33a9282458bdb904a6d00440eca0ec http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/62015 Review URL: https://codereview.chromium.org/1112523006
* handle large conic strokes betterGravatar caryclark2015-05-19
| | | | | | | | | | | | | | | | | | | | A stroked conic computes the outset quad's control point by computing the intersection of the quad's endpoints. If the the denominator used to compute the scale factor for the control point is small, check to see if the numerator is also small so that the division stays bounded. Also clean up error returns and internal function calls to simplify the code. Additionally, remove comic max curvature (unimplemented) and call extrema functions instead to handle cases where the conic is degenerate or is a line. R=reed@google.com, fmalita@chromium.org BUG=skia:3843 Review URL: https://codereview.chromium.org/1144883003
* Documentation: SkCanvas APIGravatar halcanary2015-05-19
| | | | | | | | | | | | | | NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1127383010 DOCS_PREVIEW= https://skia.org/user/api?cl=1127383010 DOCS_PREVIEW= https://skia.org/user/api/skcanvas?cl=1127383010 DOCS_PREVIEW= https://skia.org/user/api/skpaint?cl=1127383010 DOCS_PREVIEW= https://skia.org/user/api/skrect?cl=1127383010 DOCS_PREVIEW= https://skia.org/user/api/skregion?cl=1127383010 DOCS_PREVIEW= https://skia.org/user/api/skmatrix?cl=1127383010 DOCS_PREVIEW= https://skia.org/user/api/canvas?cl=1127383010 Review URL: https://codereview.chromium.org/1127383010
* rename GrDrawTargetCaps to GrCapsGravatar bsalomon2015-05-19
| | | | Review URL: https://codereview.chromium.org/1133123009
* Preliminary attempt to remove batch trackerGravatar joshualitt2015-05-19
| | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/cbfe91d82500f4ae8c3ff7bd74b3021a4b89fd84 Review URL: https://codereview.chromium.org/1139723004
* Revert of Preliminary attempt to remove batch tracker (patchset #3 id:40001 ↵Gravatar joshualitt2015-05-19
| | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/1139723004/) Reason for revert: breaking bots Original issue's description: > Preliminary attempt to remove batch tracker > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/cbfe91d82500f4ae8c3ff7bd74b3021a4b89fd84 TBR=robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1132323003
* Preliminary attempt to remove batch trackerGravatar joshualitt2015-05-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1139723004
* This allows to restart the device.Gravatar stephana2015-05-19
| | | | | | | BUG=skia: TBR=borenet Review URL: https://codereview.chromium.org/1137873007
* Fix GrAARectRenderer's handling of unsorted nested rectsGravatar robertphillips2015-05-19
| | | | | | | | What is going on here is that, after the mapPoints in fillAANestedRects, devInside was upside down so the isEmpty check was always firing. I don't see why we need to avoid having devInside sorted. BUG=488103 Review URL: https://codereview.chromium.org/1135753004
* Improve caching of dashed paths in GrStencilAndCoverPathRendererGravatar kkinnunen2015-05-18
| | | | | | | | | | | | | | | | Improve caching of dashed paths in GrStencilAndCoverPathRenderer. Look up the (NVPR specific) GrGLPath based on GrStrokeInfo and the original path. Use unique keys for all GrPaths. Dash the path with Skia dash stroker and use that path geometry for NVPR path. NVPR internal dashing stroke is not used, because the dashing implementation of NVPR does not match Skia implementation. Review URL: https://codereview.chromium.org/1116123003
* Make GrResourceCache perf less sensitive to key length changeGravatar kkinnunen2015-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make GrResourceCache performance less sensitive to key length change. The memcmp in GrResourceKey is called when SkTDynamicHash jumps the slots to find the hash by a index. Avoid most of the memcmps by comparing the hash first. This is important because small changes in key data length can cause big performance regressions. The theory is that key length change causes different hash values. These hash values might trigger memcmps that originally weren't there, causing the regression. Adds few specialized benches to grresourcecache_add to test different key lengths. The tests are run only on release, because on debug the SkTDynamicHash validation takes too long, and adding many such delays to development test runs would be unproductive. On release the tests are quite fast. Effect of this patch to the added tests on amd64: grresourcecache_find_10 738us -> 768us 1.04x grresourcecache_find_2 472us -> 476us 1.01x grresourcecache_find_25 841us -> 845us 1x grresourcecache_find_4 565us -> 531us 0.94x grresourcecache_find_54 1.18ms -> 1.1ms 0.93x grresourcecache_find_5 834us -> 749us 0.9x grresourcecache_find_3 620us -> 542us 0.87x grresourcecache_add_25 2.74ms -> 2.24ms 0.82x grresourcecache_add_56 3.23ms -> 2.56ms 0.79x grresourcecache_add_54 3.34ms -> 2.62ms 0.78x grresourcecache_add_5 2.68ms -> 2.1ms 0.78x grresourcecache_add_10 2.7ms -> 2.11ms 0.78x grresourcecache_add_2 1.85ms -> 1.41ms 0.76x grresourcecache_add 1.84ms -> 1.4ms 0.76x grresourcecache_add_4 1.99ms -> 1.49ms 0.75x grresourcecache_add_3 2.11ms -> 1.55ms 0.73x grresourcecache_add_55 39ms -> 13.9ms 0.36x grresourcecache_find_55 23.2ms -> 6.21ms 0.27x On arm64 the results are similar. On arm_v7_neon, the results lack the discontinuity at 55: grresourcecache_add 4.06ms -> 4.26ms 1.05x grresourcecache_add_2 4.05ms -> 4.23ms 1.05x grresourcecache_find 1.28ms -> 1.3ms 1.02x grresourcecache_find_56 3.35ms -> 3.32ms 0.99x grresourcecache_find_2 1.31ms -> 1.29ms 0.99x grresourcecache_find_54 3.28ms -> 3.24ms 0.99x grresourcecache_add_5 6.38ms -> 6.26ms 0.98x grresourcecache_add_55 8.44ms -> 8.24ms 0.98x grresourcecache_add_25 7.03ms -> 6.86ms 0.98x grresourcecache_find_25 2.7ms -> 2.59ms 0.96x grresourcecache_find_4 1.45ms -> 1.38ms 0.95x grresourcecache_find_10 2.52ms -> 2.39ms 0.95x grresourcecache_find_55 3.54ms -> 3.33ms 0.94x grresourcecache_find_5 2.5ms -> 2.32ms 0.93x grresourcecache_find_3 1.57ms -> 1.43ms 0.91x The extremely slow case, 55, is postulated to be due to the index jump collisions running the memcmp. This is not visible on arm_v7_neon probably due to hash function producing different results for 32 bit architectures. This change is needed for extending path cache key in Gr NV_path_rendering codepath. Extending is needed in order to add dashed paths to the path cache. Review URL: https://codereview.chromium.org/1132723003
* Improve NVPR stroke accuracy to fix thick strokesGravatar kkinnunen2015-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Set the "path stroke error bound" path parameter to 0.02 for all paths. This means that the stroked path area will be within 98% of the stroke width in path space. This should fix many cases where NVPR stroked paths were visibly different to Skia stroked paths. One such path is in dashcubics gm. This increases the amount of subdivisions the path object creation will make for paths that need it. This in turn will increase gpu object space requirements sligthly. Both of these effects should be unnoticeable. GL_NV_path_rendering.txt: """ Every path object has a stroke approximation bound parameter (PATH_STROKE_BOUND_NV) that is a floating-point value /sab/ clamped between 0.0 and 1.0 and set and queried with the PATH_STROKE_BOUND_NV path parameter. Exact determination of samples swept an orthogonal centered line segment along cubic Bezier segments and rational quadratic Bezier curves (so non-circular partial elliptical arcs) is intractable for real-time rendering so an approximation is required; /sab/ intuitively bounds the approximation error as a percentage of the path object's stroke width. Specifically, this path parameter requests the implementation to stencil any samples within /sweep/ object space units of the exact sweep of the path's cubic Bezier segments or partial elliptical arcs to be sampled by the stroke where sweep = ((1-sab)*sw)/2 where /sw/ is the path object's stroke width. The initial value of /sab/ when a path is created is 0.2. In practical terms, this initial value means the stencil sample positions coverage within 80% (100%-20%) of the stroke width of cubic and rational quadratic stroke segments should be sampled. """ BUG=skia:2049 Review URL: https://codereview.chromium.org/1124423007
* Make GrStrokeInfo inherit from SkStrokeRecGravatar kkinnunen2015-05-18
| | | | | | | | | | | | | | | | | | | Make the code more readable by inheriting GrStrokeInfo from SkStrokeRec. This should avoid the long .getStrokeRec() and .getStrokeRecPtr(). These were a bit cumbersome especially in cases where an alias variable was created for these, and then the reader had to keep track to which StrokeInfo member the StrokeRec alias was pointing. Removes SkStrokeRec::SkStrokeRec(const SkStrokeRec&). It was memcpying. Try to play it safe wrt compiler using the possible padding of superclass for subclass members. Instead, let the compiler generate the copy constructor. Assignment operator was already compiler-generated, so at least in that way this is consistent. Renames GrStrokeInfo::applyDash to applyDashToPath for consistency with superclass applyToPath. Review URL: https://codereview.chromium.org/1128113008
* Revert of Sketch splitting SkPicture into an interface and SkBigPicture. ↵Gravatar mtklein2015-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #25 id:480001 of https://codereview.chromium.org/1112523006/) Reason for revert: win_chromium_compile_dbg_ng FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\third_party\skia\src\core\skia.SkBitmapHeap.obj.rsp /c ..\..\third_party\skia\src\core\SkBitmapHeap.cpp /Foobj\third_party\skia\src\core\skia.SkBitmapHeap.obj /Fdobj\skia\skia.cc.pdb e:\b\build\slave\win\build\src\third_party\skia\include\core\skpicture.h(176) : error C2487: 'CURRENT_PICTURE_VERSION' : member of dll interface class may not be declared with dll interface Original issue's description: > Sketch splitting SkPicture into an interface and SkBigPicture. > > Adds small pictures for drawRect(), drawTextBlob(), and drawPath(). > These cover about 89% of draw calls from Blink SKPs, > and about 25% of draw calls from our GMs. > > SkPicture handles: > - serialization and deserialization > - unique IDs > > Everything else is left to the subclasses: > - playback(), cullRect() > - hasBitmap(), hasText(), suitableForGPU(), etc. > - LayerInfo / AccelData if applicable. > > The time to record a 1-op picture improves a good chunk > (2 mallocs to 1), and the time to record a 0-op picture > greatly improves (2 mallocs to none): > > picture_overhead_draw: 450ns -> 350ns > picture_overhead_nodraw: 300ns -> 90ns > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c92c129ff85b05a714bd1bf921c02d5e14651f8b > > Latest blink_linux_rel: > > http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/61248 > > Committed: https://skia.googlesource.com/skia/+/15877b6eae33a9282458bdb904a6d00440eca0ec TBR=reed@google.com,robertphillips@google.com,fmalita@chromium.org,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1130283004
* Making mount more robustGravatar stephana2015-05-18
| | | | | | | BUG=skia: TBR=borenet Review URL: https://codereview.chromium.org/1131933007
* Sketch splitting SkPicture into an interface and SkBigPicture.Gravatar mtklein2015-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds small pictures for drawRect(), drawTextBlob(), and drawPath(). These cover about 89% of draw calls from Blink SKPs, and about 25% of draw calls from our GMs. SkPicture handles: - serialization and deserialization - unique IDs Everything else is left to the subclasses: - playback(), cullRect() - hasBitmap(), hasText(), suitableForGPU(), etc. - LayerInfo / AccelData if applicable. The time to record a 1-op picture improves a good chunk (2 mallocs to 1), and the time to record a 0-op picture greatly improves (2 mallocs to none): picture_overhead_draw: 450ns -> 350ns picture_overhead_nodraw: 300ns -> 90ns BUG=skia: Committed: https://skia.googlesource.com/skia/+/c92c129ff85b05a714bd1bf921c02d5e14651f8b Latest blink_linux_rel: http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/61248 Review URL: https://codereview.chromium.org/1112523006
* Empty picture shaders should draw nothing.Gravatar mtklein2015-05-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1142053004
* SkPDF: Add Sfntly to DEPS, gypGravatar halcanary2015-05-18
| | | | | | | | | | | | | | | | | Note: this can be disabled via: GYP_DEFINES='skia_pdf_use_sfntly=0 Warning: dm is 34% slower and uses 9% more memory. This is okay. Motivation: We want to test this code path in DM, since it is always used by Chromium and Android. BUG=skia:3563 Committed: https://skia.googlesource.com/skia/+/6a53b04e26749ea61f690ece408f2a1c0a5ad5bb Review URL: https://codereview.chromium.org/1134683006
* Prevent integer wrap around for malloc size when creating a SkRegionGravatar djsollen2015-05-18
| | | | | | BUG=484998 Review URL: https://codereview.chromium.org/1143603003
* Don't do discards when on Adreno4xx due to driver bug.Gravatar egdaniel2015-05-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1126423006
* add GM to test extractAlphaGravatar reed2015-05-18
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1142123003
* fix builder winding againGravatar caryclark2015-05-18
| | | | | | | | | | Record the nesting level when finding the edge winding contribution so that inner edges can be reversed as needed. R=fmalita@chromium.org BUG=skia:3838 Review URL: https://codereview.chromium.org/1140383002
* Remove SK_LEGACY_DRAWPICTURECALLBACK from skia_for_chromium_defines.gypiGravatar Florin Malita2015-05-18
| | | | | | | | The flag now lives in Chromium's SkUserConfig.h. R=reed@google.com Review URL: https://codereview.chromium.org/1133243009
* Revert of SkPDF: Add Sfntly to DEPS, gyp, SkUserConfig (patchset #7 ↵Gravatar halcanary2015-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:570001 of https://codereview.chromium.org/1134683006/) Reason for revert: break cros build Original issue's description: > SkPDF: Add Sfntly to DEPS, gyp > > Note: this can be disabled via: > GYP_DEFINES='skia_pdf_use_sfntly=0 > > Warning: dm is 34% slower and uses 9% more memory. This is > okay. > > Motivation: We want to test this code path in DM, since it is > always used by Chromium and Android. > > BUG=skia:3563 > > Committed: https://skia.googlesource.com/skia/+/6a53b04e26749ea61f690ece408f2a1c0a5ad5bb TBR=reed@google.com,mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3563 Review URL: https://codereview.chromium.org/1128353004
* SkPDF: Add Sfntly to DEPS, gypGravatar halcanary2015-05-18
| | | | | | | | | | | | | | | Note: this can be disabled via: GYP_DEFINES='skia_pdf_use_sfntly=0 Warning: dm is 34% slower and uses 9% more memory. This is okay. Motivation: We want to test this code path in DM, since it is always used by Chromium and Android. BUG=skia:3563 Review URL: https://codereview.chromium.org/1134683006
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-05 22:57:05 +0000