aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* The TextBlobCache needs the ability to trigger a flush because otherwise its ↵Gravatar joshualitt2015-04-10
| | | | | | | | | entire budget can be used up, but it will not be able to free up any space due to blobs being stuck in the GrInOrderDrawBuffer. This was causing a segfault. After this CL the cache will try to purge, and then flush if it cannot purge enough. It will not purge the most recent addition to the cache. TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1071333002
* Replace NEON assembly memset16 and memset32 with intrinsic versions.Gravatar mtklein2015-04-10
| | | | | | | | | | | According to bench/MemsetBench.cpp, I've got them somewhere between 10% slower and a percent or two faster than the old assembly. BUG=skia: CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Debug-Trybot Review URL: https://codereview.chromium.org/1075003002
* Adding draw looper gm for textblobsGravatar joshualitt2015-04-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1067853002
* Rewrite memset benches, then use results to add a small-N optimization.Gravatar mtklein2015-04-09
| | | | | | | | | | | | | | | The benches for N <= 10 get around 2x faster on my N7 and N9. I believe this is because of the reduced function-call-then-function-pointer-call overhead on the N7, and additionally because it seems autovectorization beats our NEON code for small N on the N9. My desktop is unchanged, though that's probably because N=10 lies well within a region where memset's performance is essentially constant: N=100 takes only about 2x as long as N=1 and N=10, which perform nearly identically. BUG=skia: Review URL: https://codereview.chromium.org/1073863002
* default to 8888 for ganesh in sampleapp on iOSGravatar reed2015-04-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1078843002
* SkPDF: ResourceDict replaced by factory functionGravatar halcanary2015-04-09
| | | | | | | | | Motivation: Having a class here was unnecessary, since the only thing that set this class apart was how it is created, not how it behaves. BUG=skia:3585 Review URL: https://codereview.chromium.org/1068343003
* Fix ASAN errorGravatar msarett2015-04-09
| | | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1072183002
* ***Disables swizzles to 565.Gravatar msarett2015-04-09
| | | | | | | | | | | | | | | | | | | | | | | We may want to enable swizzles to 565 for images that are encoded in a format similar to 565, however, we do not want to take images that decode naturally to kN32 and then convert them to 565. ***Enable swizzles to kIndex_8. For images encoded in a color table format, we suggest that they be decoded to kIndex_8. When we decode, we only allow conversion to kIndex_8 if it matches the suggested color type (except wbmp which seems good as is). ***Modify dm to test images that decode to kIndex_8. BUG=skia:3257 BUG=skia:3440 Review URL: https://codereview.chromium.org/1055743003
* Change some more GMs to clear to opaque black, not transparent black.Gravatar senorblanco2015-04-09
| | | | | | | | N.B.: this will change results on the bots for all the tests modified. BUG=skia:3319 Review URL: https://codereview.chromium.org/1077763002
* Avoid sending empty bitmaps through proxy canvasGravatar tomhudson2015-04-09
| | | | | | | | | | Some back ends may crash when asked to draw an empty bitmap, so we filter it out here. BUG=skia:3692 R=djsollen@google.com,reed@google.com Review URL: https://codereview.chromium.org/1072033002
* Remove ARM assembly memsets.Gravatar mtklein2015-04-09
| | | | | | | | | | | Step 1 of a zillion in the quest for NEON on iOS, and step 1 of a different zillion in the Great Assembly Purge. ios, arm, arm64, arm_v7, arm_v7_neon all build. BUG=skia: Review URL: https://codereview.chromium.org/1072063002
* [SkTextBlob] Custom run font recordGravatar fmalita2015-04-09
| | | | | | | | | | | Instead of using a full-blown SkPaint to store run font info, use a custom structure. This saves 96 bytes / run on 64bit platforms. R=reed@google.com,mtklein@google.com,joshualitt@google.com Review URL: https://codereview.chromium.org/1070943002
* add test for opaque-preserving colormatrixfiltersGravatar reed2015-04-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1069463002
* fix for perf regression on ugamsolutions / msaa16Gravatar joshualitt2015-04-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1076853002
* Rename DistanceFieldTextureEffect.{cpp,h}Gravatar jvanverth2015-04-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1073473005
* BUG=skia:Gravatar stephana2015-04-09
| | | | Review URL: https://codereview.chromium.org/1054073003
* Rearrange SkRecord with small N in mindGravatar mtklein2015-04-09
| | | | | | | | | | | | | | This rearranges the record pointers and types so they can go in a single array, then preallocates some space for them and for the SkVarAlloc. picture_overhead_draw bench drops from ~1000ns to 500-600ns, with no effect on picture_overhead_nodraw. I don't see any significant effect on large picture recording times from our .skps. BUG=chromium:470553 Committed: https://skia.googlesource.com/skia/+/e2dd9408cd711777afaa9410427fb0d761ab004a Review URL: https://codereview.chromium.org/1061783002
* Update DEPS to use a cloned copy of libpngGravatar djsollen2015-04-09
| | | | | | BUG=skia:3689 Review URL: https://codereview.chromium.org/1077673002
* Add GM to repro crbug.com/472795Gravatar robertphillips2015-04-09
| | | | | | | | This CL also adds a new parameter to SkBitmapSource which gives the user control of the filter quality. BUG=472795 Review URL: https://codereview.chromium.org/1072603002
* Remove SK_SUPPORT_LEGACY_SCALAR_MAPPOINTSGravatar fmalita2015-04-09
| | | | | | | | | | | No longer used in Chromium. Also drop now-unused SkMatrix::Rot_pts() & SkMatrix::RotTrans_pts(). BUG=475022 R=reed@google.com,mtklein@google.com Review URL: https://codereview.chromium.org/1071833002
* Mark SkPictureRecorder::endRecording as SK_WARN_UNUSED_RESULT.Gravatar jbroman2015-04-09
| | | | | | | | | | | | Ignoring the result is a memory leak. Callers should always at least unref the result. This bug has occurred in Blink: https://codereview.chromium.org/1068413002/ BUG=skia:3680 Review URL: https://codereview.chromium.org/1072633002
* Valgrind sez: new[] wants delete[].Gravatar mtklein2015-04-09
| | | | | | | | | | https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind/builds/17/steps/dm/logs/stdio TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1075853002
* expand pdf/worldjournal blacklist entry to cover the new skp tooGravatar Mike Klein2015-04-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1070013002
* Revert of Rearrange SkRecord with small N in mind (patchset #8 id:120001 of ↵Gravatar mtklein2015-04-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1061783002/) Reason for revert: https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug/builds/149/steps/dm/logs/stdio Original issue's description: > Rearrange SkRecord with small N in mind > > This rearranges the record pointers and types so they can go in a single array, then preallocates some space for them and for the SkVarAlloc. > > picture_overhead_draw bench drops from ~1000ns to 500-600ns, with no effect on picture_overhead_nodraw. > > I don't see any significant effect on large picture recording times from our .skps. > > BUG=chromium:470553 > > Committed: https://skia.googlesource.com/skia/+/e2dd9408cd711777afaa9410427fb0d761ab004a TBR=reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:470553 Review URL: https://codereview.chromium.org/1068383003
* Rearrange SkRecord with small N in mindGravatar mtklein2015-04-08
| | | | | | | | | | | | This rearranges the record pointers and types so they can go in a single array, then preallocates some space for them and for the SkVarAlloc. picture_overhead_draw bench drops from ~1000ns to 500-600ns, with no effect on picture_overhead_nodraw. I don't see any significant effect on large picture recording times from our .skps. BUG=chromium:470553 Review URL: https://codereview.chromium.org/1061783002
* SkString: remove fStr memberGravatar halcanary2015-04-08
| | | | | | Motivation: I'd like sizeof(SkString) to be the same in Debug and Release. Review URL: https://codereview.chromium.org/1073473003
* Rename the distance field geoprocs to something more reasonable.Gravatar jvanverth2015-04-08
| | | | | | | | Prep for adding Mali fix for distance field paths. BUG=skia:3528 Review URL: https://codereview.chromium.org/1075543002
* Use opaque black not transparent black as imagefilter GM background.Gravatar senorblanco2015-04-08
| | | | | | | | | | | | | | | | For some reason, GM's are now being composited against white in some modes, where the alpha used to be ignored (or composited against black, I'm not sure which). At any rate, it doesn't make much sense to have alpha in the result anyway, so let's clear to opaque black instead of transparent black and avoid the problem. This is a trial balloon for bitmapsource and pictureimagefilter. If all goes well, I'll make this change more widely. R=scroggo BUG=skia:3319 Review URL: https://codereview.chromium.org/1074513002
* Fail gracefully when dm.json is not presentGravatar Derek Sollenberger2015-04-08
| | | | Review URL: https://codereview.chromium.org/1073593002
* SkCanvas::resetForNextPicture()Gravatar mtklein2015-04-08
| | | | | | | | | | | | | | | No diffs against head for DM --config 8888 gpu 2ndpic-8888 2ndpic-gpu. picture_overhead_draw 1.62us -> 1.6us 0.99x picture_overhead_nodraw 792ns -> 342ns 0.43x tiles and serialization modes will also test this a bit. BUG=chromium:470553 Committed: https://skia.googlesource.com/skia/+/f920e468ac66a36c9653d1b11181480295044c7d Review URL: https://codereview.chromium.org/1067893002
* Add mechanism to proactively purge old resources in GrResourceCache.Gravatar bsalomon2015-04-08
| | | | | | This change leaves the feature turned off by default. Review URL: https://codereview.chromium.org/1032873002
* Adding a cache + memory pool for GPU TextBlobsGravatar joshualitt2015-04-08
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1055843002
* SkPDF: Remove Array's unused set(i) and get(i) (leaving only append())Gravatar halcanary2015-04-08
| | | | | | BUG=skia:3585 Review URL: https://codereview.chromium.org/1071583003
* Add helper for creating a SkSurface from a client created texture.Gravatar bsalomon2015-04-08
| | | | Review URL: https://codereview.chromium.org/1071603002
* change isNestedRect to isNestedFillRectGravatar caryclark2015-04-08
| | | | | | | | | R=reed@google.com, bsalomon@google.com Let isNested(Fill)Rect return true if drawn path describes filled rectangles. Review URL: https://codereview.chromium.org/1073473002
* Make --undefok a little louder now that we're using it all the time.Gravatar mtklein2015-04-08
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1073483002
* Adding bulk plot reffer to cached textblobsGravatar joshualitt2015-04-08
| | | | | | | | | | | This change will prevent the atlas from evicting glyphs the TextBlob needs. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7281c61e7bc689d484dcbda49be3cef4ce4f11c2 Review URL: https://codereview.chromium.org/1050113004
* Remove unused InstCounterClass.Gravatar bungeman2015-04-08
| | | | | | | | This was added with r4719 (f7943035) to support testing SkTRefArray. With 703d3c70 SkTRefArray and the associated test was removed, but the supporting InstCounterClass was not. Review URL: https://codereview.chromium.org/1063403003
* add realloc method to SkAutoSTMallocGravatar joshualitt2015-04-08
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1069013002
* Add missing override of willSaveLayer()Gravatar tomhudson2015-04-08
| | | | | | | | | Also tweak formatting. BUG=3624 R=djsollen@google.com Review URL: https://codereview.chromium.org/1068163004
* Revert of SkCanvas::resetForNextPicture() (patchset #4 id:60001 of ↵Gravatar mtklein2015-04-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1067893002/) Reason for revert: https://uberchromegw.corp.google.com/i/client.skia/builders/Linux%20Tests/builds/1816 Original issue's description: > SkCanvas::resetForNextPicture() > > No diffs against head for DM --config 8888 gpu 2ndpic-8888 2ndpic-gpu. > > picture_overhead_draw 1.62us -> 1.6us 0.99x > picture_overhead_nodraw 792ns -> 342ns 0.43x > > tiles and serialization modes will also test this a bit. > > BUG=chromium:470553 > > Committed: https://skia.googlesource.com/skia/+/f920e468ac66a36c9653d1b11181480295044c7d TBR=mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:470553 Review URL: https://codereview.chromium.org/1062353002
* SkCanvas::resetForNextPicture()Gravatar mtklein2015-04-07
| | | | | | | | | | | | | No diffs against head for DM --config 8888 gpu 2ndpic-8888 2ndpic-gpu. picture_overhead_draw 1.62us -> 1.6us 0.99x picture_overhead_nodraw 792ns -> 342ns 0.43x tiles and serialization modes will also test this a bit. BUG=chromium:470553 Review URL: https://codereview.chromium.org/1067893002
* Move uninteresting MD5 check to after adding it to JSON.Gravatar mtklein2015-04-07
| | | | | | BUG=skia:3676 Review URL: https://codereview.chromium.org/1067053002
* Fix formatting in the sheriff documentationGravatar rmistry2015-04-07
| | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1066013002 Review URL: https://codereview.chromium.org/1066013002
* Switch textures created by DeviceImageFilterProxy toGravatar senorblanco2015-04-07
| | | | | | | | | | | | | | | | | | | approx-match. This revealed some further 0..1 texture coordinate depedencies,specifically in SkDisplacementMapEffect and SkXfermodeImageFilter, fixed through use of GrTextureDomain. Note: causes minor pixel diffs in pictureimagefilter, testimagefilters GMs. Also causes minor pixel diffs in some Blink layout tests, suppressed here: https://codereview.chromium.org/1064943002 BUG=skia:3532 Review URL: https://codereview.chromium.org/1065683002
* re-enable neon opts for some xfermodesGravatar reed2015-04-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1068783003
* SkPDF: SkPDFString is no longer aware of wide strings.Gravatar halcanary2015-04-07
| | | | | | | | | | | | Since wide strings are only used in SkPDFDevice, I have moved the function that manages them to that directory. Motivation: The SkPDFString will be refactored later along with the other SkPFObject heirarchy. BUG=skia:3585 Review URL: https://codereview.chromium.org/1064013003
* Revert of Adding bulk plot reffer to cached textblobs (patchset #7 id:110001 ↵Gravatar joshualitt2015-04-07
| | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/1050113004/) Reason for revert: Breaks linux builder Original issue's description: > Adding bulk plot reffer to cached textblobs > > This change will prevent the atlas from evicting glyphs the TextBlob > needs. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7281c61e7bc689d484dcbda49be3cef4ce4f11c2 TBR=bsalomon@google.com,jvanverth@google.com,robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1061713003
* Adding bulk plot reffer to cached textblobsGravatar joshualitt2015-04-07
| | | | | | | | | This change will prevent the atlas from evicting glyphs the TextBlob needs. BUG=skia: Review URL: https://codereview.chromium.org/1050113004
* Calculate inverse scale for distance field text in vertex shaderGravatar jvanverth2015-04-07
| | | | | | | | | | | | This is for the uniform scale case only. Using the dFdx() function on certain Mali GPUs causes issues because the precision is too low, so we have to compute 1/scale from the view matrix instead. BUG=skia:3528 Committed: https://skia.googlesource.com/skia/+/5b143038cb47763974d2750ed78d436eb6c38bea Review URL: https://codereview.chromium.org/1029423003
generated by cgit v1.2.3 (git 2.39.1) at 2024-10-16 14:52:47 +0000