aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* fix ios buildGravatar caryclark2014-10-09
| | | | | | | | NOTREECHECKS=true NOTRY=true TBR= Review URL: https://codereview.chromium.org/641063002
* Draw more accurate thick-stroked Beziers (disabled)Gravatar caryclark2014-10-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Draw thick-stroked Beziers by computing the outset quadratic, measuring the error, and subdividing until the error is within a predetermined limit. To try this CL out, change src/core/SkStroke.h:18 to #define QUAD_STROKE_APPROXIMATION 1 or from the command line: CPPFLAGS="-D QUAD_STROKE_APPROXIMATION=1" ./gyp_skia Here's what's in this CL: bench/BezierBench.cpp : a microbench for examining where the time is going gm/beziers.cpp : random Beziers with various thicknesses gm/smallarc.cpp : a distillation of bug skia:2769 samplecode/SampleRotateCircles.cpp : controls added for error, limit, width src/core/SkStroke.cpp : the new stroke implementation (disabled) tests/StrokerTest.cpp : a stroke torture test that checks normal and extreme values The new stroke algorithm has a tweakable parameter: stroker.setError(1); (SkStrokeRec.cpp:112) The stroke error is the allowable gap between the midpoint of the stroke quadratic and the center Bezier. As the projection from the quadratic approaches the endpoints, the error is decreased proportionally so that it is always inside the quadratic curve. An overview of how this works: - For a given T range of a Bezier, compute the perpendiculars and find the points outset and inset for some radius. - Construct tangents for the quadratic stroke. - If the tangent don't intersect between them (may happen with cubics), subdivide. - If the quadratic stroke end points are close (again, may happen with cubics), draw a line between them. - Compute the quadratic formed by the intersecting tangents. - If the midpoint of the quadratic is close to the midpoint of the Bezier perpendicular, return the quadratic. - If the end of the stroke at the Bezier midpoint doesn't intersect the quad's bounds, subdivide. - Find where the Bezier midpoint ray intersects the quadratic. - If the intersection is too close to the quad's endpoints, subdivide. - If the error is large proportional to the intersection's distance to the quad's endpoints, subdivide. BUG=skia:723,skia:2769 Review URL: https://codereview.chromium.org/558163005
* use real pdfdevice behind SkDocumentGravatar reed2014-10-09
| | | | | | | BUG=skia: TBR=bungeman@google.com Review URL: https://codereview.chromium.org/645563002
* Adding 3D lut color filterGravatar sugoi2014-10-09
| | | | | | | | Included in this cl is support for 3D textures. BUG=skia: Review URL: https://codereview.chromium.org/580863004
* Make the Sk GL context class an abstract base classGravatar kkinnunen2014-10-09
| | | | | | | | | | | | | | | | | | | | | | | Make the Sk GL context class, SkGLNativeContext, an abstract base class. Before, it depended on ifdefs to implement the platform dependent polymorphism. Move the logic to subclasses of the various platform implementations. This a step to enable Skia embedders to compile dm and bench_pictures. The concrete goal is to support running these test apps with Chromium command buffer. With this change, Chromium can implement its own version of SkGLNativeContext that uses command buffer, and host the implementation in its own repository. Implements the above by renaming the SkGLContextHelper to SkGLContext and removing the unneeded SkGLNativeContext. Also removes SkGLNativeContext::AutoRestoreContext functionality, it appeared to be unused: no use in Skia code, and no tests. BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/a90ed4e83897b45d6331ee4c54e1edd4054de9a8 Review URL: https://codereview.chromium.org/630843002
* Update old tools to allow MultiPictureDraw renderingGravatar robertphillips2014-10-09
| | | | | | I'll post a separate patch for nanobench and dm Review URL: https://codereview.chromium.org/639013003
* Update SKP version to 121Gravatar borenet2014-10-08
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/644633002
* webtry: Simply move sys/ directory into setup/.Gravatar tfarina2014-10-08
| | | | | | | | | | | | | | That seems to make things more tied and that seems to be where we have the same scripts/configs in the perf directory: https://skia.googlesource.com/buildbot/+/master/perf/setup/sys/ That way we keep all files used/related to setting up a new webtry server in one place. BUG=None TEST=None R=humper@google.com Review URL: https://codereview.chromium.org/644513003
* call derived ~ from GrIORefGravatar bsalomon2014-10-08
| | | | | | | TBR=mtklein@google.com NOTREECHECKS=true Review URL: https://codereview.chromium.org/641813002
* Remove ~GrIORef since last remaining virtual and now all inlineGravatar bsalomon2014-10-08
| | | | | | | TBR=reed@google.com NOTRY=true Review URL: https://codereview.chromium.org/638003003
* Revert of Use presence of a content key as non-scratch indicator (patchset ↵Gravatar bsalomon2014-10-08
| | | | | | | | | | | | | | | | | | | | | #5 id:80001 of https://codereview.chromium.org/639873002/) Reason for revert: breaking nanobench on ubuntu Original issue's description: > Use presence of a content key as non-scratch indicator > > BUG=skia:2889 > > Committed: https://skia.googlesource.com/skia/+/9eefe0851eeaa8ded05b4774ebcb38ed201d5dbf TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2889 Review URL: https://codereview.chromium.org/642493003
* use SkDocument to capture pdfs from SampleApp 'e'Gravatar reed2014-10-08
| | | | | | | | BUG=skia: TBR= NOTRY=True Review URL: https://codereview.chromium.org/634293004
* Use presence of a content key as non-scratch indicatorGravatar bsalomon2014-10-08
| | | | | | BUG=skia:2889 Review URL: https://codereview.chromium.org/639873002
* Add SK_API to GrGpuResourceGravatar bsalomon2014-10-08
| | | | | | TBR=reed@google.com Review URL: https://codereview.chromium.org/638963003
* Rebase Nexus 10 gm failureGravatar egdaniel2014-10-08
| | | | | | | | TBR=robertphillips@google.com BUG=skia: Review URL: https://codereview.chromium.org/638043002
* pre-build the resources library for the fiddle jailGravatar Greg Humphreys2014-10-08
| | | | | | | BUG=skia: TBR=jcgregorio Review URL: https://codereview.chromium.org/637353003
* repair the webtry setup processGravatar Greg Humphreys2014-10-08
| | | | | | | | | | | | | | | | The previous version of the script didn't properly update the code for the webtry user, so only changes to skia would really be pulled, not changes to the actual webtry server itself. This version of the setup script is 100% automated and brings everything up to date. It's also a little more verbose about what it's doing, so it's easier to debug. BUG=skia: R=tfarina@chromium.org TBR=jcgregorio, mtklein, tfarina Review URL: https://codereview.chromium.org/636173003
* allow fiddles to use the futex system call; fixes fonts finallyGravatar Greg Humphreys2014-10-08
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/639013002
* Rearrange code in TextContexts to be more consistent and match style guide.Gravatar jvanverth2014-10-08
| | | | Review URL: https://codereview.chromium.org/641613003
* In the generated fiddle, set the portable fonts flag first.Gravatar Greg Humphreys2014-10-08
| | | | | | | BUG=skia: TBR=jcgregorio Review URL: https://codereview.chromium.org/635373002
* GrResourceCache2 manages scratch texture.Gravatar bsalomon2014-10-08
| | | | | | BUG=skia:2889 Review URL: https://codereview.chromium.org/608883003
* Make GM default to reseting gpu contexts on android.Gravatar bsalomon2014-10-08
| | | | | | | | TBR=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/8dd35ce178e4319685a870faf544a0b1d7aef5bb Review URL: https://codereview.chromium.org/635293003
* preliminary support for fiddle font useGravatar Greg Humphreys2014-10-08
| | | | | | | BUG=skia:2998 TBR=jcgregorio, tfarina Review URL: https://codereview.chromium.org/639833003
* Fix conditional check when copying coverage stages in ODSGravatar egdaniel2014-10-08
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/639773004
* fix android framework build errorsGravatar djsollen2014-10-08
| | | | Review URL: https://codereview.chromium.org/637953002
* Delay copying effects from DS or ODS till end of creating ODSGravatar egdaniel2014-10-08
| | | | | | | | Also delay the removal of fixed function VA's until so we only have to do a single removal step BUG=skia: Review URL: https://codereview.chromium.org/634073002
* remove dead code from SK_SUPPORT_LEGACY_IMAGECACHE_NAMEGravatar reed2014-10-08
| | | | | | TBR= Review URL: https://codereview.chromium.org/638903002
* Implement C path functionsGravatar robertphillips2014-10-08
| | | | | | Mainly just to familiarize myself with this code. Review URL: https://codereview.chromium.org/633183002
* Revert of Make GM default to reseting gpu contexts on android. (patchset #1 ↵Gravatar bsalomon2014-10-08
| | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/635293003/) Reason for revert: Crashing on Galaxy Nexus (probably tickled an existing skia or driver bug) Original issue's description: > Make GM default to reseting gpu contexts on android. > > TBR=mtklein@google.com > > Committed: https://skia.googlesource.com/skia/+/8dd35ce178e4319685a870faf544a0b1d7aef5bb TBR=mtklein@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/639773003
* Add SkCachedData and use it for SkMipMapGravatar reed2014-10-08
| | | | | | | | This reverts commit 37c5a815d8ea33247968212ef4cc83394ceee1bc. TBR=mtklein Review URL: https://codereview.chromium.org/635333002
* Expose layer hoisting API in GrContextGravatar robertphillips2014-10-08
| | | | | | This CL exposes the layer hoisting API in GrContext for use in SkMultiPictureDraw::draw. It basically mirrors what SkGpuDevice::EXPERIMENTAL_drawPicture has been doing. Review URL: https://codereview.chromium.org/533673002
* Revert of Make the Sk GL context class an abstract base class (patchset #4 ↵Gravatar bsalomon2014-10-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:60001 of https://codereview.chromium.org/630843002/) Reason for revert: nanobech failing on Android Original issue's description: > Make the Sk GL context class an abstract base class > > Make the Sk GL context class, SkGLNativeContext, an abstract base class. Before, > it depended on ifdefs to implement the platform dependent polymorphism. Move > the logic to subclasses of the various platform implementations. > > This a step to enable Skia embedders to compile dm and bench_pictures. The > concrete goal is to support running these test apps with Chromium command buffer. > > With this change, Chromium can implement its own version of SkGLNativeContext > that uses command buffer, and host the implementation in its own repository. > > Implements the above by renaming the SkGLContextHelper to SkGLContext and > removing the unneeded SkGLNativeContext. Also removes > SkGLNativeContext::AutoRestoreContext functionality, it appeared to be unused: > no use in Skia code, and no tests. > > BUG=skia:2992 > > Committed: https://skia.googlesource.com/skia/+/a90ed4e83897b45d6331ee4c54e1edd4054de9a8 TBR=kkinnunen@nvidia.com NOTREECHECKS=true NOTRY=true BUG=skia:2992 Review URL: https://codereview.chromium.org/639793002
* Revert of speculative fix for ios (patchset #1 id:1 of ↵Gravatar bsalomon2014-10-08
| | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/637293003/) Reason for revert: Need to revert a90ed4e83897b45d6331ee4c54e1edd4054de9a8 Original issue's description: > speculative fix for ios > > TBR= > > Committed: https://skia.googlesource.com/skia/+/96e89d5b45e8e293139ecd95302b5b4f07f8e9dc TBR= NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/636153002
* speculative fix for iosGravatar Brian Salomon2014-10-08
| | | | | | TBR= Review URL: https://codereview.chromium.org/637293003
* Make GM default to reseting gpu contexts on android.Gravatar bsalomon2014-10-08
| | | | | | TBR=mtklein@google.com Review URL: https://codereview.chromium.org/635293003
* Make the Sk GL context class an abstract base classGravatar kkinnunen2014-10-08
| | | | | | | | | | | | | | | | | | | | | Make the Sk GL context class, SkGLNativeContext, an abstract base class. Before, it depended on ifdefs to implement the platform dependent polymorphism. Move the logic to subclasses of the various platform implementations. This a step to enable Skia embedders to compile dm and bench_pictures. The concrete goal is to support running these test apps with Chromium command buffer. With this change, Chromium can implement its own version of SkGLNativeContext that uses command buffer, and host the implementation in its own repository. Implements the above by renaming the SkGLContextHelper to SkGLContext and removing the unneeded SkGLNativeContext. Also removes SkGLNativeContext::AutoRestoreContext functionality, it appeared to be unused: no use in Skia code, and no tests. BUG=skia:2992 Review URL: https://codereview.chromium.org/630843002
* Update SKP version to 120Gravatar borenet2014-10-07
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/637173002
* Cleanup of shader building systemGravatar joshualitt2014-10-07
| | | | | | | | | | | | | | | | | this is a huge refactor and cleanup of the gl shader building system in Skia. The entire shader building pipeline is now part of GrGLProgramCreator, which takes a gp, and some fps, and creates a program. I added some subclasses of GrGLProgram to handle the eccentricities of Nvpr/Nvpres. Outside of the builders folder and GrGLPrograms, this change is basically just a rename solo gp BUG=skia: Committed: https://skia.googlesource.com/skia/+/fe1233c3f12f81bb675718516bbb32f72af726ec Review URL: https://codereview.chromium.org/611653002
* Only use msaa target for blur mask when doAA is trueGravatar derekf2014-10-07
| | | | | | BUG=skia:2995 Review URL: https://codereview.chromium.org/639523002
* Revert of Cleanup of shader building system (patchset #25 id:470001 of ↵Gravatar joshualitt2014-10-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/611653002/) Reason for revert: Seems to have messed up windows 7 gms Original issue's description: > Cleanup of shader building system > > this is a huge refactor and cleanup of the gl shader building system in > Skia. The entire shader building pipeline is now part of > GrGLProgramCreator, which takes a gp, and some fps, and creates a > program. I added some subclasses of GrGLProgram to handle the > eccentricities of Nvpr/Nvpres. Outside of the builders folder > and GrGLPrograms, this change is basically just a rename > > > solo gp > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/fe1233c3f12f81bb675718516bbb32f72af726ec TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/635533005
* Cleanup of shader building systemGravatar joshualitt2014-10-07
| | | | | | | | | | | | | | | this is a huge refactor and cleanup of the gl shader building system in Skia. The entire shader building pipeline is now part of GrGLProgramCreator, which takes a gp, and some fps, and creates a program. I added some subclasses of GrGLProgram to handle the eccentricities of Nvpr/Nvpres. Outside of the builders folder and GrGLPrograms, this change is basically just a rename solo gp BUG=skia: Review URL: https://codereview.chromium.org/611653002
* Revert "GrResourceCache2 manages scratch texture."Gravatar Brian Salomon2014-10-07
| | | | This reverts commit d14e1a27643125bfef37fa0ed314b64c1fae22b7.
* Stay in floats as much as possible in SkTileGrid, particularly in insert.Gravatar mtklein2014-10-07
| | | | | | | | | | | | | | SkTileGrid::insert() is about 15% of recording time before this CL, which reduces it to ~10%. Next steps are looking into some of the TODOs I've left myself, and vectorizing the math. Most of the win here comes from converting integer divisions into float multiplies. BUG=skia:1021 Review URL: https://codereview.chromium.org/615853007
* Update perspective GMs for dfpathsGravatar jvanverth2014-10-07
| | | | | | TBR=egdaniel@google.com Review URL: https://codereview.chromium.org/632363004
* Add baselines for dftext GM.Gravatar jvanverth2014-10-07
| | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/638683002
* Add -Wno-invalid-offsetof to Mac and iOS builds too.Gravatar mtklein2014-10-07
| | | | | | | | | | | | We use this on Linux already, but for whatever reason wasn't a problem on iOS until using it in SkPaint. Mac 10.7 and 10.8 are showing this warning too, but seems -Werror is not enabled. CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Release-iOS-Trybot BUG=skia: Review URL: https://codereview.chromium.org/637593002
* Add SkPaint::getHash().Gravatar mtklein2014-10-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/637583002
* Revert of gl programs rewrite (patchset #10 id:180001 of ↵Gravatar joshualitt2014-10-07
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/628633003/) Reason for revert: breaks angle bot Original issue's description: > gl programs rewrite > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/07a255310aca9f3e83bf741dc663a58818ad681c TBR=bsalomon@google.com,egdaniel@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/631183003
* gl programs rewriteGravatar joshualitt2014-10-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/628633003
* Fix for perspective GMs and df paths.Gravatar jvanverth2014-10-07
| | | | Review URL: https://codereview.chromium.org/636933003