aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* fix path measure fuzzesGravatar Cary Clark2018-06-25
| | | | | | | | | | | | | these fixes suppress debug asserts when the fuzzer is run R=reed@google.com,kjlubick@google.com Bug: skia: Change-Id: I7b8c16fe475056213314ecb588a4368b547836b0 Reviewed-on: https://skia-review.googlesource.com/137363 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>
* Implement onMakeClone(const SkFontArguments& args) in classes: ↵Gravatar Bruce Wang2018-06-25
| | | | | | | | | SkTypeface_Empty, SkTypeface_Stream, SkTypeface_File Change-Id: I534cfc3439601f682d6b5a2fa023aef6b04d1653 Reviewed-on: https://skia-review.googlesource.com/137192 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Add bullet proofing for preAbandonContextGravatar Robert Phillips2018-06-25
| | | | | | | | | | With the more agressive abandonment of the GrContext state in https://skia-review.googlesource.com/c/skia/+/137121 (Fix abandonment of programs) (i.e., nulling out of the interface) it is necessary to add more guards so that we don't try calling GL methods when the context has been abandoned. Change-Id: Ib2a3c17b9eaebd1eb84eb82a2781cf9d5a6a34a3 Reviewed-on: https://skia-review.googlesource.com/137362 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Make GrVkBackendContext no longer derive from SkRefCnt.Gravatar Greg Daniel2018-06-25
| | | | | | | | | | | | Also moves the helper Create functions to VkTestUtils since no clients are using them anymore. Bug: skia: Change-Id: I7e8e4912e7ef6fb00a7e2a00407aed5e83211799 Reviewed-on: https://skia-review.googlesource.com/135323 Reviewed-by: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* fix pathop fuzz timeoutGravatar Cary Clark2018-06-25
| | | | | | | | | | | R=caryclark@google.com Bug:855751 Change-Id: Ieb6bae50311f62c9b03b84b2cf84f09ad2db2e46 Reviewed-on: https://skia-review.googlesource.com/137361 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org> Auto-Submit: Cary Clark <caryclark@skia.org>
* ccpr: Blacklist PowerVR Rogue in GLGravatar Chris Dalton2018-06-25
| | | | | | | | Bug: skia: Change-Id: Icba3de2eabc24840ae6917e0eeaa279788397653 Reviewed-on: https://skia-review.googlesource.com/137341 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Fix abandonment of programsGravatar Robert Phillips2018-06-25
| | | | | | | | | | Bug: skia:8092 TBR=bsalomon@google.com Change-Id: If9cf4ed9f8ded4b7fbb58a244ec0b179b8430ca2 Reviewed-on: https://skia-review.googlesource.com/137121 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Fix SkPaint::getTypeface() documentation.Gravatar Ben Wagner2018-06-25
| | | | | | | | | | | | | SkPaint::getTypeface() allows the caller to borrow a pointer to its SkTypeface, it does not affect ownership. The existing documentation would lead a user to beleive that getTypeface() increments the reference count, but it does not. TBR=reed@google.com Change-Id: Ic1a660b026e3c4295f9f0de28abfde29c3f05524 Reviewed-on: https://skia-review.googlesource.com/137183 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
* ccpr: Enable ccpr by defaultGravatar Chris Dalton2018-06-25
| | | | | | | | | | | | | | | | | | | Now that the path cache is implemented, we can use ccpr everywhere. Modifies ccpr to not cache unless the "fAllowPathMaskCaching" context option is enabled. Adds a small condition to skip complicated paths with more vertices than pixels, simply so we don't regress a couple testcases. Updates skpbench to do three draws before starting the timer, in order to prime the cache. Bug: skia: Change-Id: Ic3a0a2bdad8a22ff6431e77fa4da2b54d6bb9aba Reviewed-on: https://skia-review.googlesource.com/137207 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Clean starting point for interop. VK will let us dodge this entirely.Gravatar Allan MacKinnon2018-06-24
| | | | | | | | Bug: skia: Change-Id: I4bc961e7e1b9ef30c5bfc096fb3f81af9191e750 Reviewed-on: https://skia-review.googlesource.com/136860 Commit-Queue: Allan MacKinnon <allanmac@google.com> Reviewed-by: Allan MacKinnon <allanmac@google.com>
* Update SKP versionGravatar skia-recreate-skps2018-06-24
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: I8ace13f7b131ee4fa9a4d035514be17cc66c18ee Reviewed-on: https://skia-review.googlesource.com/137300 Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com> Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
* Add legacy flag for vulkan interface for flutter.Gravatar Greg Daniel2018-06-23
| | | | | | | | Bug: skia: Change-Id: I50eb5c331b4a5818037155865d477914276a983c Reviewed-on: https://skia-review.googlesource.com/137194 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-06-23
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/6cf964d26783026b01cdcdf8c40b30e9fb0c845d [cipd] Add support for acl-check command (phosek@google.com) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iecdba61236a42d1be4c00b74810f925a8a124e85 Reviewed-on: https://skia-review.googlesource.com/137225 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* flush to zero tiny radiiGravatar Mike Reed2018-06-22
| | | | | | | | | Bug: 850350 Change-Id: If1f8efdb02782d520195a6b66bd159628c89f811 Reviewed-on: https://skia-review.googlesource.com/137220 Reviewed-by: Kevin Lubick <kjlubick@google.com> Auto-Submit: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Reland "Implement onMakeClone(const SkFontArguments& args) in class ↵Gravatar Ben Wagner2018-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SkTypeface_fontconfig." This reverts commit cce82d2b7c6ce3addd72016191e1be73bc084953. Reason for revert: Just add suppression. Original change's description: > Revert "Implement onMakeClone(const SkFontArguments& args) in class SkTypeface_fontconfig." > > This reverts commit 96b1ecc25d00a3d52dcc51a788b0df0acdd1dad9. > > Reason for revert: Breaking Google3, I think > > Original change's description: > > Implement onMakeClone(const SkFontArguments& args) in class SkTypeface_fontconfig. > > > > Create FontMgrFontConfigTest.cpp file to test the above function. > > > > Change-Id: I7716355f702af3d6f25574305914f0b82a4147ce > > Reviewed-on: https://skia-review.googlesource.com/137133 > > Reviewed-by: Ben Wagner <bungeman@google.com> > > Commit-Queue: Ben Wagner <bungeman@google.com> > > TBR=bungeman@google.com,herb@google.com,brucewang@google.com > > Change-Id: I665de46d379f1b533358f0be644814aa4bfffb33 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/137240 > Reviewed-by: Kevin Lubick <kjlubick@google.com> > Commit-Queue: Kevin Lubick <kjlubick@google.com> TBR=bungeman@google.com,herb@google.com,kjlubick@google.com,brucewang@google.com Change-Id: I41f0e4505ed0579a77a56212898e9a6caf6f1ed5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/137260 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Revert "Implement onMakeClone(const SkFontArguments& args) in class ↵Gravatar Kevin Lubick2018-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | SkTypeface_fontconfig." This reverts commit 96b1ecc25d00a3d52dcc51a788b0df0acdd1dad9. Reason for revert: Breaking Google3, I think Original change's description: > Implement onMakeClone(const SkFontArguments& args) in class SkTypeface_fontconfig. > > Create FontMgrFontConfigTest.cpp file to test the above function. > > Change-Id: I7716355f702af3d6f25574305914f0b82a4147ce > Reviewed-on: https://skia-review.googlesource.com/137133 > Reviewed-by: Ben Wagner <bungeman@google.com> > Commit-Queue: Ben Wagner <bungeman@google.com> TBR=bungeman@google.com,herb@google.com,brucewang@google.com Change-Id: I665de46d379f1b533358f0be644814aa4bfffb33 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/137240 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-06-22
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/09ac15a0e9da9cf8f2c22320968f21544a0b25f0 gitattr_checker: Add tests for the cache. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id97dcb6e13f76a4ddf6e556b7bc8101523b3ff7b Reviewed-on: https://skia-review.googlesource.com/137199 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll third_party/externals/swiftshader 932640b2d9cd..41b7748432ef (1 commits)Gravatar swiftshader-skia-autoroll2018-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader.git/+log/932640b2d9cd..41b7748432ef git log 932640b2d9cd..41b7748432ef --date=short --no-merges --format='%ad %ae %s' 2018-06-22 sugoi@google.com Memory leak fix Created with: gclient setdep -r third_party/externals/swiftshader@41b7748432ef The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader TBR=kjlubick@google.com Change-Id: I852adcefdd38d5325c461eb6b49ba2e0e0196ebf Reviewed-on: https://skia-review.googlesource.com/137144 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* ccpr: Cache paths with >=50% visibilityGravatar Chris Dalton2018-06-22
| | | | | | | | | | | | | Adds a hit count to cache entries. Paths now don't get stashed until their second hit (and cached on their third). Mostly-visible, cachable paths render their entire mask on the second hit, in hopes that we will be able to cache them alongside the fully visible ones. Bug: skia: Change-Id: Idd18f5dc3090f13531f630d229f4808198695fea Reviewed-on: https://skia-review.googlesource.com/136541 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* renamed samplecode/Nima to samplecode/SampleNimaActorGravatar Ruiqi Mao2018-06-22
| | | | | | | | Bug: skia: Change-Id: I305ca837d5ed35df4b519e7283201f0a0f87b1c3 Reviewed-on: https://skia-review.googlesource.com/136636 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ruiqi Mao <ruiqimao@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-06-22
| | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/568b7a8998b127cb5e34149cd63e9b16fe823a40 Wipe out shallow checkout support from bot_update. (tandrii@chromium.org) https://crrev.com/565fa6a4078091814163e8449609619953545947 Revert "Wipe out shallow checkout support from bot_update." (tandrii@chromium.org) https://crrev.com/612d62d0cacf15e89fb9bd14f10ab91c9adde442 Revert "bot_update: Don't force solutions to be unmanaged." (tandrii@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I6e9ab41d376e8ef2e4360b2befb729b91807c8db Reviewed-on: https://skia-review.googlesource.com/137196 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Presubmit: blacklist .recipe_depsGravatar Eric Boren2018-06-22
| | | | | | | | Bug: skia: Change-Id: Ibadcc3bf18510e767609374641859f505e56a21c Reviewed-on: https://skia-review.googlesource.com/137195 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Make fontmgr_bounds change with veryVerboseGravatar Ben Wagner2018-06-22
| | | | | | | | | | | When using the --veryVerbose command line flag, make the fontmgr_bounds gm label each box with the name of the typeface and the glyph ids used for each extrema. Change-Id: Icf029366e51688cb4be1a3369f6d24bcba8386aa Reviewed-on: https://skia-review.googlesource.com/137190 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-06-22
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/c48318a35b173ee25ca65de6910b88e918b84dec bot_update: Don't force solutions to be unmanaged. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib6e17f1e8658ad7a7f7e685bbbdaf9590bd9493d Reviewed-on: https://skia-review.googlesource.com/137185 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* ccpr: Recycle the stashed atlas's texture explicitlyGravatar Chris Dalton2018-06-22
| | | | | | | | | | This solution is more future-proof. Bug: skia: Change-Id: Ifa437a511336282d73befddea2656f3fcdb3f2ef Reviewed-on: https://skia-review.googlesource.com/136964 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Roll third_party/externals/swiftshader a9969b2ab8c3..932640b2d9cd (1 commits)Gravatar swiftshader-skia-autoroll2018-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader.git/+log/a9969b2ab8c3..932640b2d9cd git log a9969b2ab8c3..932640b2d9cd --date=short --no-merges --format='%ad %ae %s' 2018-06-22 sugoi@google.com Std:unordered_map removed from Optimizer for improved performance Created with: gclient setdep -r third_party/externals/swiftshader@932640b2d9cd The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader TBR=kjlubick@google.com Change-Id: I9ecdc0e8048ba0624c100e528b7b11f30b71ade6 Reviewed-on: https://skia-review.googlesource.com/137143 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Implement onMakeClone(const SkFontArguments& args) in class ↵Gravatar Bruce Wang2018-06-22
| | | | | | | | | | | SkTypeface_fontconfig. Create FontMgrFontConfigTest.cpp file to test the above function. Change-Id: I7716355f702af3d6f25574305914f0b82a4147ce Reviewed-on: https://skia-review.googlesource.com/137133 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Upgrade MacOS on Skolo bots.Gravatar Ben Wagner2018-06-22
| | | | | | | | | These include MacBook10.1 and MacBookAir7.2. Change-Id: I5d90f0c95a2d0199ec498dda7ad70064bb98aa22 Reviewed-on: https://skia-review.googlesource.com/135328 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Use the correct paint from the looperGravatar Herb Derby2018-06-22
| | | | | | | Change-Id: I7e17c25a66d873c4988050a4a1bb135ec6fa4300 Reviewed-on: https://skia-review.googlesource.com/137137 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Remove include/ports/SkFontMgr.hGravatar Ben Wagner2018-06-22
| | | | | | | | | | | The SkFontMgr.h header has been moved to core/SkFontMgr.h and the ports/SkFontMgr.h header is simply a forwarding header. Remove the forwarding header now that users have been updated. Change-Id: Icecef2ecb3ac20fc2c885429b06cdb306524303d Reviewed-on: https://skia-review.googlesource.com/137130 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Roll third_party/externals/swiftshader bf8fd5b5fb68..a9969b2ab8c3 (1 commits)Gravatar swiftshader-skia-autoroll2018-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader.git/+log/bf8fd5b5fb68..a9969b2ab8c3 git log bf8fd5b5fb68..a9969b2ab8c3 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 capn@google.com Newly load sibling library from the same directory. Created with: gclient setdep -r third_party/externals/swiftshader@a9969b2ab8c3 The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader TBR=kjlubick@google.com Change-Id: I3aa94b1e234aae1e2e42d1e08c0338c9afffe88b Reviewed-on: https://skia-review.googlesource.com/137141 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* GrTessellator: avoid split with zero primary and out-of-range secondary.Gravatar Stephen White2018-06-22
| | | | | | | | | | | | | | Sometimes the intersector will return an intersection which is on the same primary sort criterion (eg., Y coordinate), but out-of-range on the secondary. We shouldn't do splits in this case. The only case we really care about is if it's less than one epsilon and greater than zero, and thus numerically unsplittable. Bug: 851914 Change-Id: Ia772763b6a66a14ca159cf409a832835244e83bc Reviewed-on: https://skia-review.googlesource.com/136803 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Add SkGlyphRunList - v2Gravatar Herb Derby2018-06-22
| | | | | | | | | | | | | | Extend the glyph run system with a glyph run list. This allows the processing of text blobs. Add original text an cluster to runs for PDF. PS - the original had read off the end of a buffer problem. Change-Id: I9430f0c27aaa3d9458bfe3caba5f433b72fdf84c Reviewed-on: https://skia-review.googlesource.com/136792 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/04925ac3f7e50988945be3a5655198736a8b3e58 chromite_wrapper: add python3 support for except (sjg@chromium.org) https://crrev.com/4099daa97b38b2ddb95e34d9fc3e2d37f58df069 gclient: Use posixpath-style separators for cipd subdirs on all platforms. (jbudorick@chromium.org) https://crrev.com/eb5f85b13255cd995b813e7efe5a5f22fd687b0d Fix minor regression in git_upstream_diff. (iannucci@chromium.org) https://crrev.com/124365b8ea553111c78af62c0d7455423a2238e5 bot_update: default to non-shallow checkouts. (tandrii@chromium.org) https://crrev.com/f7e1e10db5f949dead75f907934aba0a4dfd8b3d cpplint: Pull in upstream changes (ahassani@google.com) https://crrev.com/87b879edf86506b63d86895cb1bfbbd60d305fef Stop checking CIPD packages exist on linux-386. (vadimsh@chromium.org) https://crrev.com/e42137040a01272ae4c515aad3894221abc84b0f gclient: Make gclient respect unmanaged dependencies when syncing. (ehmaldonado@chromium.org) https://crrev.com/09098853e1073dadc74e18451479b82c0c398164 Demote linux-386 to "best effort support", just like e.g. linux-ppc64. (vadimsh@chromium.org) https://crrev.com/120b2e4f2660a4c583996d5334cff1fc65c251f0 Add gerrit retries for HTTP 409 Conflict responses. (mmoss@google.com) https://crrev.com/7999d926809fdb560e58012dddd74b235ea1d99a Revert "cpplint: Pull in upstream changes" (sergiyb@chromium.org) https://crrev.com/c5a26a769e69377391ed9bf71ca74d7eae5e6717 [win-cross] Support using a zip file for the Windows SDK (hferreiro@igalia.com) recipe_engine: https://crrev.com/0e71eb80de4e88898496b6dcc752ca9554c0433c Remove all bootstrapping logic from recipe engine. (iannucci@chromium.org) https://crrev.com/59ce6b333bae640882c70e5eb79a3f37662925f4 Do not rely on recipes.py to update recipe_engine. (iannucci@chromium.org) https://crrev.com/76d8765a8b0b0f8702de49231b7f3eba66970afc Prune more evidence of VPython from the environment. (iannucci@chromium.org) https://crrev.com/94bb0a758456a5df6891677a8cf2876c07ea5f0c Fix typo in autoroll code. (iannucci@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I624e5cdf4949dba4509d74ce51166fc10f7622d8 Reviewed-on: https://skia-review.googlesource.com/137129 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Fix pylint check in presubmitGravatar Eric Boren2018-06-22
| | | | | | | | | | | | | | | | | | | This fixes the unexpected behavior where we only run pylint over the affected Python files *unless* there are affected Python files which we have explicitly blacklisted, in which case we run pylint over ALL Python files in every subdirectory of the Skia checkout, including repos in DEPS. - Added buildtools and common to the blacklist. - Changed to run pylint over all Python files in Skia, like presubmit_support expects. - Fix existing pylint problems. Bug: skia: Change-Id: Ife1321f5ae5eaff2a28cc14c99a82a0716c12677 Reviewed-on: https://skia-review.googlesource.com/137126 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Roll third_party/externals/swiftshader 050ef946947a..bf8fd5b5fb68 (1 commits)Gravatar swiftshader-skia-autoroll2018-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader.git/+log/050ef946947a..bf8fd5b5fb68 git log 050ef946947a..bf8fd5b5fb68 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 capn@google.com Support Sanitizer builds with CMake. Created with: gclient setdep -r third_party/externals/swiftshader@bf8fd5b5fb68 The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader TBR=kjlubick@google.com Change-Id: I24e33a3e7be1f2fe0a2fc76de533f21df70b034e Reviewed-on: https://skia-review.googlesource.com/136920 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/angle2 3237f75953c1..5bdf8bd1cf56 (6 commits)Gravatar angle-skia-autoroll2018-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/3237f75953c1..5bdf8bd1cf56 git log 3237f75953c1..5bdf8bd1cf56 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 lucferron@chromium.org Vulkan: enable the rest of dEQP tests in fbo.render.* 2018-06-21 rafael.cintron@microsoft.com Replace reinterpret_cast with safer or no cast 2018-06-21 lucferron@chromium.org Vulkan: Mask the alpha channel for draw when needed 2018-06-21 oetuaho@nvidia.com Use ImmutableString instead of TString in QualifierTypes 2018-06-21 jmadill@chromium.org Vulkan: Add struct sampler parsing. 2018-06-21 jmadill@chromium.org Vulkan: Handle embedded struct uniforms. Created with: gclient setdep -r third_party/externals/angle2@5bdf8bd1cf56 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=kjlubick@google.com Change-Id: I2d862ab431398311a23fdfc56420b0de726606a4 Reviewed-on: https://skia-review.googlesource.com/136820 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* [skottie] Ensure static split-position properties are committedGravatar Florin Malita2018-06-22
| | | | | | | | | | | We currently drop static split-position adapters without commiting the value to the scene graph. TBR= Change-Id: Id5852da35345fa58ecaf6c752456ecb32e5b405a Reviewed-on: https://skia-review.googlesource.com/136782 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Whitespace change to trigger flutter rollerGravatar Ravi Mistry2018-06-22
| | | | | | | | | | No-Tree-Checks: true No-Try: true Bug: skia: Change-Id: I32bc42bee181e44b32fe28465873133e8ea50276 Reviewed-on: https://skia-review.googlesource.com/135702 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Alternative fix for stale MIP maps on texture export/import.Gravatar Brian Salomon2018-06-21
| | | | | | | | | | | | | | | | | This change assumes imported textures in SkImages have dirty mip levels and disables regenerating the MIP levels on export (added in https://skia.googlesource.com/skia/+/930f939c48af1be6005af12bb6f709ca5da9d118). This is being done temporarily because it is a simpler change to cherry pick to earlier branches than https://skia.googlesource.com/skia/+/930f939c48af1be6005af12bb6f709ca5da9d118 Bug: chromium:850617 Change-Id: I7c90da782a0ed9014acd6a54ffdee1a0b34fa00c Reviewed-on: https://skia-review.googlesource.com/136788 Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Revert "SkRefCnt, SkTypes: fix includes for clients"Gravatar Ben Wagner2018-06-21
| | | | | | | | | | | | | | | | | | | | | This reverts commit 61582510eeb8484ad3e12df97bf781a3129f60d0. Reason for revert: Chromium should now be fixed. Original change's description: > SkRefCnt, SkTypes: fix includes for clients > > Change-Id: I1cfdc03963eaab9687608974958d20411806cfeb > Reviewed-on: https://skia-review.googlesource.com/136592 > Commit-Queue: Hal Canary <halcanary@google.com> > Reviewed-by: Hal Canary <halcanary@google.com> TBR=halcanary@google.com Change-Id: I1a3588ed9e19ee5884f8a907abcfc2aa00cfe5e9 Reviewed-on: https://skia-review.googlesource.com/136700 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Revert "Add SkGlyphRunList"Gravatar Herb Derby2018-06-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f2e4a039df33d9246bd0ec68602d4d06e6199553. Reason for revert: Breaks asan tests Original change's description: > Add SkGlyphRunList > > Extend the glyph run system with a glyph run list. This > allows the processing of text blobs. > > Add original text an cluster to runs for PDF. > > Change-Id: If4867d000e45f8975a30e982fc8fdbe104ef4332 > Reviewed-on: https://skia-review.googlesource.com/135627 > Reviewed-by: Ben Wagner <bungeman@google.com> > Commit-Queue: Herb Derby <herb@google.com> TBR=bungeman@google.com,herb@google.com Change-Id: I903592714da901383efc7e5f47ce3dfd529e2aca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/136761 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Use local strike caches to avoid flaky test behaviorGravatar Herb Derby2018-06-21
| | | | | | | | | | | | | | The remote glyph cache tests assume that the strike cache will not change during a test. This is not true because other test also mutate the strike cache. This is causing flaky tests. BUG=skia:8091 Change-Id: I397d411f9412006715f6860941dfb05ad54ae1b6 Reviewed-on: https://skia-review.googlesource.com/136741 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Make SkStrikeCache::Validate call non global versionGravatar Herb Derby2018-06-21
| | | | | | | | | | | | Change Validate to ValidateGlyphCacheDataSize. Make it call a non-global version. BUG=skia:8091 Change-Id: Iec31a06569a0ab1ec318e693e699a808eb9ad247 Reviewed-on: https://skia-review.googlesource.com/136638 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Roll skia/third_party/skcms 78ef7c5c81fb..97bcdb1d73a1 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-06-21
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/78ef7c5c81fb..97bcdb1d73a1 2018-06-21 brianosman@google.com Add support for Alpha8, Gray8, and 4444 pixel formats The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=kjlubick@google.com Change-Id: I0f7ec97e88bd17fbee65c825c60da2044dfece8c Reviewed-on: https://skia-review.googlesource.com/136665 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Add SkGlyphRunListGravatar Herb Derby2018-06-21
| | | | | | | | | | | | Extend the glyph run system with a glyph run list. This allows the processing of text blobs. Add original text an cluster to runs for PDF. Change-Id: If4867d000e45f8975a30e982fc8fdbe104ef4332 Reviewed-on: https://skia-review.googlesource.com/135627 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Revert "[infra] Enable retries for Windows compiles"Gravatar Ben Wagner2018-06-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c2a887031691c675cc519347258019f45ceb555c. Reason for revert: Issue causing flakiness has been resolved. Original change's description: > [infra] Enable retries for Windows compiles > > They're flaky due to https://github.com/golang/go/issues/21376 > > Bug: skia: > Change-Id: Ic629c84b72c492b35d393328aa2178762ce3c7d8 > Reviewed-on: https://skia-review.googlesource.com/123932 > Reviewed-by: Ravi Mistry <rmistry@google.com> > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Eric Boren <borenet@google.com> TBR=borenet@google.com,mtklein@google.com,rmistry@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia: Change-Id: Ieaae0be9796e61ca8f4265198687e847afa853aa Reviewed-on: https://skia-review.googlesource.com/136633 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix vulkan copy resolve.Gravatar Greg Daniel2018-06-21
| | | | | | | | Bug: skia: Change-Id: I4ea72e05ddf307f1fff042fa5f5ddda019129566 Reviewed-on: https://skia-review.googlesource.com/136243 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Roll third_party/externals/swiftshader 20eea3cd3b2d..050ef946947a (1 commits)Gravatar swiftshader-skia-autoroll2018-06-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader.git/+log/20eea3cd3b2d..050ef946947a git log 20eea3cd3b2d..050ef946947a --date=short --no-merges --format='%ad %ae %s' 2018-06-21 enne@chromium.org Expose suffixed versions of VertexAttribDivisor Created with: gclient setdep -r third_party/externals/swiftshader@050ef946947a The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader TBR=kjlubick@google.com Change-Id: I731e6fffb5f807358a0b1b9a398f2c4520d23e28 Reviewed-on: https://skia-review.googlesource.com/136640 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* make includes available for flutterGravatar Cary Clark2018-06-21
| | | | | | | | | | | | | | | | | | temporarily copy SkBase64.h until flutter can move to using the one in include/util Copy TRACE_EVENT_PHASE_* into its own file in include/util; the only part of SkTraceEventCommon.h that flutter needs. R=reed@google.com,chinmaygarde@google.com Bug: skia:7741 Change-Id: I8671edbf1d6b6b868bde98aa9ad04abcb85a43a0 Reviewed-on: https://skia-review.googlesource.com/135870 Reviewed-by: Chinmay Garde <chinmaygarde@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>