aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Roll skia/third_party/externals/angle2/ 0c37100df..c6faa9745 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/0c37100dfc68..c6faa9745f88 $ git log 0c37100df..c6faa9745 --date=short --no-merges --format='%ad %ae %s' 2017-12-20 ynovikov Skip UniformBufferTest.SimpleBindingChange on Mac NVIDIA GL Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=csmartdalton@google.com Change-Id: I124f93e2c9d63de915387c43013cc5160f6c6540 Reviewed-on: https://skia-review.googlesource.com/88241 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Revert "CCPR: Initial semi-optimized vertex shader Impl"Gravatar Chris Dalton2017-12-20
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a8f6aef13d0592305e05baf19ee724f31a53b466. Reason for revert: Intel driver crash Original change's description: > CCPR: Initial semi-optimized vertex shader Impl > > Bug: skia: > Change-Id: If22f47a3b945ce7336f8e609c2e0c911f09e1d18 > Reviewed-on: https://skia-review.googlesource.com/86820 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Chris Dalton <csmartdalton@google.com> TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com Change-Id: Ibb244d7de64021a8f2055c74e4ff61cbf3252ae8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/88240 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Revert "CCPR: Initial semi-optimized vertex shader Impl"Gravatar Brian Osman2017-12-20
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a8f6aef13d0592305e05baf19ee724f31a53b466. Reason for revert: Looks to failing on ANGLE bots Original change's description: > CCPR: Initial semi-optimized vertex shader Impl > > Bug: skia: > Change-Id: If22f47a3b945ce7336f8e609c2e0c911f09e1d18 > Reviewed-on: https://skia-review.googlesource.com/86820 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Chris Dalton <csmartdalton@google.com> TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com Change-Id: Ic5a73434cba4246a72790db2c27d06e7a50f389a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/88220 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Switch CQ from IntelIris540 to 640 for Ubuntu bot.Gravatar Ben Wagner2017-12-20
| | | | | | | Change-Id: I587be7c5e5da175e1f5f165511cbd14308cb9a95 Reviewed-on: https://skia-review.googlesource.com/87721 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Roll skia/third_party/externals/angle2/ 26143fdd0..0c37100df (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/26143fdd0f82..0c37100dfc68 $ git log 26143fdd0..0c37100df --date=short --no-merges --format='%ad %ae %s' 2017-12-13 oetuaho Always create TFunctions for function call nodes Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=csmartdalton@google.com Change-Id: I8d93b433456af322f490d64af1bd079848d9a66c Reviewed-on: https://skia-review.googlesource.com/88063 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* CCPR: Initial semi-optimized vertex shader ImplGravatar Chris Dalton2017-12-20
| | | | | | | | Bug: skia: Change-Id: If22f47a3b945ce7336f8e609c2e0c911f09e1d18 Reviewed-on: https://skia-review.googlesource.com/86820 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* removed extraneous unused uniform handles for SkSL samplersGravatar Ethan Nicholas2017-12-20
| | | | | | | | Bug: skia: Change-Id: I11fc3c0d5304b9b308ee5f3a6f8023542ebfd133 Reviewed-on: https://skia-review.googlesource.com/87790 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* remove unused willPlayBackBitmaps from pictureGravatar Mike Reed2017-12-20
| | | | | | | | | | | and SkPictureAnalyzer Bug: skia: Change-Id: I394eca648234b1a69e6f9a0a88c407366a33d079 Reviewed-on: https://skia-review.googlesource.com/87791 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* converted GrRRectBlurEffect to SkSLGravatar Ethan Nicholas2017-12-20
| | | | | | | | Bug: skia: Change-Id: Ifd192db07e02d69d445277a361760ce4a452f603 Reviewed-on: https://skia-review.googlesource.com/87441 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* SkRegion: validate_run() checks for overflowGravatar Hal Canary2017-12-20
| | | | | | | | Change-Id: I9ffe9bcc5a59252e45b05b73b96912caf7da5c8b Reviewed-on: https://skia-review.googlesource.com/87766 Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Guard the sqrt(temp) where temp < 0 in 2pt conical gradientGravatar Yuqian Li2017-12-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Although Linux and Android will return NAN, iOS and some some Win10 devices would return undefined values. This relands 82161 (with the fix mentioned above). The speedup is a little less due to the additional temp < 0 check. 4.08% faster in gradient_conicalOutZero_clamp 6.83% faster in gradient_conical_clamp_shallow_dither 9.43% faster in gradient_conicalOutZero_clamp_3color 12.66% faster in gradient_conicalOut_clamp_hicolor 16.67% faster in gradient_conicalOut_clamp_3color 17.83% faster in gradient_conicalOut_clamp and the speedup is further reduced because we break up the if with two conditions into two ifs with single condition: 7.32% faster in gradient_conical_clamp_shallow_dither 8.00% faster in gradient_conicalOut_clamp_hicolor 8.57% faster in gradient_conicalOut_clamp 8.73% faster in gradient_conicalOut_clamp_3color CQ_INCLUDE_TRYBOTS=skia.primary:Test-Android-Clang-Nexus7-GPU-Tegra3-arm-Release-All-Android,Test-Android-Clang-Nexus7-GPU-Tegra3-arm-Debug-All-Android,Test-Mac-Clang-MacMini7.1-GPU-IntelIris5100-x86_64-Debug-All-CommandBuffer Change-Id: I41fb8d97e31c577b52a200f0b883591c9bdc4d1c Reviewed-on: https://skia-review.googlesource.com/84963 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* make InternalOnly_ functions actually privateGravatar Mike Reed2017-12-20
| | | | | | | | Bug: skia: Change-Id: Id06ad4283a0cd9835b3349c783b705b30435855a Reviewed-on: https://skia-review.googlesource.com/87980 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkQP: better error report workflowGravatar Hal Canary2017-12-20
| | | | | | | | | | | | * Generate report in app after running all tests. * Add script to unpack backup.ab file. * Remove unused index file. * Streamline instructions in README.md. Change-Id: I44c80b17332eb4496ee31578287b691bd646d71a Reviewed-on: https://skia-review.googlesource.com/86742 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
* remove unused setterGravatar Mike Reed2017-12-20
| | | | | | | | Bug: skia: Change-Id: I72340b4e11c9f2b53632baa4ab2d524e29be58f6 Reviewed-on: https://skia-review.googlesource.com/87960 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* long rect dash fix with guardsGravatar Cary Clark2017-12-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | long rect dash with guards check dash fix back in with guards against changing chrome layout test results original change clipped against wrong rectangle some of the time, causing tiled drawing to fail. Always clip against outset rectangle. original CL: skia-review.googlesource.com/c/skia/+/84862 efficiently dash very large rectangles and very long lines Speed up dashing when lines and rects are absurdly large. Prior to this CL, only horizontal lines were detected. Also folded in a change to handle dashing of zero length lines. TBR=egdaniel@google.com Bug: skia:7311 Change-Id: Ic3c68ec8ea35d0597c892c3b26ba7bb077045990 Reviewed-on: https://skia-review.googlesource.com/87768 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* Make GrRenderTargetContext::drawPath() use GrShape to identify simplerGravatar Brian Salomon2017-12-20
| | | | | | | | | geometries. Change-Id: I24230efc8bcb60f00c0c855090e3311ad13d7da8 Reviewed-on: https://skia-review.googlesource.com/85962 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Roll skia/third_party/externals/angle2/ 89c422adb..26143fdd0 (2 commits)Gravatar angle-deps-roller@chromium.org2017-12-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/89c422adb41e..26143fdd0f82 $ git log 89c422adb..26143fdd0 --date=short --no-merges --format='%ad %ae %s' 2017-11-01 xinghua.cao ES31: Support bindImageTexture on Texture2D for compute shaders on D3D 2017-12-18 yizhou.jiang Fix addDummyTextureNoRenderTarget workaround memory leak Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=csmartdalton@google.com Change-Id: Ifec45458d7b9d0bf42612e204b1cb7092ac347ff Reviewed-on: https://skia-review.googlesource.com/87921 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Avoid redrawing every time the mouse movesGravatar Brian Osman2017-12-20
| | | | | | | | Bug: skia: Change-Id: Idc74e6c7e50f8d416d716ee666b37b52792c7c4b Reviewed-on: https://skia-review.googlesource.com/87789 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Roll skia/third_party/externals/angle2/ 37385e11d..89c422adb (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/37385e11d383..89c422adb41e $ git log 37385e11d..89c422adb --date=short --no-merges --format='%ad %ae %s' 2017-11-29 xinghua.cao ES31: Support memoryBarrier and memoryBarrierRegion APIs Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=csmartdalton@google.com Change-Id: Ie3aa5b62ff242197310bdc05049c4981c7903c59 Reviewed-on: https://skia-review.googlesource.com/87860 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Init executor in SetCtxOptionsFromCommonFlagsGravatar Chris Dalton2017-12-20
| | | | | | | | Bug: skia: Change-Id: I45501b6e32ac593d5d69c98c1455d9bde01b239f Reviewed-on: https://skia-review.googlesource.com/87603 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Move stats code to new layer (with configurable list of timers)Gravatar Brian Osman2017-12-20
| | | | | | | | Bug: skia: Change-Id: I3ca5c8c7047309983018339ec7b71b9aea5ee786 Reviewed-on: https://skia-review.googlesource.com/86921 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Revert "long rect dash with guards"Gravatar Cary Clark2017-12-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 4ad0c592ce830f17ff07052f20392caa700e9a53. Reason for revert: test fails in tiled case Original change's description: > long rect dash with guards > > check dash fix back in with > guards against changing > chrome layout test results > > original CL: skia-review.googlesource.com/c/skia/+/84862 > > efficiently dash very large rectangles and very long lines > Speed up dashing when lines and rects are absurdly large. > > Prior to this CL, only horizontal lines were detected. > > Also folded in a change to handle dashing of zero length lines. > > TBR=egdaniel@google.com > Bug: skia:7311 > Change-Id: I139b10f676e7ae06ad83aaf2a35d49cf06280a67 > Reviewed-on: https://skia-review.googlesource.com/87760 > Commit-Queue: Cary Clark <caryclark@skia.org> > Reviewed-by: Cary Clark <caryclark@skia.org> TBR=egdaniel@google.com,caryclark@skia.org Change-Id: Ifd35ddf395826a55c72e650470527d01740b6438 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7311 Reviewed-on: https://skia-review.googlesource.com/87841 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
* Revert "forgot to turn off dash test"Gravatar Cary Clark2017-12-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2b974e4be90fe5842a1a510fb8a48d222cfaa89d. Reason for revert: test fails in tiled case Original change's description: > forgot to turn off dash test > > TBR=egdaniel@google.com > NOTRY=true > Bug: skia: > Change-Id: Id1cf3e25d04e5dab8148114c4378abaa49fd67bc > Reviewed-on: https://skia-review.googlesource.com/87761 > Commit-Queue: Cary Clark <caryclark@skia.org> > Reviewed-by: Cary Clark <caryclark@skia.org> TBR=egdaniel@google.com,caryclark@skia.org Change-Id: I40aa957c210dec9367bae6cc1be8ca0a044a31af No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/87840 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
* fuzz/FuzzCanvas: range in inclucive, not half-openGravatar Hal Canary2017-12-20
| | | | | | | | | BUG=skia:7427 Change-Id: Id38e7ed42021a9a4a0c406668d8909e7f47d5ba8 Reviewed-on: https://skia-review.googlesource.com/87765 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* ensure self-consistent parameters for drawtextGravatar Mike Reed2017-12-20
| | | | | | | | Bug: skia:7426 Change-Id: Iea687bc1a03b3428a1648bc75861276cb7e970da Reviewed-on: https://skia-review.googlesource.com/87782 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Handle invalid mode in SkGpuDevice::drawPoints.Gravatar Brian Salomon2017-12-20
| | | | | | | | Bug: skia:7427 Change-Id: I5f63d1c77577942f648fdc1439a9b4338299b033 Reviewed-on: https://skia-review.googlesource.com/87340 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* forgot to turn off dash testGravatar Cary Clark2017-12-20
| | | | | | | | | | TBR=egdaniel@google.com NOTRY=true Bug: skia: Change-Id: Id1cf3e25d04e5dab8148114c4378abaa49fd67bc Reviewed-on: https://skia-review.googlesource.com/87761 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* long rect dash with guardsGravatar Cary Clark2017-12-20
| | | | | | | | | | | | | | | | | | | | | | check dash fix back in with guards against changing chrome layout test results original CL: skia-review.googlesource.com/c/skia/+/84862 efficiently dash very large rectangles and very long lines Speed up dashing when lines and rects are absurdly large. Prior to this CL, only horizontal lines were detected. Also folded in a change to handle dashing of zero length lines. TBR=egdaniel@google.com Bug: skia:7311 Change-Id: I139b10f676e7ae06ad83aaf2a35d49cf06280a67 Reviewed-on: https://skia-review.googlesource.com/87760 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Account for border with small sigma.Gravatar Herb Derby2017-12-20
| | | | | | | | | | | | | | | When sigma is small a very small border is generated, but no actual blurring happens. Copy the image and add the small border instead of just copying the image. Tested by patching into chrome, and observing no shift. BUG=chromium:795528 Change-Id: I9eee74a3155575c747fafc71ace77ed4247bcae5 Reviewed-on: https://skia-review.googlesource.com/87420 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Fix Adobe RGB color space in SkiaGravatar Brian Osman2017-12-20
| | | | | | | | | | | | | | | | Our runtime definition of the XYZ matrix was fairly inaccurate. It also didn't round-trip through ICC fixed point correctly. Now, constructing the color space at runtime produces exactly the same matrix as constructing the space from the ICC profile. And the values can then be serialized back to ICC exactly. This eliminates the need for the snapping logic, too. Bug: skia: Change-Id: I69f4a9bfec3eeef153935e21ab3a0630794b1607 Reviewed-on: https://skia-review.googlesource.com/84840 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
* Add matrix stack to SkAtlasTextTarget.Gravatar Brian Salomon2017-12-20
| | | | | | | | | Makes SkAtlasTextRenderer::SDFVertex now has a 3 component position vector. Change-Id: I7ec1a8068fb84388a82e1748d6e9d02820d55abd Reviewed-on: https://skia-review.googlesource.com/84202 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* Reland "hide unused var"Gravatar Mike Reed2017-12-20
| | | | | | | | | | | | | | | | | This is a reland of 746db42e2c07050d5d0a0db11bfdab441d57e8cd Original change's description: > hide unused var > > Bug: skia: > Change-Id: Ia060e0becd8d40817c59e2918678dbdc6dfd6cdd > Reviewed-on: https://skia-review.googlesource.com/86041 > Reviewed-by: Mike Reed <reed@google.com> Bug: skia: Change-Id: I610ccfec1e1eb7888bd4f16f7d83fded10ccf0af Reviewed-on: https://skia-review.googlesource.com/87720 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* remove bicubic clamp in SkImageShaderGravatar Mike Klein2017-12-20
| | | | | | | | | | | | We ought to be able to handle out-of-gamut colors now, whatever their provenance. Should be we can just not clamp here. Bug: skia:5733 Change-Id: Icd9851543638fd81755afee2eac2347702b88e9f Reviewed-on: https://skia-review.googlesource.com/87000 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* Remove SK_SUPPORT_LEGACY_ICC_PRECISIONGravatar Brian Osman2017-12-20
| | | | | | | | | | | chromium has rebaselined against the new code Bug: skia: Change-Id: I5e13da56ade52e5e0fc61ff01b39953bf1bd7e8c Reviewed-on: https://skia-review.googlesource.com/87300 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Roll isolate binaries generated at infra@2aafb3b.Gravatar Michael McGreevy2017-12-20
| | | | | | | | | | | | | | | | | | | | | | | | Note: I skipped the presubmit when uploading, because I had issues setting up my skia checkout correctly. Roll isolate binaries generated at infra@2aafb3b. Isolate sha1s were taken from the following builds: https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-precise-64/10401 https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-mac-10.10-64/9823 https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-win-64/10680 This cl brings the skia isolate binaries up to date with the main chrome infra setup (see similar cl at https://chromium-review.googlesource.com/c/chromium/src/+/834928). These new versions introduce an "--exparchive" flag for both "isolate archive" and "isolate batcharchive", which will enable the skia isolate recipes to be transitioned away from the "isolate exparchive" command. Change-Id: I535500e678b2c2faa784720d72ae661aa975277f Reviewed-on: https://skia-review.googlesource.com/87500 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* cleanup unused fields/includesGravatar Mike Reed2017-12-20
| | | | | | | | Bug: skia: Change-Id: I30533cf81631a146b729a530c30bd9831fd0ea7d Reviewed-on: https://skia-review.googlesource.com/87660 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Roll skia/third_party/externals/angle2/ ffd27d853..37385e11d (2 commits)Gravatar angle-deps-roller@chromium.org2017-12-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/ffd27d85371b..37385e11d383 $ git log ffd27d853..37385e11d --date=short --no-merges --format='%ad %ae %s' 2017-12-19 oetuaho Emulate tanh on HLSL 2017-12-12 oetuaho Define symbol classes in a separate file Created with: roll-dep skia/third_party/externals/angle2BUG=795269 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=csmartdalton@google.com Change-Id: Ib79386f57da236fe0f2a9c77bf867b785fc75e84 Reviewed-on: https://skia-review.googlesource.com/87620 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* move SkWriteBuffer.h to srcGravatar Mike Reed2017-12-20
| | | | | | | | | | Need this to land first: https://chromium-review.googlesource.com/c/chromium/src/+/834714 Bug: skia: Change-Id: I426bc3d9b5c4382b5b874b991e37fdd1725bd9a3 Reviewed-on: https://skia-review.googlesource.com/87301 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* simple version of serialization for SkTextBlobGravatar Mike Reed2017-12-19
| | | | | | | | Bug: skia: Change-Id: I5c7d6a74ecf6079440fe5fc758e444a16764c7aa Reviewed-on: https://skia-review.googlesource.com/87460 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Roll skia/third_party/externals/angle2/ ca71c75dc..ffd27d853 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/ca71c75dce60..ffd27d85371b $ git log ca71c75dc..ffd27d853 --date=short --no-merges --format='%ad %ae %s' 2017-12-19 jmadill Vulkan: Roll loader and validation layers SDK (1.5/2) Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=csmartdalton@google.com Change-Id: I2f2fae72810c38bf56179d3c4da85f3e588dc089 Reviewed-on: https://skia-review.googlesource.com/87440 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Protect against nans causing infinite recursion in ↵Gravatar Brian Salomon2017-12-19
| | | | | | | | | | GrPathUtils::convertCubicToQuads Bug: skia:7427 Change-Id: I72426574be20cd41981bbb8366bda039443aa606 Reviewed-on: https://skia-review.googlesource.com/87302 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Don't canonicalize empty SkRRects. They stroke differently.Gravatar Brian Salomon2017-12-19
| | | | | | | | | | | | Make insetting greater than width or height collapse to a point/line. SkPath::addRRect() doesn't ignore an empty SkRRect. Change-Id: I933a3419a6d75be534f1d8328faa715772045f67 Reviewed-on: https://skia-review.googlesource.com/85680 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Re-add IntelIris640 Linux bots.Gravatar Ben Wagner2017-12-19
| | | | | | | | | | | | | These were removed in https://skia-review.googlesource.com/c/skia/+/78640 However, we've now decided on the 640 rather than the 540 due to inventory. No-Try: true Change-Id: Icf6db636287e151d3dd3ac74cfddf8f6bd3bea6a Reviewed-on: https://skia-review.googlesource.com/87202 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* macro to handle type-casting for SkFlattenable::DeserializeGravatar Mike Reed2017-12-19
| | | | | | | | Bug: skia: Change-Id: If64f166cc03c32b7423361178d319474be063f19 Reviewed-on: https://skia-review.googlesource.com/87260 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Revert "move homogenous with stride to matrixpriv""Gravatar Brian Salomon2017-12-19
| | | | | | | | | | | | | This reverts commit de71572f650005e36d4fc2fe95fb5677a25ae4f6. Revert "Revert "Transform vertices for distance field glyphs on CPU."" This reverts commit f226e66d75374e370f3ae2c6895bc689670e9e18. Change-Id: I2545afae3beb1d6b14bba056853ed826ae7a4679 Reviewed-on: https://skia-review.googlesource.com/86603 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "efficiently dash very large rectangles and very long lines"Gravatar Cary Clark2017-12-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 1ad81981b0027e96ef0cecd78661ab2c22bdc4aa. Reason for revert: broke chrome layout tests Original change's description: > efficiently dash very large rectangles and very long lines > > Speed up dashing when lines and rects are absurdly large. > > Prior to this CL, only horizontal lines were detected. > > The onOnceBeforeDraw changes are there to make debugging easier. > > Also folded in a change to handle dashing of zero length lines. > > R=​reed@google.com, egdaniel@google.com > Bug: skia:7311 > Change-Id: Ia16fb124c7a78a5cc639e612fae29c879a37da1a > Reviewed-on: https://skia-review.googlesource.com/84862 > Commit-Queue: Cary Clark <caryclark@skia.org> > Reviewed-by: Mike Reed <reed@google.com> TBR=egdaniel@google.com,reed@google.com,caryclark@skia.org Change-Id: I5e8f04c54486f8cd1a931f6cade92feaaa4a7647 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7311 Reviewed-on: https://skia-review.googlesource.com/87282 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
* Revert "disable large rect dash temporarily"Gravatar Cary Clark2017-12-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 54956e158131add01c5166f68e3a115b823fe5f4. Reason for revert: original cl broke chrome layout tests Original change's description: > disable large rect dash temporarily > > fix the build > > TBR:halcanary@google.com > NOTRY=true > Bug: skia:7423 > Change-Id: I362fdf2b56c08111c1feab9ffd72351f2ff16f91 > Reviewed-on: https://skia-review.googlesource.com/87002 > Reviewed-by: Cary Clark <caryclark@skia.org> > Commit-Queue: Cary Clark <caryclark@skia.org> TBR=halcanary@google.com,caryclark@skia.org Change-Id: Ia71118dfb7d59ad9d4962d90f2e9a016b0988d0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7423 Reviewed-on: https://skia-review.googlesource.com/87281 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
* Roll skia/third_party/externals/angle2/ ae4dbf32b..ca71c75dc (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/ae4dbf32ba11..ca71c75dce60 $ git log ae4dbf32b..ca71c75dc --date=short --no-merges --format='%ad %ae %s' 2017-12-15 bryan.bernhart Fix error handling of ID3D11DeviceContext::Map Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=csmartdalton@google.com Change-Id: I5855f6f5d6864f75cd90e3b3d59564d25e046ec1 Reviewed-on: https://skia-review.googlesource.com/87102 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Add findOrMakeStaticBuffer method to GrResourceProviderGravatar Chris Dalton2017-12-19
| | | | | | | | | Bug: skia: Change-Id: Ie47f00bf8542462d719df0d08972794861ec4a2b Reviewed-on: https://skia-review.googlesource.com/86283 Reviewed-by: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Fix alpha contribution to tonal color.Gravatar Jim Van Verth2017-12-19
| | | | | | | | | | | Also adds a tonal color GM, a grayscale mode to shadowutils GM, and animated alpha to SampleAndroidShadows. Bug: skia: Change-Id: I1dcb5cab7e53ffa7a3bf1a07b6ebfed38df1a9ed Reviewed-on: https://skia-review.googlesource.com/85002 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>