| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/523413002/)
Reason for revert:
ws
Original issue's description:
> Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519303002/)
>
> Reason for revert:
> ws
>
> Original issue's description:
> > Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/)
> >
> > Reason for revert:
> > spring break forever
> >
> > Original issue's description:
> > > Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/)
> > >
> > > Reason for revert:
> > > nah
> > >
> > > Original issue's description:
> > > > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
> > > >
> > > > Reason for revert:
> > > > i like the old file better
> > > >
> > > > Original issue's description:
> > > > > moar ws
> > > > >
> > > > > BUG=skia:
> > > > >
> > > > > Committed: https://skia.googlesource.com/skia/+/7a353e9
> > > >
> > > > TBR=mtklein@chromium.org
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=skia:
> > > >
> > > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2
> > >
> > > TBR=mtklein@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56
> >
> > TBR=mtklein@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/2fe2ce41e3e5647c7aead4d76d75f5500f573fde
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c7bee661a1e2b2f3b367bdd2b4176d1921aa69d4
R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/519413002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/519303002/)
Reason for revert:
ws
Original issue's description:
> Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/)
>
> Reason for revert:
> spring break forever
>
> Original issue's description:
> > Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/)
> >
> > Reason for revert:
> > nah
> >
> > Original issue's description:
> > > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
> > >
> > > Reason for revert:
> > > i like the old file better
> > >
> > > Original issue's description:
> > > > moar ws
> > > >
> > > > BUG=skia:
> > > >
> > > > Committed: https://skia.googlesource.com/skia/+/7a353e9
> > >
> > > TBR=mtklein@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2
> >
> > TBR=mtklein@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/2fe2ce41e3e5647c7aead4d76d75f5500f573fde
R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/523413002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/524103002
|
|
|
|
|
|
|
|
|
|
| |
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/520323002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/520023003/)
Reason for revert:
spring break forever
Original issue's description:
> Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/)
>
> Reason for revert:
> nah
>
> Original issue's description:
> > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
> >
> > Reason for revert:
> > i like the old file better
> >
> > Original issue's description:
> > > moar ws
> > >
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/7a353e9
> >
> > TBR=mtklein@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56
R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/519303002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/518333002/)
Reason for revert:
nah
Original issue's description:
> Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
>
> Reason for revert:
> i like the old file better
>
> Original issue's description:
> > moar ws
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/7a353e9
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2
R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/520023003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/518233004/)
Reason for revert:
i like the old file better
Original issue's description:
> moar ws
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7a353e9
R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/518333002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/518233004
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/519583008
|
|
|
|
|
|
|
|
| |
R=robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/523833003
|
|
|
|
|
|
|
|
| |
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/522873005
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/524853004
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/523133002
|
|
|
|
|
|
| |
R=mtklein@google.com
Review URL: https://codereview.chromium.org/519063004
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/518253002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/524643003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/520863002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ensure asserts aren't fired when creating a GrGLPath path from an
empty SkPath. An empty path is valid and has practical use, for
example, as a template path for certain nvpr calls.
BUG=skia:2891
R=bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/522883002
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:2860
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/521623003
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FcPattern uses 'intptr_t elts_offsets' instead of 'FcPatternEltPtr elts'
to reference its elements. Therefore, valgrind suspects possible leaks
on all values, elements, and element lists in FontConfig.
BUG=skia:2879
R=djsollen@google.com, mtklein@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/518903002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=humper@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/521433002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:2860
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/519473003
|
|
|
|
|
|
|
|
| |
R=mtklein@google.com, reed@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/494763004
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=djsollen@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/522803002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/519813002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/520753002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/517183003
|
|
|
|
|
|
|
|
|
|
|
| |
Originally from https://bugzilla.mozilla.org/show_bug.cgi?id=996108, patch by Jeff Muizelaar
R=reed@google.com, reed1
BUG=skia:
Author: george@mozilla.com
Review URL: https://codereview.chromium.org/270263005
|
|
|
|
|
|
|
|
| |
TBR=halcanary, scroggo
Author: reed@google.com
Review URL: https://codereview.chromium.org/518103002
|
|
|
|
|
|
|
|
| |
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/522733003
|
|
|
|
|
|
|
|
|
|
| |
This paves the way for removing the 'fTile' parameter from SkPictureShader (although that should be a different CL). If we like this we could also move to providing an entire cull SkRect.
R=reed@google.com, mtklein@google.com, fmalita@google.com, fmalita@chromium.org
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/513983002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=djsollen@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/519743002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Seems the obvious thing works now.
Ran nanobench,
-----------------------------------------------------
Suppressions used:
count bytes template
586 3530064 libGL.so
-----------------------------------------------------
and dm,
-----------------------------------------------------
Suppressions used:
count bytes template
340 2048160 libGL.so
-----------------------------------------------------
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/517133002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/517123002/)
Reason for revert:
Seems to be triggering assert in blink
SSLUITest.TestRedirectHTTPToBadHTTPS (run #1):
[ RUN ] SSLUITest.TestRedirectHTTPToBadHTTPS
HTTP server started on http://127.0.0.1:58000...
sending server_data: {"host": "127.0.0.1", "port": 58000} (36 bytes)
HTTPS server started on https://127.0.0.1:58009...
sending server_data: {"host": "127.0.0.1", "port": 58009} (36 bytes)
ASSERTION FAILED: info.fAlphaType == m_imageInfo.fAlphaType
../../third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp(78) : virtual bool blink::DecodingImageGenerator::onGetPixels(const SkImageInfo &, void *, size_t, SkPMColor *, int *)
1 0x77eb0d3 blink::DecodingImageGenerator::onGetPixels(SkImageInfo const&, void*, unsigned long, unsigned int*, int*)
2 0x92edddc SkImageGenerator::getPixels(SkImageInfo const&, void*, unsigned long, unsigned int*, int*)
3 0x92adf78 SkDiscardablePixelRef::onNewLockPixels(SkPixelRef::LockRec*)
4 0x9369283 SkPixelRef::lockPixels(SkPixelRef::LockRec*)
5 0x9369433 SkPixelRef::lockPixels()
6 0x9213344 SkBitmap::lockPixels() const
7 0x921ca57 SkAutoLockPixels::SkAutoLockPixels(SkBitmap const&, bool)
8 0x921ad80 SkAutoLockPixels::SkAutoLockPixels(SkBitmap const&, bool)
9 0x92b7125 SkDraw::drawBitmap(SkBitmap const&, SkMatrix const&, SkPaint const&) const
10 0x921f4fb SkBitmapDevice::drawBitmap(SkDraw const&, SkBitmap const&, SkMatrix const&, SkPaint const&)
11 0x921f8c7 SkBitmapDevice::drawBitmapRect(SkDraw const&, SkBitmap const&, SkRect const*, SkRect const&, SkPaint const&, SkCanvas::DrawBitmapRectFlags)
12 0x9288e12 SkCanvas::internalDrawBitmapRect(SkBitmap const&, SkRect const*, SkRect const&, SkPaint const*, SkCanvas::DrawBitmapRectFlags)
13 0x9288ee9 SkCanvas::drawBitmapRectToRect(SkBitmap const&, SkRect const*, SkRect const&, SkPaint const*, SkCanvas::DrawBitmapRectFlags)
Original issue's description:
> Add gamma/sRGB tags to SkImageInfo
>
> requires this CL to land in chrome
> https://codereview.chromium.org/517803002/
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/228b285ba14a6e9b6d1cc95ea1583caab30168a1
R=fmalita@google.com, fmalita@chromium.org, reed@chromium.org
TBR=fmalita@chromium.org, fmalita@google.com, reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/519583004
|
|
|
|
|
|
|
|
| |
R=robertphillips@google.com, reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/506413004
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=djsollen
Author: humper@google.com
Review URL: https://codereview.chromium.org/522703002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=djsollen
Author: humper@google.com
Review URL: https://codereview.chromium.org/518833002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/519763002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/519753002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/517123005
|
|
|
|
|
|
|
|
|
|
|
|
| |
requires this CL to land in chrome
https://codereview.chromium.org/517803002/
BUG=skia:
R=fmalita@google.com, fmalita@chromium.org, reed@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/517123002
|
|
|
|
|
|
|
|
|
|
| |
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/523533002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/511363002/)
Reason for revert:
android builder in chrome reveals the caller using { } initialization for SkImageInfo, which this CL now makes illegal. Will have to fix the call site before I can re-land this
Original issue's description:
> Revert of Revert of add gamma/sRGB to SkImageInfo (patchset #1 of https://codereview.chromium.org/512243002/)
>
> Reason for revert:
> this revert was premature -- the chrome canary I looked at is old, and newer ones were green. So trying again...
>
> Original issue's description:
> > Revert of add gamma/sRGB to SkImageInfo (patchset #4 of https://codereview.chromium.org/514753002/)
> >
> > Reason for revert:
> > breaks linker on chrome -- may need SK_API, but not sure.
> >
> > Original issue's description:
> > > add gamma/sRGB to SkImageInfo
> > >
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/615c369777258231054840a88cdb74c68c382485
> >
> > TBR=bungeman@google.com,bsalomon@google.com
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/dc53701216c0e9f98eacf6c0cda769ebbd200b59
>
> TBR=bungeman@google.com,bsalomon@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/e759a2662273fdf52ebbb3822229945eda317e46
R=bungeman@google.com, bsalomon@google.com
TBR=bsalomon@google.com, bungeman@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/517113002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/513333003/)
Reason for revert:
need to revert the big ImageInfo CL but since this was landed on top of it, I need to revert this guy first.
Original issue's description:
> add SK_API to SkImageInfo
>
> BUG=skia:
> TBR=bungeman
> NOTRY=True
>
> Committed: https://skia.googlesource.com/skia/+/bedec8456ff0ea814ed1bba748a86678f458d063
TBR=
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/518543002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of unrolling blobs in SkCanvas, perform the equivalent ops in
SkBaseDevice.
This depends on https://codereview.chromium.org/511783005/.
R=jvanverth@google.com, reed@google.com, robertphillips@google.com, bsalomon@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/517663003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Scale all images to the nearest rounded integer, and if there's still
any scaling factor left over, pass it on to the subsequent bilerp code.
Should avoid artifacts when tiling scaled images.
Original CL received an LGTM from reed; new version disabled tiling
in the downsamplebitmap GM; I verified that this fixes the issue
we were seeing there on non-neon androids.
BUG=skia:2888
R=reed@android.com
TBR=reed
Author: humper@google.com
Review URL: https://codereview.chromium.org/514383003
|
|
|
|
|
|
|
|
|
|
|
| |
This should make the LSAN bots able to see all our pointers.
BUG=skia:
R=reed@google.com, robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/517073002
|
|
|
|
|
|
|
|
| |
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/517033002
|
|
|
|
|
|
|
|
|
|
|
| |
triggers assert.
BUG=skia:1460
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/517023003
|
|
|
|
|
|
|
|
|
|
|
| |
Works around some garbage bottom rows for certain scaled images. Will land a separate GM that demonstrates.
BUG=skia:
R=mtklein@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/513833003
|