diff options
-rw-r--r-- | src/core/SkGpuBlurUtils.cpp | 49 |
1 files changed, 16 insertions, 33 deletions
diff --git a/src/core/SkGpuBlurUtils.cpp b/src/core/SkGpuBlurUtils.cpp index 0f948082a0..cfd14ee2f6 100644 --- a/src/core/SkGpuBlurUtils.cpp +++ b/src/core/SkGpuBlurUtils.cpp @@ -161,11 +161,10 @@ static sk_sp<GrRenderTargetContext> convolve_gaussian(GrContext* context, Direction direction, int radius, float sigma, - SkIRect* contentRect, + const SkIRect& srcBounds, GrTextureDomain::Mode mode, const SkImageInfo& dstII, - SkBackingFit fit, - int radiusY /* temporarary*/) { + SkBackingFit fit) { SkASSERT(srcRect.width() <= dstII.width() && srcRect.height() <= dstII.height()); GrPixelConfig config = get_blur_config(proxy.get(), dstII.colorSpace()); @@ -185,19 +184,18 @@ static sk_sp<GrRenderTargetContext> convolve_gaussian(GrContext* context, int bounds[2] = { 0, 0 }; SkIRect dstRect = SkIRect::MakeWH(srcRect.width(), srcRect.height()); if (GrTextureDomain::kIgnore_Mode == mode) { - *contentRect = dstRect; convolve_gaussian_1d(dstRenderTargetContext.get(), clip, dstRect, srcOffset, std::move(proxy), direction, radius, sigma, GrTextureDomain::kIgnore_Mode, bounds); return dstRenderTargetContext; } - SkIRect midRect = *contentRect, leftRect, rightRect; + SkIRect midRect = srcBounds, leftRect, rightRect; midRect.offset(srcOffset); SkIRect topRect, bottomRect; if (Direction::kX == direction) { - bounds[0] = contentRect->left(); - bounds[1] = contentRect->right(); + bounds[0] = srcBounds.left(); + bounds[1] = srcBounds.right(); topRect = SkIRect::MakeLTRB(0, 0, dstRect.right(), midRect.top()); bottomRect = SkIRect::MakeLTRB(0, midRect.bottom(), dstRect.right(), dstRect.bottom()); midRect.inset(radius, 0); @@ -206,22 +204,9 @@ static sk_sp<GrRenderTargetContext> convolve_gaussian(GrContext* context, SkIRect::MakeLTRB(midRect.right(), midRect.top(), dstRect.width(), midRect.bottom()); dstRect.fTop = midRect.top(); dstRect.fBottom = midRect.bottom(); - -#ifdef SK_IGNORE_BLUR_IMAGE_FILTER_FIX - *contentRect = dstRect; - if (GrTextureDomain::kClamp_Mode == mode) { - // We need to adjust bounds because we only fill part of the srcRect in x-pass. - contentRect->inset(0, radiusY); - } -#else - contentRect->fLeft = dstRect.fLeft; - contentRect->fTop = midRect.fTop; - contentRect->fRight = dstRect.fRight; - contentRect->fBottom = midRect.fBottom; -#endif } else { - bounds[0] = contentRect->top(); - bounds[1] = contentRect->bottom(); + bounds[0] = srcBounds.top(); + bounds[1] = srcBounds.bottom(); topRect = SkIRect::MakeLTRB(0, 0, midRect.left(), dstRect.bottom()); bottomRect = SkIRect::MakeLTRB(midRect.right(), 0, dstRect.right(), dstRect.bottom()); midRect.inset(0, radius); @@ -230,13 +215,6 @@ static sk_sp<GrRenderTargetContext> convolve_gaussian(GrContext* context, SkIRect::MakeLTRB(midRect.left(), midRect.bottom(), midRect.right(), dstRect.height()); dstRect.fLeft = midRect.left(); dstRect.fRight = midRect.right(); - -#ifndef SK_IGNORE_BLUR_IMAGE_FILTER_FIX - contentRect->fLeft = midRect.fLeft; - contentRect->fTop = dstRect.fTop; - contentRect->fRight = midRect.fRight; - contentRect->fBottom = dstRect.fBottom; -#endif } if (!topRect.isEmpty()) { dstRenderTargetContext->clear(&topRect, 0, GrRenderTargetContext::CanClearFullscreen::kNo); @@ -510,8 +488,8 @@ sk_sp<GrRenderTargetContext> GaussianBlur(GrContext* context, scale_irect_roundout(&srcRect, 1.0f / scaleFactorX, 1.0f / scaleFactorY); if (sigmaX > 0.0f) { dstRenderTargetContext = convolve_gaussian(context, std::move(srcProxy), srcRect, srcOffset, - Direction::kX, radiusX, sigmaX, &localSrcBounds, - mode, finalDestII, xFit, radiusY); + Direction::kX, radiusX, sigmaX, localSrcBounds, + mode, finalDestII, xFit); if (!dstRenderTargetContext) { return nullptr; } @@ -530,13 +508,18 @@ sk_sp<GrRenderTargetContext> GaussianBlur(GrContext* context, } srcRect.offsetTo(0, 0); + localSrcBounds = srcRect; + if (GrTextureDomain::kClamp_Mode == mode) { + // We need to adjust bounds because we only fill part of the srcRect in x-pass. + localSrcBounds.inset(0, radiusY); + } srcOffset.set(0, 0); } if (sigmaY > 0.0f) { dstRenderTargetContext = convolve_gaussian(context, std::move(srcProxy), srcRect, srcOffset, - Direction::kY, radiusY, sigmaY, &localSrcBounds, - mode, finalDestII, yFit, radiusY); + Direction::kY, radiusY, sigmaY, localSrcBounds, + mode, finalDestII, yFit); if (!dstRenderTargetContext) { return nullptr; } |