aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
-rw-r--r--include/core/SkCanvas.h3
-rw-r--r--src/core/SkCanvas.cpp39
2 files changed, 7 insertions, 35 deletions
diff --git a/include/core/SkCanvas.h b/include/core/SkCanvas.h
index ac01fad6b2..e7dac5e145 100644
--- a/include/core/SkCanvas.h
+++ b/include/core/SkCanvas.h
@@ -1261,7 +1261,7 @@ private:
enum {
kMCRecSize = 128, // most recent measurement
kMCRecCount = 8, // common depth for save/restores
- kDeviceCMSize = 176, // most recent measurement
+ kDeviceCMSize = 136, // most recent measurement
};
intptr_t fMCRecStorage[kMCRecSize * kMCRecCount / sizeof(intptr_t)];
intptr_t fDeviceCMStorage[kDeviceCMSize / sizeof(intptr_t)];
@@ -1285,7 +1285,6 @@ private:
void doSave();
void checkForDeferredSave();
- void internalSetMatrix(const SkMatrix& matrix);
friend class SkDrawIter; // needs setupDrawForLayerDevice()
friend class AutoDrawLooper;
diff --git a/src/core/SkCanvas.cpp b/src/core/SkCanvas.cpp
index f2ca15159e..34d6aaa0ab 100644
--- a/src/core/SkCanvas.cpp
+++ b/src/core/SkCanvas.cpp
@@ -115,14 +115,12 @@ struct DeviceCM {
SkPaint* fPaint; // may be null (in the future)
const SkMatrix* fMatrix;
SkMatrix fMatrixStorage;
- SkMatrix fStashedMatrix; // Original CTM; used by imageFilter at saveLayer time
const bool fDeviceIsBitmapDevice;
DeviceCM(SkBaseDevice* device, const SkPaint* paint, SkCanvas* canvas,
- bool conservativeRasterClip, bool deviceIsBitmapDevice, const SkMatrix& stashed)
+ bool conservativeRasterClip, bool deviceIsBitmapDevice)
: fNext(NULL)
, fClip(conservativeRasterClip)
- , fStashedMatrix(stashed)
, fDeviceIsBitmapDevice(deviceIsBitmapDevice)
{
if (NULL != device) {
@@ -530,8 +528,7 @@ SkBaseDevice* SkCanvas::init(SkBaseDevice* device, InitFlags flags) {
SkASSERT(sizeof(DeviceCM) <= sizeof(fDeviceCMStorage));
fMCRec->fLayer = (DeviceCM*)fDeviceCMStorage;
- new (fDeviceCMStorage) DeviceCM(NULL, NULL, NULL, fConservativeRasterClip, false,
- fMCRec->fMatrix);
+ new (fDeviceCMStorage) DeviceCM(NULL, NULL, NULL, fConservativeRasterClip, false);
fMCRec->fTopLayer = fMCRec->fLayer;
@@ -994,22 +991,6 @@ void SkCanvas::internalSaveLayer(const SkRect* bounds, const SkPaint* paint, Sav
#ifndef SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG
flags |= kClipToLayer_SaveFlag;
#endif
- SkLazyPaint lazyP;
- SkImageFilter* imageFilter = paint ? paint->getImageFilter() : NULL;
- SkMatrix stashedMatrix = fMCRec->fMatrix;
- SkMatrix remainder;
- SkSize scale;
- if (imageFilter &&
- !stashedMatrix.isScaleTranslate() && stashedMatrix.decomposeScale(&scale, &remainder)) {
- // We will restore the matrix (which we are overwriting here) in restore via fStashedMatrix
- this->internalSetMatrix(SkMatrix::MakeScale(scale.width(), scale.height()));
- SkAutoTUnref<SkImageFilter> matrixFilter(SkImageFilter::CreateMatrixFilter(
- remainder, SkFilterQuality::kLow_SkFilterQuality, imageFilter));
- imageFilter = matrixFilter.get();
- SkPaint* p = lazyP.set(*paint);
- p->setImageFilter(imageFilter);
- paint = p;
- }
// do this before we create the layer. We don't call the public save() since
// that would invoke a possibly overridden virtual
@@ -1018,7 +999,7 @@ void SkCanvas::internalSaveLayer(const SkRect* bounds, const SkPaint* paint, Sav
fDeviceCMDirty = true;
SkIRect ir;
- if (!this->clipRectBounds(bounds, flags, &ir, imageFilter)) {
+ if (!this->clipRectBounds(bounds, flags, &ir, paint ? paint->getImageFilter() : NULL)) {
return;
}
@@ -1066,7 +1047,7 @@ void SkCanvas::internalSaveLayer(const SkRect* bounds, const SkPaint* paint, Sav
device->setOrigin(ir.fLeft, ir.fTop);
DeviceCM* layer = SkNEW_ARGS(DeviceCM, (device, paint, this, fConservativeRasterClip,
- forceSpriteOnRestore, stashedMatrix));
+ forceSpriteOnRestore));
device->unref();
layer->fNext = fMCRec->fTopLayer;
@@ -1124,10 +1105,6 @@ void SkCanvas::internalRestore() {
SkASSERT(layer == (void*)fDeviceCMStorage);
layer->~DeviceCM();
}
- if (fMCRec) {
- // restore what we smashed in internalSaveLayer
- fMCRec->fMatrix = layer->fStashedMatrix;
- }
}
}
@@ -1355,15 +1332,11 @@ void SkCanvas::concat(const SkMatrix& matrix) {
this->didConcat(matrix);
}
-void SkCanvas::internalSetMatrix(const SkMatrix& matrix) {
+void SkCanvas::setMatrix(const SkMatrix& matrix) {
+ this->checkForDeferredSave();
fDeviceCMDirty = true;
fCachedLocalClipBoundsDirty = true;
fMCRec->fMatrix = matrix;
-}
-
-void SkCanvas::setMatrix(const SkMatrix& matrix) {
- this->checkForDeferredSave();
- this->internalSetMatrix(matrix);
this->didSetMatrix(matrix);
}