diff options
| author |  Mike Klein <mtklein@chromium.org> | 2018-02-06 14:53:47 -0500 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-02-07 00:00:25 +0000 |
| commit | 9a7a2ee5ad8453a985d7d76c1e0ebb50d17fec63 (patch) | |
| tree | 6365e1bc5abaa6daf4f620442e9149e8dfa95490 /tools | |
| parent | fd5a5081d53d16facd315cb0b5d4b9622ba22d9d (diff) | |
remove SkCanvas::kIsOpaque_SaveLayerFlag
This is a performance-only hint that no one but fuzzers
is using. It's even explicitly filtered out in Android.
The fuzzers have noticed they can trick us into allocating
uninitialized memory and treating it as opaque, blending
uninitialized pixels, etc.
Since no one's using this, we can just kill the bit.
Bug: skia:7566, chromium:808830
Change-Id: Id74a85e51bc4d0907b4127eb9ac5b02576f8f0a7
Reviewed-on: https://skia-review.googlesource.com/104441
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/debugger/SkObjectParser.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/tools/debugger/SkObjectParser.cpp b/tools/debugger/SkObjectParser.cpp index 352a01da23..dae2cde92e 100644 --- a/tools/debugger/SkObjectParser.cpp +++ b/tools/debugger/SkObjectParser.cpp @@ -349,9 +349,6 @@ SkString* SkObjectParser::RegionToString(const SkRegion& region) { SkString* SkObjectParser::SaveLayerFlagsToString(SkCanvas::SaveLayerFlags saveLayerFlags) { SkString* mFlags = new SkString("SkCanvas::SaveFlags: "); - if (saveLayerFlags & SkCanvas::kIsOpaque_SaveLayerFlag) { - mFlags->append("kIsOpaque_SaveLayerFlag "); - } if (saveLayerFlags & SkCanvas::kPreserveLCDText_SaveLayerFlag) { mFlags->append("kPreserveLCDText_SaveLayerFlag "); } |