Don't clobber initial transform with SetMatrix.

BUG=skia:2378
R=reed@google.com, mtklein@google.com, robertphillips@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/290883004

git-svn-id: http://skia.googlecode.com/svn/trunk@14778 2bbb7eff-a529-9590-31e7-b0007b416f81

3 files changed, 62 insertions, 25 deletions

diff --git a/tests/RecordDrawTest.cpp b/tests/RecordDrawTest.cpp
index d830aea6e5..b0e55a6fdb 100644
--- a/tests/RecordDrawTest.cpp
+++ b/tests/RecordDrawTest.cpp
@@ -6,6 +6,7 @@
  */
 
 #include "Test.h"
+#include "RecordTestUtils.h"
 
 #include "SkDebugCanvas.h"
 #include "SkRecord.h"
@@ -73,3 +74,32 @@ DEF_TEST(RecordDraw_Culling, r) {
     // If culling weren't working, we'd see 8 commands recorded here.
     REPORTER_ASSERT(r, 5 == clipped.count());
 }
+
+DEF_TEST(RecordDraw_SetMatrixClobber, r) {
+    // Set up an SkRecord that just scales by 2x,3x.
+    SkRecord scaleRecord;
+    SkRecorder scaleCanvas(SkRecorder::kReadWrite_Mode, &scaleRecord, W, H);
+    SkMatrix scale;
+    scale.setScale(2, 3);
+    scaleCanvas.setMatrix(scale);
+
+    // Set up an SkRecord with an initial +20, +20 translate.
+    SkRecord translateRecord;
+    SkRecorder translateCanvas(SkRecorder::kReadWrite_Mode, &translateRecord, W, H);
+    SkMatrix translate;
+    translate.setTranslate(20, 20);
+    translateCanvas.setMatrix(translate);
+
+    SkRecordDraw(scaleRecord, &translateCanvas);
+
+    // When we look at translateRecord now, it should have its first +20,+20 translate,
+    // then a 2x,3x scale that's been concatted with that +20,+20 translate.
+    const SkRecords::SetMatrix* setMatrix;
+    setMatrix = assert_type<SkRecords::SetMatrix>(r, translateRecord, 0);
+    REPORTER_ASSERT(r, setMatrix->matrix == translate);
+
+    setMatrix = assert_type<SkRecords::SetMatrix>(r, translateRecord, 1);
+    SkMatrix expected = scale;
+    expected.postConcat(translate);
+    REPORTER_ASSERT(r, setMatrix->matrix == expected);
+}
diff --git a/tests/RecordOptsTest.cpp b/tests/RecordOptsTest.cpp
index 34229d7a6b..d4ad73931b 100644
--- a/tests/RecordOptsTest.cpp
+++ b/tests/RecordOptsTest.cpp
@@ -6,40 +6,16 @@
  */
 
 #include "Test.h"
+#include "RecordTestUtils.h"
 
 #include "SkRecord.h"
 #include "SkRecordOpts.h"
 #include "SkRecorder.h"
 #include "SkRecords.h"
-
 #include "SkXfermode.h"
 
 static const int W = 1920, H = 1080;
 
-// If the command we're reading is a U, set ptr to it, otherwise set it to NULL.
-template <typename U>
-struct ReadAs {
-    ReadAs() : ptr(NULL), type(SkRecords::Type(~0)) {}
-
-    const U* ptr;
-    SkRecords::Type type;
-
-    void operator()(const U& r) { ptr = &r; type = U::kType; }
-
-    template <typename T>
-    void operator()(const T&) { type = U::kType; }
-};
-
-// Assert that the ith command in record is of type T, and return it.
-template <typename T>
-static const T* assert_type(skiatest::Reporter* r, const SkRecord& record, unsigned index) {
-    ReadAs<T> reader;
-    record.visit<void>(index, reader);
-    REPORTER_ASSERT(r, T::kType == reader.type);
-    REPORTER_ASSERT(r, NULL != reader.ptr);
-    return reader.ptr;
-}
-
 DEF_TEST(RecordOpts_Culling, r) {
     SkRecord record;
     SkRecorder recorder(SkRecorder::kWriteOnly_Mode, &record, W, H);
diff --git a/tests/RecordTestUtils.h b/tests/RecordTestUtils.h
new file mode 100644
index 0000000000..db3f02d3a2
--- /dev/null
+++ b/tests/RecordTestUtils.h
@@ -0,0 +1,31 @@
+#ifndef RecordTestUtils_DEFINED
+#define RecordTestUtils_DEFINED
+
+#include "SkRecord.h"
+#include "SkRecords.h"
+
+// If the command we're reading is a U, set ptr to it, otherwise set it to NULL.
+template <typename U>
+struct ReadAs {
+    ReadAs() : ptr(NULL), type(SkRecords::Type(~0)) {}
+
+    const U* ptr;
+    SkRecords::Type type;
+
+    void operator()(const U& r) { ptr = &r; type = U::kType; }
+
+    template <typename T>
+    void operator()(const T&) { type = U::kType; }
+};
+
+// Assert that the ith command in record is of type T, and return it.
+template <typename T>
+static const T* assert_type(skiatest::Reporter* r, const SkRecord& record, unsigned index) {
+    ReadAs<T> reader;
+    record.visit<void>(index, reader);
+    REPORTER_ASSERT(r, T::kType == reader.type);
+    REPORTER_ASSERT(r, NULL != reader.ptr);
+    return reader.ptr;
+}
+
+#endif//RecordTestUtils_DEFINED