diff options
author | Florin Malita <fmalita@chromium.org> | 2017-07-07 12:49:29 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-07-08 21:47:36 +0000 |
commit | 8d1fc16ba6161afc1174e29e30bae4fc9939264f (patch) | |
tree | 7ab2f7de4ac4a4ed17d4705f7deae7ab265ade36 /src/core | |
parent | 8fe24272fa6d2fa9eb2458221ed9852d6ec16f56 (diff) |
More SkColorSpaceXformer caching
* apply(SkColorFilter*)
* apply(SkImage*)
Change-Id: I9b55632edd73dbbc5edb8b5ca9bb5bead1131260
Reviewed-on: https://skia-review.googlesource.com/21736
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Diffstat (limited to 'src/core')
-rw-r--r-- | src/core/SkColorSpaceXformer.cpp | 44 | ||||
-rw-r--r-- | src/core/SkColorSpaceXformer.h | 10 |
2 files changed, 39 insertions, 15 deletions
diff --git a/src/core/SkColorSpaceXformer.cpp b/src/core/SkColorSpaceXformer.cpp index 71715add87..6b126a4580 100644 --- a/src/core/SkColorSpaceXformer.cpp +++ b/src/core/SkColorSpaceXformer.cpp @@ -33,8 +33,29 @@ std::unique_ptr<SkColorSpaceXformer> SkColorSpaceXformer::Make(sk_sp<SkColorSpac : nullptr; } +template <typename T> +sk_sp<T> SkColorSpaceXformer::cachedApply(const T* src, Cache<T>* cache, + sk_sp<T> (*applyFunc)(const T*, SkColorSpaceXformer*)) { + if (!src) { + return nullptr; + } + + auto key = sk_ref_sp(const_cast<T*>(src)); + if (auto* xformed = cache->find(key)) { + return sk_ref_sp(xformed->get()); + } + + auto xformed = applyFunc(src, this); + cache->set(std::move(key), xformed); + + return xformed; +} + sk_sp<SkImage> SkColorSpaceXformer::apply(const SkImage* src) { - return src->makeColorSpace(fDst, SkTransferFunctionBehavior::kIgnore); + return this->cachedApply<SkImage>(src, &fImageCache, + [](const SkImage* img, SkColorSpaceXformer* xformer) { + return img->makeColorSpace(xformer->fDst, SkTransferFunctionBehavior::kIgnore); + }); } sk_sp<SkImage> SkColorSpaceXformer::apply(const SkBitmap& src) { @@ -50,22 +71,17 @@ sk_sp<SkImage> SkColorSpaceXformer::apply(const SkBitmap& src) { } sk_sp<SkColorFilter> SkColorSpaceXformer::apply(const SkColorFilter* colorFilter) { - return colorFilter->makeColorSpace(this); + return this->cachedApply<SkColorFilter>(colorFilter, &fColorFilterCache, + [](const SkColorFilter* f, SkColorSpaceXformer* xformer) { + return f->makeColorSpace(xformer); + }); } sk_sp<SkImageFilter> SkColorSpaceXformer::apply(const SkImageFilter* imageFilter) { - if (!imageFilter) { - return nullptr; - } - - if (auto* xformedFilter = fFilterCache.find(imageFilter->fUniqueID)) { - return sk_ref_sp(xformedFilter->get()); - } - - auto xformedFilter = imageFilter->makeColorSpace(this); - fFilterCache.set(imageFilter->fUniqueID, xformedFilter); - - return xformedFilter; + return this->cachedApply<SkImageFilter>(imageFilter, &fImageFilterCache, + [](const SkImageFilter* f, SkColorSpaceXformer* xformer) { + return f->makeColorSpace(xformer); + }); } sk_sp<SkShader> SkColorSpaceXformer::apply(const SkShader* shader) { diff --git a/src/core/SkColorSpaceXformer.h b/src/core/SkColorSpaceXformer.h index fce8d03e43..15701c2317 100644 --- a/src/core/SkColorSpaceXformer.h +++ b/src/core/SkColorSpaceXformer.h @@ -44,7 +44,15 @@ private: sk_sp<SkColorSpace> fDst; std::unique_ptr<SkColorSpaceXform> fFromSRGB; - SkTHashMap<uint32_t, sk_sp<SkImageFilter>> fFilterCache; + template <typename T> + using Cache = SkTHashMap<sk_sp<T>, sk_sp<T>>; + + template <typename T> + sk_sp<T> cachedApply(const T*, Cache<T>*, sk_sp<T> (*)(const T*, SkColorSpaceXformer*)); + + Cache<SkImage > fImageCache; + Cache<SkColorFilter> fColorFilterCache; + Cache<SkImageFilter> fImageFilterCache; }; #endif |