diff options
| author |  msarett <msarett@google.com> | 2016-08-18 14:29:22 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-08-18 14:29:22 -0700 |
| commit | 7fc08585d0d4daada1c8600b6cdef970ee6c2369 (patch) | |
| tree | 0b39ac90f0f21f4496efef50c5fff1aed1f3302c /include/private | |
| parent | 530032a18e373ee673ae96fdbfa1fae6292f8f08 (diff) | |
Revert of Batched implementation of drawLattice() for GPU (patchset #7 id:180001 of https://codereview.chromium.org/2255963002/ )
Reason for revert:
Things drawing weird.
Original issue's description:
> Batched implementation of drawLattice() for GPU
>
> Bechmarks (Nexus 6P):
>
> Src=100x100, Dst=250x250, NumRects=9
> Android 77.7us
> Skia (without patch) 57.2us
> Skia (with patch) 34.7us
>
> Src=100x100, Dst=500x500, NumRects=9
> Android 77.0us
> Skia (without patch) 56.9us
> Skia (with patch) 44.5us
>
> Src=100x100, Dst=1000x1000, NumRects=9
> Android 180us
> Skia (without patch) 96.8us
> Skia (with patch) 70.5us
>
> Src=100x100, Dst=250x250, NumRects=15
> Android 208us
> Skia (without patch) 155us
> Skia (with patch) 55.9us
>
> Src=100x100, Dst=500x500, NumRects=15
> Android 207us
> Skia (without patch) 152us
> Skia (with patch) 63.0us
>
> Src=100x100, Dst=1000x1000, NumRects=15
> Android 233us
> Skia (without patch) 156us
> Skia (with patch) 99.9us
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255963002
>
> Committed: https://skia.googlesource.com/skia/+/93242c4ae50dfcc0d922cdb3ba80bbc7b4bbe93d
TBR=bsalomon@google.com,reed@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2255683004
Diffstat (limited to 'include/private')
| -rw-r--r-- | include/private/SkTArray.h | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/include/private/SkTArray.h b/include/private/SkTArray.h index 1c06bf331a..1fe2c3857c 100644 --- a/include/private/SkTArray.h +++ b/include/private/SkTArray.h @@ -238,19 +238,6 @@ public: } /** - * Version of above that uses the move constructor to set n items. - */ - T* move_back_n(int n, T* t) { - SkASSERT(n >= 0); - this->checkRealloc(n); - for (int i = 0; i < n; ++i) { - new (fItemArray + fCount + i) T(std::move(t[i])); - } - fCount += n; - return fItemArray + fCount - n; - } - - /** * Removes the last element. Not safe to call when count() == 0. */ void pop_back() { |