remove toString

toString may have been used by obsolete debugger only
find out if that is so

R=brianosman@google.com,bsalomon@google.com

Docs-Preview: https://skia.org/?cl=119894
Bug:830651
Change-Id: I737f19b7d3fbc869bea2f443fa3b5ed7c1393ffd
Reviewed-on: https://skia-review.googlesource.com/119894
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>

9 files changed, 2 insertions, 37 deletions

diff --git a/include/core/SkBitmap.h b/include/core/SkBitmap.h
index c4c9dc50a8..8c14a756ca 100644
--- a/include/core/SkBitmap.h
+++ b/include/core/SkBitmap.h
@@ -1246,13 +1246,6 @@ public:
         bool allocPixelRef(SkBitmap* bitmap) override;
     };
 
-    /** Creates string representation of SkBitmap. The representation is read by
-        internal debugging tools.
-
-        @param str  storage for string representation
-    */
-    void toString(SkString* str) const;
-
 private:
     enum Flags {
         kImageIsVolatile_Flag   = 0x02,
diff --git a/include/core/SkColorFilter.h b/include/core/SkColorFilter.h
index e8b09bae9c..eac58471c4 100644
--- a/include/core/SkColorFilter.h
+++ b/include/core/SkColorFilter.h
@@ -138,8 +138,6 @@ public:
         return this->filterColor(SK_ColorTRANSPARENT) != SK_ColorTRANSPARENT;
     }
 
-    virtual void toString(SkString* str) const = 0;
-
     SK_DECLARE_FLATTENABLE_REGISTRAR_GROUP()
     SK_DEFINE_FLATTENABLE_TYPE(SkColorFilter)
 
diff --git a/include/core/SkDrawLooper.h b/include/core/SkDrawLooper.h
index 4280daa4a9..f4b3373dca 100644
--- a/include/core/SkDrawLooper.h
+++ b/include/core/SkDrawLooper.h
@@ -96,7 +96,6 @@ public:
      */
     virtual bool asABlurShadow(BlurShadowRec*) const;
 
-    virtual void toString(SkString* str) const = 0;
     SK_DEFINE_FLATTENABLE_TYPE(SkDrawLooper)
 
 protected:
diff --git a/include/core/SkImage.h b/include/core/SkImage.h
index afcbb89a5b..a7f3e4ab20 100644
--- a/include/core/SkImage.h
+++ b/include/core/SkImage.h
@@ -727,14 +727,6 @@ public:
     */
     sk_sp<SkData> refEncodedData() const;
 
-    /** Appends SkImage description to string, including unique ID, width, height, and
-        whether the image is opaque.
-
-        @param string  storage for description; existing content is preserved
-        @return        string appended with SkImage description
-    */
-    const char* toString(SkString* string) const;
-
     /** Returns subset of SkImage. subset must be fully contained by SkImage dimensions().
         The implementation may share pixels, or may copy them.
 
diff --git a/include/core/SkImageFilter.h b/include/core/SkImageFilter.h
index 70f5513843..e9594b535b 100644
--- a/include/core/SkImageFilter.h
+++ b/include/core/SkImageFilter.h
@@ -97,7 +97,6 @@ public:
             : fRect(rect), fFlags(flags) {}
         uint32_t flags() const { return fFlags; }
         const SkRect& rect() const { return fRect; }
-        void toString(SkString* str) const;
 
         /**
          *  Apply this cropRect to the imageBounds. If a given edge of the cropRect is not
@@ -249,7 +248,8 @@ public:
                                                  SkFilterQuality quality,
                                                  sk_sp<SkImageFilter> input);
 
-    virtual void toString(SkString* str) const = 0;
+    // Deprecated; used only by chrome
+    virtual void toString(SkString* ) const {}
     SK_DEFINE_FLATTENABLE_TYPE(SkImageFilter)
     SK_DECLARE_FLATTENABLE_REGISTRAR_GROUP()
 
diff --git a/include/core/SkMaskFilter.h b/include/core/SkMaskFilter.h
index bd2a20b825..45c5724843 100644
--- a/include/core/SkMaskFilter.h
+++ b/include/core/SkMaskFilter.h
@@ -59,7 +59,6 @@ public:
      */
     sk_sp<SkMaskFilter> makeWithMatrix(const SkMatrix&) const;
 
-    virtual void toString(SkString* str) const = 0;
     SK_DEFINE_FLATTENABLE_TYPE(SkMaskFilter)
 
 private:
diff --git a/include/core/SkMatrix.h b/include/core/SkMatrix.h
index 9733590167..8ba4e1bb28 100644
--- a/include/core/SkMatrix.h
+++ b/include/core/SkMatrix.h
@@ -1575,14 +1575,6 @@ public:
     */
     void dump() const;
 
-    /** Creates string representation of SkMatrix. Floating point values
-        are written with limited precision; it may not be possible to reconstruct
-        original SkMatrix from output.
-
-        @param str  storage for string representation of SkMatrix
-    */
-    void toString(SkString* str) const;
-
     /** Returns the minimum scaling factor of SkMatrix by decomposing the scaling and
         skewing elements.
         Returns -1 if scale factor overflows or SkMatrix contains perspective.
diff --git a/include/core/SkPaint.h b/include/core/SkPaint.h
index 85c2e3b2f7..42a65cc1db 100644
--- a/include/core/SkPaint.h
+++ b/include/core/SkPaint.h
@@ -1598,13 +1598,6 @@ public:
     const SkRect& doComputeFastBounds(const SkRect& orig, SkRect* storage,
                                       Style style) const;
 
-    /** Creates string representation of SkPaint. The representation is read by
-        internal debugging tools.
-
-        @param str  storage for string representation of SkPaint
-    */
-    void toString(SkString* str) const;
-
 private:
     typedef const SkGlyph& (*GlyphCacheProc)(SkGlyphCache*, const char**);
 
diff --git a/include/core/SkPathEffect.h b/include/core/SkPathEffect.h
index 97b48ea503..a85614a9d5 100644
--- a/include/core/SkPathEffect.h
+++ b/include/core/SkPathEffect.h
@@ -145,7 +145,6 @@ public:
 
     virtual DashType asADash(DashInfo* info) const;
 
-    virtual void toString(SkString* str) const = 0;
     SK_DEFINE_FLATTENABLE_TYPE(SkPathEffect)
 
 #ifdef SK_BUILD_FOR_ANDROID_FRAMEWORK