diff options
| author |  egdaniel <egdaniel@google.com> | 2016-07-27 08:03:57 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-07-27 08:03:57 -0700 |
| commit | 735109c24892a95290974c9665527b57b01e5440 (patch) | |
| tree | 9af8307d3bf071ca638d0624365701ab661b184a /gyp | |
| parent | c043324e56a24bbb46aedbfa56fb04c54f52c850 (diff) | |
Add gyp define to enable vulkan debug layers
On Debug vulkan bots, running with the debug layers on seems to be adding
more than an hour to the total running time. Since we suppress any output
on the bots anyways the debug layers are serving no purpose. Thus I am
adding a gyp define to disable the layers on the bot.
With this change, by default when running vulkan in Debug, the debug_layers
will be enabled. The bots should disable the layers. Android framework
should also have them disabled by default.
TBR=djsollen@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003
Review-Url: https://codereview.chromium.org/2185953003
Diffstat (limited to 'gyp')
| -rw-r--r-- | gyp/common.gypi | 7 | ||||
| -rw-r--r-- | gyp/common_variables.gypi | 3 |
2 files changed, 10 insertions, 0 deletions
diff --git a/gyp/common.gypi b/gyp/common.gypi index b8ea389d55..b350963515 100644 --- a/gyp/common.gypi +++ b/gyp/common.gypi @@ -70,6 +70,13 @@ 'SK_VULKAN', ], }, + 'conditions': [ + [ 'skia_vulkan_debug_layers', { + 'configurations': { + 'Debug': { 'defines': [ 'SK_ENABLE_VK_LAYERS' ] }, + }, + }], + ], }], [ 'skia_command_buffer', { 'defines': [ diff --git a/gyp/common_variables.gypi b/gyp/common_variables.gypi index acd187c363..68d5072a32 100644 --- a/gyp/common_variables.gypi +++ b/gyp/common_variables.gypi @@ -83,6 +83,7 @@ 'skia_use_android_framework_defines%': 1, 'skia_use_system_json%': 1, 'skia_vulkan%': 1, + 'skia_vulkan_debug_layers%': 0, }, { 'skia_os%': '<(skia_os)', 'skia_chrome_utils%': 1, @@ -145,6 +146,7 @@ 'skia_pdf%': 1, 'skia_profile_enabled%': 0, 'skia_vulkan%': 0, + 'skia_vulkan_debug_layers%': 1, 'skia_win_debuggers_path%': '', 'skia_shared_lib%': 0, 'skia_force_distance_field_text%': 0, @@ -226,6 +228,7 @@ 'skia_gdi%': '<(skia_gdi)', 'skia_gpu%': '<(skia_gpu)', 'skia_vulkan%': '<(skia_vulkan)', + 'skia_vulkan_debug_layers%': '<(skia_vulkan_debug_layers)', 'skia_win_exceptions%': 0, 'skia_win_ltcg%': '<(skia_is_bot)', 'skia_osx_deployment_target%': '<(skia_osx_deployment_target)', |