From 5f052ae7ae8a757dd919e95e0f1481e08fef749b Mon Sep 17 00:00:00 2001 From: Eric Anderson Date: Wed, 28 Mar 2018 16:58:47 -0700 Subject: protoc-artifacts: Avoid checking out protobuf code It is a bad idea to check out code into the docker image, as it will be out-of-date. It is better to have the image just be the environment, and let any scripts that need source check them out themselves. This fixes #4419 in that it allows the image to build again, albeit users would need to use wget to grab the source of the version of protobuf they wish. --- protoc-artifacts/README.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'protoc-artifacts/README.md') diff --git a/protoc-artifacts/README.md b/protoc-artifacts/README.md index ba3ca018..d11cde5d 100644 --- a/protoc-artifacts/README.md +++ b/protoc-artifacts/README.md @@ -143,7 +143,11 @@ To run the image: $ docker run -it --rm=true protoc-artifacts ``` -The Protobuf repository has been cloned into ``/protobuf``. +To checkout protobuf (run within the container): +``` +$ # Replace v3.5.1 with the version you want +$ wget -O - https://github.com/google/protobuf/archive/v3.5.1.tar.gz | tar xvzp +``` ### Tips for deploying on Windows Under Windows the following error may occur: ``gpg: cannot open tty `no tty': -- cgit v1.2.3