From 13a41246dd9aa6c6a84d436307b933fd4a6ec4a8 Mon Sep 17 00:00:00 2001 From: Thomas Van Lenten Date: Thu, 1 Sep 2016 11:45:50 -0400 Subject: Make Root's +extensionRegistry generation smarter. At generation time, walk the file's dependencies to see what really contains extensions so we can generate more minimal code that only links together the roots that provided extensions. Gets a bunch of otherwise noop code out of the call flow when the roots are +initialized. --- objectivec/Tests/unittest_cycle.proto | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'objectivec/Tests/unittest_cycle.proto') diff --git a/objectivec/Tests/unittest_cycle.proto b/objectivec/Tests/unittest_cycle.proto index 5f6f56a1..afc1b0fe 100644 --- a/objectivec/Tests/unittest_cycle.proto +++ b/objectivec/Tests/unittest_cycle.proto @@ -31,10 +31,8 @@ syntax = "proto2"; package protobuf_unittest; -// Cycles in the Message graph can cause problems for the mutable classes -// since the properties on the mutable class change types. This file just -// needs to generate source, and that source must compile, to ensure the -// generated source works for this sort of case. +// Cycles in the Message graph can cause problems for message class +// initialization order. // You can't make a object graph that spans files, so this can only be done // within a single proto file. -- cgit v1.2.3