From da3ce6717156c8b4f8890207895069ce6b102f65 Mon Sep 17 00:00:00 2001 From: Jon Skeet Date: Thu, 29 Mar 2018 17:13:52 +0100 Subject: Deliberately call simple code to avoid Unity linker pruning The SampleEnumMethod method was previously only called via reflection, so the Unity linker thought it could be removed. Ditto the parameterless constructor in ReflectionHelper. This PR should avoid that issue, reducing the work needed by customers to use Google.Protobuf from Unity. --- .../src/Google.Protobuf/Reflection/ReflectionUtil.cs | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) (limited to 'csharp') diff --git a/csharp/src/Google.Protobuf/Reflection/ReflectionUtil.cs b/csharp/src/Google.Protobuf/Reflection/ReflectionUtil.cs index 1afaa90c..80d5c774 100644 --- a/csharp/src/Google.Protobuf/Reflection/ReflectionUtil.cs +++ b/csharp/src/Google.Protobuf/Reflection/ReflectionUtil.cs @@ -163,6 +163,8 @@ namespace Google.Protobuf.Reflection { try { + PreventLinkerFailures(); + // Try to do the conversion using reflection, so we can see whether it's supported. MethodInfo method = typeof(ReflectionUtil).GetMethod(nameof(SampleEnumMethod)); // If this passes, we're in a reasonable runtime. method.CreateDelegate(typeof(Func)); @@ -174,6 +176,23 @@ namespace Google.Protobuf.Reflection } } + /// + /// This method is effectively pointless, but only called once. It's present (and called) + /// to avoid the Unity linker from removing code that's only called via reflection. + /// + private static void PreventLinkerFailures() + { + // Exercise the method directly. This should avoid any pro-active linkers from stripping + // the method out. + SampleEnum x = SampleEnumMethod(); + if (x != SampleEnum.X) + { + throw new InvalidOperationException("Failure in reflection utilities"); + } + // Make sure the ReflectionHelper parameterless constructor isn't removed... + var helper = new ReflectionHelper(); + } + public enum SampleEnum { X -- cgit v1.2.3